[INFO] crate flexi_config 0.1.0 is already in cache [INFO] extracting crate flexi_config 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/flexi_config/0.1.0 [INFO] extracting crate flexi_config 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flexi_config/0.1.0 [INFO] validating manifest of flexi_config-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flexi_config-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flexi_config-0.1.0 [INFO] finished frobbing flexi_config-0.1.0 [INFO] frobbed toml for flexi_config-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/flexi_config/0.1.0/Cargo.toml [INFO] started frobbing flexi_config-0.1.0 [INFO] finished frobbing flexi_config-0.1.0 [INFO] frobbed toml for flexi_config-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flexi_config/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flexi_config-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/flexi_config/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5954e15dfb897c1b4a8fedeef396857008cc6014e05c7225661853be921a2fd3 [INFO] running `"docker" "start" "-a" "5954e15dfb897c1b4a8fedeef396857008cc6014e05c7225661853be921a2fd3"` [INFO] [stderr] Checking flexi_logger v0.5.2 [INFO] [stderr] Checking flexi_config v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/file.rs:35:68 [INFO] [stderr] | [INFO] [stderr] 35 | Ok(formatter) => FormatResult::Ok(Box::new(File { formatter : formatter })), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/event.rs:35:69 [INFO] [stderr] | [INFO] [stderr] 35 | Ok(formatter) => FormatResult::Ok(Box::new(Event { formatter : formatter })), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/formatter.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | align : align, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `align` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/formatter.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | width : width, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/formatter.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | truncate : truncate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `truncate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/formatter.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | padding : padding [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `padding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/line.rs:37:68 [INFO] [stderr] | [INFO] [stderr] 37 | Ok(formatter) => FormatResult::Ok(Box::new(Line { formatter : formatter })), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/module.rs:35:70 [INFO] [stderr] | [INFO] [stderr] 35 | Ok(formatter) => FormatResult::Ok(Box::new(Module { formatter : formatter })), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/target.rs:35:71 [INFO] [stderr] | [INFO] [stderr] 35 | Ok(formatter) => FormatResult::Ok(Box::new(Target { formatter : formatter })), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/time/time_format.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | pieces : pieces [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `pieces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/time/year.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | format : format [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/log_test.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | message : message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/log_test.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | module : module, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `module` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/log_test.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | level : level, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/log_test.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | target : target, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/log_test.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | path : path, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/log_test.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | file : file, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/issues.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | errors : errors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/issues_builder.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | table : table, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/issues_builder.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | group : group, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `group` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/issues_builder.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | issues : issues [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `issues` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/log_format_parser.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | fmt : fmt, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `fmt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/toml_file.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | common : common, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `common` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/toml_file.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | disk : disk, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `disk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/toml_file.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | depends : depends, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `depends` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/toml_common.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | common : common [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `common` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/toml_depends.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | depends : depends [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `depends` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/toml_disk.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | disk : disk [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `disk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:372:13 [INFO] [stderr] | [INFO] [stderr] 372 | dependencies : dependencies, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dependencies` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/file.rs:35:68 [INFO] [stderr] | [INFO] [stderr] 35 | Ok(formatter) => FormatResult::Ok(Box::new(File { formatter : formatter })), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/event.rs:35:69 [INFO] [stderr] | [INFO] [stderr] 35 | Ok(formatter) => FormatResult::Ok(Box::new(Event { formatter : formatter })), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/formatter.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | align : align, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `align` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/formatter.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | width : width, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/formatter.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | truncate : truncate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `truncate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/formatter.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | padding : padding [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `padding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/line.rs:37:68 [INFO] [stderr] | [INFO] [stderr] 37 | Ok(formatter) => FormatResult::Ok(Box::new(Line { formatter : formatter })), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/module.rs:35:70 [INFO] [stderr] | [INFO] [stderr] 35 | Ok(formatter) => FormatResult::Ok(Box::new(Module { formatter : formatter })), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/target.rs:35:71 [INFO] [stderr] | [INFO] [stderr] 35 | Ok(formatter) => FormatResult::Ok(Box::new(Target { formatter : formatter })), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/time/time_format.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | pieces : pieces [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `pieces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/appender/time/year.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | format : format [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/issues.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | errors : errors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `errors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/issues_builder.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | table : table, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/issues_builder.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | group : group, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `group` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/issues_builder.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | issues : issues [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `issues` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/log_format_parser.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | fmt : fmt, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `fmt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/toml_file.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | common : common, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `common` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/toml_file.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | disk : disk, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `disk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/toml_file.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | depends : depends, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `depends` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/toml_common.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | common : common [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `common` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/toml_depends.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | depends : depends [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `depends` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config/toml_disk.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | disk : disk [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `disk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:372:13 [INFO] [stderr] | [INFO] [stderr] 372 | dependencies : dependencies, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dependencies` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/appender/time/millisecond.rs:31:45 [INFO] [stderr] | [INFO] [stderr] 31 | write!(tmp, "{:03}", what.tm_nsec / 1000000).unwrap(); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_common.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | const APPLICATION : &'static str = "application"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_common.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | const TARGET : &'static str = "target"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_common.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | const STDERR : &'static str = "stderr_format"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_common.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | const DISK : &'static str = "disk_format"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_common.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | const PRIORITY : &'static str = "priority"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_disk.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | const DUP_ERROR : &'static str = "dup_err"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_disk.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | const DUP_INFO : &'static str = "dup_info"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_disk.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | const EXT : &'static str = "extension"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_disk.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | const TIMESTAMP : &'static str = "timestamp"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_disk.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | const DIR : &'static str = "dir"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_disk.rs:38:19 [INFO] [stderr] | [INFO] [stderr] 38 | const MAX_SIZE : &'static str = "max_size"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_disk.rs:42:15 [INFO] [stderr] | [INFO] [stderr] 42 | const NAME : &'static str = "name_suffix"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/flexi_config_cargo.rs:176:41 [INFO] [stderr] | [INFO] [stderr] 176 | Err(Issues::single(String::from(("Error parsing cargo file.")))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/flexi_config_cargo.rs:176:41 [INFO] [stderr] | [INFO] [stderr] 176 | Err(Issues::single(String::from(("Error parsing cargo file.")))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/file.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new( [INFO] [stderr] 30 | | fmt : &str [INFO] [stderr] 31 | | ) -> FormatResult [INFO] [stderr] 32 | | { [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/event.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new( [INFO] [stderr] 30 | | fmt : &str [INFO] [stderr] 31 | | ) -> FormatResult [INFO] [stderr] 32 | | { [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/appender/formatter.rs:174:46 [INFO] [stderr] | [INFO] [stderr] 174 | return Err((truncate_offset, format!("Cannot have truncate without a width"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot have truncate without a width".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/appender/formatter.rs:177:16 [INFO] [stderr] | [INFO] [stderr] 177 | if align.is_none() == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!align.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/appender/formatter.rs:179:43 [INFO] [stderr] | [INFO] [stderr] 179 | return Err((align_offset, format!("Cannot have an align without a width"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot have an align without a width".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/appender/formatter.rs:182:36 [INFO] [stderr] | [INFO] [stderr] 182 | else if align.is_none() && truncate == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!truncate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/appender/formatter.rs:184:28 [INFO] [stderr] | [INFO] [stderr] 184 | return Err((1, format!("Cannot have a width without an align or truncate"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot have a width without an align or truncate".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/line.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new( [INFO] [stderr] 32 | | fmt : &str [INFO] [stderr] 33 | | ) ->FormatResult [INFO] [stderr] 34 | | { [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/module.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new( [INFO] [stderr] 30 | | fmt : &str [INFO] [stderr] 31 | | ) -> FormatResult [INFO] [stderr] 32 | | { [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/priority.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn new( [INFO] [stderr] 51 | | format : PriorityFormat [INFO] [stderr] 52 | | ) -> FormatResult [INFO] [stderr] 53 | | { [INFO] [stderr] ... | [INFO] [stderr] 68 | | })) [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/target.rs:29:6 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new( [INFO] [stderr] 30 | | fmt : &str [INFO] [stderr] 31 | | ) -> FormatResult [INFO] [stderr] 32 | | { [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/time/am_pm.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / pub fn new( [INFO] [stderr] 54 | | fmt : AmPmFormat [INFO] [stderr] 55 | | ) -> Box [INFO] [stderr] 56 | | { [INFO] [stderr] ... | [INFO] [stderr] 61 | | }) [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/time/hour.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new( [INFO] [stderr] 55 | | fmt : HourFormat [INFO] [stderr] 56 | | ) -> Box [INFO] [stderr] 57 | | { [INFO] [stderr] ... | [INFO] [stderr] 62 | | }) [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/time/month.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn new( [INFO] [stderr] 64 | | format : MonthFormat [INFO] [stderr] 65 | | ) -> Box [INFO] [stderr] 66 | | { [INFO] [stderr] ... | [INFO] [stderr] 72 | | }) [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/time/time_format.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn new( [INFO] [stderr] 63 | | fmt : &str [INFO] [stderr] 64 | | ) -> FormatResult [INFO] [stderr] 65 | | { [INFO] [stderr] ... | [INFO] [stderr] 141 | | })) [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/appender/time/time_format.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | if escape == false [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!escape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/appender/time/time_format.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | if current.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/appender/time/time_format.rs:125:12 [INFO] [stderr] | [INFO] [stderr] 125 | if current.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/time/year.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new( [INFO] [stderr] 43 | | format : YearFormat [INFO] [stderr] 44 | | ) -> Box [INFO] [stderr] 45 | | { [INFO] [stderr] ... | [INFO] [stderr] 48 | | }) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `config::issues::Issues` [INFO] [stderr] --> src/config/issues.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn new() -> Issues [INFO] [stderr] 66 | | { [INFO] [stderr] 67 | | Issues { [INFO] [stderr] 68 | | errors : Vec::new(), [INFO] [stderr] 69 | | warnings : Vec::new() [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config/issues.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | self.errors.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config/issues.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | self.errors.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config/issues_builder.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | None => format!("{}", property) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `property.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/appender/time/millisecond.rs:31:45 [INFO] [stderr] | [INFO] [stderr] 31 | write!(tmp, "{:03}", what.tm_nsec / 1000000).unwrap(); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/config/issues_builder.rs:299:74 [INFO] [stderr] | [INFO] [stderr] 299 | if value.as_str().is_none() && (value.as_bool().is_none() || value.as_bool().unwrap() == true) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `value.as_bool().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/config/issues_builder.rs:318:114 [INFO] [stderr] | [INFO] [stderr] 318 | if (value.as_integer().is_none() || value.as_integer().unwrap() < 0 || value.as_integer().unwrap() > u32::MAX as i64) && [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/config/issues_builder.rs:319:46 [INFO] [stderr] | [INFO] [stderr] 319 | (value.as_bool().is_none() || value.as_bool().unwrap() == true) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `value.as_bool().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/config/issues_builder.rs:389:58 [INFO] [stderr] | [INFO] [stderr] 389 | let known : HashSet = used.drain(..).map(|x| String::from(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/config/issues_builder.rs:391:50 [INFO] [stderr] | [INFO] [stderr] 391 | for key in self.table.keys().filter(|&x| known.contains(x) == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!known.contains(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config/log_format_parser.rs:209:16 [INFO] [stderr] | [INFO] [stderr] 209 | if self.current.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.current.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config/log_format_parser.rs:263:72 [INFO] [stderr] | [INFO] [stderr] 263 | "t" => return Some(self.panic(self.section_start + 1, format!("time must have a format defined"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"time must have a format defined".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config/log_format_parser.rs:265:72 [INFO] [stderr] | [INFO] [stderr] 265 | _ => return Some(self.panic(self.section_start + 1, format!("Unrecognized element type"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unrecognized element type".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config/log_format_parser.rs:290:72 [INFO] [stderr] | [INFO] [stderr] 290 | "p" => return Some(self.panic(self.section_start + 1, format!("priority cannot have a format defined, expected {{p}}"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"priority cannot have a format defined, expected {{p}}".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config/log_format_parser.rs:291:72 [INFO] [stderr] | [INFO] [stderr] 291 | "P" => return Some(self.panic(self.section_start + 1, format!("priority cannot have a format defined, expected {{P}}"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"priority cannot have a format defined, expected {{P}}".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config/log_format_parser.rs:292:72 [INFO] [stderr] | [INFO] [stderr] 292 | "pp" => return Some(self.panic(self.section_start + 1, format!("priority cannot have a format defined, expected {{pp}}"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"priority cannot have a format defined, expected {{pp}}".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config/log_format_parser.rs:293:72 [INFO] [stderr] | [INFO] [stderr] 293 | "PP" => return Some(self.panic(self.section_start + 1, format!("priority cannot have a format defined, expected {{PP}}"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"priority cannot have a format defined, expected {{PP}}".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config/log_format_parser.rs:299:72 [INFO] [stderr] | [INFO] [stderr] 299 | _ => return Some(self.panic(self.section_start + 1, format!("Unrecognized element type"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unrecognized element type".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/config/toml_file.rs:149:12 [INFO] [stderr] | [INFO] [stderr] 149 | if issues.has_errors() == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!issues.has_errors()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/config/toml_file.rs:220:20 [INFO] [stderr] | [INFO] [stderr] 220 | pub fn to_toml(self) -> Table [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_common.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | const APPLICATION : &'static str = "application"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_common.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | const TARGET : &'static str = "target"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_common.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | const STDERR : &'static str = "stderr_format"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_common.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | const DISK : &'static str = "disk_format"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_common.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | const PRIORITY : &'static str = "priority"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_disk.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | const DUP_ERROR : &'static str = "dup_err"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_disk.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | const DUP_INFO : &'static str = "dup_info"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_disk.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | const EXT : &'static str = "extension"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_disk.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | const TIMESTAMP : &'static str = "timestamp"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_disk.rs:34:14 [INFO] [stderr] | [INFO] [stderr] 34 | const DIR : &'static str = "dir"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_disk.rs:38:19 [INFO] [stderr] | [INFO] [stderr] 38 | const MAX_SIZE : &'static str = "max_size"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/toml_disk.rs:42:15 [INFO] [stderr] | [INFO] [stderr] 42 | const NAME : &'static str = "name_suffix"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/config/toml_common.rs:312:20 [INFO] [stderr] | [INFO] [stderr] 312 | pub fn to_toml(self) -> Table [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/config/toml_depends.rs:114:20 [INFO] [stderr] | [INFO] [stderr] 114 | pub fn to_toml(self) -> Table [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/flexi_config_cargo.rs:176:41 [INFO] [stderr] | [INFO] [stderr] 176 | Err(Issues::single(String::from(("Error parsing cargo file.")))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/flexi_config_cargo.rs:176:41 [INFO] [stderr] | [INFO] [stderr] 176 | Err(Issues::single(String::from(("Error parsing cargo file.")))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config/toml_disk.rs:271:20 [INFO] [stderr] | [INFO] [stderr] 271 | if value.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/config/toml_disk.rs:280:25 [INFO] [stderr] | [INFO] [stderr] 280 | else if let Some(_) = value.as_bool() [INFO] [stderr] | __________________- ^^^^^^^ [INFO] [stderr] 281 | | { [INFO] [stderr] 282 | | None [INFO] [stderr] 283 | | } [INFO] [stderr] ... | [INFO] [stderr] 286 | | panic!("disk.{} is not valid.", DIR); [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____________- help: try this: `if value.as_bool().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/config/toml_disk.rs:307:77 [INFO] [stderr] | [INFO] [stderr] 307 | self.disk.insert(String::from(MAX_SIZE), Value::Integer(value as i64)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/config/toml_disk.rs:331:43 [INFO] [stderr] | [INFO] [stderr] 331 | if value >= 0 && value <= u32::MAX as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/config/toml_disk.rs:341:25 [INFO] [stderr] | [INFO] [stderr] 341 | else if let Some(_) = value.as_bool() [INFO] [stderr] | __________________- ^^^^^^^ [INFO] [stderr] 342 | | { [INFO] [stderr] 343 | | None [INFO] [stderr] 344 | | } [INFO] [stderr] ... | [INFO] [stderr] 347 | | panic!("disk.{} is not valid.", MAX_SIZE); [INFO] [stderr] 348 | | } [INFO] [stderr] | |_____________- help: try this: `if value.as_bool().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config/toml_disk.rs:382:20 [INFO] [stderr] | [INFO] [stderr] 382 | if value.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/config/toml_disk.rs:392:25 [INFO] [stderr] | [INFO] [stderr] 392 | else if let Some(_) = value.as_bool() [INFO] [stderr] | __________________- ^^^^^^^ [INFO] [stderr] 393 | | { [INFO] [stderr] 394 | | None [INFO] [stderr] 395 | | } [INFO] [stderr] ... | [INFO] [stderr] 398 | | panic!("disk.{} is not valid.", NAME); [INFO] [stderr] 399 | | } [INFO] [stderr] | |_____________- help: try this: `if value.as_bool().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/config/toml_disk.rs:410:20 [INFO] [stderr] | [INFO] [stderr] 410 | pub fn to_toml(self) -> Table [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/flexi_config_cargo.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | else if parser.errors.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parser.errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/flexi_config_from_toml.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | else if parser.errors.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parser.errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/flexi_config_to_toml.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | fn to_toml(self) -> Table [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/flexi_config_to_toml.rs:65:27 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn to_toml_string(self) -> String [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/flexi_config_to_toml.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | self, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/flexi_config_setters.rs:98:12 [INFO] [stderr] | [INFO] [stderr] 98 | if dir.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dir.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/flexi_config_setters.rs:185:12 [INFO] [stderr] | [INFO] [stderr] 185 | if suffix.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!suffix.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused import: `appender::time::TimeAppender` [INFO] [stderr] --> src/appender/time/am_pm.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | use appender::time::TimeAppender; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `appender::time::TimeAppender` [INFO] [stderr] --> src/appender/time/hour.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | use appender::time::TimeAppender; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `appender::time::TimeAppender` [INFO] [stderr] --> src/appender/time/month.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | use appender::time::TimeAppender; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `appender::Appender` [INFO] [stderr] --> src/appender/time/time_format.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | use appender::Appender; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `appender::time::TimeAppender` [INFO] [stderr] --> src/appender/time/year.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | use appender::time::TimeAppender; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/file.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new( [INFO] [stderr] 30 | | fmt : &str [INFO] [stderr] 31 | | ) -> FormatResult [INFO] [stderr] 32 | | { [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/event.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new( [INFO] [stderr] 30 | | fmt : &str [INFO] [stderr] 31 | | ) -> FormatResult [INFO] [stderr] 32 | | { [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/appender/formatter.rs:174:46 [INFO] [stderr] | [INFO] [stderr] 174 | return Err((truncate_offset, format!("Cannot have truncate without a width"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot have truncate without a width".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/appender/formatter.rs:177:16 [INFO] [stderr] | [INFO] [stderr] 177 | if align.is_none() == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!align.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/appender/formatter.rs:179:43 [INFO] [stderr] | [INFO] [stderr] 179 | return Err((align_offset, format!("Cannot have an align without a width"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot have an align without a width".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/appender/formatter.rs:182:36 [INFO] [stderr] | [INFO] [stderr] 182 | else if align.is_none() && truncate == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!truncate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/appender/formatter.rs:184:28 [INFO] [stderr] | [INFO] [stderr] 184 | return Err((1, format!("Cannot have a width without an align or truncate"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Cannot have a width without an align or truncate".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/line.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new( [INFO] [stderr] 32 | | fmt : &str [INFO] [stderr] 33 | | ) ->FormatResult [INFO] [stderr] 34 | | { [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/module.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new( [INFO] [stderr] 30 | | fmt : &str [INFO] [stderr] 31 | | ) -> FormatResult [INFO] [stderr] 32 | | { [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/priority.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn new( [INFO] [stderr] 51 | | format : PriorityFormat [INFO] [stderr] 52 | | ) -> FormatResult [INFO] [stderr] 53 | | { [INFO] [stderr] ... | [INFO] [stderr] 68 | | })) [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/target.rs:29:6 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new( [INFO] [stderr] 30 | | fmt : &str [INFO] [stderr] 31 | | ) -> FormatResult [INFO] [stderr] 32 | | { [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/time/am_pm.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / pub fn new( [INFO] [stderr] 54 | | fmt : AmPmFormat [INFO] [stderr] 55 | | ) -> Box [INFO] [stderr] 56 | | { [INFO] [stderr] ... | [INFO] [stderr] 61 | | }) [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/time/hour.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new( [INFO] [stderr] 55 | | fmt : HourFormat [INFO] [stderr] 56 | | ) -> Box [INFO] [stderr] 57 | | { [INFO] [stderr] ... | [INFO] [stderr] 62 | | }) [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/time/month.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn new( [INFO] [stderr] 64 | | format : MonthFormat [INFO] [stderr] 65 | | ) -> Box [INFO] [stderr] 66 | | { [INFO] [stderr] ... | [INFO] [stderr] 72 | | }) [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/time/time_format.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn new( [INFO] [stderr] 63 | | fmt : &str [INFO] [stderr] 64 | | ) -> FormatResult [INFO] [stderr] 65 | | { [INFO] [stderr] ... | [INFO] [stderr] 141 | | })) [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/appender/time/time_format.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | if escape == false [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!escape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/appender/time/time_format.rs:81:24 [INFO] [stderr] | [INFO] [stderr] 81 | if current.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/appender/time/time_format.rs:125:12 [INFO] [stderr] | [INFO] [stderr] 125 | if current.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/appender/time/time_format.rs:204:53 [INFO] [stderr] | [INFO] [stderr] 204 | assert_eq!(lowercase.test(LogTest::time(tm.clone())), time::strftime("%b", &tm).unwrap().to_lowercase()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `tm` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/appender/time/time_format.rs:205:53 [INFO] [stderr] | [INFO] [stderr] 205 | assert_eq!(uppercase.test(LogTest::time(tm.clone())), time::strftime("%b", &tm).unwrap().to_uppercase()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `tm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/appender/time/time_format.rs:206:51 [INFO] [stderr] | [INFO] [stderr] 206 | assert_eq!(numbers.test(LogTest::time(tm.clone())), time::strftime("%m", &tm).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `tm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/appender/time/time_format.rs:221:47 [INFO] [stderr] | [INFO] [stderr] 221 | assert_eq!(day.test(LogTest::time(tm.clone())), time::strftime("%d", &tm).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `tm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/appender/time/time_format.rs:236:49 [INFO] [stderr] | [INFO] [stderr] 236 | assert_eq!(milli.test(LogTest::time(tm.clone())).len(), 3); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `tm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/appender/time/time_format.rs:252:55 [INFO] [stderr] | [INFO] [stderr] 252 | assert_eq!(twenty_four.test(LogTest::time(tm.clone())), time::strftime("%H", &tm).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `tm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/appender/time/time_format.rs:253:50 [INFO] [stderr] | [INFO] [stderr] 253 | assert_eq!(twelve.test(LogTest::time(tm.clone())), time::strftime("%I", &tm).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `tm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/appender/time/time_format.rs:268:50 [INFO] [stderr] | [INFO] [stderr] 268 | assert_eq!(minute.test(LogTest::time(tm.clone())), time::strftime("%M", &tm).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `tm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/appender/time/time_format.rs:284:53 [INFO] [stderr] | [INFO] [stderr] 284 | assert_eq!(uppercase.test(LogTest::time(tm.clone())), time::strftime("%p", &tm).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `tm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/appender/time/time_format.rs:285:53 [INFO] [stderr] | [INFO] [stderr] 285 | assert_eq!(lowercase.test(LogTest::time(tm.clone())), time::strftime("%P", &tm).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `tm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/appender/time/time_format.rs:300:50 [INFO] [stderr] | [INFO] [stderr] 300 | assert_eq!(second.test(LogTest::time(tm.clone())), time::strftime("%S", &tm).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `tm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/appender/time/time_format.rs:316:49 [INFO] [stderr] | [INFO] [stderr] 316 | assert_eq!(short.test(LogTest::time(tm.clone())), time::strftime("%y", &tm).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `tm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/appender/time/time_format.rs:317:48 [INFO] [stderr] | [INFO] [stderr] 317 | assert_eq!(long.test(LogTest::time(tm.clone())), time::strftime("%Y", &tm).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `tm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/appender/time/time_format.rs:329:44 [INFO] [stderr] | [INFO] [stderr] 329 | assert_eq!(test.test(LogTest::time(tm.clone())), "abc%xyz"); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `tm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/appender/time/time_format.rs:340:44 [INFO] [stderr] | [INFO] [stderr] 340 | assert_eq!(test.test(LogTest::time(now.clone())), time::strftime("[%Y-%m-%d %H:%M:%S]", &now).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `now` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/appender/time/year.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new( [INFO] [stderr] 43 | | format : YearFormat [INFO] [stderr] 44 | | ) -> Box [INFO] [stderr] 45 | | { [INFO] [stderr] ... | [INFO] [stderr] 48 | | }) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `config::issues::Issues` [INFO] [stderr] --> src/config/issues.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn new() -> Issues [INFO] [stderr] 66 | | { [INFO] [stderr] 67 | | Issues { [INFO] [stderr] 68 | | errors : Vec::new(), [INFO] [stderr] 69 | | warnings : Vec::new() [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config/issues.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | self.errors.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config/issues.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | self.errors.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config/issues_builder.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | None => format!("{}", property) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `property.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/config/issues_builder.rs:299:74 [INFO] [stderr] | [INFO] [stderr] 299 | if value.as_str().is_none() && (value.as_bool().is_none() || value.as_bool().unwrap() == true) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `value.as_bool().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/config/issues_builder.rs:318:114 [INFO] [stderr] | [INFO] [stderr] 318 | if (value.as_integer().is_none() || value.as_integer().unwrap() < 0 || value.as_integer().unwrap() > u32::MAX as i64) && [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/config/issues_builder.rs:319:46 [INFO] [stderr] | [INFO] [stderr] 319 | (value.as_bool().is_none() || value.as_bool().unwrap() == true) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `value.as_bool().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/config/issues_builder.rs:389:58 [INFO] [stderr] | [INFO] [stderr] 389 | let known : HashSet = used.drain(..).map(|x| String::from(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/config/issues_builder.rs:391:50 [INFO] [stderr] | [INFO] [stderr] 391 | for key in self.table.keys().filter(|&x| known.contains(x) == false) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!known.contains(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/config/issues_builder.rs:420:59 [INFO] [stderr] | [INFO] [stderr] 420 | table.insert(String::from("huge"), Value::Integer(u32::MAX as i64 + 133)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config/log_format_parser.rs:209:16 [INFO] [stderr] | [INFO] [stderr] 209 | if self.current.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.current.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config/log_format_parser.rs:263:72 [INFO] [stderr] | [INFO] [stderr] 263 | "t" => return Some(self.panic(self.section_start + 1, format!("time must have a format defined"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"time must have a format defined".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config/log_format_parser.rs:265:72 [INFO] [stderr] | [INFO] [stderr] 265 | _ => return Some(self.panic(self.section_start + 1, format!("Unrecognized element type"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unrecognized element type".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config/log_format_parser.rs:290:72 [INFO] [stderr] | [INFO] [stderr] 290 | "p" => return Some(self.panic(self.section_start + 1, format!("priority cannot have a format defined, expected {{p}}"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"priority cannot have a format defined, expected {{p}}".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config/log_format_parser.rs:291:72 [INFO] [stderr] | [INFO] [stderr] 291 | "P" => return Some(self.panic(self.section_start + 1, format!("priority cannot have a format defined, expected {{P}}"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"priority cannot have a format defined, expected {{P}}".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config/log_format_parser.rs:292:72 [INFO] [stderr] | [INFO] [stderr] 292 | "pp" => return Some(self.panic(self.section_start + 1, format!("priority cannot have a format defined, expected {{pp}}"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"priority cannot have a format defined, expected {{pp}}".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config/log_format_parser.rs:293:72 [INFO] [stderr] | [INFO] [stderr] 293 | "PP" => return Some(self.panic(self.section_start + 1, format!("priority cannot have a format defined, expected {{PP}}"))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"priority cannot have a format defined, expected {{PP}}".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config/log_format_parser.rs:299:72 [INFO] [stderr] | [INFO] [stderr] 299 | _ => return Some(self.panic(self.section_start + 1, format!("Unrecognized element type"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unrecognized element type".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config/log_format_parser.rs:437:17 [INFO] [stderr] | [INFO] [stderr] 437 | assert!(LogFormatParser::parse("{t:%H:%M:%S.%f} | {m:>20} | {f:>30}:{l:>4} | {e}").unwrap().len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!LogFormatParser::parse("{t:%H:%M:%S.%f} | {m:>20} | {f:>30}:{l:>4} | {e}").unwrap().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/config/toml_file.rs:149:12 [INFO] [stderr] | [INFO] [stderr] 149 | if issues.has_errors() == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!issues.has_errors()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/config/toml_file.rs:220:20 [INFO] [stderr] | [INFO] [stderr] 220 | pub fn to_toml(self) -> Table [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/config/toml_common.rs:312:20 [INFO] [stderr] | [INFO] [stderr] 312 | pub fn to_toml(self) -> Table [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config/toml_common.rs:356:17 [INFO] [stderr] | [INFO] [stderr] 356 | assert!(issues.warnings.len() == 0, "{:?}", issues); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `issues.warnings.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config/toml_common.rs:357:17 [INFO] [stderr] | [INFO] [stderr] 357 | assert!(issues.errors.len() == 0, "{:?}", issues); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `issues.errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/config/toml_depends.rs:114:20 [INFO] [stderr] | [INFO] [stderr] 114 | pub fn to_toml(self) -> Table [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config/toml_depends.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | assert!(data.get(&String::from("abc")).unwrap().is_none()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&data[&String::from("abc")]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config/toml_disk.rs:271:20 [INFO] [stderr] | [INFO] [stderr] 271 | if value.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/config/toml_disk.rs:280:25 [INFO] [stderr] | [INFO] [stderr] 280 | else if let Some(_) = value.as_bool() [INFO] [stderr] | __________________- ^^^^^^^ [INFO] [stderr] 281 | | { [INFO] [stderr] 282 | | None [INFO] [stderr] 283 | | } [INFO] [stderr] ... | [INFO] [stderr] 286 | | panic!("disk.{} is not valid.", DIR); [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____________- help: try this: `if value.as_bool().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/config/toml_disk.rs:307:77 [INFO] [stderr] | [INFO] [stderr] 307 | self.disk.insert(String::from(MAX_SIZE), Value::Integer(value as i64)) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/config/toml_disk.rs:331:43 [INFO] [stderr] | [INFO] [stderr] 331 | if value >= 0 && value <= u32::MAX as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/config/toml_disk.rs:341:25 [INFO] [stderr] | [INFO] [stderr] 341 | else if let Some(_) = value.as_bool() [INFO] [stderr] | __________________- ^^^^^^^ [INFO] [stderr] 342 | | { [INFO] [stderr] 343 | | None [INFO] [stderr] 344 | | } [INFO] [stderr] ... | [INFO] [stderr] 347 | | panic!("disk.{} is not valid.", MAX_SIZE); [INFO] [stderr] 348 | | } [INFO] [stderr] | |_____________- help: try this: `if value.as_bool().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config/toml_disk.rs:382:20 [INFO] [stderr] | [INFO] [stderr] 382 | if value.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/config/toml_disk.rs:392:25 [INFO] [stderr] | [INFO] [stderr] 392 | else if let Some(_) = value.as_bool() [INFO] [stderr] | __________________- ^^^^^^^ [INFO] [stderr] 393 | | { [INFO] [stderr] 394 | | None [INFO] [stderr] 395 | | } [INFO] [stderr] ... | [INFO] [stderr] 398 | | panic!("disk.{} is not valid.", NAME); [INFO] [stderr] 399 | | } [INFO] [stderr] | |_____________- help: try this: `if value.as_bool().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/config/toml_disk.rs:410:20 [INFO] [stderr] | [INFO] [stderr] 410 | pub fn to_toml(self) -> Table [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/config/toml_disk.rs:861:60 [INFO] [stderr] | [INFO] [stderr] 861 | data.insert(String::from(MAX_SIZE), Value::Integer(u32::MAX as i64 + 127)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/flexi_config_cargo.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | else if parser.errors.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parser.errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/flexi_config_from_toml.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | else if parser.errors.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parser.errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/flexi_config_to_toml.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | fn to_toml(self) -> Table [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/flexi_config_to_toml.rs:65:27 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn to_toml_string(self) -> String [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/flexi_config_to_toml.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | self, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/flexi_config_setters.rs:98:12 [INFO] [stderr] | [INFO] [stderr] 98 | if dir.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dir.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/flexi_config_setters.rs:185:12 [INFO] [stderr] | [INFO] [stderr] 185 | if suffix.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!suffix.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> examples/disk.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(_) = matches.subcommand_matches("create") [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 34 | | { [INFO] [stderr] 35 | | let mut config = FlexiConfig::new("disk", BTreeMap::new()); [INFO] [stderr] 36 | | [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("create").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> examples/custom.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(_) = matches.subcommand_matches("create") [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 34 | | { [INFO] [stderr] 35 | | let mut config = FlexiConfig::new("custom", BTreeMap::new()); [INFO] [stderr] 36 | | [INFO] [stderr] ... | [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("create").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> examples/stderr.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(_) = matches.subcommand_matches("create") [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 34 | | { [INFO] [stderr] 35 | | let mut config = FlexiConfig::new("stderr", BTreeMap::new()); [INFO] [stderr] 36 | | [INFO] [stderr] ... | [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____- help: try this: `if matches.subcommand_matches("create").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.79s [INFO] running `"docker" "inspect" "5954e15dfb897c1b4a8fedeef396857008cc6014e05c7225661853be921a2fd3"` [INFO] running `"docker" "rm" "-f" "5954e15dfb897c1b4a8fedeef396857008cc6014e05c7225661853be921a2fd3"` [INFO] [stdout] 5954e15dfb897c1b4a8fedeef396857008cc6014e05c7225661853be921a2fd3