[INFO] crate flexer 0.1.1 is already in cache [INFO] extracting crate flexer 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/flexer/0.1.1 [INFO] extracting crate flexer 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flexer/0.1.1 [INFO] validating manifest of flexer-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flexer-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flexer-0.1.1 [INFO] finished frobbing flexer-0.1.1 [INFO] frobbed toml for flexer-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/flexer/0.1.1/Cargo.toml [INFO] started frobbing flexer-0.1.1 [INFO] finished frobbing flexer-0.1.1 [INFO] frobbed toml for flexer-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flexer/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flexer-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/flexer/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0839162cfe6cd4e9e3f717df0b7508f1b9b8912e944b6b8c5663bfbd589f6289 [INFO] running `"docker" "start" "-a" "0839162cfe6cd4e9e3f717df0b7508f1b9b8912e944b6b8c5663bfbd589f6289"` [INFO] [stderr] Checking flexer v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/token_definition.rs:28:33 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn conversion(&self) -> &Box T> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&Fn(String) -> T` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tokens.rs:13:29 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new(definitions: &'b Vec>, matches: Vec>) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[TokenDefinition]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/token_definition.rs:28:33 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn conversion(&self) -> &Box T> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&Fn(String) -> T` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tokens.rs:13:29 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new(definitions: &'b Vec>, matches: Vec>) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[TokenDefinition]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/lisp.rs:24:60 [INFO] [stderr] | [INFO] [stderr] 24 | "id" => r"[\w_]+" => |token| Token::Id(token) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Token::Id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/lisp.rs:25:60 [INFO] [stderr] | [INFO] [stderr] 25 | "operator" => r"[\+\-\*/]" => |token| Token::Operator(token) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Token::Operator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/lisp.rs:26:60 [INFO] [stderr] | [INFO] [stderr] 26 | "unknown" => r"\S.*\S" => |token| Token::Unknown(token) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Token::Unknown` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.74s [INFO] running `"docker" "inspect" "0839162cfe6cd4e9e3f717df0b7508f1b9b8912e944b6b8c5663bfbd589f6289"` [INFO] running `"docker" "rm" "-f" "0839162cfe6cd4e9e3f717df0b7508f1b9b8912e944b6b8c5663bfbd589f6289"` [INFO] [stdout] 0839162cfe6cd4e9e3f717df0b7508f1b9b8912e944b6b8c5663bfbd589f6289