[INFO] crate flate2-crc 0.1.2 is already in cache [INFO] extracting crate flate2-crc 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/flate2-crc/0.1.2 [INFO] extracting crate flate2-crc 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flate2-crc/0.1.2 [INFO] validating manifest of flate2-crc-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flate2-crc-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flate2-crc-0.1.2 [INFO] finished frobbing flate2-crc-0.1.2 [INFO] frobbed toml for flate2-crc-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/flate2-crc/0.1.2/Cargo.toml [INFO] started frobbing flate2-crc-0.1.2 [INFO] finished frobbing flate2-crc-0.1.2 [INFO] frobbed toml for flate2-crc-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flate2-crc/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flate2-crc-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/flate2-crc/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f4ee484d57930e956519f59cb6bafe1c4b477359cffcefe9f9eaef4fe2dd3d4c [INFO] running `"docker" "start" "-a" "f4ee484d57930e956519f59cb6bafe1c4b477359cffcefe9f9eaef4fe2dd3d4c"` [INFO] [stderr] Compiling flate2-crc v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/x86.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | const K1: i64 = 0x154442bd4; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_5444_2bd4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/x86.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | const K2: i64 = 0x1c6e41596; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_c6e4_1596` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/x86.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | const K3: i64 = 0x1751997d0; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_7519_97d0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/x86.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | const K4: i64 = 0x0ccaa009e; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0000_ccaa_009e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/x86.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | const K5: i64 = 0x163cd6124; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_63cd_6124` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/x86.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | const K6: i64 = 0x1db710640; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_db71_0640` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/x86.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | const P_x: i64 = 0x1DB710641; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_DB71_0641` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/x86.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | const U_prime: i64 = 0x1F7011641; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_F701_1641` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/x86.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return a [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/x86.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | return r [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/x86.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | drop(K6); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type i64 [INFO] [stderr] --> src/x86.rs:104:10 [INFO] [stderr] | [INFO] [stderr] 104 | drop(K6); [INFO] [stderr] | ^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/x86.rs:142:8 [INFO] [stderr] | [INFO] [stderr] 142 | if data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const std::arch::x86_64::__m128i`) [INFO] [stderr] --> src/x86.rs:157:29 [INFO] [stderr] | [INFO] [stderr] 157 | let r = _mm_loadu_si128(a.as_ptr() as *const __m128i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `flate2-crc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/x86.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | const K1: i64 = 0x154442bd4; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_5444_2bd4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/x86.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | const K2: i64 = 0x1c6e41596; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_c6e4_1596` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/x86.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | const K3: i64 = 0x1751997d0; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_7519_97d0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/x86.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | const K4: i64 = 0x0ccaa009e; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0000_ccaa_009e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/x86.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | const K5: i64 = 0x163cd6124; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_63cd_6124` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/x86.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | const K6: i64 = 0x1db710640; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_db71_0640` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/x86.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | const P_x: i64 = 0x1DB710641; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_DB71_0641` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/x86.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | const U_prime: i64 = 0x1F7011641; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x0001_F701_1641` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/x86.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return a [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/x86.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | return r [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/x86.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | drop(K6); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type i64 [INFO] [stderr] --> src/x86.rs:104:10 [INFO] [stderr] | [INFO] [stderr] 104 | drop(K6); [INFO] [stderr] | ^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/x86.rs:142:8 [INFO] [stderr] | [INFO] [stderr] 142 | if data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const std::arch::x86_64::__m128i`) [INFO] [stderr] --> src/x86.rs:157:29 [INFO] [stderr] | [INFO] [stderr] 157 | let r = _mm_loadu_si128(a.as_ptr() as *const __m128i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:64:33 [INFO] [stderr] | [INFO] [stderr] 64 | miniz_sys::mz_crc32(a as _, b.as_ptr(), b.len()) as u32 [INFO] [stderr] | ^^^^^^ help: try: `u64::from(a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `flate2-crc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f4ee484d57930e956519f59cb6bafe1c4b477359cffcefe9f9eaef4fe2dd3d4c"` [INFO] running `"docker" "rm" "-f" "f4ee484d57930e956519f59cb6bafe1c4b477359cffcefe9f9eaef4fe2dd3d4c"` [INFO] [stdout] f4ee484d57930e956519f59cb6bafe1c4b477359cffcefe9f9eaef4fe2dd3d4c