[INFO] crate flatarchive 0.0.1 is already in cache [INFO] extracting crate flatarchive 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/flatarchive/0.0.1 [INFO] extracting crate flatarchive 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flatarchive/0.0.1 [INFO] validating manifest of flatarchive-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flatarchive-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flatarchive-0.0.1 [INFO] finished frobbing flatarchive-0.0.1 [INFO] frobbed toml for flatarchive-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/flatarchive/0.0.1/Cargo.toml [INFO] started frobbing flatarchive-0.0.1 [INFO] finished frobbing flatarchive-0.0.1 [INFO] frobbed toml for flatarchive-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flatarchive/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flatarchive-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/flatarchive/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6e840442f0ae20c3f62789f40322df05940a1fd2ba2e1f81e481a43fbb913734 [INFO] running `"docker" "start" "-a" "6e840442f0ae20c3f62789f40322df05940a1fd2ba2e1f81e481a43fbb913734"` [INFO] [stderr] Checking flatarchive v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | pub const VERSION: &'static str = "0.1.0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/compression/bzip.rs:25:32 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn decompress_bytes(bytes: &Vec) -> io::Result> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/compression/bzip.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn compress_bytes(bytes: &Vec) -> io::Result> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/compression/mod.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | fn compress(&self, bytes: &Vec) -> ResultVector; [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/compression/mod.rs:35:33 [INFO] [stderr] | [INFO] [stderr] 35 | fn decompress(&self, bytes: &Vec) -> ResultVector; [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `entry::EntryBuilder` [INFO] [stderr] --> src/entry.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn new() -> EntryBuilder { [INFO] [stderr] 45 | | EntryBuilder { [INFO] [stderr] 46 | | entry: Entry::empty(), [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | impl Default for entry::EntryBuilder { [INFO] [stderr] 44 | fn default() -> Self { [INFO] [stderr] 45 | Self::new() [INFO] [stderr] 46 | } [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/entry.rs:65:52 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn with_compression(mut self, compression: &Compression) -> EntryBuilder { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Compression` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | pub const VERSION: &'static str = "0.1.0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/entry.rs:98:29 [INFO] [stderr] | [INFO] [stderr] 98 | let offset: usize = 0x001010; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_1010` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/compression/bzip.rs:25:32 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn decompress_bytes(bytes: &Vec) -> io::Result> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/compression/bzip.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn compress_bytes(bytes: &Vec) -> io::Result> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/compression/mod.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | fn compress(&self, bytes: &Vec) -> ResultVector; [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/compression/mod.rs:35:33 [INFO] [stderr] | [INFO] [stderr] 35 | fn decompress(&self, bytes: &Vec) -> ResultVector; [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `entry::EntryBuilder` [INFO] [stderr] --> src/entry.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / pub fn new() -> EntryBuilder { [INFO] [stderr] 45 | | EntryBuilder { [INFO] [stderr] 46 | | entry: Entry::empty(), [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | impl Default for entry::EntryBuilder { [INFO] [stderr] 44 | fn default() -> Self { [INFO] [stderr] 45 | Self::new() [INFO] [stderr] 46 | } [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/entry.rs:65:52 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn with_compression(mut self, compression: &Compression) -> EntryBuilder { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Compression` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.48s [INFO] running `"docker" "inspect" "6e840442f0ae20c3f62789f40322df05940a1fd2ba2e1f81e481a43fbb913734"` [INFO] running `"docker" "rm" "-f" "6e840442f0ae20c3f62789f40322df05940a1fd2ba2e1f81e481a43fbb913734"` [INFO] [stdout] 6e840442f0ae20c3f62789f40322df05940a1fd2ba2e1f81e481a43fbb913734