[INFO] crate flat-json 0.1.0 is already in cache [INFO] extracting crate flat-json 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/flat-json/0.1.0 [INFO] extracting crate flat-json 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flat-json/0.1.0 [INFO] validating manifest of flat-json-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flat-json-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flat-json-0.1.0 [INFO] finished frobbing flat-json-0.1.0 [INFO] frobbed toml for flat-json-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/flat-json/0.1.0/Cargo.toml [INFO] started frobbing flat-json-0.1.0 [INFO] finished frobbing flat-json-0.1.0 [INFO] frobbed toml for flat-json-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flat-json/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flat-json-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/flat-json/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 10957e0bf27b5b3f1b02d45df8357327cf8f6a7c9774f4b024a9e79e889af2ec [INFO] running `"docker" "start" "-a" "10957e0bf27b5b3f1b02d45df8357327cf8f6a7c9774f4b024a9e79e889af2ec"` [INFO] [stderr] Checking flat-json v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / match value { [INFO] [stderr] 17 | | &Value::Null => scalar("", prefix), [INFO] [stderr] 18 | | &Value::Bool(ref b) => scalar(b, prefix), [INFO] [stderr] 19 | | &Value::I64(ref i) => scalar(i, prefix), [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *value { [INFO] [stderr] 17 | Value::Null => scalar("", prefix), [INFO] [stderr] 18 | Value::Bool(ref b) => scalar(b, prefix), [INFO] [stderr] 19 | Value::I64(ref i) => scalar(i, prefix), [INFO] [stderr] 20 | Value::U64(ref i) => scalar(i, prefix), [INFO] [stderr] 21 | Value::F64(ref f) => scalar(f, prefix), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / match value { [INFO] [stderr] 17 | | &Value::Null => scalar("", prefix), [INFO] [stderr] 18 | | &Value::Bool(ref b) => scalar(b, prefix), [INFO] [stderr] 19 | | &Value::I64(ref i) => scalar(i, prefix), [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 16 | match *value { [INFO] [stderr] 17 | Value::Null => scalar("", prefix), [INFO] [stderr] 18 | Value::Bool(ref b) => scalar(b, prefix), [INFO] [stderr] 19 | Value::I64(ref i) => scalar(i, prefix), [INFO] [stderr] 20 | Value::U64(ref i) => scalar(i, prefix), [INFO] [stderr] 21 | Value::F64(ref f) => scalar(f, prefix), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.46s [INFO] running `"docker" "inspect" "10957e0bf27b5b3f1b02d45df8357327cf8f6a7c9774f4b024a9e79e889af2ec"` [INFO] running `"docker" "rm" "-f" "10957e0bf27b5b3f1b02d45df8357327cf8f6a7c9774f4b024a9e79e889af2ec"` [INFO] [stdout] 10957e0bf27b5b3f1b02d45df8357327cf8f6a7c9774f4b024a9e79e889af2ec