[INFO] crate flame 0.2.1-pre2 is already in cache
[INFO] extracting crate flame 0.2.1-pre2 into work/ex/clippy-test-run/sources/stable/reg/flame/0.2.1-pre2
[INFO] extracting crate flame 0.2.1-pre2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flame/0.2.1-pre2
[INFO] validating manifest of flame-0.2.1-pre2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of flame-0.2.1-pre2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing flame-0.2.1-pre2
[INFO] finished frobbing flame-0.2.1-pre2
[INFO] frobbed toml for flame-0.2.1-pre2 written to work/ex/clippy-test-run/sources/stable/reg/flame/0.2.1-pre2/Cargo.toml
[INFO] started frobbing flame-0.2.1-pre2
[INFO] finished frobbing flame-0.2.1-pre2
[INFO] frobbed toml for flame-0.2.1-pre2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flame/0.2.1-pre2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting flame-0.2.1-pre2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/flame/0.2.1-pre2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a5889ddb980a7210988a384ec19c7f23dce8dc8fde3a155fa728c8d614449e28
[INFO] running `"docker" "start" "-a" "a5889ddb980a7210988a384ec19c7f23dce8dc8fde3a155fa728c8d614449e28"`
[INFO] [stderr]     Checking flame v0.2.1-pre2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:197:13
[INFO] [stderr]     |
[INFO] [stderr] 197 |             depth: depth,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `depth`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:337:13
[INFO] [stderr]     |
[INFO] [stderr] 337 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:437:13
[INFO] [stderr]     |
[INFO] [stderr] 437 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:438:13
[INFO] [stderr]     |
[INFO] [stderr] 438 |             description: description,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:489:17
[INFO] [stderr]     |
[INFO] [stderr] 489 |                 id: id,
[INFO] [stderr]     |                 ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(out, "")`
[INFO] [stderr]    --> src/lib.rs:541:9
[INFO] [stderr]     |
[INFO] [stderr] 541 |         writeln!(out, "")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(out)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::writeln_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:197:13
[INFO] [stderr]     |
[INFO] [stderr] 197 |             depth: depth,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `depth`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:337:13
[INFO] [stderr]     |
[INFO] [stderr] 337 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:437:13
[INFO] [stderr]     |
[INFO] [stderr] 437 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:438:13
[INFO] [stderr]     |
[INFO] [stderr] 438 |             description: description,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:489:17
[INFO] [stderr]     |
[INFO] [stderr] 489 |                 id: id,
[INFO] [stderr]     |                 ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(out, "")`
[INFO] [stderr]    --> src/lib.rs:541:9
[INFO] [stderr]     |
[INFO] [stderr] 541 |         writeln!(out, "")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(out)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::writeln_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: digits grouped inconsistently by underscores
[INFO] [stderr]    --> src/lib.rs:175:25
[INFO] [stderr]     |
[INFO] [stderr] 175 |     elapsed.as_secs() * 1000_000_000 + elapsed.subsec_nanos() as u64
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: consider: `1_000_000_000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::inconsistent_digit_grouping)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:515:38
[INFO] [stderr]     |
[INFO] [stderr] 515 |         let ms = span.delta as f32 / 1000000.0;
[INFO] [stderr]     |                                      ^^^^^^^^^ help: consider: `1_000_000.0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: digits grouped inconsistently by underscores
[INFO] [stderr]    --> src/lib.rs:175:25
[INFO] [stderr]     |
[INFO] [stderr] 175 |     elapsed.as_secs() * 1000_000_000 + elapsed.subsec_nanos() as u64
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: consider: `1_000_000_000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::inconsistent_digit_grouping)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:515:38
[INFO] [stderr]     |
[INFO] [stderr] 515 |         let ms = span.delta as f32 / 1000000.0;
[INFO] [stderr]     |                                      ^^^^^^^^^ help: consider: `1_000_000.0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:175:40
[INFO] [stderr]     |
[INFO] [stderr] 175 |     elapsed.as_secs() * 1000_000_000 + elapsed.subsec_nanos() as u64
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:217:20
[INFO] [stderr]     |
[INFO] [stderr] 217 |                 if span.children.len() != 0 && child.collapsable && child.children.len() == 0 {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!span.children.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:217:69
[INFO] [stderr]     |
[INFO] [stderr] 217 |                 if span.children.len() != 0 && child.collapsable && child.children.len() == 0 {
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `child.children.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:238:22
[INFO] [stderr]     |
[INFO] [stderr] 238 |     pub fn into_json(&self) -> String {
[INFO] [stderr]     |                      ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:245:22
[INFO] [stderr]     |
[INFO] [stderr] 245 |     pub fn into_json(&self) -> String {
[INFO] [stderr]     |                      ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:250:36
[INFO] [stderr]     |
[INFO] [stderr] 250 |     pub fn into_json_list(threads: &Vec<Thread>) -> String {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^ help: change this to: `&[Thread]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:250:27
[INFO] [stderr]     |
[INFO] [stderr] 250 |     pub fn into_json_list(threads: &Vec<Thread>) -> String {
[INFO] [stderr]     |                           ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:525:22
[INFO] [stderr]     |
[INFO] [stderr] 525 |             for _ in 0 .. (span.depth + 1) {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=span.depth`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:175:40
[INFO] [stderr]     |
[INFO] [stderr] 175 |     elapsed.as_secs() * 1000_000_000 + elapsed.subsec_nanos() as u64
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:217:20
[INFO] [stderr]     |
[INFO] [stderr] 217 |                 if span.children.len() != 0 && child.collapsable && child.children.len() == 0 {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!span.children.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:217:69
[INFO] [stderr]     |
[INFO] [stderr] 217 |                 if span.children.len() != 0 && child.collapsable && child.children.len() == 0 {
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `child.children.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:238:22
[INFO] [stderr]     |
[INFO] [stderr] 238 |     pub fn into_json(&self) -> String {
[INFO] [stderr]     |                      ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:245:22
[INFO] [stderr]     |
[INFO] [stderr] 245 |     pub fn into_json(&self) -> String {
[INFO] [stderr]     |                      ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:250:36
[INFO] [stderr]     |
[INFO] [stderr] 250 |     pub fn into_json_list(threads: &Vec<Thread>) -> String {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^ help: change this to: `&[Thread]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:250:27
[INFO] [stderr]     |
[INFO] [stderr] 250 |     pub fn into_json_list(threads: &Vec<Thread>) -> String {
[INFO] [stderr]     |                           ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:525:22
[INFO] [stderr]     |
[INFO] [stderr] 525 |             for _ in 0 .. (span.depth + 1) {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=span.depth`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.09s
[INFO] running `"docker" "inspect" "a5889ddb980a7210988a384ec19c7f23dce8dc8fde3a155fa728c8d614449e28"`
[INFO] running `"docker" "rm" "-f" "a5889ddb980a7210988a384ec19c7f23dce8dc8fde3a155fa728c8d614449e28"`
[INFO] [stdout] a5889ddb980a7210988a384ec19c7f23dce8dc8fde3a155fa728c8d614449e28