[INFO] crate flake 0.0.1 is already in cache [INFO] extracting crate flake 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/flake/0.0.1 [INFO] extracting crate flake 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flake/0.0.1 [INFO] validating manifest of flake-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flake-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flake-0.0.1 [INFO] finished frobbing flake-0.0.1 [INFO] frobbed toml for flake-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/flake/0.0.1/Cargo.toml [INFO] started frobbing flake-0.0.1 [INFO] finished frobbing flake-0.0.1 [INFO] frobbed toml for flake-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flake/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flake-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/flake/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dd5d165753f566fbdb30cdeb8916f580a5b5d1a269c209f4ab6604afa0647325 [INFO] running `"docker" "start" "-a" "dd5d165753f566fbdb30cdeb8916f580a5b5d1a269c209f4ab6604afa0647325"` [INFO] [stderr] Checking flake v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return flake; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `flake` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | flake.twepoch = 1288834974657; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_288_834_974_657` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / return ((timestamp - self.twepoch) << self.timestamp_left_shift) | [INFO] [stderr] 66 | | (self.datacenter_id << self.datacenter_id_shift) | [INFO] [stderr] 67 | | (self.worker_id << self.worker_id_shift) | self.sequence; [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 65 | ((timestamp - self.twepoch) << self.timestamp_left_shift) | [INFO] [stderr] 66 | (self.datacenter_id << self.datacenter_id_shift) | [INFO] [stderr] 67 | (self.worker_id << self.worker_id_shift) | self.sequence [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return flake; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `flake` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | flake.twepoch = 1288834974657; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_288_834_974_657` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / return ((timestamp - self.twepoch) << self.timestamp_left_shift) | [INFO] [stderr] 66 | | (self.datacenter_id << self.datacenter_id_shift) | [INFO] [stderr] 67 | | (self.worker_id << self.worker_id_shift) | self.sequence; [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 65 | ((timestamp - self.twepoch) << self.timestamp_left_shift) | [INFO] [stderr] 66 | (self.datacenter_id << self.datacenter_id_shift) | [INFO] [stderr] 67 | (self.worker_id << self.worker_id_shift) | self.sequence [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/mod.rs:4:26 [INFO] [stderr] | [INFO] [stderr] 4 | const WORKER_MASK: u64 = 0x000000000001F000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0001_F000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/mod.rs:5:30 [INFO] [stderr] | [INFO] [stderr] 5 | const DATACENTER_MASK: u64 = 0x00000000003E0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_003E_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/mod.rs:6:29 [INFO] [stderr] | [INFO] [stderr] 6 | const TIMESTAMP_MASK: u64 = 0xFFFFFFFFFFC00000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFC0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/mod.rs:63:26 [INFO] [stderr] | [INFO] [stderr] 63 | let start_sequence = 0xFFFFFF - 20; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/mod.rs:64:24 [INFO] [stderr] | [INFO] [stderr] 64 | let end_sequence = 0xFFFFFF + 20; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `TIMESTAMP_MASK` [INFO] [stderr] --> src/tests/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const TIMESTAMP_MASK: u64 = 0xFFFFFFFFFFC00000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.85s [INFO] running `"docker" "inspect" "dd5d165753f566fbdb30cdeb8916f580a5b5d1a269c209f4ab6604afa0647325"` [INFO] running `"docker" "rm" "-f" "dd5d165753f566fbdb30cdeb8916f580a5b5d1a269c209f4ab6604afa0647325"` [INFO] [stdout] dd5d165753f566fbdb30cdeb8916f580a5b5d1a269c209f4ab6604afa0647325