[INFO] crate flac 0.5.0 is already in cache [INFO] extracting crate flac 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/flac/0.5.0 [INFO] extracting crate flac 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flac/0.5.0 [INFO] validating manifest of flac-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flac-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flac-0.5.0 [INFO] finished frobbing flac-0.5.0 [INFO] frobbed toml for flac-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/flac/0.5.0/Cargo.toml [INFO] started frobbing flac-0.5.0 [INFO] finished frobbing flac-0.5.0 [INFO] frobbed toml for flac-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flac/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flac-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/flac/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 55e77db020a8e45b50bddb2120ee5181752df06597209579ac3b7f43fe0e2823 [INFO] running `"docker" "start" "-a" "55e77db020a8e45b50bddb2120ee5181752df06597209579ac3b7f43fe0e2823"` [INFO] [stderr] Checking hound v1.1.0 [INFO] [stderr] Checking flac v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utility/types.rs:108:7 [INFO] [stderr] | [INFO] [stderr] 108 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utility/types.rs:304:7 [INFO] [stderr] | [INFO] [stderr] 304 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subframe/types.rs:104:7 [INFO] [stderr] | [INFO] [stderr] 104 | capacity: capacity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `capacity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subframe/types.rs:105:7 [INFO] [stderr] | [INFO] [stderr] 105 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subframe/parser.rs:338:7 [INFO] [stderr] | [INFO] [stderr] 338 | contents: contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata/types.rs:58:7 [INFO] [stderr] | [INFO] [stderr] 58 | is_last: is_last, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `is_last` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata/types.rs:59:7 [INFO] [stderr] | [INFO] [stderr] 59 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata/types.rs:60:7 [INFO] [stderr] | [INFO] [stderr] 60 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata/types.rs:942:7 [INFO] [stderr] | [INFO] [stderr] 942 | comments: comments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `comments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata/parser.rs:476:9 [INFO] [stderr] | [INFO] [stderr] 476 | comments: comments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `comments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | producer: producer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `producer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:127:7 [INFO] [stderr] | [INFO] [stderr] 127 | samples_left: samples_left, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `samples_left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utility/types.rs:108:7 [INFO] [stderr] | [INFO] [stderr] 108 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utility/types.rs:304:7 [INFO] [stderr] | [INFO] [stderr] 304 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subframe/types.rs:104:7 [INFO] [stderr] | [INFO] [stderr] 104 | capacity: capacity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `capacity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subframe/types.rs:105:7 [INFO] [stderr] | [INFO] [stderr] 105 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subframe/parser.rs:338:7 [INFO] [stderr] | [INFO] [stderr] 338 | contents: contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata/types.rs:58:7 [INFO] [stderr] | [INFO] [stderr] 58 | is_last: is_last, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `is_last` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata/types.rs:59:7 [INFO] [stderr] | [INFO] [stderr] 59 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata/types.rs:60:7 [INFO] [stderr] | [INFO] [stderr] 60 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata/types.rs:942:7 [INFO] [stderr] | [INFO] [stderr] 942 | comments: comments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `comments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metadata/parser.rs:476:9 [INFO] [stderr] | [INFO] [stderr] 476 | comments: comments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `comments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | producer: producer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `producer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream.rs:127:7 [INFO] [stderr] | [INFO] [stderr] 127 | samples_left: samples_left, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `samples_left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:86:32 [INFO] [stderr] | [INFO] [stderr] 86 | let is_valid = sync_code == 0b11111111111110 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b11_1111_1111_1110` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:166:7 [INFO] [stderr] | [INFO] [stderr] 166 | 0b00000000...0b01111111 => Some((0, byte)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:166:20 [INFO] [stderr] | [INFO] [stderr] 166 | 0b00000000...0b01111111 => Some((0, byte)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:167:7 [INFO] [stderr] | [INFO] [stderr] 167 | 0b11000000...0b11011111 => Some((1, byte & 0b00011111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:167:20 [INFO] [stderr] | [INFO] [stderr] 167 | 0b11000000...0b11011111 => Some((1, byte & 0b00011111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1101_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:167:50 [INFO] [stderr] | [INFO] [stderr] 167 | 0b11000000...0b11011111 => Some((1, byte & 0b00011111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:168:7 [INFO] [stderr] | [INFO] [stderr] 168 | 0b11100000...0b11101111 => Some((2, byte & 0b00001111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:168:20 [INFO] [stderr] | [INFO] [stderr] 168 | 0b11100000...0b11101111 => Some((2, byte & 0b00001111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:168:50 [INFO] [stderr] | [INFO] [stderr] 168 | 0b11100000...0b11101111 => Some((2, byte & 0b00001111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:169:7 [INFO] [stderr] | [INFO] [stderr] 169 | 0b11110000...0b11110111 => Some((3, byte & 0b00000111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:169:20 [INFO] [stderr] | [INFO] [stderr] 169 | 0b11110000...0b11110111 => Some((3, byte & 0b00000111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:169:50 [INFO] [stderr] | [INFO] [stderr] 169 | 0b11110000...0b11110111 => Some((3, byte & 0b00000111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:170:7 [INFO] [stderr] | [INFO] [stderr] 170 | 0b11111000...0b11111011 => Some((4, byte & 0b00000011)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:170:20 [INFO] [stderr] | [INFO] [stderr] 170 | 0b11111000...0b11111011 => Some((4, byte & 0b00000011)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:170:50 [INFO] [stderr] | [INFO] [stderr] 170 | 0b11111000...0b11111011 => Some((4, byte & 0b00000011)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:171:7 [INFO] [stderr] | [INFO] [stderr] 171 | 0b11111100...0b11111101 => Some((5, byte & 0b00000001)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:171:20 [INFO] [stderr] | [INFO] [stderr] 171 | 0b11111100...0b11111101 => Some((5, byte & 0b00000001)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:171:50 [INFO] [stderr] | [INFO] [stderr] 171 | 0b11111100...0b11111101 => Some((5, byte & 0b00000001)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:172:7 [INFO] [stderr] | [INFO] [stderr] 172 | 0b11111110 => if is_u64 { Some((6, 0)) } else { None }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:193:16 [INFO] [stderr] | [INFO] [stderr] 193 | if byte >= 0b10000000 && byte <= 0b10111111 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:193:38 [INFO] [stderr] | [INFO] [stderr] 193 | if byte >= 0b10000000 && byte <= 0b10111111 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:194:40 [INFO] [stderr] | [INFO] [stderr] 194 | result = (result << 6) + (byte & 0b00111111); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:266:19 [INFO] [stderr] | [INFO] [stderr] 266 | 0b0010 => 176400, [INFO] [stderr] | ^^^^^^ help: consider: `176_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:267:19 [INFO] [stderr] | [INFO] [stderr] 267 | 0b0011 => 192000, [INFO] [stderr] | ^^^^^^ help: consider: `192_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:128:39 [INFO] [stderr] | [INFO] [stderr] 128 | let subframe_type = (byte >> 1) & 0b111111; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | 0b000000 => constant(input, bits_per_sample), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | 0b000001 => verbatim(input, bits_per_sample, block_size) [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:150:5 [INFO] [stderr] | [INFO] [stderr] 150 | 0b001000...0b001100 => fixed(input, subframe_type & 0b0111, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:150:16 [INFO] [stderr] | [INFO] [stderr] 150 | 0b001000...0b001100 => fixed(input, subframe_type & 0b0111, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | 0b100000...0b111111 => lpc(input, (subframe_type & 0b011111) + 1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:152:16 [INFO] [stderr] | [INFO] [stderr] 152 | 0b100000...0b111111 => lpc(input, (subframe_type & 0b011111) + 1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:152:56 [INFO] [stderr] | [INFO] [stderr] 152 | 0b100000...0b111111 => lpc(input, (subframe_type & 0b011111) + 1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/types.rs:123:7 [INFO] [stderr] | [INFO] [stderr] 123 | 0b10000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/types.rs:125:7 [INFO] [stderr] | [INFO] [stderr] 125 | 0b00000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/types.rs:454:15 [INFO] [stderr] | [INFO] [stderr] 454 | flag |= 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/types.rs:508:16 [INFO] [stderr] | [INFO] [stderr] 508 | flags |= 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/types.rs:512:16 [INFO] [stderr] | [INFO] [stderr] 512 | flags |= 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/parser.rs:282:37 [INFO] [stderr] | [INFO] [stderr] 282 | let block_type = block_byte & 0b01111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/metadata/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | mod metadata; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/types.rs:499:24 [INFO] [stderr] | [INFO] [stderr] 499 | assert_eq!(result, 1214606444); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_214_606_444` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/types.rs:510:24 [INFO] [stderr] | [INFO] [stderr] 510 | assert_eq!(result, 1214606444) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_214_606_444` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:314:38 [INFO] [stderr] | [INFO] [stderr] 314 | assert_eq!(to_u32(&bytes[0..1]), 0x00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:315:38 [INFO] [stderr] | [INFO] [stderr] 315 | assert_eq!(to_u32(&bytes[3..5]), 0x00006789); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_6789` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:316:38 [INFO] [stderr] | [INFO] [stderr] 316 | assert_eq!(to_u32(&bytes[1..4]), 0x00234567); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0023_4567` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:317:37 [INFO] [stderr] | [INFO] [stderr] 317 | assert_eq!(to_u32(&bytes[4..]), 0x89abcdef); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x89ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:332:28 [INFO] [stderr] | [INFO] [stderr] 332 | assert_eq!(extend_sign(8388608, 24), -8388608); [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_608` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:332:43 [INFO] [stderr] | [INFO] [stderr] 332 | assert_eq!(extend_sign(8388608, 24), -8388608); [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_608` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:333:28 [INFO] [stderr] | [INFO] [stderr] 333 | assert_eq!(extend_sign(8388607, 24), 8388607); [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_607` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:333:42 [INFO] [stderr] | [INFO] [stderr] 333 | assert_eq!(extend_sign(8388607, 24), 8388607); [INFO] [stderr] | ^^^^^^^ help: consider: `8_388_607` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:334:28 [INFO] [stderr] | [INFO] [stderr] 334 | assert_eq!(extend_sign(2147483648, 32), -2147483648); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:334:46 [INFO] [stderr] | [INFO] [stderr] 334 | assert_eq!(extend_sign(2147483648, 32), -2147483648); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:335:28 [INFO] [stderr] | [INFO] [stderr] 335 | assert_eq!(extend_sign(2147483647, 32), 2147483647); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:335:45 [INFO] [stderr] | [INFO] [stderr] 335 | assert_eq!(extend_sign(2147483647, 32), 2147483647); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:350:34 [INFO] [stderr] | [INFO] [stderr] 350 | assert_eq!(power_of_two(31), 2147483648); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:399:44 [INFO] [stderr] | [INFO] [stderr] 399 | assert!((&mut buffer[..]).write_le_u24(0xabcdef).is_ok()); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:402:44 [INFO] [stderr] | [INFO] [stderr] 402 | assert!((&mut buffer[..]).write_le_u24(0x54a21d).is_ok()); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0054_a21d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:405:44 [INFO] [stderr] | [INFO] [stderr] 405 | assert!((&mut buffer[..]).write_le_u24(0xffeedd).is_ok()); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_eedd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:413:44 [INFO] [stderr] | [INFO] [stderr] 413 | assert!((&mut buffer[..]).write_be_u24(0xabcdef).is_ok()); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:416:44 [INFO] [stderr] | [INFO] [stderr] 416 | assert!((&mut buffer[..]).write_be_u24(0x54a21d).is_ok()); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0054_a21d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:419:44 [INFO] [stderr] | [INFO] [stderr] 419 | assert!((&mut buffer[..]).write_be_u24(0xffeedd).is_ok()); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_eedd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:427:44 [INFO] [stderr] | [INFO] [stderr] 427 | assert!((&mut buffer[..]).write_le_u32(0x89abcdef).is_ok()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x89ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:430:44 [INFO] [stderr] | [INFO] [stderr] 430 | assert!((&mut buffer[..]).write_le_u32(0xc354a21d).is_ok()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc354_a21d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:433:44 [INFO] [stderr] | [INFO] [stderr] 433 | assert!((&mut buffer[..]).write_le_u32(0xffeeddcc).is_ok()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffee_ddcc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:441:44 [INFO] [stderr] | [INFO] [stderr] 441 | assert!((&mut buffer[..]).write_be_u32(0x89abcdef).is_ok()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x89ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:444:44 [INFO] [stderr] | [INFO] [stderr] 444 | assert!((&mut buffer[..]).write_be_u32(0xc354a21d).is_ok()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc354_a21d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:447:44 [INFO] [stderr] | [INFO] [stderr] 447 | assert!((&mut buffer[..]).write_be_u32(0xffeeddcc).is_ok()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffee_ddcc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:455:44 [INFO] [stderr] | [INFO] [stderr] 455 | assert!((&mut buffer[..]).write_le_u64(0x0123456789abcdef).is_ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0123_4567_89ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:458:44 [INFO] [stderr] | [INFO] [stderr] 458 | assert!((&mut buffer[..]).write_le_u64(0x3f9348cda3b8d022).is_ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3f93_48cd_a3b8_d022` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:461:44 [INFO] [stderr] | [INFO] [stderr] 461 | assert!((&mut buffer[..]).write_le_u64(0x0f1e2d3c4b5a6978).is_ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0f1e_2d3c_4b5a_6978` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:469:44 [INFO] [stderr] | [INFO] [stderr] 469 | assert!((&mut buffer[..]).write_be_u64(0x0123456789abcdef).is_ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0123_4567_89ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:472:44 [INFO] [stderr] | [INFO] [stderr] 472 | assert!((&mut buffer[..]).write_be_u64(0x3f9348cda3b8d022).is_ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3f93_48cd_a3b8_d022` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utility/mod.rs:475:44 [INFO] [stderr] | [INFO] [stderr] 475 | assert!((&mut buffer[..]).write_be_u64(0x0f1e2d3c4b5a6978).is_ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0f1e_2d3c_4b5a_6978` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:86:32 [INFO] [stderr] | [INFO] [stderr] 86 | let is_valid = sync_code == 0b11111111111110 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0b11_1111_1111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:166:7 [INFO] [stderr] | [INFO] [stderr] 166 | 0b00000000...0b01111111 => Some((0, byte)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:166:20 [INFO] [stderr] | [INFO] [stderr] 166 | 0b00000000...0b01111111 => Some((0, byte)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:167:7 [INFO] [stderr] | [INFO] [stderr] 167 | 0b11000000...0b11011111 => Some((1, byte & 0b00011111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:167:20 [INFO] [stderr] | [INFO] [stderr] 167 | 0b11000000...0b11011111 => Some((1, byte & 0b00011111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1101_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:167:50 [INFO] [stderr] | [INFO] [stderr] 167 | 0b11000000...0b11011111 => Some((1, byte & 0b00011111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:168:7 [INFO] [stderr] | [INFO] [stderr] 168 | 0b11100000...0b11101111 => Some((2, byte & 0b00001111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:168:20 [INFO] [stderr] | [INFO] [stderr] 168 | 0b11100000...0b11101111 => Some((2, byte & 0b00001111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:168:50 [INFO] [stderr] | [INFO] [stderr] 168 | 0b11100000...0b11101111 => Some((2, byte & 0b00001111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:169:7 [INFO] [stderr] | [INFO] [stderr] 169 | 0b11110000...0b11110111 => Some((3, byte & 0b00000111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:169:20 [INFO] [stderr] | [INFO] [stderr] 169 | 0b11110000...0b11110111 => Some((3, byte & 0b00000111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:169:50 [INFO] [stderr] | [INFO] [stderr] 169 | 0b11110000...0b11110111 => Some((3, byte & 0b00000111)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:170:7 [INFO] [stderr] | [INFO] [stderr] 170 | 0b11111000...0b11111011 => Some((4, byte & 0b00000011)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:170:20 [INFO] [stderr] | [INFO] [stderr] 170 | 0b11111000...0b11111011 => Some((4, byte & 0b00000011)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:170:50 [INFO] [stderr] | [INFO] [stderr] 170 | 0b11111000...0b11111011 => Some((4, byte & 0b00000011)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:171:7 [INFO] [stderr] | [INFO] [stderr] 171 | 0b11111100...0b11111101 => Some((5, byte & 0b00000001)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:171:20 [INFO] [stderr] | [INFO] [stderr] 171 | 0b11111100...0b11111101 => Some((5, byte & 0b00000001)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:171:50 [INFO] [stderr] | [INFO] [stderr] 171 | 0b11111100...0b11111101 => Some((5, byte & 0b00000001)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:172:7 [INFO] [stderr] | [INFO] [stderr] 172 | 0b11111110 => if is_u64 { Some((6, 0)) } else { None }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:193:16 [INFO] [stderr] | [INFO] [stderr] 193 | if byte >= 0b10000000 && byte <= 0b10111111 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:193:38 [INFO] [stderr] | [INFO] [stderr] 193 | if byte >= 0b10000000 && byte <= 0b10111111 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:194:40 [INFO] [stderr] | [INFO] [stderr] 194 | result = (result << 6) + (byte & 0b00111111); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:266:19 [INFO] [stderr] | [INFO] [stderr] 266 | 0b0010 => 176400, [INFO] [stderr] | ^^^^^^ help: consider: `176_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:267:19 [INFO] [stderr] | [INFO] [stderr] 267 | 0b0011 => 192000, [INFO] [stderr] | ^^^^^^ help: consider: `192_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:416:61 [INFO] [stderr] | [INFO] [stderr] 416 | , IResult::Done(slice, NumberType::Sample(67662254016)) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `67_662_254_016` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:463:37 [INFO] [stderr] | [INFO] [stderr] 463 | sample_rate: 192000, [INFO] [stderr] | ^^^^^^ help: consider: `192_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame/parser.rs:476:51 [INFO] [stderr] | [INFO] [stderr] 476 | number: NumberType::Sample(68719476732), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `68_719_476_732` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:128:39 [INFO] [stderr] | [INFO] [stderr] 128 | let subframe_type = (byte >> 1) & 0b111111; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | 0b000000 => constant(input, bits_per_sample), [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | 0b000001 => verbatim(input, bits_per_sample, block_size) [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:150:5 [INFO] [stderr] | [INFO] [stderr] 150 | 0b001000...0b001100 => fixed(input, subframe_type & 0b0111, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:150:16 [INFO] [stderr] | [INFO] [stderr] 150 | 0b001000...0b001100 => fixed(input, subframe_type & 0b0111, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | 0b100000...0b111111 => lpc(input, (subframe_type & 0b011111) + 1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:152:16 [INFO] [stderr] | [INFO] [stderr] 152 | 0b100000...0b111111 => lpc(input, (subframe_type & 0b011111) + 1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:152:56 [INFO] [stderr] | [INFO] [stderr] 152 | 0b100000...0b111111 => lpc(input, (subframe_type & 0b011111) + 1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:467:24 [INFO] [stderr] | [INFO] [stderr] 467 | let inputs = [ (&[0b10000000][..], 0) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:468:24 [INFO] [stderr] | [INFO] [stderr] 468 | , (&[0b11000000][..], 1) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:469:24 [INFO] [stderr] | [INFO] [stderr] 469 | , (&[0b00000001][..], 0) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:470:24 [INFO] [stderr] | [INFO] [stderr] 470 | , (&[0b11111111][..], 7) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:471:24 [INFO] [stderr] | [INFO] [stderr] 471 | , (&[0b00000000, 0b10000000][..], 0) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:471:36 [INFO] [stderr] | [INFO] [stderr] 471 | , (&[0b00000000, 0b10000000][..], 0) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:472:24 [INFO] [stderr] | [INFO] [stderr] 472 | , (&[0b10000000, 0b10000000][..], 1) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:472:36 [INFO] [stderr] | [INFO] [stderr] 472 | , (&[0b10000000, 0b10000000][..], 1) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:473:24 [INFO] [stderr] | [INFO] [stderr] 473 | , (&[0b00000000, 0b00000001][..], 0) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:473:36 [INFO] [stderr] | [INFO] [stderr] 473 | , (&[0b00000000, 0b00000001][..], 0) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:474:24 [INFO] [stderr] | [INFO] [stderr] 474 | , (&[0b11111110, 0b00000010][..], 7) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:474:36 [INFO] [stderr] | [INFO] [stderr] 474 | , (&[0b11111110, 0b00000010][..], 7) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:475:24 [INFO] [stderr] | [INFO] [stderr] 475 | , (&[0b10101010, 0b00000000][..], 7) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:475:36 [INFO] [stderr] | [INFO] [stderr] 475 | , (&[0b10101010, 0b00000000][..], 7) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:501:24 [INFO] [stderr] | [INFO] [stderr] 501 | let inputs = [ (&[0b01010100][..], 0) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0101_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:502:24 [INFO] [stderr] | [INFO] [stderr] 502 | , (&[0b00011111][..], 0) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:503:24 [INFO] [stderr] | [INFO] [stderr] 503 | , (&[0b00000000][..], 0) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:504:24 [INFO] [stderr] | [INFO] [stderr] 504 | , (&[0b10000000][..], 0) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:506:50 [INFO] [stderr] | [INFO] [stderr] 506 | let results = [ IResult::Done((&[][..], 0), (0b101010, false)) [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:507:50 [INFO] [stderr] | [INFO] [stderr] 507 | , IResult::Done((&[][..], 0), (0b001111, true)) [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/subframe/parser.rs:508:50 [INFO] [stderr] | [INFO] [stderr] 508 | , IResult::Done((&[][..], 0), (0b000000, false)) [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/types.rs:123:7 [INFO] [stderr] | [INFO] [stderr] 123 | 0b10000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/types.rs:125:7 [INFO] [stderr] | [INFO] [stderr] 125 | 0b00000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/types.rs:454:15 [INFO] [stderr] | [INFO] [stderr] 454 | flag |= 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/types.rs:508:16 [INFO] [stderr] | [INFO] [stderr] 508 | flags |= 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/types.rs:512:16 [INFO] [stderr] | [INFO] [stderr] 512 | flags |= 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/types.rs:789:24 [INFO] [stderr] | [INFO] [stderr] 789 | total_samples: 10194762, [INFO] [stderr] | ^^^^^^^^ help: consider: `10_194_762` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/types.rs:865:24 [INFO] [stderr] | [INFO] [stderr] 865 | sample_number: 0xffffffffffffffff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/types.rs:870:24 [INFO] [stderr] | [INFO] [stderr] 870 | sample_number: 0xffffffffffffffff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/types.rs:875:24 [INFO] [stderr] | [INFO] [stderr] 875 | sample_number: 0xffffffffffffffff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/parser.rs:282:37 [INFO] [stderr] | [INFO] [stderr] 282 | let block_type = block_byte & 0b01111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/parser.rs:373:24 [INFO] [stderr] | [INFO] [stderr] 373 | total_samples: 10194762, [INFO] [stderr] | ^^^^^^^^ help: consider: `10_194_762` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/parser.rs:432:24 [INFO] [stderr] | [INFO] [stderr] 432 | sample_number: 0xffffffffffffffff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/parser.rs:437:24 [INFO] [stderr] | [INFO] [stderr] 437 | sample_number: 0xffffffffffffffff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metadata/parser.rs:442:24 [INFO] [stderr] | [INFO] [stderr] 442 | sample_number: 0xffffffffffffffff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/metadata/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | mod metadata; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/utility/types.rs:362:9 [INFO] [stderr] | [INFO] [stderr] 362 | let mut buffer = &mut self.buffer; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/utility/types.rs:249:27 [INFO] [stderr] | [INFO] [stderr] 249 | let offset_ptr = self.data.as_ptr().offset(self.offset as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.as_ptr().add(self.offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:409:19 [INFO] [stderr] | [INFO] [stderr] 409 | let min = $normal::min_value() as $extended; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from($normal::min_value())` [INFO] [stderr] ... [INFO] [stderr] 453 | sample!(i8, i16, 8); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:410:19 [INFO] [stderr] | [INFO] [stderr] 410 | let max = $normal::max_value() as $extended; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from($normal::max_value())` [INFO] [stderr] ... [INFO] [stderr] 453 | sample!(i8, i16, 8); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:421:9 [INFO] [stderr] | [INFO] [stderr] 421 | sample as Self [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i16::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 453 | sample!(i8, i16, 8); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:433:19 [INFO] [stderr] | [INFO] [stderr] 433 | let min = $extended::min_value() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from($extended::min_value())` [INFO] [stderr] ... [INFO] [stderr] 453 | sample!(i8, i16, 8); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:434:19 [INFO] [stderr] | [INFO] [stderr] 434 | let max = $extended::max_value() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from($extended::max_value())` [INFO] [stderr] ... [INFO] [stderr] 453 | sample!(i8, i16, 8); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:436:23 [INFO] [stderr] | [INFO] [stderr] 436 | let _sample = sample as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 453 | sample!(i8, i16, 8); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:409:19 [INFO] [stderr] | [INFO] [stderr] 409 | let min = $normal::min_value() as $extended; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from($normal::min_value())` [INFO] [stderr] ... [INFO] [stderr] 454 | sample!(i16, i32, 16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:410:19 [INFO] [stderr] | [INFO] [stderr] 410 | let max = $normal::max_value() as $extended; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from($normal::max_value())` [INFO] [stderr] ... [INFO] [stderr] 454 | sample!(i16, i32, 16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:421:9 [INFO] [stderr] | [INFO] [stderr] 421 | sample as Self [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 454 | sample!(i16, i32, 16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:426:9 [INFO] [stderr] | [INFO] [stderr] 426 | sample as Self [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 454 | sample!(i16, i32, 16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:433:19 [INFO] [stderr] | [INFO] [stderr] 433 | let min = $extended::min_value() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from($extended::min_value())` [INFO] [stderr] ... [INFO] [stderr] 454 | sample!(i16, i32, 16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:434:19 [INFO] [stderr] | [INFO] [stderr] 434 | let max = $extended::max_value() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from($extended::max_value())` [INFO] [stderr] ... [INFO] [stderr] 454 | sample!(i16, i32, 16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:436:23 [INFO] [stderr] | [INFO] [stderr] 436 | let _sample = sample as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 454 | sample!(i16, i32, 16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:409:19 [INFO] [stderr] | [INFO] [stderr] 409 | let min = $normal::min_value() as $extended; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from($normal::min_value())` [INFO] [stderr] ... [INFO] [stderr] 455 | sample!(i32, i64, 32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:410:19 [INFO] [stderr] | [INFO] [stderr] 410 | let max = $normal::max_value() as $extended; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from($normal::max_value())` [INFO] [stderr] ... [INFO] [stderr] 455 | sample!(i32, i64, 32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:421:9 [INFO] [stderr] | [INFO] [stderr] 421 | sample as Self [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 455 | sample!(i32, i64, 32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:426:9 [INFO] [stderr] | [INFO] [stderr] 426 | sample as Self [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 455 | sample!(i32, i64, 32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:436:23 [INFO] [stderr] | [INFO] [stderr] 436 | let _sample = sample as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 455 | sample!(i32, i64, 32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:439:16 [INFO] [stderr] | [INFO] [stderr] 439 | Some(sample as $extended) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 455 | sample!(i32, i64, 32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:447:9 [INFO] [stderr] | [INFO] [stderr] 447 | sample as Self [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 455 | sample!(i32, i64, 32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utility/mod.rs:209:15 [INFO] [stderr] | [INFO] [stderr] 209 | result + ((byte as u32) << ((length - 1 - i) * 8)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/frame/parser.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | &mut subframes[0..(frame_header.channels as usize)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/frame/parser.rs:84:20 [INFO] [stderr] | [INFO] [stderr] 84 | let sync_code = ((bytes[0] as u16) << 6) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/frame/parser.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | ((bytes[1] as u16) >> 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/frame/parser.rs:187:22 [INFO] [stderr] | [INFO] [stderr] 187 | let mut result = value as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/frame/parser.rs:191:16 [INFO] [stderr] | [INFO] [stderr] 191 | let byte = *_byte as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/frame/parser.rs:257:47 [INFO] [stderr] | [INFO] [stderr] 257 | 0b0010...0b0101 => 576 * power_of_two(block_byte as u32 - 2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(block_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/frame/parser.rs:259:47 [INFO] [stderr] | [INFO] [stderr] 259 | 0b1000...0b1111 => 256 * power_of_two(block_byte as u32 - 8), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(block_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/subframe/types.rs:25:3 [INFO] [stderr] | [INFO] [stderr] 25 | LPC(LPC), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 25 | LPC(Box), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/subframe/parser.rs:179:20 [INFO] [stderr] | [INFO] [stderr] 179 | &mut warmup[0..order]) ~ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/subframe/parser.rs:206:1 [INFO] [stderr] | [INFO] [stderr] 206 | / pub fn lpc<'a, S>(input: (&'a [u8], usize), [INFO] [stderr] 207 | | order: usize, [INFO] [stderr] 208 | | bits_per_sample: usize, [INFO] [stderr] 209 | | block_size: usize, [INFO] [stderr] ... | [INFO] [stderr] 239 | | LPCParser) [INFO] [stderr] 240 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/subframe/parser.rs:219:20 [INFO] [stderr] | [INFO] [stderr] 219 | &mut warmup[0..order]) ~ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/subframe/parser.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | &mut qlp_coefficients[0..order] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `output`. [INFO] [stderr] --> src/subframe/decoder.rs:93:16 [INFO] [stderr] | [INFO] [stderr] 93 | for i in 0..output.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for in &mut output { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `output` [INFO] [stderr] --> src/subframe/decoder.rs:105:16 [INFO] [stderr] | [INFO] [stderr] 105 | for i in 0..order { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 105 | for (i, ) in output.iter_mut().enumerate().take(order) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `output` [INFO] [stderr] --> src/subframe/decoder.rs:117:16 [INFO] [stderr] | [INFO] [stderr] 117 | for i in 0..order { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 117 | for (i, ) in output.iter_mut().enumerate().take(order) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `byte` [INFO] [stderr] --> src/metadata/types.rs:132:30 [INFO] [stderr] | [INFO] [stderr] 132 | try!(buffer.write_u8(byte + 0)); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata/parser.rs:39:32 [INFO] [stderr] | [INFO] [stderr] 39 | let sample_rate = ((bytes[0] as u32) << 12) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata/parser.rs:40:32 [INFO] [stderr] | [INFO] [stderr] 40 | ((bytes[1] as u32) << 4) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata/parser.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | ((bytes[2] as u32) >> 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata/parser.rs:45:33 [INFO] [stderr] | [INFO] [stderr] 45 | let total_samples = (((bytes[3] as u64) & 0x0f) << 32) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata/parser.rs:46:32 [INFO] [stderr] | [INFO] [stderr] 46 | ((bytes[4] as u64) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata/parser.rs:47:32 [INFO] [stderr] | [INFO] [stderr] 47 | ((bytes[5] as u64) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata/parser.rs:48:32 [INFO] [stderr] | [INFO] [stderr] 48 | ((bytes[6] as u64) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata/parser.rs:49:31 [INFO] [stderr] | [INFO] [stderr] 49 | (bytes[7] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/metadata/metadata.rs:264:1 [INFO] [stderr] | [INFO] [stderr] 264 | / pub fn get_picture(filename: &str, [INFO] [stderr] 265 | | picture_type: Option, [INFO] [stderr] 266 | | mime_type: Option<&str>, [INFO] [stderr] 267 | | description: Option<&str>, [INFO] [stderr] ... | [INFO] [stderr] 306 | | }) [INFO] [stderr] 307 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata/metadata.rs:287:20 [INFO] [stderr] | [INFO] [stderr] 287 | let area = (picture.width as u64) * (picture.height as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(picture.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata/metadata.rs:287:45 [INFO] [stderr] | [INFO] [stderr] 287 | let area = (picture.width as u64) * (picture.height as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(picture.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/stream.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new(reader: R) -> Result, ErrorKind> { [INFO] [stderr] 33 | | let producer = ReadStream::new(reader); [INFO] [stderr] 34 | | [INFO] [stderr] 35 | | Stream::from_stream_producer(producer) [INFO] [stderr] 36 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/utility/types.rs:362:9 [INFO] [stderr] | [INFO] [stderr] 362 | let mut buffer = &mut self.buffer; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> examples/parse.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | channels: info.channels as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(info.channels)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> examples/parse.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | bits_per_sample: info.bits_per_sample as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(info.bits_per_sample)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> examples/parse.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | let mut output = hound::WavWriter::create("test.wav", spec) [INFO] [stderr] | ______________________^ [INFO] [stderr] 53 | | .ok().expect("failed to create wav file"); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> examples/parse.rs:56:7 [INFO] [stderr] | [INFO] [stderr] 56 | output.write_sample(sample).ok().expect("failed to write sample"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in s.enumerate()` or similar iterators [INFO] [stderr] --> examples/read.rs:89:29 [INFO] [stderr] | [INFO] [stderr] 89 | for seek_point in s { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/utility/types.rs:249:27 [INFO] [stderr] | [INFO] [stderr] 249 | let offset_ptr = self.data.as_ptr().offset(self.offset as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.data.as_ptr().add(self.offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:409:19 [INFO] [stderr] | [INFO] [stderr] 409 | let min = $normal::min_value() as $extended; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from($normal::min_value())` [INFO] [stderr] ... [INFO] [stderr] 453 | sample!(i8, i16, 8); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:410:19 [INFO] [stderr] | [INFO] [stderr] 410 | let max = $normal::max_value() as $extended; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from($normal::max_value())` [INFO] [stderr] ... [INFO] [stderr] 453 | sample!(i8, i16, 8); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:421:9 [INFO] [stderr] | [INFO] [stderr] 421 | sample as Self [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i16::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 453 | sample!(i8, i16, 8); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:433:19 [INFO] [stderr] | [INFO] [stderr] 433 | let min = $extended::min_value() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from($extended::min_value())` [INFO] [stderr] ... [INFO] [stderr] 453 | sample!(i8, i16, 8); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:434:19 [INFO] [stderr] | [INFO] [stderr] 434 | let max = $extended::max_value() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from($extended::max_value())` [INFO] [stderr] ... [INFO] [stderr] 453 | sample!(i8, i16, 8); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:436:23 [INFO] [stderr] | [INFO] [stderr] 436 | let _sample = sample as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 453 | sample!(i8, i16, 8); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:409:19 [INFO] [stderr] | [INFO] [stderr] 409 | let min = $normal::min_value() as $extended; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from($normal::min_value())` [INFO] [stderr] ... [INFO] [stderr] 454 | sample!(i16, i32, 16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:410:19 [INFO] [stderr] | [INFO] [stderr] 410 | let max = $normal::max_value() as $extended; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from($normal::max_value())` [INFO] [stderr] ... [INFO] [stderr] 454 | sample!(i16, i32, 16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:421:9 [INFO] [stderr] | [INFO] [stderr] 421 | sample as Self [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 454 | sample!(i16, i32, 16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:426:9 [INFO] [stderr] | [INFO] [stderr] 426 | sample as Self [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 454 | sample!(i16, i32, 16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:433:19 [INFO] [stderr] | [INFO] [stderr] 433 | let min = $extended::min_value() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from($extended::min_value())` [INFO] [stderr] ... [INFO] [stderr] 454 | sample!(i16, i32, 16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:434:19 [INFO] [stderr] | [INFO] [stderr] 434 | let max = $extended::max_value() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from($extended::max_value())` [INFO] [stderr] ... [INFO] [stderr] 454 | sample!(i16, i32, 16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:436:23 [INFO] [stderr] | [INFO] [stderr] 436 | let _sample = sample as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 454 | sample!(i16, i32, 16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:409:19 [INFO] [stderr] | [INFO] [stderr] 409 | let min = $normal::min_value() as $extended; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from($normal::min_value())` [INFO] [stderr] ... [INFO] [stderr] 455 | sample!(i32, i64, 32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:410:19 [INFO] [stderr] | [INFO] [stderr] 410 | let max = $normal::max_value() as $extended; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from($normal::max_value())` [INFO] [stderr] ... [INFO] [stderr] 455 | sample!(i32, i64, 32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:421:9 [INFO] [stderr] | [INFO] [stderr] 421 | sample as Self [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 455 | sample!(i32, i64, 32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:426:9 [INFO] [stderr] | [INFO] [stderr] 426 | sample as Self [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 455 | sample!(i32, i64, 32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:436:23 [INFO] [stderr] | [INFO] [stderr] 436 | let _sample = sample as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 455 | sample!(i32, i64, 32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:439:16 [INFO] [stderr] | [INFO] [stderr] 439 | Some(sample as $extended) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 455 | sample!(i32, i64, 32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:447:9 [INFO] [stderr] | [INFO] [stderr] 447 | sample as Self [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(sample)` [INFO] [stderr] ... [INFO] [stderr] 455 | sample!(i32, i64, 32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:519:36 [INFO] [stderr] | [INFO] [stderr] 519 | assert_eq!(Sample::to_normal(min as i16), Some(min)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i16::from(min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:521:36 [INFO] [stderr] | [INFO] [stderr] 521 | assert_eq!(Sample::to_normal(max as i16), Some(max)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i16::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:523:36 [INFO] [stderr] | [INFO] [stderr] 523 | assert_eq!(Sample::to_normal((min as i16) - 1), None); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:524:36 [INFO] [stderr] | [INFO] [stderr] 524 | assert_eq!(Sample::to_normal((max as i16) + 1), None); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i16::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:531:36 [INFO] [stderr] | [INFO] [stderr] 531 | assert_eq!(Sample::to_normal(min as i32), Some(min)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:533:36 [INFO] [stderr] | [INFO] [stderr] 533 | assert_eq!(Sample::to_normal(max as i32), Some(max)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:535:36 [INFO] [stderr] | [INFO] [stderr] 535 | assert_eq!(Sample::to_normal((min as i32) - 1), None); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:536:36 [INFO] [stderr] | [INFO] [stderr] 536 | assert_eq!(Sample::to_normal((max as i32) + 1), None); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:543:36 [INFO] [stderr] | [INFO] [stderr] 543 | assert_eq!(Sample::to_normal(min as i64), Some(min)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:545:36 [INFO] [stderr] | [INFO] [stderr] 545 | assert_eq!(Sample::to_normal(max as i64), Some(max)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:547:36 [INFO] [stderr] | [INFO] [stderr] 547 | assert_eq!(Sample::to_normal((min as i64) - 1), None); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:548:36 [INFO] [stderr] | [INFO] [stderr] 548 | assert_eq!(Sample::to_normal((max as i64) + 1), None); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:570:47 [INFO] [stderr] | [INFO] [stderr] 570 | assert_eq!(::from_i8(min), min as i16); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i16::from(min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:571:48 [INFO] [stderr] | [INFO] [stderr] 571 | assert_eq!(::from_i8(zero), zero as i16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i16::from(zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:572:47 [INFO] [stderr] | [INFO] [stderr] 572 | assert_eq!(::from_i8(max), max as i16); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i16::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:573:47 [INFO] [stderr] | [INFO] [stderr] 573 | assert_eq!(::from_i8(min), min as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:574:48 [INFO] [stderr] | [INFO] [stderr] 574 | assert_eq!(::from_i8(zero), zero as i32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:575:47 [INFO] [stderr] | [INFO] [stderr] 575 | assert_eq!(::from_i8(max), max as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:576:47 [INFO] [stderr] | [INFO] [stderr] 576 | assert_eq!(::from_i8(min), min as i64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:577:48 [INFO] [stderr] | [INFO] [stderr] 577 | assert_eq!(::from_i8(zero), zero as i64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:578:47 [INFO] [stderr] | [INFO] [stderr] 578 | assert_eq!(::from_i8(max), max as i64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:590:48 [INFO] [stderr] | [INFO] [stderr] 590 | assert_eq!(::from_i16(min), min as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:591:49 [INFO] [stderr] | [INFO] [stderr] 591 | assert_eq!(::from_i16(zero), zero as i32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:592:48 [INFO] [stderr] | [INFO] [stderr] 592 | assert_eq!(::from_i16(max), max as i32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:593:48 [INFO] [stderr] | [INFO] [stderr] 593 | assert_eq!(::from_i16(min), min as i64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:594:49 [INFO] [stderr] | [INFO] [stderr] 594 | assert_eq!(::from_i16(zero), zero as i64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:595:48 [INFO] [stderr] | [INFO] [stderr] 595 | assert_eq!(::from_i16(max), max as i64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:610:53 [INFO] [stderr] | [INFO] [stderr] 610 | assert_eq!(::from_i32(min), Some(min as i64)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:611:54 [INFO] [stderr] | [INFO] [stderr] 611 | assert_eq!(::from_i32(zero), Some(zero as i64)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:612:53 [INFO] [stderr] | [INFO] [stderr] 612 | assert_eq!(::from_i32(max), Some(max as i64)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:627:54 [INFO] [stderr] | [INFO] [stderr] 627 | assert_eq!(::from_i32_lossy(min), min as i64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:628:55 [INFO] [stderr] | [INFO] [stderr] 628 | assert_eq!(::from_i32_lossy(zero), zero as i64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(zero)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utility/types.rs:629:54 [INFO] [stderr] | [INFO] [stderr] 629 | assert_eq!(::from_i32_lossy(max), max as i64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/utility/mod.rs:209:15 [INFO] [stderr] | [INFO] [stderr] 209 | result + ((byte as u32) << ((length - 1 - i) * 8)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/frame/parser.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | &mut subframes[0..(frame_header.channels as usize)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/frame/parser.rs:84:20 [INFO] [stderr] | [INFO] [stderr] 84 | let sync_code = ((bytes[0] as u16) << 6) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/frame/parser.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | ((bytes[1] as u16) >> 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/frame/parser.rs:187:22 [INFO] [stderr] | [INFO] [stderr] 187 | let mut result = value as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/frame/parser.rs:191:16 [INFO] [stderr] | [INFO] [stderr] 191 | let byte = *_byte as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(*_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/frame/parser.rs:257:47 [INFO] [stderr] | [INFO] [stderr] 257 | 0b0010...0b0101 => 576 * power_of_two(block_byte as u32 - 2), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(block_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/frame/parser.rs:259:47 [INFO] [stderr] | [INFO] [stderr] 259 | 0b1000...0b1111 => 256 * power_of_two(block_byte as u32 - 8), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(block_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/subframe/types.rs:25:3 [INFO] [stderr] | [INFO] [stderr] 25 | LPC(LPC), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 25 | LPC(Box), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/subframe/parser.rs:179:20 [INFO] [stderr] | [INFO] [stderr] 179 | &mut warmup[0..order]) ~ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/subframe/parser.rs:206:1 [INFO] [stderr] | [INFO] [stderr] 206 | / pub fn lpc<'a, S>(input: (&'a [u8], usize), [INFO] [stderr] 207 | | order: usize, [INFO] [stderr] 208 | | bits_per_sample: usize, [INFO] [stderr] 209 | | block_size: usize, [INFO] [stderr] ... | [INFO] [stderr] 239 | | LPCParser) [INFO] [stderr] 240 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/subframe/parser.rs:219:20 [INFO] [stderr] | [INFO] [stderr] 219 | &mut warmup[0..order]) ~ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/subframe/parser.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | &mut qlp_coefficients[0..order] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/decode.rs:14:15 [INFO] [stderr] | [INFO] [stderr] 14 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `output`. [INFO] [stderr] --> src/subframe/decoder.rs:93:16 [INFO] [stderr] | [INFO] [stderr] 93 | for i in 0..output.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for in &mut output { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `output` [INFO] [stderr] --> src/subframe/decoder.rs:105:16 [INFO] [stderr] | [INFO] [stderr] 105 | for i in 0..order { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 105 | for (i, ) in output.iter_mut().enumerate().take(order) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `output` [INFO] [stderr] --> src/subframe/decoder.rs:117:16 [INFO] [stderr] | [INFO] [stderr] 117 | for i in 0..order { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 117 | for (i, ) in output.iter_mut().enumerate().take(order) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/subframe/decoder.rs:253:16 [INFO] [stderr] | [INFO] [stderr] 253 | for i in 0..residual.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `output[3..(residual.len() + 3)].clone_from_slice(&residual[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/subframe/decoder.rs:265:16 [INFO] [stderr] | [INFO] [stderr] 265 | for i in 0..residual.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `output[7..(residual.len() + 7)].clone_from_slice(&residual[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `byte` [INFO] [stderr] --> src/metadata/types.rs:132:30 [INFO] [stderr] | [INFO] [stderr] 132 | try!(buffer.write_u8(byte + 0)); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> examples/decode.rs:50:15 [INFO] [stderr] | [INFO] [stderr] 50 | channels: info.channels as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(info.channels)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> examples/decode.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | bits_per_sample: info.bits_per_sample as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(info.bits_per_sample)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> examples/decode.rs:90:34 [INFO] [stderr] | [INFO] [stderr] 90 | fn decode_all_files(input_files: &Vec, directory: &str) [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/decode.rs:98:7 [INFO] [stderr] | [INFO] [stderr] 98 | for ref input_file in input_files { [INFO] [stderr] | ^^^^^^^^^^^^^^ ----------- help: try: `let input_file = &input_files;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata/parser.rs:39:32 [INFO] [stderr] | [INFO] [stderr] 39 | let sample_rate = ((bytes[0] as u32) << 12) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata/parser.rs:40:32 [INFO] [stderr] | [INFO] [stderr] 40 | ((bytes[1] as u32) << 4) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/metadata/parser.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | ((bytes[2] as u32) >> 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata/parser.rs:45:33 [INFO] [stderr] | [INFO] [stderr] 45 | let total_samples = (((bytes[3] as u64) & 0x0f) << 32) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata/parser.rs:46:32 [INFO] [stderr] | [INFO] [stderr] 46 | ((bytes[4] as u64) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata/parser.rs:47:32 [INFO] [stderr] | [INFO] [stderr] 47 | ((bytes[5] as u64) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata/parser.rs:48:32 [INFO] [stderr] | [INFO] [stderr] 48 | ((bytes[6] as u64) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata/parser.rs:49:31 [INFO] [stderr] | [INFO] [stderr] 49 | (bytes[7] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/metadata/metadata.rs:264:1 [INFO] [stderr] | [INFO] [stderr] 264 | / pub fn get_picture(filename: &str, [INFO] [stderr] 265 | | picture_type: Option, [INFO] [stderr] 266 | | mime_type: Option<&str>, [INFO] [stderr] 267 | | description: Option<&str>, [INFO] [stderr] ... | [INFO] [stderr] 306 | | }) [INFO] [stderr] 307 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata/metadata.rs:287:20 [INFO] [stderr] | [INFO] [stderr] 287 | let area = (picture.width as u64) * (picture.height as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(picture.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/metadata/metadata.rs:287:45 [INFO] [stderr] | [INFO] [stderr] 287 | let area = (picture.width as u64) * (picture.height as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(picture.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/stream.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new(reader: R) -> Result, ErrorKind> { [INFO] [stderr] 33 | | let producer = ReadStream::new(reader); [INFO] [stderr] 34 | | [INFO] [stderr] 35 | | Stream::from_stream_producer(producer) [INFO] [stderr] 36 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/commands/streaminfo.rs:5:19 [INFO] [stderr] | [INFO] [stderr] 5 | pub const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/commands/comments.rs:7:19 [INFO] [stderr] | [INFO] [stderr] 7 | pub const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> examples/commands/comments.rs:44:10 [INFO] [stderr] | [INFO] [stderr] 44 | } else { [INFO] [stderr] | __________^ [INFO] [stderr] 45 | | if let Some(ref name) = args.flag_name { [INFO] [stderr] 46 | | let error_str = format!("Couldn't find tag name: \"{}\"", name); [INFO] [stderr] 47 | | let result = vorbis_comment.comments.get(name).unwrap_or(&error_str); [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | } else if let Some(ref name) = args.flag_name { [INFO] [stderr] 45 | let error_str = format!("Couldn't find tag name: \"{}\"", name); [INFO] [stderr] 46 | let result = vorbis_comment.comments.get(name).unwrap_or(&error_str); [INFO] [stderr] 47 | [INFO] [stderr] 48 | println!("{}", result) [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/commands/seektable.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | pub const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/commands/picture.rs:7:19 [INFO] [stderr] | [INFO] [stderr] 7 | pub const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/metadata.rs:13:15 [INFO] [stderr] | [INFO] [stderr] 13 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> examples/commands/streaminfo.rs:35:18 [INFO] [stderr] | [INFO] [stderr] 35 | let no_flags = (args.flag_block_size || args.flag_frame_size || [INFO] [stderr] | __________________^ [INFO] [stderr] 36 | | args.flag_sample_rate || args.flag_channels || [INFO] [stderr] 37 | | args.flag_bits_per_sample || args.flag_total_samples || [INFO] [stderr] 38 | | args.flag_md5) == false; [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] help: try simplifying it as shown [INFO] [stderr] | [INFO] [stderr] 35 | let no_flags = !((args.flag_block_size || args.flag_frame_size || [INFO] [stderr] 36 | args.flag_sample_rate || args.flag_channels || [INFO] [stderr] 37 | args.flag_bits_per_sample || args.flag_total_samples || [INFO] [stderr] 38 | args.flag_md5)); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> examples/commands/comments.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | let no_flags = (args.flag_vendor || args.flag_name.is_some()) == false; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!((args.flag_vendor || args.flag_name.is_some()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the variable `count` is used as a loop counter. Consider using `for (count, item) in seek_points.enumerate()` or similar iterators [INFO] [stderr] --> examples/commands/seektable.rs:24:21 [INFO] [stderr] | [INFO] [stderr] 24 | for seek_point in seek_points { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.44s [INFO] running `"docker" "inspect" "55e77db020a8e45b50bddb2120ee5181752df06597209579ac3b7f43fe0e2823"` [INFO] running `"docker" "rm" "-f" "55e77db020a8e45b50bddb2120ee5181752df06597209579ac3b7f43fe0e2823"` [INFO] [stdout] 55e77db020a8e45b50bddb2120ee5181752df06597209579ac3b7f43fe0e2823