[INFO] crate fixedvec 0.2.3 is already in cache [INFO] extracting crate fixedvec 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/fixedvec/0.2.3 [INFO] extracting crate fixedvec 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fixedvec/0.2.3 [INFO] validating manifest of fixedvec-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fixedvec-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fixedvec-0.2.3 [INFO] finished frobbing fixedvec-0.2.3 [INFO] frobbed toml for fixedvec-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/fixedvec/0.2.3/Cargo.toml [INFO] started frobbing fixedvec-0.2.3 [INFO] finished frobbing fixedvec-0.2.3 [INFO] frobbed toml for fixedvec-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fixedvec/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fixedvec-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fixedvec/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b45a9e68da8611d2fca935027706f5989d1336cf13ad4dd341fb74ccf7edf10a [INFO] running `"docker" "start" "-a" "b45a9e68da8611d2fca935027706f5989d1336cf13ad4dd341fb74ccf7edf10a"` [INFO] [stderr] Compiling getopts v0.2.18 [INFO] [stderr] Checking pulldown-cmark v0.0.3 [INFO] [stderr] Checking skeptic v0.5.0 [INFO] [stderr] Compiling fixedvec v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | memory: memory, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | memory: memory, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:627:14 [INFO] [stderr] | [INFO] [stderr] 627 | let (mut slice, _) = self.memory.split_at_mut(self.len); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:891:18 [INFO] [stderr] | [INFO] [stderr] 891 | fn into_iter(mut self) -> IterMut<'a, T> { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/lib.rs:960:27 [INFO] [stderr] | [INFO] [stderr] 960 | use std::hash::{Hash, SipHasher}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/lib.rs:1032:27 [INFO] [stderr] | [INFO] [stderr] 1032 | let mut hasher1 = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::hash::SipHasher': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/lib.rs:1036:27 [INFO] [stderr] | [INFO] [stderr] 1036 | let mut hasher2 = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::hash::SipHasher::new': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/lib.rs:1032:27 [INFO] [stderr] | [INFO] [stderr] 1032 | let mut hasher1 = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::hash::SipHasher::new': use `std::collections::hash_map::DefaultHasher` instead [INFO] [stderr] --> src/lib.rs:1036:27 [INFO] [stderr] | [INFO] [stderr] 1036 | let mut hasher2 = SipHasher::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:627:14 [INFO] [stderr] | [INFO] [stderr] 627 | let (mut slice, _) = self.memory.split_at_mut(self.len); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:891:18 [INFO] [stderr] | [INFO] [stderr] 891 | fn into_iter(mut self) -> IterMut<'a, T> { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:1023:31 [INFO] [stderr] | [INFO] [stderr] 1023 | let result: Vec = vec.iter().map(|&x| x).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `vec.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> /opt/crater/target/debug/build/fixedvec-dc9ba76e061fdf8f/out/skeptic-tests.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | let ref s = format!("{}", r####"#[macro_use] extern crate fixedvec; [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 6 | | "####); [INFO] [stderr] | |_______- help: try: `let s = &$ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) );` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> /opt/crater/target/debug/build/fixedvec-dc9ba76e061fdf8f/out/skeptic-tests.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | let ref s = format!("{}", r####"#[macro_use] extern crate fixedvec; [INFO] [stderr] | _________________^ [INFO] [stderr] 6 | | "####); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( r####"#[macro_use] extern crate fixedvec; [INFO] [stderr] 3 | "####.to_string() ) ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> /opt/crater/target/debug/build/fixedvec-dc9ba76e061fdf8f/out/skeptic-tests.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | let ref s = format!("{}", r####"#[macro_use] extern crate fixedvec; [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 13 | | [INFO] [stderr] 14 | | use fixedvec::FixedVec; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | "####); [INFO] [stderr] | |_______- help: try: `let s = &$ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> /opt/crater/target/debug/build/fixedvec-dc9ba76e061fdf8f/out/skeptic-tests.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | let ref s = format!("{}", r####"#[macro_use] extern crate fixedvec; [INFO] [stderr] | _________________^ [INFO] [stderr] 13 | | [INFO] [stderr] 14 | | use fixedvec::FixedVec; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | "####); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( r####"#[macro_use] extern crate fixedvec; [INFO] [stderr] 3 | [INFO] [stderr] 4 | use fixedvec::FixedVec; [INFO] [stderr] 5 | [INFO] [stderr] 6 | fn main() { [INFO] [stderr] 7 | let mut preallocated_space = alloc_stack!([u8; 10]); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.55s [INFO] running `"docker" "inspect" "b45a9e68da8611d2fca935027706f5989d1336cf13ad4dd341fb74ccf7edf10a"` [INFO] running `"docker" "rm" "-f" "b45a9e68da8611d2fca935027706f5989d1336cf13ad4dd341fb74ccf7edf10a"` [INFO] [stdout] b45a9e68da8611d2fca935027706f5989d1336cf13ad4dd341fb74ccf7edf10a