[INFO] crate fix-whitespace 1.0.2 is already in cache [INFO] extracting crate fix-whitespace 1.0.2 into work/ex/clippy-test-run/sources/stable/reg/fix-whitespace/1.0.2 [INFO] extracting crate fix-whitespace 1.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fix-whitespace/1.0.2 [INFO] validating manifest of fix-whitespace-1.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fix-whitespace-1.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fix-whitespace-1.0.2 [INFO] finished frobbing fix-whitespace-1.0.2 [INFO] frobbed toml for fix-whitespace-1.0.2 written to work/ex/clippy-test-run/sources/stable/reg/fix-whitespace/1.0.2/Cargo.toml [INFO] started frobbing fix-whitespace-1.0.2 [INFO] finished frobbing fix-whitespace-1.0.2 [INFO] frobbed toml for fix-whitespace-1.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fix-whitespace/1.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fix-whitespace-1.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fix-whitespace/1.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9ec2012ed6d46bf786c0ec6568418ae61ef0e1a5119fe06f45e732fc10a62f89 [INFO] running `"docker" "start" "-a" "9ec2012ed6d46bf786c0ec6568418ae61ef0e1a5119fe06f45e732fc10a62f89"` [INFO] [stderr] Checking fix-whitespace v1.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:228:10 [INFO] [stderr] | [INFO] [stderr] 228 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 229 | | [INFO] [stderr] 230 | | if ( [INFO] [stderr] 231 | | last_character == '\n' [INFO] [stderr] ... | [INFO] [stderr] 239 | | [INFO] [stderr] 240 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 228 | } else if ( [INFO] [stderr] 229 | last_character == '\n' [INFO] [stderr] 230 | && second_last_character.is_whitespace () [INFO] [stderr] 231 | ) || ( [INFO] [stderr] 232 | last_character == '\r' [INFO] [stderr] 233 | && second_last_character.is_whitespace () [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:228:10 [INFO] [stderr] | [INFO] [stderr] 228 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 229 | | [INFO] [stderr] 230 | | if ( [INFO] [stderr] 231 | | last_character == '\n' [INFO] [stderr] ... | [INFO] [stderr] 239 | | [INFO] [stderr] 240 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 228 | } else if ( [INFO] [stderr] 229 | last_character == '\n' [INFO] [stderr] 230 | && second_last_character.is_whitespace () [INFO] [stderr] 231 | ) || ( [INFO] [stderr] 232 | last_character == '\r' [INFO] [stderr] 233 | && second_last_character.is_whitespace () [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:98:3 [INFO] [stderr] | [INFO] [stderr] 98 | match modeline_regex.captures ( [INFO] [stderr] | _________^ [INFO] [stderr] 99 | | & line) { [INFO] [stderr] 100 | | [INFO] [stderr] 101 | | Some (captures) => [INFO] [stderr] ... | [INFO] [stderr] 108 | | [INFO] [stderr] 109 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 98 | if let Some (captures) = modeline_regex.captures ( [INFO] [stderr] 99 | & line) { modeline = [INFO] [stderr] 100 | Some ( [INFO] [stderr] 101 | captures.at (2).unwrap ().to_owned ()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:137:4 [INFO] [stderr] | [INFO] [stderr] 137 | match modeline [3 .. ].parse:: () { [INFO] [stderr] | _____________^ [INFO] [stderr] 138 | | [INFO] [stderr] 139 | | Ok (tab_size) => { [INFO] [stderr] 140 | | [INFO] [stderr] ... | [INFO] [stderr] 148 | | [INFO] [stderr] 149 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 137 | if let Ok (tab_size) = modeline [3 .. ].parse:: () { [INFO] [stderr] 138 | [INFO] [stderr] 139 | config.tab_size = [INFO] [stderr] 140 | tab_size; [INFO] [stderr] 141 | [INFO] [stderr] 142 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:98:3 [INFO] [stderr] | [INFO] [stderr] 98 | match modeline_regex.captures ( [INFO] [stderr] | _________^ [INFO] [stderr] 99 | | & line) { [INFO] [stderr] 100 | | [INFO] [stderr] 101 | | Some (captures) => [INFO] [stderr] ... | [INFO] [stderr] 108 | | [INFO] [stderr] 109 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 98 | if let Some (captures) = modeline_regex.captures ( [INFO] [stderr] 99 | & line) { modeline = [INFO] [stderr] 100 | Some ( [INFO] [stderr] 101 | captures.at (2).unwrap ().to_owned ()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:137:4 [INFO] [stderr] | [INFO] [stderr] 137 | match modeline [3 .. ].parse:: () { [INFO] [stderr] | _____________^ [INFO] [stderr] 138 | | [INFO] [stderr] 139 | | Ok (tab_size) => { [INFO] [stderr] 140 | | [INFO] [stderr] ... | [INFO] [stderr] 148 | | [INFO] [stderr] 149 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 137 | if let Ok (tab_size) = modeline [3 .. ].parse:: () { [INFO] [stderr] 138 | [INFO] [stderr] 139 | config.tab_size = [INFO] [stderr] 140 | tab_size; [INFO] [stderr] 141 | [INFO] [stderr] 142 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.31s [INFO] running `"docker" "inspect" "9ec2012ed6d46bf786c0ec6568418ae61ef0e1a5119fe06f45e732fc10a62f89"` [INFO] running `"docker" "rm" "-f" "9ec2012ed6d46bf786c0ec6568418ae61ef0e1a5119fe06f45e732fc10a62f89"` [INFO] [stdout] 9ec2012ed6d46bf786c0ec6568418ae61ef0e1a5119fe06f45e732fc10a62f89