[INFO] crate fitsio-derive 0.1.0 is already in cache
[INFO] extracting crate fitsio-derive 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/fitsio-derive/0.1.0
[INFO] extracting crate fitsio-derive 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fitsio-derive/0.1.0
[INFO] validating manifest of fitsio-derive-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of fitsio-derive-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing fitsio-derive-0.1.0
[INFO] finished frobbing fitsio-derive-0.1.0
[INFO] frobbed toml for fitsio-derive-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/fitsio-derive/0.1.0/Cargo.toml
[INFO] started frobbing fitsio-derive-0.1.0
[INFO] finished frobbing fitsio-derive-0.1.0
[INFO] frobbed toml for fitsio-derive-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fitsio-derive/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting fitsio-derive-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fitsio-derive/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6a47edb052a6a00bb4f751d2761ed2f134b3b08e39bab307f925d86d99162c16
[INFO] running `"docker" "start" "-a" "6a47edb052a6a00bb4f751d2761ed2f134b3b08e39bab307f925d86d99162c16"`
[INFO] [stderr]     Checking syn v0.12.15
[INFO] [stderr]     Checking fitsio-derive v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/lib.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     match &input.data {
[INFO] [stderr] 22 | |         &syn::Data::Struct(ref s) => match &s.fields {
[INFO] [stderr] 23 | |             &syn::Fields::Named(ref fields) => for field in &fields.named {
[INFO] [stderr] 24 | |                 let ident = &field.ident.unwrap();
[INFO] [stderr] ...  |
[INFO] [stderr] 70 | |         _ => panic!("derive only possible for structs"),
[INFO] [stderr] 71 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 21 |     match input.data {
[INFO] [stderr] 22 |         syn::Data::Struct(ref s) => match &s.fields {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/lib.rs:22:38
[INFO] [stderr]    |
[INFO] [stderr] 22 |           &syn::Data::Struct(ref s) => match &s.fields {
[INFO] [stderr]    |  ______________________________________^
[INFO] [stderr] 23 | |             &syn::Fields::Named(ref fields) => for field in &fields.named {
[INFO] [stderr] 24 | |                 let ident = &field.ident.unwrap();
[INFO] [stderr] 25 | |                 let ident_str = ident.to_string();
[INFO] [stderr] ...  |
[INFO] [stderr] 68 | |             _ => panic!("Only #[fitsio(colname = \"...\")] is supported"),
[INFO] [stderr] 69 | |         },
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 22 |         &syn::Data::Struct(ref s) => match s.fields {
[INFO] [stderr] 23 |             syn::Fields::Named(ref fields) => for field in &fields.named {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/lib.rs:42:44
[INFO] [stderr]    |
[INFO] [stderr] 42 |                                         if attr_ident.to_string() != "colname" {
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^^^^^^ help: try: `*attr_ident`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/lib.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | /     match &input.data {
[INFO] [stderr] 22 | |         &syn::Data::Struct(ref s) => match &s.fields {
[INFO] [stderr] 23 | |             &syn::Fields::Named(ref fields) => for field in &fields.named {
[INFO] [stderr] 24 | |                 let ident = &field.ident.unwrap();
[INFO] [stderr] ...  |
[INFO] [stderr] 70 | |         _ => panic!("derive only possible for structs"),
[INFO] [stderr] 71 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 21 |     match input.data {
[INFO] [stderr] 22 |         syn::Data::Struct(ref s) => match &s.fields {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]   --> src/lib.rs:22:38
[INFO] [stderr]    |
[INFO] [stderr] 22 |           &syn::Data::Struct(ref s) => match &s.fields {
[INFO] [stderr]    |  ______________________________________^
[INFO] [stderr] 23 | |             &syn::Fields::Named(ref fields) => for field in &fields.named {
[INFO] [stderr] 24 | |                 let ident = &field.ident.unwrap();
[INFO] [stderr] 25 | |                 let ident_str = ident.to_string();
[INFO] [stderr] ...  |
[INFO] [stderr] 68 | |             _ => panic!("Only #[fitsio(colname = \"...\")] is supported"),
[INFO] [stderr] 69 | |         },
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 22 |         &syn::Data::Struct(ref s) => match s.fields {
[INFO] [stderr] 23 |             syn::Fields::Named(ref fields) => for field in &fields.named {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]   --> src/lib.rs:42:44
[INFO] [stderr]    |
[INFO] [stderr] 42 |                                         if attr_ident.to_string() != "colname" {
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^^^^^^ help: try: `*attr_ident`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.04s
[INFO] running `"docker" "inspect" "6a47edb052a6a00bb4f751d2761ed2f134b3b08e39bab307f925d86d99162c16"`
[INFO] running `"docker" "rm" "-f" "6a47edb052a6a00bb4f751d2761ed2f134b3b08e39bab307f925d86d99162c16"`
[INFO] [stdout] 6a47edb052a6a00bb4f751d2761ed2f134b3b08e39bab307f925d86d99162c16