[INFO] crate fits-rs 0.3.0 is already in cache [INFO] extracting crate fits-rs 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/fits-rs/0.3.0 [INFO] extracting crate fits-rs 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fits-rs/0.3.0 [INFO] validating manifest of fits-rs-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fits-rs-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fits-rs-0.3.0 [INFO] finished frobbing fits-rs-0.3.0 [INFO] frobbed toml for fits-rs-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/fits-rs/0.3.0/Cargo.toml [INFO] started frobbing fits-rs-0.3.0 [INFO] finished frobbing fits-rs-0.3.0 [INFO] frobbed toml for fits-rs-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fits-rs/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fits-rs-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fits-rs/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5d07e5115345451c7755dd685bc343d164b96921937da2ed439c762950948595 [INFO] running `"docker" "start" "-a" "5d07e5115345451c7755dd685bc343d164b96921937da2ed439c762950948595"` [INFO] [stderr] Checking fits-rs v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/mod.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | primary_hdu: primary_hdu, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `primary_hdu` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/mod.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | extensions: extensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/mod.rs:37:15 [INFO] [stderr] | [INFO] [stderr] 37 | HDU { header: header, data_array: Option::None } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/mod.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | Header { keyword_records: keyword_records } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keyword_records` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/mod.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | KeywordRecord { keyword: keyword, value: value, comment: comment } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `keyword` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/mod.rs:152:43 [INFO] [stderr] | [INFO] [stderr] 152 | KeywordRecord { keyword: keyword, value: value, comment: comment } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/mod.rs:152:57 [INFO] [stderr] | [INFO] [stderr] 152 | KeywordRecord { keyword: keyword, value: value, comment: comment } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `comment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/mod.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | primary_hdu: primary_hdu, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `primary_hdu` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/mod.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | extensions: extensions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `extensions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/mod.rs:37:15 [INFO] [stderr] | [INFO] [stderr] 37 | HDU { header: header, data_array: Option::None } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/mod.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | Header { keyword_records: keyword_records } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keyword_records` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/mod.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | KeywordRecord { keyword: keyword, value: value, comment: comment } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `keyword` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/mod.rs:152:43 [INFO] [stderr] | [INFO] [stderr] 152 | KeywordRecord { keyword: keyword, value: value, comment: comment } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/mod.rs:152:57 [INFO] [stderr] | [INFO] [stderr] 152 | KeywordRecord { keyword: keyword, value: value, comment: comment } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `comment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/mod.rs:288:47 [INFO] [stderr] | [INFO] [stderr] 288 | Value::Integer(200164267i64), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `200_164_267i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/mod.rs:438:36 [INFO] [stderr] | [INFO] [stderr] 438 | Value::Integer(200164267), [INFO] [stderr] | ^^^^^^^^^ help: consider: `200_164_267` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/mod.rs:473:50 [INFO] [stderr] | [INFO] [stderr] 473 | assert_eq!(value, Value::Integer(200164267)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `200_164_267` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser/mod.rs:623:68 [INFO] [stderr] | [INFO] [stderr] 623 | IResult::Done(_, h) => assert_eq!(h.data_array_size(), 84418560usize), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `84_418_560usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/types/mod.rs:113:22 [INFO] [stderr] | [INFO] [stderr] 113 | .expect(format!("NAXIS{} should be defined", n).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("NAXIS{} should be defined", n))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: the `input @ _` pattern can be written as just `input` [INFO] [stderr] --> src/types/mod.rs:335:13 [INFO] [stderr] | [INFO] [stderr] 335 | input @ _ => { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parser/mod.rs:409:20 [INFO] [stderr] | [INFO] [stderr] 409 | let data = "OBJECT = 'EPIC 200164267' / string version of target id " [INFO] [stderr] | ____________________^ [INFO] [stderr] 410 | | .as_bytes(); [INFO] [stderr] | |_______________________^ help: consider using a byte string literal instead: `b"OBJECT = 'EPIC 200164267' / string version of target id "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parser/mod.rs:429:20 [INFO] [stderr] | [INFO] [stderr] 429 | let data = "KEPLERID= 200164267 " [INFO] [stderr] | ____________________^ [INFO] [stderr] 430 | | .as_bytes(); [INFO] [stderr] | |_______________________^ help: consider using a byte string literal instead: `b"KEPLERID= 200164267 "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parser/mod.rs:449:20 [INFO] [stderr] | [INFO] [stderr] 449 | let data = "'EPIC 200164267' / string version of target id " [INFO] [stderr] | ____________________^ [INFO] [stderr] 450 | | .as_bytes(); [INFO] [stderr] | |_______________________^ help: consider using a byte string literal instead: `b"'EPIC 200164267' / string version of target id "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parser/mod.rs:466:20 [INFO] [stderr] | [INFO] [stderr] 466 | let data = "200164267 " [INFO] [stderr] | ____________________^ [INFO] [stderr] 467 | | .as_bytes(); [INFO] [stderr] | |_______________________^ help: consider using a byte string literal instead: `b"200164267 "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parser/mod.rs:483:20 [INFO] [stderr] | [INFO] [stderr] 483 | let data = " 'EPIC 200164267' " [INFO] [stderr] | ____________________^ [INFO] [stderr] 484 | | .as_bytes(); [INFO] [stderr] | |_______________________^ help: consider using a byte string literal instead: `b" 'EPIC 200164267' "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/mod.rs:501:36 [INFO] [stderr] | [INFO] [stderr] 501 | for (constant, boolean) in vec!(("T", true), ("F", false), (" T ", true)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[("T", true), ("F", false), (" T ", true)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/mod.rs:516:27 [INFO] [stderr] | [INFO] [stderr] 516 | for (input, f) in vec!(("1.0", 1f64), ("37.0", 37f64), ("51.0", 51f64)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[("1.0", 1f64), ("37.0", 37f64), ("51.0", 51f64)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/mod.rs:531:27 [INFO] [stderr] | [INFO] [stderr] 531 | for (input, n) in vec!(("1", 1i64), ("37", 37i64), ("51", 51i64)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[("1", 1i64), ("37", 37i64), ("51", 51i64)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser/mod.rs:546:22 [INFO] [stderr] | [INFO] [stderr] 546 | for input in vec!(" ", "\t", " \t ") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[" ", "\t", " \t "]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parser/mod.rs:561:20 [INFO] [stderr] | [INFO] [stderr] 561 | let data = "OBJECT " [INFO] [stderr] | ____________________^ [INFO] [stderr] 562 | | .as_bytes(); [INFO] [stderr] | |_______________________^ help: consider using a byte string literal instead: `b"OBJECT "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parser/mod.rs:576:20 [INFO] [stderr] | [INFO] [stderr] 576 | let data = "END " [INFO] [stderr] | ____________________^ [INFO] [stderr] 577 | | .as_bytes(); [INFO] [stderr] | |_______________________^ help: consider using a byte string literal instead: `b"END "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parser/mod.rs:591:20 [INFO] [stderr] | [INFO] [stderr] 591 | let data = " " [INFO] [stderr] | ____________________^ [INFO] [stderr] 592 | | .as_bytes(); [INFO] [stderr] | |_______________________^ help: consider using a byte string literal instead: `b" "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/types/mod.rs:113:22 [INFO] [stderr] | [INFO] [stderr] 113 | .expect(format!("NAXIS{} should be defined", n).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("NAXIS{} should be defined", n))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: the `input @ _` pattern can be written as just `input` [INFO] [stderr] --> src/types/mod.rs:335:13 [INFO] [stderr] | [INFO] [stderr] 335 | input @ _ => { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(2880*8) as usize` [INFO] [stderr] --> src/types/mod.rs:633:46 [INFO] [stderr] | [INFO] [stderr] 633 | assert_eq!(header.data_array_size(), 1*(2880*8) as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/headers.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | for ref record in &header.keyword_records { [INFO] [stderr] | ^^^^^^^^^^ ----------------------- help: try: `let record = &&header.keyword_records;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/nom-test.rs:36:64 [INFO] [stderr] | [INFO] [stderr] 36 | assert_eq!(number(&b"373379"[..]), IResult::Done(&b""[..], 373379)); [INFO] [stderr] | ^^^^^^ help: consider: `373_379` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/nom-test.rs:43:66 [INFO] [stderr] | [INFO] [stderr] 43 | assert_eq!(number(&b"-373379"[..]), IResult::Done(&b""[..], -373379)); [INFO] [stderr] | ^^^^^^ help: consider: `373_379` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/nom-test.rs:50:65 [INFO] [stderr] | [INFO] [stderr] 50 | assert_eq!(number(&b"+373379"[..]), IResult::Done(&b""[..], 373379)); [INFO] [stderr] | ^^^^^^ help: consider: `373_379` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> tests/nom-test.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | .and_then(|s| if s[0] == ('-' as u8) { Some(-1i64) } else { None }) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'-' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bin/headers.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | for ref record in &header.keyword_records { [INFO] [stderr] | ^^^^^^^^^^ ----------------------- help: try: `let record = &&header.keyword_records;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.18s [INFO] running `"docker" "inspect" "5d07e5115345451c7755dd685bc343d164b96921937da2ed439c762950948595"` [INFO] running `"docker" "rm" "-f" "5d07e5115345451c7755dd685bc343d164b96921937da2ed439c762950948595"` [INFO] [stdout] 5d07e5115345451c7755dd685bc343d164b96921937da2ed439c762950948595