[INFO] crate fisher_processor 0.1.0 is already in cache [INFO] extracting crate fisher_processor 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/fisher_processor/0.1.0 [INFO] extracting crate fisher_processor 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fisher_processor/0.1.0 [INFO] validating manifest of fisher_processor-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fisher_processor-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fisher_processor-0.1.0 [INFO] finished frobbing fisher_processor-0.1.0 [INFO] frobbed toml for fisher_processor-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/fisher_processor/0.1.0/Cargo.toml [INFO] started frobbing fisher_processor-0.1.0 [INFO] finished frobbing fisher_processor-0.1.0 [INFO] frobbed toml for fisher_processor-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fisher_processor/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fisher_processor-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fisher_processor/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0e6a98df0e8bde4dcdfd4c7688fcdb41b47724c85b1c5e668920da23de299e09 [INFO] running `"docker" "start" "-a" "0e6a98df0e8bde4dcdfd4c7688fcdb41b47724c85b1c5e668920da23de299e09"` [INFO] [stderr] Checking fisher_common v0.2.0 [INFO] [stderr] Checking fisher_processor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduled_job.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | job: job, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `job` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduled_job.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | priority: priority, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `priority` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduled_job.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | serial: serial, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `serial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | waiting: waiting, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `waiting` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | max_threads: max_threads, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_threads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | hooks: hooks, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hooks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | waiting: waiting, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `waiting` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | input_send: input_send, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | input_recv: input_recv, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_recv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:172:25 [INFO] [stderr] | [INFO] [stderr] 172 | queued_jobs: queued_jobs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queued_jobs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/thread.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/thread.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | input_send: input_send, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | input_recv: input_recv, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_recv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduled_job.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | job: job, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `job` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduled_job.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | priority: priority, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `priority` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduled_job.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | serial: serial, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `serial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | waiting: waiting, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `waiting` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | max_threads: max_threads, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_threads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | hooks: hooks, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hooks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | waiting: waiting, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `waiting` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | input_send: input_send, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | input_recv: input_recv, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_recv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scheduler.rs:172:25 [INFO] [stderr] | [INFO] [stderr] 172 | queued_jobs: queued_jobs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `queued_jobs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/thread.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/thread.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | input_send: input_send, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_send` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | input_recv: input_recv, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_recv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scheduler.rs:403:9 [INFO] [stderr] | [INFO] [stderr] 403 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scheduler.rs:403:9 [INFO] [stderr] | [INFO] [stderr] 403 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scheduler.rs:366:25 [INFO] [stderr] | [INFO] [stderr] 366 | if let Some(mut waiting) = self.waiting.get_mut(&hook_id) { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/scheduler.rs:366:25 [INFO] [stderr] | [INFO] [stderr] 366 | if let Some(mut waiting) = self.waiting.get_mut(&hook_id) { [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/scheduler.rs:499:43 [INFO] [stderr] | [INFO] [stderr] 499 | repo.job("append", (chr + '0' as u8) as char).unwrap(), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'0' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/test_utils.rs:28:11 [INFO] [stderr] | [INFO] [stderr] 28 | func: Arc Result<()> + Send>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.15s [INFO] running `"docker" "inspect" "0e6a98df0e8bde4dcdfd4c7688fcdb41b47724c85b1c5e668920da23de299e09"` [INFO] running `"docker" "rm" "-f" "0e6a98df0e8bde4dcdfd4c7688fcdb41b47724c85b1c5e668920da23de299e09"` [INFO] [stdout] 0e6a98df0e8bde4dcdfd4c7688fcdb41b47724c85b1c5e668920da23de299e09