[INFO] crate findr 0.1.5 is already in cache
[INFO] extracting crate findr 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/findr/0.1.5
[INFO] extracting crate findr 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/findr/0.1.5
[INFO] validating manifest of findr-0.1.5 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of findr-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing findr-0.1.5
[INFO] finished frobbing findr-0.1.5
[INFO] frobbed toml for findr-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/findr/0.1.5/Cargo.toml
[INFO] started frobbing findr-0.1.5
[INFO] finished frobbing findr-0.1.5
[INFO] frobbed toml for findr-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/findr/0.1.5/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting findr-0.1.5 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/findr/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2f7797c0b42f731f8648d134004c44781d4f39f7d58029ad55ac28aa3a0dc8b3
[INFO] running `"docker" "start" "-a" "2f7797c0b42f731f8648d134004c44781d4f39f7d58029ad55ac28aa3a0dc8b3"`
[INFO] [stderr]     Checking scanlex v0.1.2
[INFO] [stderr]     Checking rhai v0.8.2
[INFO] [stderr]     Checking ignore v0.4.6
[INFO] [stderr]     Checking chrono-english v0.1.4
[INFO] [stderr]     Checking findr v0.1.5 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             entry: entry, metadata: metadata,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `entry`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:132:27
[INFO] [stderr]     |
[INFO] [stderr] 132 |             entry: entry, metadata: metadata,
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:133:13
[INFO] [stderr]     |
[INFO] [stderr] 133 |             globs: globs
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `globs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/main.rs:289:29
[INFO] [stderr]     |
[INFO] [stderr] 289 |                             write!(out,"{}\n", path.display())?;
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             entry: entry, metadata: metadata,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `entry`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:132:27
[INFO] [stderr]     |
[INFO] [stderr] 132 |             entry: entry, metadata: metadata,
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:133:13
[INFO] [stderr]     |
[INFO] [stderr] 133 |             globs: globs
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `globs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/main.rs:289:29
[INFO] [stderr]     |
[INFO] [stderr] 289 |                             write!(out,"{}\n", path.display())?;
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/preprocess.rs:65:21
[INFO] [stderr]    |
[INFO] [stderr] 65 |                     return "".into();
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"".into()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/preprocess.rs:65:21
[INFO] [stderr]    |
[INFO] [stderr] 65 |                     return "".into();
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"".into()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/preprocess.rs:127:12
[INFO] [stderr]     |
[INFO] [stderr] 127 |         if patterns.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!patterns.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/preprocess.rs:157:8
[INFO] [stderr]     |
[INFO] [stderr] 157 |     if rest.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rest.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:99:5
[INFO] [stderr]    |
[INFO] [stderr] 99 |     (m.mode() & 0o777) as i64
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(m.mode() & 0o777)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/main.rs:142:16
[INFO] [stderr]     |
[INFO] [stderr] 142 |     fn is_file(&mut self) -> bool {
[INFO] [stderr]     |                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/main.rs:146:15
[INFO] [stderr]     |
[INFO] [stderr] 146 |     fn is_dir(&mut self) -> bool {
[INFO] [stderr]     |               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/main.rs:150:16
[INFO] [stderr]     |
[INFO] [stderr] 150 |     fn is_exec(&mut self) -> bool {
[INFO] [stderr]     |                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/main.rs:154:17
[INFO] [stderr]     |
[INFO] [stderr] 154 |     fn is_write(&mut self) -> bool {
[INFO] [stderr]     |                 ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/main.rs:177:13
[INFO] [stderr]     |
[INFO] [stderr] 177 |         let ref pattern = self.globs[idx as usize].0;
[INFO] [stderr]     |         ----^^^^^^^^^^^------------------------------ help: try: `let pattern = &self.globs[idx as usize].0;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/main.rs:178:13
[INFO] [stderr]     |
[INFO] [stderr] 178 |         let ref options = match self.globs[idx as usize].1 {
[INFO] [stderr]     |             ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 178 |         let options = &(match self.globs[idx as usize].1 {
[INFO] [stderr] 179 |             GlobIgnoreCase::CaseSensitive => MatchOptions::new(),
[INFO] [stderr] 180 |             GlobIgnoreCase::CaseInsensitive => MatchOptions::default(),
[INFO] [stderr] 181 |         });
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/preprocess.rs:127:12
[INFO] [stderr]     |
[INFO] [stderr] 127 |         if patterns.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!patterns.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/preprocess.rs:157:8
[INFO] [stderr]     |
[INFO] [stderr] 157 |     if rest.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rest.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:99:5
[INFO] [stderr]    |
[INFO] [stderr] 99 |     (m.mode() & 0o777) as i64
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(m.mode() & 0o777)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/main.rs:142:16
[INFO] [stderr]     |
[INFO] [stderr] 142 |     fn is_file(&mut self) -> bool {
[INFO] [stderr]     |                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/main.rs:146:15
[INFO] [stderr]     |
[INFO] [stderr] 146 |     fn is_dir(&mut self) -> bool {
[INFO] [stderr]     |               ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/main.rs:150:16
[INFO] [stderr]     |
[INFO] [stderr] 150 |     fn is_exec(&mut self) -> bool {
[INFO] [stderr]     |                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/main.rs:154:17
[INFO] [stderr]     |
[INFO] [stderr] 154 |     fn is_write(&mut self) -> bool {
[INFO] [stderr]     |                 ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/main.rs:177:13
[INFO] [stderr]     |
[INFO] [stderr] 177 |         let ref pattern = self.globs[idx as usize].0;
[INFO] [stderr]     |         ----^^^^^^^^^^^------------------------------ help: try: `let pattern = &self.globs[idx as usize].0;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/main.rs:178:13
[INFO] [stderr]     |
[INFO] [stderr] 178 |         let ref options = match self.globs[idx as usize].1 {
[INFO] [stderr]     |             ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 178 |         let options = &(match self.globs[idx as usize].1 {
[INFO] [stderr] 179 |             GlobIgnoreCase::CaseSensitive => MatchOptions::new(),
[INFO] [stderr] 180 |             GlobIgnoreCase::CaseInsensitive => MatchOptions::default(),
[INFO] [stderr] 181 |         });
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.55s
[INFO] running `"docker" "inspect" "2f7797c0b42f731f8648d134004c44781d4f39f7d58029ad55ac28aa3a0dc8b3"`
[INFO] running `"docker" "rm" "-f" "2f7797c0b42f731f8648d134004c44781d4f39f7d58029ad55ac28aa3a0dc8b3"`
[INFO] [stdout] 2f7797c0b42f731f8648d134004c44781d4f39f7d58029ad55ac28aa3a0dc8b3