[INFO] crate find_folder 0.3.0 is already in cache [INFO] extracting crate find_folder 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/find_folder/0.3.0 [INFO] extracting crate find_folder 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/find_folder/0.3.0 [INFO] validating manifest of find_folder-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of find_folder-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing find_folder-0.3.0 [INFO] finished frobbing find_folder-0.3.0 [INFO] frobbed toml for find_folder-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/find_folder/0.3.0/Cargo.toml [INFO] started frobbing find_folder-0.3.0 [INFO] finished frobbing find_folder-0.3.0 [INFO] frobbed toml for find_folder-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/find_folder/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting find_folder-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/find_folder/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] adaa3ad038fef1787249480f0bce673c4acf13bcbc791131b61258740bf6ad70 [INFO] running `"docker" "start" "-a" "adaa3ad038fef1787249480f0bce673c4acf13bcbc791131b61258740bf6ad70"` [INFO] [stderr] Checking find_folder v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:71:23 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn for_folder(&self, target: &str) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:125:39 [INFO] [stderr] | [INFO] [stderr] 125 | err @ Err(Error::NotFound) => match depth > 0 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 126 | | true => { [INFO] [stderr] 127 | | for entry in try!(fs::read_dir(path)) { [INFO] [stderr] 128 | | let entry = try!(entry); [INFO] [stderr] ... | [INFO] [stderr] 138 | | false => err, [INFO] [stderr] 139 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 125 | err @ Err(Error::NotFound) => if depth > 0 { [INFO] [stderr] 126 | for entry in try!(fs::read_dir(path)) { [INFO] [stderr] 127 | let entry = try!(entry); [INFO] [stderr] 128 | let entry_path = entry.path(); [INFO] [stderr] 129 | if try!(fs::metadata(&entry_path)).is_dir() { [INFO] [stderr] 130 | if let Ok(folder) = check_kids(depth-1, name, &entry_path) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:147:39 [INFO] [stderr] | [INFO] [stderr] 147 | err @ Err(Error::NotFound) => match depth > 0 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 148 | | true => match path.parent() { [INFO] [stderr] 149 | | None => err, [INFO] [stderr] 150 | | Some(parent) => check_parents(depth-1, name, parent), [INFO] [stderr] 151 | | }, [INFO] [stderr] 152 | | false => err, [INFO] [stderr] 153 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 147 | err @ Err(Error::NotFound) => if depth > 0 { match path.parent() { [INFO] [stderr] 148 | None => err, [INFO] [stderr] 149 | Some(parent) => check_parents(depth-1, name, parent), [INFO] [stderr] 150 | } } else { err }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:71:23 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn for_folder(&self, target: &str) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:125:39 [INFO] [stderr] | [INFO] [stderr] 125 | err @ Err(Error::NotFound) => match depth > 0 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 126 | | true => { [INFO] [stderr] 127 | | for entry in try!(fs::read_dir(path)) { [INFO] [stderr] 128 | | let entry = try!(entry); [INFO] [stderr] ... | [INFO] [stderr] 138 | | false => err, [INFO] [stderr] 139 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 125 | err @ Err(Error::NotFound) => if depth > 0 { [INFO] [stderr] 126 | for entry in try!(fs::read_dir(path)) { [INFO] [stderr] 127 | let entry = try!(entry); [INFO] [stderr] 128 | let entry_path = entry.path(); [INFO] [stderr] 129 | if try!(fs::metadata(&entry_path)).is_dir() { [INFO] [stderr] 130 | if let Ok(folder) = check_kids(depth-1, name, &entry_path) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:147:39 [INFO] [stderr] | [INFO] [stderr] 147 | err @ Err(Error::NotFound) => match depth > 0 { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 148 | | true => match path.parent() { [INFO] [stderr] 149 | | None => err, [INFO] [stderr] 150 | | Some(parent) => check_parents(depth-1, name, parent), [INFO] [stderr] 151 | | }, [INFO] [stderr] 152 | | false => err, [INFO] [stderr] 153 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 147 | err @ Err(Error::NotFound) => if depth > 0 { match path.parent() { [INFO] [stderr] 148 | None => err, [INFO] [stderr] 149 | Some(parent) => check_parents(depth-1, name, parent), [INFO] [stderr] 150 | } } else { err }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.17s [INFO] running `"docker" "inspect" "adaa3ad038fef1787249480f0bce673c4acf13bcbc791131b61258740bf6ad70"` [INFO] running `"docker" "rm" "-f" "adaa3ad038fef1787249480f0bce673c4acf13bcbc791131b61258740bf6ad70"` [INFO] [stdout] adaa3ad038fef1787249480f0bce673c4acf13bcbc791131b61258740bf6ad70