[INFO] crate finchers-session 0.2.0 is already in cache [INFO] extracting crate finchers-session 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/finchers-session/0.2.0 [INFO] extracting crate finchers-session 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/finchers-session/0.2.0 [INFO] validating manifest of finchers-session-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of finchers-session-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing finchers-session-0.2.0 [INFO] finished frobbing finchers-session-0.2.0 [INFO] frobbed toml for finchers-session-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/finchers-session/0.2.0/Cargo.toml [INFO] started frobbing finchers-session-0.2.0 [INFO] finished frobbing finchers-session-0.2.0 [INFO] frobbed toml for finchers-session-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/finchers-session/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting finchers-session-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/finchers-session/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3572755e2562c4cac5d4a0b04d95dde6a9945c85d054a947fa9a7c25059152ad [INFO] running `"docker" "start" "-a" "3572755e2562c4cac5d4a0b04d95dde6a9945c85d054a947fa9a7c25059152ad"` [INFO] [stderr] Compiling finchers v0.13.5 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking serde_qs v0.4.5 [INFO] [stderr] Checking uuid v0.7.2 [INFO] [stderr] Checking tokio-io v0.1.11 [INFO] [stderr] Checking http v0.1.15 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking h2 v0.1.16 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking finchers-session v0.2.0 (/opt/crater/workdir) [INFO] [stderr] error: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tests.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | endpoint [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::let_and_return)] implied by #[deny(warnings)] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tests.rs:76:24 [INFO] [stderr] | [INFO] [stderr] 76 | let endpoint = session_endpoint.and_then(|session: Session| { [INFO] [stderr] | ________________________^ [INFO] [stderr] 77 | | session.with(|session| { [INFO] [stderr] 78 | | session.get(); [INFO] [stderr] 79 | | session.set("foo"); [INFO] [stderr] ... | [INFO] [stderr] 82 | | }) [INFO] [stderr] 83 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] error: use of deprecated item 'finchers::input::Input::cookies': use `Input::cookies2()` instead. [INFO] [stderr] --> src/cookie.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | let jar = input.cookies()?; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(deprecated)] implied by #[deny(warnings)] [INFO] [stderr] [INFO] [stderr] error: use of deprecated item 'finchers::input::Input::cookies': use `Input::cookies2()` instead. [INFO] [stderr] --> src/cookie.rs:134:25 [INFO] [stderr] | [INFO] [stderr] 134 | let jar = input.cookies()?; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: use of deprecated item 'finchers::input::Input::cookies': use `Input::cookies2()` instead. [INFO] [stderr] --> src/cookie.rs:148:25 [INFO] [stderr] | [INFO] [stderr] 148 | let jar = input.cookies()?; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: use of deprecated item 'finchers::input::Input::cookies': use `Input::cookies2()` instead. [INFO] [stderr] --> src/in_memory.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | match input.cookies()?.get("session-id") { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: use of deprecated item 'finchers::input::Input::cookies': use `Input::cookies2()` instead. [INFO] [stderr] --> src/in_memory.rs:101:14 [INFO] [stderr] | [INFO] [stderr] 101 | .cookies()? [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: use of deprecated item 'finchers::input::Input::cookies': use `Input::cookies2()` instead. [INFO] [stderr] --> src/in_memory.rs:108:15 [INFO] [stderr] | [INFO] [stderr] 108 | input.cookies()?.remove(Cookie::named("session-id")); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'finchers::input::Input::cookies': use `Input::cookies2()` instead. [INFO] [stderr] --> src/cookie.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | let jar = input.cookies()?; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] error: Could not compile `finchers-session`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of deprecated item 'finchers::input::Input::cookies': use `Input::cookies2()` instead. [INFO] [stderr] --> src/cookie.rs:134:25 [INFO] [stderr] | [INFO] [stderr] 134 | let jar = input.cookies()?; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'finchers::input::Input::cookies': use `Input::cookies2()` instead. [INFO] [stderr] --> src/cookie.rs:148:25 [INFO] [stderr] | [INFO] [stderr] 148 | let jar = input.cookies()?; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'finchers::input::Input::cookies': use `Input::cookies2()` instead. [INFO] [stderr] --> src/in_memory.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | match input.cookies()?.get("session-id") { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'finchers::input::Input::cookies': use `Input::cookies2()` instead. [INFO] [stderr] --> src/in_memory.rs:101:14 [INFO] [stderr] | [INFO] [stderr] 101 | .cookies()? [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'finchers::input::Input::cookies': use `Input::cookies2()` instead. [INFO] [stderr] --> src/in_memory.rs:108:15 [INFO] [stderr] | [INFO] [stderr] 108 | input.cookies()?.remove(Cookie::named("session-id")); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/in_memory.rs:99:32 [INFO] [stderr] | [INFO] [stderr] 99 | self.inner.storage.set(session_id.clone(), value)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `session_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "3572755e2562c4cac5d4a0b04d95dde6a9945c85d054a947fa9a7c25059152ad"` [INFO] running `"docker" "rm" "-f" "3572755e2562c4cac5d4a0b04d95dde6a9945c85d054a947fa9a7c25059152ad"` [INFO] [stdout] 3572755e2562c4cac5d4a0b04d95dde6a9945c85d054a947fa9a7c25059152ad