[INFO] crate finality-grandpa 0.5.1 is already in cache
[INFO] extracting crate finality-grandpa 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/finality-grandpa/0.5.1
[INFO] extracting crate finality-grandpa 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/finality-grandpa/0.5.1
[INFO] validating manifest of finality-grandpa-0.5.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of finality-grandpa-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing finality-grandpa-0.5.1
[INFO] finished frobbing finality-grandpa-0.5.1
[INFO] frobbed toml for finality-grandpa-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/finality-grandpa/0.5.1/Cargo.toml
[INFO] started frobbing finality-grandpa-0.5.1
[INFO] finished frobbing finality-grandpa-0.5.1
[INFO] frobbed toml for finality-grandpa-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/finality-grandpa/0.5.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting finality-grandpa-0.5.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/finality-grandpa/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 513fa643e59634ff75737c603722460c63df72e5ee4d64124b0b95eae31b4f87
[INFO] running `"docker" "start" "-a" "513fa643e59634ff75737c603722460c63df72e5ee4d64124b0b95eae31b4f87"`
[INFO] [stderr]     Checking finality-grandpa v0.5.1 (/opt/crater/workdir)
[INFO] [stderr]     Checking exit-future v0.1.3
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/round.rs:285:4
[INFO] [stderr]     |
[INFO] [stderr] 285 |             total_weight: total_weight,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_weight`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/voter.rs:1097:6
[INFO] [stderr]      |
[INFO] [stderr] 1097 |                     precommit: precommit,
[INFO] [stderr]      |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precommit`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/voter.rs:1098:6
[INFO] [stderr]      |
[INFO] [stderr] 1098 |                     signature: signature,
[INFO] [stderr]      |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/voter.rs:1099:6
[INFO] [stderr]      |
[INFO] [stderr] 1099 |                     id: id,
[INFO] [stderr]      |                     ^^^^^^ help: replace it with: `id`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/round.rs:285:4
[INFO] [stderr]     |
[INFO] [stderr] 285 |             total_weight: total_weight,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_weight`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/voter.rs:1097:6
[INFO] [stderr]      |
[INFO] [stderr] 1097 |                     precommit: precommit,
[INFO] [stderr]      |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precommit`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/voter.rs:1098:6
[INFO] [stderr]      |
[INFO] [stderr] 1098 |                     signature: signature,
[INFO] [stderr]      |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]     --> src/voter.rs:1099:6
[INFO] [stderr]      |
[INFO] [stderr] 1099 |                     id: id,
[INFO] [stderr]      |                     ^^^^^^ help: replace it with: `id`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/round.rs:165:5
[INFO] [stderr]     |
[INFO] [stderr] 165 |                 return Some(&*vacant.insert(VoteMultiplicity::Single(vote, signature)));
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&*vacant.insert(VoteMultiplicity::Single(vote, signature)))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/vote_graph.rs:207:3
[INFO] [stderr]     |
[INFO] [stderr] 207 |         x
[INFO] [stderr]     |         ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/vote_graph.rs:203:11
[INFO] [stderr]     |
[INFO] [stderr] 203 |           let x = good_subchain.blocks_reverse().find(|&(ref good_hash, good_number)|
[INFO] [stderr]     |  _________________^
[INFO] [stderr] 204 | |             canonical_node.in_direct_ancestry(good_hash, good_number).unwrap_or(false)
[INFO] [stderr] 205 | |         );
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/round.rs:110:28
[INFO] [stderr]     |
[INFO] [stderr] 110 |     fn equivocation(&self) -> Option<(&(Vote, Signature), &(Vote, Signature))> {
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/round.rs:312:7
[INFO] [stderr]     |
[INFO] [stderr] 312 |     ) -> Result<Option<Equivocation<Id, Prevote<H, N>, Signature>>, ::Error> {
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/round.rs:379:7
[INFO] [stderr]     |
[INFO] [stderr] 379 |     ) -> Result<Option<Equivocation<Id, Precommit<H, N>, Signature>>, ::Error> {
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/vote_graph.rs:56:3
[INFO] [stderr]    |
[INFO] [stderr] 56 |         self.ancestors.last().map(|x| x.clone())
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.ancestors.last().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/vote_graph.rs:124:3
[INFO] [stderr]     |
[INFO] [stderr] 124 |           match self.find_containing_nodes(hash.clone(), number) {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 125 | |             Some(containing) => if containing.is_empty() {
[INFO] [stderr] 126 | |                 self.append(hash.clone(), number, chain)?;
[INFO] [stderr] 127 | |             } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 130 | |             None => {}, // this entry already exists
[INFO] [stderr] 131 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 124 |         if let Some(containing) = self.find_containing_nodes(hash.clone(), number) { if containing.is_empty() {
[INFO] [stderr] 125 |     self.append(hash.clone(), number, chain)?;
[INFO] [stderr] 126 | } else {
[INFO] [stderr] 127 |     self.introduce_branch(containing, hash.clone(), number);
[INFO] [stderr] 128 | } }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]    --> src/vote_graph.rs:250:26
[INFO] [stderr]     |
[INFO] [stderr] 250 |               let next_descendent = active_node.descendents
[INFO] [stderr]     |  ___________________________________^
[INFO] [stderr] 251 | |                 .iter()
[INFO] [stderr] 252 | |                 .map(|d| (d.clone(), get_node(d)))
[INFO] [stderr] 253 | |                 .filter(|&(_, ref node)| {
[INFO] [stderr] ...   |
[INFO] [stderr] 261 | |                 .filter(|&(_, ref node)| condition(&node.cumulative_vote))
[INFO] [stderr] 262 | |                 .next();
[INFO] [stderr]     | |_______________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]     = note: replace `filter(|&(_, ref node)| condition(&node.cumulative_vote)).next()` with `find(|&(_, ref node)| condition(&node.cumulative_vote))`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/voter.rs:183:20
[INFO] [stderr]     |
[INFO] [stderr] 183 |     finalized_sender: UnboundedSender<(H, N, u64, Commit<H, N, E::Signature, E::Id>)>,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/voter.rs:196:21
[INFO] [stderr]     |
[INFO] [stderr] 196 |         finalized_sender: UnboundedSender<(H, N, u64, Commit<H, N, E::Signature, E::Id>)>,
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/voter.rs:438:4
[INFO] [stderr]     |
[INFO] [stderr] 438 |               match (&self.state, new_state.finalized) {
[INFO] [stderr]     |  _____________^
[INFO] [stderr] 439 | |                 (&Some(State::Precommitted), Some((ref f_hash, ref f_number))) => {
[INFO] [stderr] 440 | |                     let commit = create_commit(f_hash.clone(), f_number.clone(), self.votes.precommits(), &*self.env);
[INFO] [stderr] 441 | |                     let finalized = (f_hash.clone(), f_number.clone(), self.votes.number(), commit.clone());
[INFO] [stderr] ...   |
[INFO] [stderr] 446 | |                 _ => {}
[INFO] [stderr] 447 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 438 |             if let (&Some(State::Precommitted), Some((ref f_hash, ref f_number))) = (&self.state, new_state.finalized) {
[INFO] [stderr] 439 |     let commit = create_commit(f_hash.clone(), f_number.clone(), self.votes.precommits(), &*self.env);
[INFO] [stderr] 440 |     let finalized = (f_hash.clone(), f_number.clone(), self.votes.number(), commit.clone());
[INFO] [stderr] 441 | 
[INFO] [stderr] 442 |     let _ = self.finalized_sender.unbounded_send(finalized);
[INFO] [stderr] 443 |     self.best_finalized = Some(commit);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/voter.rs:440:49
[INFO] [stderr]     |
[INFO] [stderr] 440 |                     let commit = create_commit(f_hash.clone(), f_number.clone(), self.votes.precommits(), &*self.env);
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*f_number`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/voter.rs:441:39
[INFO] [stderr]     |
[INFO] [stderr] 441 |                     let finalized = (f_hash.clone(), f_number.clone(), self.votes.number(), commit.clone());
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*f_number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/voter.rs:542:77
[INFO] [stderr]     |
[INFO] [stderr] 542 |         if commit.target_number < voting_round.votes.finalized().map(|(_, n)| *n).unwrap_or(N::zero()) {
[INFO] [stderr]     |                                                                                   ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(N::zero)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/voter.rs:567:26
[INFO] [stderr]     |
[INFO] [stderr] 567 |     fn commit(&mut self) -> Poll<Option<Commit<H, N, E::Signature, E::Id>>, E::Error> {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/voter.rs:641:36
[INFO] [stderr]     |
[INFO] [stderr] 641 |     fn process_incoming(&mut self) -> Result<Option<(u64, Commit<H, N, E::Signature, E::Id>)>, E::Error> {
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/voter.rs:679:32
[INFO] [stderr]     |
[INFO] [stderr] 679 |                         *last_finalized_number = finalized_number.clone();
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `finalized_number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/voter.rs:726:24
[INFO] [stderr]     |
[INFO] [stderr] 726 |     fn poll(&mut self) -> Poll<(u64, Commit<H, N, E::Signature, E::Id>), E::Error> {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/voter.rs:748:27
[INFO] [stderr]     |
[INFO] [stderr] 748 |     finalized_notifications: UnboundedReceiver<(H, N, u64, Commit<H, N, E::Signature, E::Id>)>,
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/voter.rs:782:51
[INFO] [stderr]     |
[INFO] [stderr] 782 |         let last_finalized_number = Arc::new(Mutex::new(last_finalized.1.clone()));
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `last_finalized.1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/voter.rs:835:38
[INFO] [stderr]     |
[INFO] [stderr] 835 |             if self.set_last_finalized_number(f_num.clone()) {
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^ help: try removing the `clone` call: `f_num`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/voter.rs:836:45
[INFO] [stderr]     |
[INFO] [stderr] 836 |                 self.env.finalize_block(f_hash.clone(), f_num.clone(), round, commit)?;
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^ help: try removing the `clone` call: `f_num`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]     --> src/voter.rs:1084:14
[INFO] [stderr]      |
[INFO] [stderr] 1084 |     precommits: Vec<(E::Id, Precommit<H, N>, E::Signature)>,
[INFO] [stderr]      |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/lib.rs:304:44
[INFO] [stderr]     |
[INFO] [stderr] 304 |       if !commit.precommits.iter().all(|signed| {
[INFO] [stderr]     |  _______________________________________________^
[INFO] [stderr] 305 | |         signed.precommit.target_number >= commit.target_number &&
[INFO] [stderr] 306 | |             chain.is_equal_or_descendent_of(
[INFO] [stderr] 307 | |                 commit.target_hash.clone(),
[INFO] [stderr] 308 | |                 signed.precommit.target_hash.clone(),
[INFO] [stderr] 309 | |             )
[INFO] [stderr] 310 | |     }) {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:336:78
[INFO] [stderr]     |
[INFO] [stderr] 336 |     let mut vote_graph = vote_graph::VoteGraph::new(commit.target_hash.clone(), commit.target_number.clone());
[INFO] [stderr]     |                                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `commit.target_number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:339:52
[INFO] [stderr]     |
[INFO] [stderr] 339 |         vote_graph.insert(precommit.target_hash.clone(), precommit.target_number.clone(), *weight, chain)?;
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `precommit.target_number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:344:37
[INFO] [stderr]     |
[INFO] [stderr] 344 |         Some((commit.target_hash.clone(), commit.target_number.clone())),
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `commit.target_number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/round.rs:165:5
[INFO] [stderr]     |
[INFO] [stderr] 165 |                 return Some(&*vacant.insert(VoteMultiplicity::Single(vote, signature)));
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&*vacant.insert(VoteMultiplicity::Single(vote, signature)))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/vote_graph.rs:207:3
[INFO] [stderr]     |
[INFO] [stderr] 207 |         x
[INFO] [stderr]     |         ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/vote_graph.rs:203:11
[INFO] [stderr]     |
[INFO] [stderr] 203 |           let x = good_subchain.blocks_reverse().find(|&(ref good_hash, good_number)|
[INFO] [stderr]     |  _________________^
[INFO] [stderr] 204 | |             canonical_node.in_direct_ancestry(good_hash, good_number).unwrap_or(false)
[INFO] [stderr] 205 | |         );
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/round.rs:110:28
[INFO] [stderr]     |
[INFO] [stderr] 110 |     fn equivocation(&self) -> Option<(&(Vote, Signature), &(Vote, Signature))> {
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/round.rs:312:7
[INFO] [stderr]     |
[INFO] [stderr] 312 |     ) -> Result<Option<Equivocation<Id, Prevote<H, N>, Signature>>, ::Error> {
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/round.rs:379:7
[INFO] [stderr]     |
[INFO] [stderr] 379 |     ) -> Result<Option<Equivocation<Id, Precommit<H, N>, Signature>>, ::Error> {
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/vote_graph.rs:56:3
[INFO] [stderr]    |
[INFO] [stderr] 56 |         self.ancestors.last().map(|x| x.clone())
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.ancestors.last().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/vote_graph.rs:124:3
[INFO] [stderr]     |
[INFO] [stderr] 124 |           match self.find_containing_nodes(hash.clone(), number) {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 125 | |             Some(containing) => if containing.is_empty() {
[INFO] [stderr] 126 | |                 self.append(hash.clone(), number, chain)?;
[INFO] [stderr] 127 | |             } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 130 | |             None => {}, // this entry already exists
[INFO] [stderr] 131 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 124 |         if let Some(containing) = self.find_containing_nodes(hash.clone(), number) { if containing.is_empty() {
[INFO] [stderr] 125 |     self.append(hash.clone(), number, chain)?;
[INFO] [stderr] 126 | } else {
[INFO] [stderr] 127 |     self.introduce_branch(containing, hash.clone(), number);
[INFO] [stderr] 128 | } }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]    --> src/vote_graph.rs:250:26
[INFO] [stderr]     |
[INFO] [stderr] 250 |               let next_descendent = active_node.descendents
[INFO] [stderr]     |  ___________________________________^
[INFO] [stderr] 251 | |                 .iter()
[INFO] [stderr] 252 | |                 .map(|d| (d.clone(), get_node(d)))
[INFO] [stderr] 253 | |                 .filter(|&(_, ref node)| {
[INFO] [stderr] ...   |
[INFO] [stderr] 261 | |                 .filter(|&(_, ref node)| condition(&node.cumulative_vote))
[INFO] [stderr] 262 | |                 .next();
[INFO] [stderr]     | |_______________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]     = note: replace `filter(|&(_, ref node)| condition(&node.cumulative_vote)).next()` with `find(|&(_, ref node)| condition(&node.cumulative_vote))`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/vote_graph.rs:524:17
[INFO] [stderr]     |
[INFO] [stderr] 524 |         let a_entry = tracker.entries.get("A").unwrap();
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tracker.entries["A"]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/vote_graph.rs:529:17
[INFO] [stderr]     |
[INFO] [stderr] 529 |         let e_entry = tracker.entries.get("E1").unwrap();
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tracker.entries["E1"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/vote_graph.rs:533:17
[INFO] [stderr]     |
[INFO] [stderr] 533 |         let f_entry = tracker.entries.get("F2").unwrap();
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tracker.entries["F2"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/vote_graph.rs:561:18
[INFO] [stderr]     |
[INFO] [stderr] 561 |             let c_entry = tracker.entries.get("C").unwrap();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tracker.entries["C"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/vote_graph.rs:567:18
[INFO] [stderr]     |
[INFO] [stderr] 567 |             let e_entry = tracker.entries.get("E1").unwrap();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tracker.entries["E1"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/vote_graph.rs:571:18
[INFO] [stderr]     |
[INFO] [stderr] 571 |             let f_entry = tracker.entries.get("F2").unwrap();
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tracker.entries["F2"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/vote_graph.rs:629:14
[INFO] [stderr]     |
[INFO] [stderr] 629 |         assert_eq!(tracker.entries.get(GENESIS_HASH).unwrap().descendents, vec!["FC", "ED"]);
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tracker.entries[GENESIS_HASH]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/vote_graph.rs:634:14
[INFO] [stderr]     |
[INFO] [stderr] 634 |         assert_eq!(tracker.entries.get(GENESIS_HASH).unwrap().descendents, vec!["E"]);
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tracker.entries[GENESIS_HASH]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/vote_graph.rs:635:22
[INFO] [stderr]     |
[INFO] [stderr] 635 |         let descendents = &tracker.entries.get("E").unwrap().descendents;
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tracker.entries["E"]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/voter.rs:183:20
[INFO] [stderr]     |
[INFO] [stderr] 183 |     finalized_sender: UnboundedSender<(H, N, u64, Commit<H, N, E::Signature, E::Id>)>,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/voter.rs:196:21
[INFO] [stderr]     |
[INFO] [stderr] 196 |         finalized_sender: UnboundedSender<(H, N, u64, Commit<H, N, E::Signature, E::Id>)>,
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/voter.rs:438:4
[INFO] [stderr]     |
[INFO] [stderr] 438 |               match (&self.state, new_state.finalized) {
[INFO] [stderr]     |  _____________^
[INFO] [stderr] 439 | |                 (&Some(State::Precommitted), Some((ref f_hash, ref f_number))) => {
[INFO] [stderr] 440 | |                     let commit = create_commit(f_hash.clone(), f_number.clone(), self.votes.precommits(), &*self.env);
[INFO] [stderr] 441 | |                     let finalized = (f_hash.clone(), f_number.clone(), self.votes.number(), commit.clone());
[INFO] [stderr] ...   |
[INFO] [stderr] 446 | |                 _ => {}
[INFO] [stderr] 447 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 438 |             if let (&Some(State::Precommitted), Some((ref f_hash, ref f_number))) = (&self.state, new_state.finalized) {
[INFO] [stderr] 439 |     let commit = create_commit(f_hash.clone(), f_number.clone(), self.votes.precommits(), &*self.env);
[INFO] [stderr] 440 |     let finalized = (f_hash.clone(), f_number.clone(), self.votes.number(), commit.clone());
[INFO] [stderr] 441 | 
[INFO] [stderr] 442 |     let _ = self.finalized_sender.unbounded_send(finalized);
[INFO] [stderr] 443 |     self.best_finalized = Some(commit);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/voter.rs:440:49
[INFO] [stderr]     |
[INFO] [stderr] 440 |                     let commit = create_commit(f_hash.clone(), f_number.clone(), self.votes.precommits(), &*self.env);
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*f_number`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/voter.rs:441:39
[INFO] [stderr]     |
[INFO] [stderr] 441 |                     let finalized = (f_hash.clone(), f_number.clone(), self.votes.number(), commit.clone());
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*f_number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/voter.rs:542:77
[INFO] [stderr]     |
[INFO] [stderr] 542 |         if commit.target_number < voting_round.votes.finalized().map(|(_, n)| *n).unwrap_or(N::zero()) {
[INFO] [stderr]     |                                                                                   ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(N::zero)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/voter.rs:567:26
[INFO] [stderr]     |
[INFO] [stderr] 567 |     fn commit(&mut self) -> Poll<Option<Commit<H, N, E::Signature, E::Id>>, E::Error> {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/voter.rs:641:36
[INFO] [stderr]     |
[INFO] [stderr] 641 |     fn process_incoming(&mut self) -> Result<Option<(u64, Commit<H, N, E::Signature, E::Id>)>, E::Error> {
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/voter.rs:679:32
[INFO] [stderr]     |
[INFO] [stderr] 679 |                         *last_finalized_number = finalized_number.clone();
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `finalized_number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/voter.rs:726:24
[INFO] [stderr]     |
[INFO] [stderr] 726 |     fn poll(&mut self) -> Poll<(u64, Commit<H, N, E::Signature, E::Id>), E::Error> {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/voter.rs:748:27
[INFO] [stderr]     |
[INFO] [stderr] 748 |     finalized_notifications: UnboundedReceiver<(H, N, u64, Commit<H, N, E::Signature, E::Id>)>,
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/voter.rs:782:51
[INFO] [stderr]     |
[INFO] [stderr] 782 |         let last_finalized_number = Arc::new(Mutex::new(last_finalized.1.clone()));
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `last_finalized.1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/voter.rs:835:38
[INFO] [stderr]     |
[INFO] [stderr] 835 |             if self.set_last_finalized_number(f_num.clone()) {
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^ help: try removing the `clone` call: `f_num`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/voter.rs:836:45
[INFO] [stderr]     |
[INFO] [stderr] 836 |                 self.env.finalize_block(f_hash.clone(), f_num.clone(), round, commit)?;
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^ help: try removing the `clone` call: `f_num`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]     --> src/voter.rs:1084:14
[INFO] [stderr]      |
[INFO] [stderr] 1084 |     precommits: Vec<(E::Id, Precommit<H, N>, E::Signature)>,
[INFO] [stderr]      |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/testing.rs:62:21
[INFO] [stderr]    |
[INFO] [stderr] 62 |         let base_number = self.inner.get(parent).unwrap().number + 1;
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.inner[parent]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/testing.rs:78:25
[INFO] [stderr]    |
[INFO] [stderr] 78 |         let new_leaf_number = self.inner.get(new_leaf).unwrap().number;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.inner[new_leaf]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/testing.rs:81:8
[INFO] [stderr]    |
[INFO] [stderr] 81 |             |x| self.inner.get(x).unwrap().number.cmp(&new_leaf_number).reverse(),
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.inner[x]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/testing.rs:88:3
[INFO] [stderr]    |
[INFO] [stderr] 88 |         self.inner.get(hash).unwrap().number
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.inner[hash]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/testing.rs:92:3
[INFO] [stderr]    |
[INFO] [stderr] 92 |         self.finalized.clone()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.finalized`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/testing.rs:120:22
[INFO] [stderr]     |
[INFO] [stderr] 120 |             let leaf_number = self.inner.get(leaf).unwrap().number;
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.inner[leaf]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/testing.rs:127:11
[INFO] [stderr]     |
[INFO] [stderr] 127 |               if let Ok(_) = self.ancestry(base, leaf) {
[INFO] [stderr]     |  _____________-      ^^^^^
[INFO] [stderr] 128 | |                 return Some((leaf, leaf_number));
[INFO] [stderr] 129 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if self.ancestry(base, leaf).is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/testing.rs:146:13
[INFO] [stderr]     |
[INFO] [stderr] 146 |     listeners: Mutex<Vec<UnboundedSender<(&'static str, u32, Commit<&'static str, u32, Signature, Id>)>>>,
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/testing.rs:165:36
[INFO] [stderr]     |
[INFO] [stderr] 165 |     pub fn finalized_stream(&self) -> UnboundedReceiver<(&'static str, u32, Commit<&'static str, u32, Signature, Id>)> {
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]    --> src/lib.rs:304:44
[INFO] [stderr]     |
[INFO] [stderr] 304 |       if !commit.precommits.iter().all(|signed| {
[INFO] [stderr]     |  _______________________________________________^
[INFO] [stderr] 305 | |         signed.precommit.target_number >= commit.target_number &&
[INFO] [stderr] 306 | |             chain.is_equal_or_descendent_of(
[INFO] [stderr] 307 | |                 commit.target_hash.clone(),
[INFO] [stderr] 308 | |                 signed.precommit.target_hash.clone(),
[INFO] [stderr] 309 | |             )
[INFO] [stderr] 310 | |     }) {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:336:78
[INFO] [stderr]     |
[INFO] [stderr] 336 |     let mut vote_graph = vote_graph::VoteGraph::new(commit.target_hash.clone(), commit.target_number.clone());
[INFO] [stderr]     |                                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `commit.target_number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:339:52
[INFO] [stderr]     |
[INFO] [stderr] 339 |         vote_graph.insert(precommit.target_hash.clone(), precommit.target_number.clone(), *weight, chain)?;
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `precommit.target_number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:344:37
[INFO] [stderr]     |
[INFO] [stderr] 344 |         Some((commit.target_hash.clone(), commit.target_number.clone())),
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `commit.target_number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 10.12s
[INFO] running `"docker" "inspect" "513fa643e59634ff75737c603722460c63df72e5ee4d64124b0b95eae31b4f87"`
[INFO] running `"docker" "rm" "-f" "513fa643e59634ff75737c603722460c63df72e5ee4d64124b0b95eae31b4f87"`
[INFO] [stdout] 513fa643e59634ff75737c603722460c63df72e5ee4d64124b0b95eae31b4f87