[INFO] crate filecheck 0.4.0 is already in cache [INFO] extracting crate filecheck 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/filecheck/0.4.0 [INFO] extracting crate filecheck 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/filecheck/0.4.0 [INFO] validating manifest of filecheck-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of filecheck-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing filecheck-0.4.0 [INFO] finished frobbing filecheck-0.4.0 [INFO] frobbed toml for filecheck-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/filecheck/0.4.0/Cargo.toml [INFO] started frobbing filecheck-0.4.0 [INFO] finished frobbing filecheck-0.4.0 [INFO] frobbed toml for filecheck-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/filecheck/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting filecheck-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/filecheck/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 771b1808abf2a17e1a3699817bfbcb255ffdc4cdc5ced78e02594a6cc3a1bbdd [INFO] running `"docker" "start" "-a" "771b1808abf2a17e1a3699817bfbcb255ffdc4cdc5ced78e02594a6cc3a1bbdd"` [INFO] [stderr] Checking filecheck v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/checker.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | directives: directives, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directives` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/explain.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/checker.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | directives: directives, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directives` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/explain.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/variable.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | pub const NO_VARIABLES: &'static VariableMap = &(); [INFO] [stderr] | -^^^^^^^------------ help: consider removing `'static`: `&VariableMap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/variable.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | pub const NO_VARIABLES: &'static VariableMap = &(); [INFO] [stderr] | -^^^^^^^------------ help: consider removing `'static`: `&VariableMap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `checker::CheckerBuilder` [INFO] [stderr] --> src/checker.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / pub fn new() -> Self { [INFO] [stderr] 98 | | Self { [INFO] [stderr] 99 | | directives: Vec::new(), [INFO] [stderr] 100 | | linerx: Regex::new(DIRECTIVE_RX).unwrap(), [INFO] [stderr] 101 | | } [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | impl Default for checker::CheckerBuilder { [INFO] [stderr] 96 | fn default() -> Self { [INFO] [stderr] 97 | Self::new() [INFO] [stderr] 98 | } [INFO] [stderr] 99 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/explain.rs:90:22 [INFO] [stderr] | [INFO] [stderr] 90 | .unwrap_or(self.text.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.text.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/pattern.rs:90:30 [INFO] [stderr] | [INFO] [stderr] 90 | let end = dollar.unwrap_or(s.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `checker::CheckerBuilder` [INFO] [stderr] --> src/checker.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / pub fn new() -> Self { [INFO] [stderr] 98 | | Self { [INFO] [stderr] 99 | | directives: Vec::new(), [INFO] [stderr] 100 | | linerx: Regex::new(DIRECTIVE_RX).unwrap(), [INFO] [stderr] 101 | | } [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | impl Default for checker::CheckerBuilder { [INFO] [stderr] 96 | fn default() -> Self { [INFO] [stderr] 97 | Self::new() [INFO] [stderr] 98 | } [INFO] [stderr] 99 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/explain.rs:90:22 [INFO] [stderr] | [INFO] [stderr] 90 | .unwrap_or(self.text.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.text.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/pattern.rs:90:30 [INFO] [stderr] | [INFO] [stderr] 90 | let end = dollar.unwrap_or(s.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| s.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.45s [INFO] running `"docker" "inspect" "771b1808abf2a17e1a3699817bfbcb255ffdc4cdc5ced78e02594a6cc3a1bbdd"` [INFO] running `"docker" "rm" "-f" "771b1808abf2a17e1a3699817bfbcb255ffdc4cdc5ced78e02594a6cc3a1bbdd"` [INFO] [stdout] 771b1808abf2a17e1a3699817bfbcb255ffdc4cdc5ced78e02594a6cc3a1bbdd