[INFO] crate filearco 0.1.0 is already in cache [INFO] extracting crate filearco 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/filearco/0.1.0 [INFO] extracting crate filearco 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/filearco/0.1.0 [INFO] validating manifest of filearco-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of filearco-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing filearco-0.1.0 [INFO] finished frobbing filearco-0.1.0 [INFO] frobbed toml for filearco-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/filearco/0.1.0/Cargo.toml [INFO] started frobbing filearco-0.1.0 [INFO] finished frobbing filearco-0.1.0 [INFO] frobbed toml for filearco-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/filearco/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting filearco-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/filearco/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d7c5ca6c933469b7a172b996def2918d52e5e2a34ef017a6b1c0f393c3c3f4e5 [INFO] running `"docker" "start" "-a" "d7c5ca6c933469b7a172b996def2918d52e5e2a34ef017a6b1c0f393c3c3f4e5"` [INFO] [stderr] Checking page_size v0.4.1 [INFO] [stderr] Checking memadvise v0.1.2 [INFO] [stderr] Checking filearco v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_data.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_data.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | base_path: base_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `base_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_data.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_data.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_data.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_data.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | checksum: checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | map: map, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:539:13 [INFO] [stderr] | [INFO] [stderr] 539 | page_size: page_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `page_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:540:13 [INFO] [stderr] | [INFO] [stderr] 540 | entries_length: entries_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entries_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:541:13 [INFO] [stderr] | [INFO] [stderr] 541 | entries_checksum: entries_checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entries_checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:552:13 [INFO] [stderr] | [INFO] [stderr] 552 | file_length: file_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:553:13 [INFO] [stderr] | [INFO] [stderr] 553 | file_offset: file_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:554:13 [INFO] [stderr] | [INFO] [stderr] 554 | page_size: page_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `page_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:555:13 [INFO] [stderr] | [INFO] [stderr] 555 | entries_length: entries_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entries_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:556:13 [INFO] [stderr] | [INFO] [stderr] 556 | entries_checksum: entries_checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entries_checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:577:30 [INFO] [stderr] | [INFO] [stderr] 577 | aligned_length: aligned_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `aligned_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:593:13 [INFO] [stderr] | [INFO] [stderr] 593 | files: files [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_data.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_data.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | base_path: base_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `base_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_data.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_data.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_data.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_data.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | checksum: checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | map: map, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:539:13 [INFO] [stderr] | [INFO] [stderr] 539 | page_size: page_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `page_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:540:13 [INFO] [stderr] | [INFO] [stderr] 540 | entries_length: entries_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entries_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:541:13 [INFO] [stderr] | [INFO] [stderr] 541 | entries_checksum: entries_checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entries_checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:552:13 [INFO] [stderr] | [INFO] [stderr] 552 | file_length: file_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:553:13 [INFO] [stderr] | [INFO] [stderr] 553 | file_offset: file_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:554:13 [INFO] [stderr] | [INFO] [stderr] 554 | page_size: page_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `page_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:555:13 [INFO] [stderr] | [INFO] [stderr] 555 | entries_length: entries_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entries_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:556:13 [INFO] [stderr] | [INFO] [stderr] 556 | entries_checksum: entries_checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entries_checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:577:30 [INFO] [stderr] | [INFO] [stderr] 577 | aligned_length: aligned_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `aligned_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/v1.rs:593:13 [INFO] [stderr] | [INFO] [stderr] 593 | files: files [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | const FILEARCO_ID: &'static [u8; 8] = b"FILEARCO"; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: item `file_data::FileData` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/file_data.rs:100:1 [INFO] [stderr] | [INFO] [stderr] 100 | / impl FileData { [INFO] [stderr] 101 | | // This is needed for unit tests in v1.rs so the fields of [INFO] [stderr] 102 | | // `FileData` do not have to be public. [INFO] [stderr] 103 | | #[cfg(test)] [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/v1.rs:104:23 [INFO] [stderr] | [INFO] [stderr] 104 | let ptr = map.ptr().offset(test_header_encoded.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `map.ptr().add(test_header_encoded.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/v1.rs:129:23 [INFO] [stderr] | [INFO] [stderr] 129 | let ptr = map.ptr().offset(offset as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `map.ptr().add(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: item `v1::FileRef` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/v1.rs:296:1 [INFO] [stderr] | [INFO] [stderr] 296 | / impl FileRef { [INFO] [stderr] 297 | | /// This method ensures the file contents have not been corrupted. [INFO] [stderr] 298 | | /// [INFO] [stderr] 299 | | /// # Example [INFO] [stderr] ... | [INFO] [stderr] 421 | | } [INFO] [stderr] 422 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/v1.rs:589:13 [INFO] [stderr] | [INFO] [stderr] 589 | offset = offset + val.aligned_length; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += val.aligned_length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/v1.rs:603:23 [INFO] [stderr] | [INFO] [stderr] 603 | let val = self.files.get(&key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.files[&key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/v1.rs:604:13 [INFO] [stderr] | [INFO] [stderr] 604 | total_length = total_length + val.aligned_length; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_length += val.aligned_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / match self { [INFO] [stderr] 75 | | &Error::Io(ref err) => err.fmt(fmt), [INFO] [stderr] 76 | | &Error::Utf8(ref err) => err.fmt(fmt), [INFO] [stderr] 77 | | &Error::Walkdir(ref err) => err.fmt(fmt), [INFO] [stderr] 78 | | &Error::FileArcoV1(ref err) => err.fmt(fmt), [INFO] [stderr] 79 | | &Error::FileData(ref err) => err.fmt(fmt), [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 74 | match *self { [INFO] [stderr] 75 | Error::Io(ref err) => err.fmt(fmt), [INFO] [stderr] 76 | Error::Utf8(ref err) => err.fmt(fmt), [INFO] [stderr] 77 | Error::Walkdir(ref err) => err.fmt(fmt), [INFO] [stderr] 78 | Error::FileArcoV1(ref err) => err.fmt(fmt), [INFO] [stderr] 79 | Error::FileData(ref err) => err.fmt(fmt), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / match self { [INFO] [stderr] 87 | | &Error::Io(ref err) => err.description(), [INFO] [stderr] 88 | | &Error::Utf8(ref err) => err.description(), [INFO] [stderr] 89 | | &Error::Walkdir(ref err) => err.description(), [INFO] [stderr] 90 | | &Error::FileArcoV1(ref err) => err.description(), [INFO] [stderr] 91 | | &Error::FileData(ref err) => err.description(), [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | match *self { [INFO] [stderr] 87 | Error::Io(ref err) => err.description(), [INFO] [stderr] 88 | Error::Utf8(ref err) => err.description(), [INFO] [stderr] 89 | Error::Walkdir(ref err) => err.description(), [INFO] [stderr] 90 | Error::FileArcoV1(ref err) => err.description(), [INFO] [stderr] 91 | Error::FileData(ref err) => err.description(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / match self { [INFO] [stderr] 97 | | &Error::Io(ref err) => err.cause(), [INFO] [stderr] 98 | | &Error::Utf8(ref err) => err.cause(), [INFO] [stderr] 99 | | &Error::Walkdir(ref err) => err.cause(), [INFO] [stderr] 100 | | &Error::FileArcoV1(ref err) => err.cause(), [INFO] [stderr] 101 | | &Error::FileData(ref err) => err.cause(), [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *self { [INFO] [stderr] 97 | Error::Io(ref err) => err.cause(), [INFO] [stderr] 98 | Error::Utf8(ref err) => err.cause(), [INFO] [stderr] 99 | Error::Walkdir(ref err) => err.cause(), [INFO] [stderr] 100 | Error::FileArcoV1(ref err) => err.cause(), [INFO] [stderr] 101 | Error::FileData(ref err) => err.cause(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | const FILEARCO_ID: &'static [u8; 8] = b"FILEARCO"; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/v1.rs:648:13 [INFO] [stderr] | [INFO] [stderr] 648 | 10574576474013701409, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `10_574_576_474_013_701_409` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/v1.rs:653:13 [INFO] [stderr] | [INFO] [stderr] 653 | 8740797956101379381, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `8_740_797_956_101_379_381` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/v1.rs:658:13 [INFO] [stderr] | [INFO] [stderr] 658 | 13423357612537305206, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `13_423_357_612_537_305_206` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: item `file_data::FileData` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/file_data.rs:100:1 [INFO] [stderr] | [INFO] [stderr] 100 | / impl FileData { [INFO] [stderr] 101 | | // This is needed for unit tests in v1.rs so the fields of [INFO] [stderr] 102 | | // `FileData` do not have to be public. [INFO] [stderr] 103 | | #[cfg(test)] [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/v1.rs:104:23 [INFO] [stderr] | [INFO] [stderr] 104 | let ptr = map.ptr().offset(test_header_encoded.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `map.ptr().add(test_header_encoded.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/v1.rs:129:23 [INFO] [stderr] | [INFO] [stderr] 129 | let ptr = map.ptr().offset(offset as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `map.ptr().add(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: item `v1::FileRef` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/v1.rs:296:1 [INFO] [stderr] | [INFO] [stderr] 296 | / impl FileRef { [INFO] [stderr] 297 | | /// This method ensures the file contents have not been corrupted. [INFO] [stderr] 298 | | /// [INFO] [stderr] 299 | | /// # Example [INFO] [stderr] ... | [INFO] [stderr] 421 | | } [INFO] [stderr] 422 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/v1.rs:589:13 [INFO] [stderr] | [INFO] [stderr] 589 | offset = offset + val.aligned_length; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += val.aligned_length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/v1.rs:603:23 [INFO] [stderr] | [INFO] [stderr] 603 | let val = self.files.get(&key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.files[&key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/v1.rs:604:13 [INFO] [stderr] | [INFO] [stderr] 604 | total_length = total_length + val.aligned_length; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_length += val.aligned_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / match self { [INFO] [stderr] 75 | | &Error::Io(ref err) => err.fmt(fmt), [INFO] [stderr] 76 | | &Error::Utf8(ref err) => err.fmt(fmt), [INFO] [stderr] 77 | | &Error::Walkdir(ref err) => err.fmt(fmt), [INFO] [stderr] 78 | | &Error::FileArcoV1(ref err) => err.fmt(fmt), [INFO] [stderr] 79 | | &Error::FileData(ref err) => err.fmt(fmt), [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 74 | match *self { [INFO] [stderr] 75 | Error::Io(ref err) => err.fmt(fmt), [INFO] [stderr] 76 | Error::Utf8(ref err) => err.fmt(fmt), [INFO] [stderr] 77 | Error::Walkdir(ref err) => err.fmt(fmt), [INFO] [stderr] 78 | Error::FileArcoV1(ref err) => err.fmt(fmt), [INFO] [stderr] 79 | Error::FileData(ref err) => err.fmt(fmt), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / match self { [INFO] [stderr] 87 | | &Error::Io(ref err) => err.description(), [INFO] [stderr] 88 | | &Error::Utf8(ref err) => err.description(), [INFO] [stderr] 89 | | &Error::Walkdir(ref err) => err.description(), [INFO] [stderr] 90 | | &Error::FileArcoV1(ref err) => err.description(), [INFO] [stderr] 91 | | &Error::FileData(ref err) => err.description(), [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | match *self { [INFO] [stderr] 87 | Error::Io(ref err) => err.description(), [INFO] [stderr] 88 | Error::Utf8(ref err) => err.description(), [INFO] [stderr] 89 | Error::Walkdir(ref err) => err.description(), [INFO] [stderr] 90 | Error::FileArcoV1(ref err) => err.description(), [INFO] [stderr] 91 | Error::FileData(ref err) => err.description(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / match self { [INFO] [stderr] 97 | | &Error::Io(ref err) => err.cause(), [INFO] [stderr] 98 | | &Error::Utf8(ref err) => err.cause(), [INFO] [stderr] 99 | | &Error::Walkdir(ref err) => err.cause(), [INFO] [stderr] 100 | | &Error::FileArcoV1(ref err) => err.cause(), [INFO] [stderr] 101 | | &Error::FileData(ref err) => err.cause(), [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *self { [INFO] [stderr] 97 | Error::Io(ref err) => err.cause(), [INFO] [stderr] 98 | Error::Utf8(ref err) => err.cause(), [INFO] [stderr] 99 | Error::Walkdir(ref err) => err.cause(), [INFO] [stderr] 100 | Error::FileArcoV1(ref err) => err.cause(), [INFO] [stderr] 101 | Error::FileData(ref err) => err.cause(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.24s [INFO] running `"docker" "inspect" "d7c5ca6c933469b7a172b996def2918d52e5e2a34ef017a6b1c0f393c3c3f4e5"` [INFO] running `"docker" "rm" "-f" "d7c5ca6c933469b7a172b996def2918d52e5e2a34ef017a6b1c0f393c3c3f4e5"` [INFO] [stdout] d7c5ca6c933469b7a172b996def2918d52e5e2a34ef017a6b1c0f393c3c3f4e5