[INFO] crate file_scanner 0.2.0 is already in cache [INFO] extracting crate file_scanner 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/file_scanner/0.2.0 [INFO] extracting crate file_scanner 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/file_scanner/0.2.0 [INFO] validating manifest of file_scanner-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of file_scanner-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing file_scanner-0.2.0 [INFO] finished frobbing file_scanner-0.2.0 [INFO] frobbed toml for file_scanner-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/file_scanner/0.2.0/Cargo.toml [INFO] started frobbing file_scanner-0.2.0 [INFO] finished frobbing file_scanner-0.2.0 [INFO] frobbed toml for file_scanner-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/file_scanner/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting file_scanner-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/file_scanner/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1fb4b5fcc09fc4c904cc32fc20aa61d7b2c49a795753af1ae20481b3a4b37dff [INFO] running `"docker" "start" "-a" "1fb4b5fcc09fc4c904cc32fc20aa61d7b2c49a795753af1ae20481b3a4b37dff"` [INFO] [stderr] Checking file_scanner v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 122 | | self.consume_leading_delims(); [INFO] [stderr] 123 | | [INFO] [stderr] 124 | | let delim_idx; [INFO] [stderr] ... | [INFO] [stderr] 170 | | Some(res) [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:84:45 [INFO] [stderr] | [INFO] [stderr] 84 | assert_eq!(test.next_int::(), Some(2147483647)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/tests.rs:109:31 [INFO] [stderr] | [INFO] [stderr] 109 | test.set_delim(Regex::new(r"foo").unwrap()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / pub fn next(&mut self) -> Option { [INFO] [stderr] 122 | | self.consume_leading_delims(); [INFO] [stderr] 123 | | [INFO] [stderr] 124 | | let delim_idx; [INFO] [stderr] ... | [INFO] [stderr] 170 | | Some(res) [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.11s [INFO] running `"docker" "inspect" "1fb4b5fcc09fc4c904cc32fc20aa61d7b2c49a795753af1ae20481b3a4b37dff"` [INFO] running `"docker" "rm" "-f" "1fb4b5fcc09fc4c904cc32fc20aa61d7b2c49a795753af1ae20481b3a4b37dff"` [INFO] [stdout] 1fb4b5fcc09fc4c904cc32fc20aa61d7b2c49a795753af1ae20481b3a4b37dff