[INFO] crate file_logger 0.1.0 is already in cache [INFO] extracting crate file_logger 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/file_logger/0.1.0 [INFO] extracting crate file_logger 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/file_logger/0.1.0 [INFO] validating manifest of file_logger-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of file_logger-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing file_logger-0.1.0 [INFO] finished frobbing file_logger-0.1.0 [INFO] frobbed toml for file_logger-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/file_logger/0.1.0/Cargo.toml [INFO] started frobbing file_logger-0.1.0 [INFO] finished frobbing file_logger-0.1.0 [INFO] frobbed toml for file_logger-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/file_logger/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting file_logger-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/file_logger/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 03466ccae2827955e939f521db3dd79b4a80434fd66451c78cf99c675c4ade6b [INFO] running `"docker" "start" "-a" "03466ccae2827955e939f521db3dd79b4a80434fd66451c78cf99c675c4ade6b"` [INFO] [stderr] Checking file_logger v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logger.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logger.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logger.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logger.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | on_error: on_error, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `on_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logger.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logger.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logger.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logger.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | on_error: on_error, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `on_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/format.rs:71:40 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn format(&self, mut w: &mut W, record: &LogRecord, datetime: &Tm) -> Result<(), Error>{ [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/format.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match self { [INFO] [stderr] 29 | | &FormatSpecifier::Str(ref s) => try!(write!(f, "{}", s)), [INFO] [stderr] 30 | | &FormatSpecifier::Level => try!(write!(f, "{}", record.level())), [INFO] [stderr] 31 | | // TODO: don't use `unwrap()` [INFO] [stderr] ... | [INFO] [stderr] 36 | | &FormatSpecifier::Message => try!(write!(f, "{}", record.args())) [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | match *self { [INFO] [stderr] 29 | FormatSpecifier::Str(ref s) => try!(write!(f, "{}", s)), [INFO] [stderr] 30 | FormatSpecifier::Level => try!(write!(f, "{}", record.level())), [INFO] [stderr] 31 | // TODO: don't use `unwrap()` [INFO] [stderr] 32 | FormatSpecifier::Timestamp(ref s) => try!(write!(f, "{}", try!(time::strftime(s, datetime)))), [INFO] [stderr] 33 | FormatSpecifier::ModulePath => try!(write!(f, "{}", location.module_path())), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `format::Formatter` [INFO] [stderr] --> src/format.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new() -> Self { [INFO] [stderr] 48 | | Formatter {f: Vec::new()} [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/format.rs:71:40 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn format(&self, mut w: &mut W, record: &LogRecord, datetime: &Tm) -> Result<(), Error>{ [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/format.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match self { [INFO] [stderr] 29 | | &FormatSpecifier::Str(ref s) => try!(write!(f, "{}", s)), [INFO] [stderr] 30 | | &FormatSpecifier::Level => try!(write!(f, "{}", record.level())), [INFO] [stderr] 31 | | // TODO: don't use `unwrap()` [INFO] [stderr] ... | [INFO] [stderr] 36 | | &FormatSpecifier::Message => try!(write!(f, "{}", record.args())) [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | match *self { [INFO] [stderr] 29 | FormatSpecifier::Str(ref s) => try!(write!(f, "{}", s)), [INFO] [stderr] 30 | FormatSpecifier::Level => try!(write!(f, "{}", record.level())), [INFO] [stderr] 31 | // TODO: don't use `unwrap()` [INFO] [stderr] 32 | FormatSpecifier::Timestamp(ref s) => try!(write!(f, "{}", try!(time::strftime(s, datetime)))), [INFO] [stderr] 33 | FormatSpecifier::ModulePath => try!(write!(f, "{}", location.module_path())), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `format::Formatter` [INFO] [stderr] --> src/format.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn new() -> Self { [INFO] [stderr] 48 | | Formatter {f: Vec::new()} [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `OnError` [INFO] [stderr] --> src/main.rs:6:40 [INFO] [stderr] | [INFO] [stderr] 6 | use self::file_logger::{LoggerBuilder, OnError}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `regex` [INFO] [stderr] --> src/main.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let regex = Regex::new("test").unwrap(); [INFO] [stderr] | ^^^^^ help: consider using `_regex` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:9:28 [INFO] [stderr] | [INFO] [stderr] 9 | let regex = Regex::new("test").unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: unused import: `OnError` [INFO] [stderr] --> src/main.rs:6:40 [INFO] [stderr] | [INFO] [stderr] 6 | use self::file_logger::{LoggerBuilder, OnError}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `regex` [INFO] [stderr] --> src/main.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let regex = Regex::new("test").unwrap(); [INFO] [stderr] | ^^^^^ help: consider using `_regex` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:9:28 [INFO] [stderr] | [INFO] [stderr] 9 | let regex = Regex::new("test").unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.40s [INFO] running `"docker" "inspect" "03466ccae2827955e939f521db3dd79b4a80434fd66451c78cf99c675c4ade6b"` [INFO] running `"docker" "rm" "-f" "03466ccae2827955e939f521db3dd79b4a80434fd66451c78cf99c675c4ade6b"` [INFO] [stdout] 03466ccae2827955e939f521db3dd79b4a80434fd66451c78cf99c675c4ade6b