[INFO] crate file-map 0.1.1 is already in cache [INFO] extracting crate file-map 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/file-map/0.1.1 [INFO] extracting crate file-map 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/file-map/0.1.1 [INFO] validating manifest of file-map-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of file-map-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing file-map-0.1.1 [INFO] finished frobbing file-map-0.1.1 [INFO] frobbed toml for file-map-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/file-map/0.1.1/Cargo.toml [INFO] started frobbing file-map-0.1.1 [INFO] finished frobbing file-map-0.1.1 [INFO] frobbed toml for file-map-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/file-map/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting file-map-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/file-map/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c183213365fb0ffd8943d06e7262a3c98bfee29dc2723b3e6814e5d9bfa61f29 [INFO] running `"docker" "start" "-a" "c183213365fb0ffd8943d06e7262a3c98bfee29dc2723b3e6814e5d9bfa61f29"` [INFO] [stderr] Checking file-map v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/directive.rs:160:29 [INFO] [stderr] | [INFO] [stderr] 160 | write!(f, "{}", "Test directive") [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | dry_run: dry_run, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dry_run` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/directive.rs:160:29 [INFO] [stderr] | [INFO] [stderr] 160 | write!(f, "{}", "Test directive") [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | dry_run: dry_run, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dry_run` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/directive.rs:30:18 [INFO] [stderr] | [INFO] [stderr] 30 | .map(|captures| (self.action_factory)(captures)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `(self.action_factory)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/directive.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | all_directives: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Box]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/directive.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | / match directive.create_mapping(directive_definition) { [INFO] [stderr] 102 | | Some(mapping_result) => { [INFO] [stderr] 103 | | matched_directives.push(directive); [INFO] [stderr] 104 | | found_mapping = Some(mapping_result); [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | _ => (), [INFO] [stderr] 107 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | if let Some(mapping_result) = directive.create_mapping(directive_definition) { [INFO] [stderr] 102 | matched_directives.push(directive); [INFO] [stderr] 103 | found_mapping = Some(mapping_result); [INFO] [stderr] 104 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mapping.rs:19:38 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn determine_tasks<'a>(mappings: &Vec, files: &Vec, file_context: &MapFileContext) -> Result>> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Mapping]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mapping.rs:19:60 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn determine_tasks<'a>(mappings: &Vec, files: &Vec, file_context: &MapFileContext) -> Result>> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[PathBuf]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mapping.rs:32:33 [INFO] [stderr] | [INFO] [stderr] 32 | fn determine_task<'a>(mappings: &Vec, file: PathBuf, file_context: MapFileContext) -> Result>> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Mapping]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:173:21 [INFO] [stderr] | [INFO] [stderr] 173 | all_directives: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Box]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / match mapping_from_string(all_directives, &line) { [INFO] [stderr] 183 | | Some(result) => mappings.push(result?), [INFO] [stderr] 184 | | None => (), [INFO] [stderr] 185 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(result) = mapping_from_string(all_directives, &line) { mappings.push(result?) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/directive.rs:30:18 [INFO] [stderr] | [INFO] [stderr] 30 | .map(|captures| (self.action_factory)(captures)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `(self.action_factory)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/directive.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | all_directives: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Box]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/directive.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | / match directive.create_mapping(directive_definition) { [INFO] [stderr] 102 | | Some(mapping_result) => { [INFO] [stderr] 103 | | matched_directives.push(directive); [INFO] [stderr] 104 | | found_mapping = Some(mapping_result); [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | _ => (), [INFO] [stderr] 107 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | if let Some(mapping_result) = directive.create_mapping(directive_definition) { [INFO] [stderr] 102 | matched_directives.push(directive); [INFO] [stderr] 103 | found_mapping = Some(mapping_result); [INFO] [stderr] 104 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/directive.rs:166:16 [INFO] [stderr] | [INFO] [stderr] 166 | if definition == &self.expected_definition { [INFO] [stderr] | ^^^^^^^^^^^^^^------------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.expected_definition` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mapping.rs:19:38 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn determine_tasks<'a>(mappings: &Vec, files: &Vec, file_context: &MapFileContext) -> Result>> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Mapping]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mapping.rs:19:60 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn determine_tasks<'a>(mappings: &Vec, files: &Vec, file_context: &MapFileContext) -> Result>> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[PathBuf]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mapping.rs:32:33 [INFO] [stderr] | [INFO] [stderr] 32 | fn determine_task<'a>(mappings: &Vec, file: PathBuf, file_context: MapFileContext) -> Result>> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Mapping]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/rule.rs:35:49 [INFO] [stderr] | [INFO] [stderr] 35 | let rule = RegexRule { rule: Regex::new("match").unwrap() }; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/rule.rs:43:49 [INFO] [stderr] | [INFO] [stderr] 43 | let rule = RegexRule { rule: Regex::new("nomatch").unwrap() }; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:173:21 [INFO] [stderr] | [INFO] [stderr] 173 | all_directives: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Box]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | / match mapping_from_string(all_directives, &line) { [INFO] [stderr] 183 | | Some(result) => mappings.push(result?), [INFO] [stderr] 184 | | None => (), [INFO] [stderr] 185 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(result) = mapping_from_string(all_directives, &line) { mappings.push(result?) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | / match get_file_paths(&PathBuf::from("does-not-exist")) { [INFO] [stderr] 228 | | Ok(_) => panic!("No results should be returned"), [INFO] [stderr] 229 | | Err(_) => (), [INFO] [stderr] 230 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = get_file_paths(&PathBuf::from("does-not-exist")) { panic!("No results should be returned") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.09s [INFO] running `"docker" "inspect" "c183213365fb0ffd8943d06e7262a3c98bfee29dc2723b3e6814e5d9bfa61f29"` [INFO] running `"docker" "rm" "-f" "c183213365fb0ffd8943d06e7262a3c98bfee29dc2723b3e6814e5d9bfa61f29"` [INFO] [stdout] c183213365fb0ffd8943d06e7262a3c98bfee29dc2723b3e6814e5d9bfa61f29