[INFO] crate fie 0.9.6 is already in cache [INFO] extracting crate fie 0.9.6 into work/ex/clippy-test-run/sources/stable/reg/fie/0.9.6 [INFO] extracting crate fie 0.9.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fie/0.9.6 [INFO] validating manifest of fie-0.9.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fie-0.9.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fie-0.9.6 [INFO] finished frobbing fie-0.9.6 [INFO] frobbed toml for fie-0.9.6 written to work/ex/clippy-test-run/sources/stable/reg/fie/0.9.6/Cargo.toml [INFO] started frobbing fie-0.9.6 [INFO] finished frobbing fie-0.9.6 [INFO] frobbed toml for fie-0.9.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fie/0.9.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fie-0.9.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fie/0.9.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 073d69ec4df9b618d710d54efd85bfd1991ea500afcfe33c40cd6c5118288d89 [INFO] running `"docker" "start" "-a" "073d69ec4df9b618d710d54efd85bfd1991ea500afcfe33c40cd6c5118288d89"` [INFO] [stderr] Checking etag v1.0.2 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking rustls v0.14.0 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking tokio-rustls v0.8.1 [INFO] [stderr] Checking hyper-rustls v0.15.1 [INFO] [stderr] Checking yukikaze v0.3.1 [INFO] [stderr] Checking fie v0.9.6 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/gab.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | const LOGIN_URL: &'static str = "https://gab.com/auth/login"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/gab.rs:7:20 [INFO] [stderr] | [INFO] [stderr] 7 | const IMAGES_URL: &'static str = "https://gab.com/api/media-attachments/images"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/gab.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | const POST_URL: &'static str = "https://gab.com/posts"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/minds.rs:6:20 [INFO] [stderr] | [INFO] [stderr] 6 | const OAUTH2_URL: &'static str = "https://www.minds.com/oauth2/token"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/minds.rs:7:20 [INFO] [stderr] | [INFO] [stderr] 7 | const IMAGES_URL: &'static str = "https://www.minds.com/api/v1/media"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/minds.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | const POST_URL: &'static str = "https://www.minds.com/api/v1/newsfeed"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/twitter/mod.rs:11:20 [INFO] [stderr] | [INFO] [stderr] 11 | const IMAGES_URL: &'static str = "https://upload.twitter.com/1.1/media/upload.json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/twitter/mod.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | const POST_URL: &'static str = "https://api.twitter.com/1.1/statuses/update.json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli/clap.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | const NAME: &'static str = env!("CARGO_PKG_NAME"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli/clap.rs:18:16 [INFO] [stderr] | [INFO] [stderr] 18 | const AUTHOR: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli/clap.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli/clap.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | const ABOUT: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | pub const NAME: &'static str = "fie.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/gab.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | const LOGIN_URL: &'static str = "https://gab.com/auth/login"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/gab.rs:7:20 [INFO] [stderr] | [INFO] [stderr] 7 | const IMAGES_URL: &'static str = "https://gab.com/api/media-attachments/images"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/gab.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | const POST_URL: &'static str = "https://gab.com/posts"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/minds.rs:6:20 [INFO] [stderr] | [INFO] [stderr] 6 | const OAUTH2_URL: &'static str = "https://www.minds.com/oauth2/token"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/minds.rs:7:20 [INFO] [stderr] | [INFO] [stderr] 7 | const IMAGES_URL: &'static str = "https://www.minds.com/api/v1/media"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/minds.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | const POST_URL: &'static str = "https://www.minds.com/api/v1/newsfeed"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/twitter/mod.rs:11:20 [INFO] [stderr] | [INFO] [stderr] 11 | const IMAGES_URL: &'static str = "https://upload.twitter.com/1.1/media/upload.json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/twitter/mod.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | const POST_URL: &'static str = "https://api.twitter.com/1.1/statuses/update.json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli/clap.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | const NAME: &'static str = env!("CARGO_PKG_NAME"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli/clap.rs:18:16 [INFO] [stderr] | [INFO] [stderr] 18 | const AUTHOR: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli/clap.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli/clap.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | const ABOUT: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | pub const NAME: &'static str = "fie.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/gab.rs:90:36 [INFO] [stderr] | [INFO] [stderr] 90 | Some(jwt_token) => match jwt_token == token { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 91 | | false => jwt_token, [INFO] [stderr] 92 | | true => { [INFO] [stderr] 93 | | eprintln!("Gab: Failed to authorize"); [INFO] [stderr] 94 | | return None; [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 90 | Some(jwt_token) => if jwt_token == token { [INFO] [stderr] 91 | eprintln!("Gab: Failed to authorize"); [INFO] [stderr] 92 | return None; [INFO] [stderr] 93 | } else { jwt_token }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/gab.rs:119:30 [INFO] [stderr] | [INFO] [stderr] 119 | .and_then(|resp| match resp.is_success() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 120 | | true => Ok(resp), [INFO] [stderr] 121 | | false => { [INFO] [stderr] 122 | | eprintln!("Gab: failed to upload image. Status code={}", resp.status()); [INFO] [stderr] 123 | | Err(()) [INFO] [stderr] 124 | | }, [INFO] [stderr] 125 | | }).and_then(|response| response.json::().map_err(|error| eprintln!("Gab upload reading error: {}", error))) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 119 | .and_then(|resp| if resp.is_success() { Ok(resp) } else { [INFO] [stderr] 120 | eprintln!("Gab: failed to upload image. Status code={}", resp.status()); [INFO] [stderr] 121 | Err(()) [INFO] [stderr] 122 | }).and_then(|response| response.json::().map_err(|error| eprintln!("Gab upload reading error: {}", error))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/gab.rs:138:30 [INFO] [stderr] | [INFO] [stderr] 138 | .and_then(|resp| match resp.is_success() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 139 | | true => Ok(resp), [INFO] [stderr] 140 | | false => { [INFO] [stderr] 141 | | eprintln!("Gab: failed to post. Status code={}", resp.status()); [INFO] [stderr] 142 | | Err(()) [INFO] [stderr] 143 | | }, [INFO] [stderr] 144 | | }).and_then(|resp| resp.json::().map_err(|error| eprintln!("Gab: Invalid response. Error={}", error))) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 138 | .and_then(|resp| if resp.is_success() { Ok(resp) } else { [INFO] [stderr] 139 | eprintln!("Gab: failed to post. Status code={}", resp.status()); [INFO] [stderr] 140 | Err(()) [INFO] [stderr] 141 | }).and_then(|resp| resp.json::().map_err(|error| eprintln!("Gab: Invalid response. Error={}", error))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/minds.rs:57:29 [INFO] [stderr] | [INFO] [stderr] 57 | .and_then(|resp| match resp.is_success() { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 58 | | true => Ok(resp), [INFO] [stderr] 59 | | false => { [INFO] [stderr] 60 | | eprintln!("Minds: failed to upload image. Status code={}", resp.status()); [INFO] [stderr] 61 | | Err(()) [INFO] [stderr] 62 | | }, [INFO] [stderr] 63 | | }).and_then(|response| response.json::().map_err(|error| eprintln!("Minds upload reading error: {}", error))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 57 | .and_then(|resp| if resp.is_success() { Ok(resp) } else { [INFO] [stderr] 58 | eprintln!("Minds: failed to upload image. Status code={}", resp.status()); [INFO] [stderr] 59 | Err(()) [INFO] [stderr] 60 | }).and_then(|response| response.json::().map_err(|error| eprintln!("Minds upload reading error: {}", error))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/minds.rs:76:29 [INFO] [stderr] | [INFO] [stderr] 76 | .and_then(|resp| match resp.is_success() { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 77 | | true => Ok(resp), [INFO] [stderr] 78 | | false => { [INFO] [stderr] 79 | | eprintln!("Minds: failed to post. Status code={}", resp.status()); [INFO] [stderr] 80 | | Err(()) [INFO] [stderr] 81 | | }, [INFO] [stderr] 82 | | }).and_then(|resp| resp.json::().map_err(|error| eprintln!("Minds: Invalid response. Error={}", error))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 76 | .and_then(|resp| if resp.is_success() { Ok(resp) } else { [INFO] [stderr] 77 | eprintln!("Minds: failed to post. Status code={}", resp.status()); [INFO] [stderr] 78 | Err(()) [INFO] [stderr] 79 | }).and_then(|resp| resp.json::().map_err(|error| eprintln!("Minds: Invalid response. Error={}", error))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/twitter/mod.rs:45:30 [INFO] [stderr] | [INFO] [stderr] 45 | .and_then(|resp| match resp.is_success() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 46 | | true => Ok(resp), [INFO] [stderr] 47 | | false => { [INFO] [stderr] 48 | | eprintln!("Twitter: failed to upload image. Status code={}", resp.status()); [INFO] [stderr] 49 | | Err(()) [INFO] [stderr] 50 | | }, [INFO] [stderr] 51 | | }).and_then(|rsp| rsp.json().map_err(|error| eprintln!("Twitter: invalid response to upload. Error: {}", error))) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 45 | .and_then(|resp| if resp.is_success() { Ok(resp) } else { [INFO] [stderr] 46 | eprintln!("Twitter: failed to upload image. Status code={}", resp.status()); [INFO] [stderr] 47 | Err(()) [INFO] [stderr] 48 | }).and_then(|rsp| rsp.json().map_err(|error| eprintln!("Twitter: invalid response to upload. Error: {}", error))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/twitter/mod.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | / match tweet.possibly_sensitive { [INFO] [stderr] 62 | | true => auth_params.insert("possibly_sensitive", "true"), [INFO] [stderr] 63 | | false => auth_params.insert("possibly_sensitive", "false"), [INFO] [stderr] 64 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if tweet.possibly_sensitive { auth_params.insert("possibly_sensitive", "true") } else { auth_params.insert("possibly_sensitive", "false") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/twitter/mod.rs:79:30 [INFO] [stderr] | [INFO] [stderr] 79 | .and_then(|resp| match resp.is_success() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 80 | | true => Ok(resp), [INFO] [stderr] 81 | | false => { [INFO] [stderr] 82 | | eprintln!("Twitter: failed to post tweet. Status code={}", resp.status()); [INFO] [stderr] 83 | | Err(()) [INFO] [stderr] 84 | | }, [INFO] [stderr] 85 | | }).and_then(|rsp| rsp.json().map_err(|error| eprintln!("Twitter: invalid response to post. Error: {}", error))) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 79 | .and_then(|resp| if resp.is_success() { Ok(resp) } else { [INFO] [stderr] 80 | eprintln!("Twitter: failed to post tweet. Status code={}", resp.status()); [INFO] [stderr] 81 | Err(()) [INFO] [stderr] 82 | }).and_then(|rsp| rsp.json().map_err(|error| eprintln!("Twitter: invalid response to post. Error: {}", error))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/api/mod.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | let message = if tags.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tags.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/api/mod.rs:100:33 [INFO] [stderr] | [INFO] [stderr] 100 | Some(ref images) if images.len() > 0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!images.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/api/mod.rs:148:42 [INFO] [stderr] | [INFO] [stderr] 148 | let image = unsafe { images.get_unchecked(0).clone() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 148 | let image = unsafe { &(*images.get_unchecked(0)).clone() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 148 | let image = unsafe { &io::Image::clone(images.get_unchecked(0)) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | cli::Commands::Batch(exec) => match exec.post { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 26 | | Some(posts) => { [INFO] [stderr] 27 | | let api = api::API::new(config.settings) [INFO] [stderr] 28 | | .start_gab_if(args.flags.gab, config.gab) [INFO] [stderr] ... | [INFO] [stderr] 37 | | None => (), [INFO] [stderr] 38 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | cli::Commands::Batch(exec) => if let Some(posts) = exec.post { [INFO] [stderr] 26 | let api = api::API::new(config.settings) [INFO] [stderr] 27 | .start_gab_if(args.flags.gab, config.gab) [INFO] [stderr] 28 | .start_minds_if(args.flags.minds, config.minds) [INFO] [stderr] 29 | .start_twitter_if(args.flags.twitter, config.twitter); [INFO] [stderr] 30 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `fie`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/gab.rs:90:36 [INFO] [stderr] | [INFO] [stderr] 90 | Some(jwt_token) => match jwt_token == token { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 91 | | false => jwt_token, [INFO] [stderr] 92 | | true => { [INFO] [stderr] 93 | | eprintln!("Gab: Failed to authorize"); [INFO] [stderr] 94 | | return None; [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 90 | Some(jwt_token) => if jwt_token == token { [INFO] [stderr] 91 | eprintln!("Gab: Failed to authorize"); [INFO] [stderr] 92 | return None; [INFO] [stderr] 93 | } else { jwt_token }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/gab.rs:119:30 [INFO] [stderr] | [INFO] [stderr] 119 | .and_then(|resp| match resp.is_success() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 120 | | true => Ok(resp), [INFO] [stderr] 121 | | false => { [INFO] [stderr] 122 | | eprintln!("Gab: failed to upload image. Status code={}", resp.status()); [INFO] [stderr] 123 | | Err(()) [INFO] [stderr] 124 | | }, [INFO] [stderr] 125 | | }).and_then(|response| response.json::().map_err(|error| eprintln!("Gab upload reading error: {}", error))) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 119 | .and_then(|resp| if resp.is_success() { Ok(resp) } else { [INFO] [stderr] 120 | eprintln!("Gab: failed to upload image. Status code={}", resp.status()); [INFO] [stderr] 121 | Err(()) [INFO] [stderr] 122 | }).and_then(|response| response.json::().map_err(|error| eprintln!("Gab upload reading error: {}", error))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/gab.rs:138:30 [INFO] [stderr] | [INFO] [stderr] 138 | .and_then(|resp| match resp.is_success() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 139 | | true => Ok(resp), [INFO] [stderr] 140 | | false => { [INFO] [stderr] 141 | | eprintln!("Gab: failed to post. Status code={}", resp.status()); [INFO] [stderr] 142 | | Err(()) [INFO] [stderr] 143 | | }, [INFO] [stderr] 144 | | }).and_then(|resp| resp.json::().map_err(|error| eprintln!("Gab: Invalid response. Error={}", error))) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 138 | .and_then(|resp| if resp.is_success() { Ok(resp) } else { [INFO] [stderr] 139 | eprintln!("Gab: failed to post. Status code={}", resp.status()); [INFO] [stderr] 140 | Err(()) [INFO] [stderr] 141 | }).and_then(|resp| resp.json::().map_err(|error| eprintln!("Gab: Invalid response. Error={}", error))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/minds.rs:57:29 [INFO] [stderr] | [INFO] [stderr] 57 | .and_then(|resp| match resp.is_success() { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 58 | | true => Ok(resp), [INFO] [stderr] 59 | | false => { [INFO] [stderr] 60 | | eprintln!("Minds: failed to upload image. Status code={}", resp.status()); [INFO] [stderr] 61 | | Err(()) [INFO] [stderr] 62 | | }, [INFO] [stderr] 63 | | }).and_then(|response| response.json::().map_err(|error| eprintln!("Minds upload reading error: {}", error))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 57 | .and_then(|resp| if resp.is_success() { Ok(resp) } else { [INFO] [stderr] 58 | eprintln!("Minds: failed to upload image. Status code={}", resp.status()); [INFO] [stderr] 59 | Err(()) [INFO] [stderr] 60 | }).and_then(|response| response.json::().map_err(|error| eprintln!("Minds upload reading error: {}", error))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/minds.rs:76:29 [INFO] [stderr] | [INFO] [stderr] 76 | .and_then(|resp| match resp.is_success() { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 77 | | true => Ok(resp), [INFO] [stderr] 78 | | false => { [INFO] [stderr] 79 | | eprintln!("Minds: failed to post. Status code={}", resp.status()); [INFO] [stderr] 80 | | Err(()) [INFO] [stderr] 81 | | }, [INFO] [stderr] 82 | | }).and_then(|resp| resp.json::().map_err(|error| eprintln!("Minds: Invalid response. Error={}", error))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 76 | .and_then(|resp| if resp.is_success() { Ok(resp) } else { [INFO] [stderr] 77 | eprintln!("Minds: failed to post. Status code={}", resp.status()); [INFO] [stderr] 78 | Err(()) [INFO] [stderr] 79 | }).and_then(|resp| resp.json::().map_err(|error| eprintln!("Minds: Invalid response. Error={}", error))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/twitter/mod.rs:45:30 [INFO] [stderr] | [INFO] [stderr] 45 | .and_then(|resp| match resp.is_success() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 46 | | true => Ok(resp), [INFO] [stderr] 47 | | false => { [INFO] [stderr] 48 | | eprintln!("Twitter: failed to upload image. Status code={}", resp.status()); [INFO] [stderr] 49 | | Err(()) [INFO] [stderr] 50 | | }, [INFO] [stderr] 51 | | }).and_then(|rsp| rsp.json().map_err(|error| eprintln!("Twitter: invalid response to upload. Error: {}", error))) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 45 | .and_then(|resp| if resp.is_success() { Ok(resp) } else { [INFO] [stderr] 46 | eprintln!("Twitter: failed to upload image. Status code={}", resp.status()); [INFO] [stderr] 47 | Err(()) [INFO] [stderr] 48 | }).and_then(|rsp| rsp.json().map_err(|error| eprintln!("Twitter: invalid response to upload. Error: {}", error))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/twitter/mod.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | / match tweet.possibly_sensitive { [INFO] [stderr] 62 | | true => auth_params.insert("possibly_sensitive", "true"), [INFO] [stderr] 63 | | false => auth_params.insert("possibly_sensitive", "false"), [INFO] [stderr] 64 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if tweet.possibly_sensitive { auth_params.insert("possibly_sensitive", "true") } else { auth_params.insert("possibly_sensitive", "false") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/api/twitter/mod.rs:79:30 [INFO] [stderr] | [INFO] [stderr] 79 | .and_then(|resp| match resp.is_success() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 80 | | true => Ok(resp), [INFO] [stderr] 81 | | false => { [INFO] [stderr] 82 | | eprintln!("Twitter: failed to post tweet. Status code={}", resp.status()); [INFO] [stderr] 83 | | Err(()) [INFO] [stderr] 84 | | }, [INFO] [stderr] 85 | | }).and_then(|rsp| rsp.json().map_err(|error| eprintln!("Twitter: invalid response to post. Error: {}", error))) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 79 | .and_then(|resp| if resp.is_success() { Ok(resp) } else { [INFO] [stderr] 80 | eprintln!("Twitter: failed to post tweet. Status code={}", resp.status()); [INFO] [stderr] 81 | Err(()) [INFO] [stderr] 82 | }).and_then(|rsp| rsp.json().map_err(|error| eprintln!("Twitter: invalid response to post. Error: {}", error))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/api/mod.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | let message = if tags.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tags.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/api/mod.rs:100:33 [INFO] [stderr] | [INFO] [stderr] 100 | Some(ref images) if images.len() > 0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!images.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/api/mod.rs:148:42 [INFO] [stderr] | [INFO] [stderr] 148 | let image = unsafe { images.get_unchecked(0).clone() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 148 | let image = unsafe { &(*images.get_unchecked(0)).clone() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 148 | let image = unsafe { &io::Image::clone(images.get_unchecked(0)) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | cli::Commands::Batch(exec) => match exec.post { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 26 | | Some(posts) => { [INFO] [stderr] 27 | | let api = api::API::new(config.settings) [INFO] [stderr] 28 | | .start_gab_if(args.flags.gab, config.gab) [INFO] [stderr] ... | [INFO] [stderr] 37 | | None => (), [INFO] [stderr] 38 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | cli::Commands::Batch(exec) => if let Some(posts) = exec.post { [INFO] [stderr] 26 | let api = api::API::new(config.settings) [INFO] [stderr] 27 | .start_gab_if(args.flags.gab, config.gab) [INFO] [stderr] 28 | .start_minds_if(args.flags.minds, config.minds) [INFO] [stderr] 29 | .start_twitter_if(args.flags.twitter, config.twitter); [INFO] [stderr] 30 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `fie`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "073d69ec4df9b618d710d54efd85bfd1991ea500afcfe33c40cd6c5118288d89"` [INFO] running `"docker" "rm" "-f" "073d69ec4df9b618d710d54efd85bfd1991ea500afcfe33c40cd6c5118288d89"` [INFO] [stdout] 073d69ec4df9b618d710d54efd85bfd1991ea500afcfe33c40cd6c5118288d89