[INFO] crate ffmpeg-screen-recorder 1.0.6 is already in cache [INFO] extracting crate ffmpeg-screen-recorder 1.0.6 into work/ex/clippy-test-run/sources/stable/reg/ffmpeg-screen-recorder/1.0.6 [INFO] extracting crate ffmpeg-screen-recorder 1.0.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ffmpeg-screen-recorder/1.0.6 [INFO] validating manifest of ffmpeg-screen-recorder-1.0.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ffmpeg-screen-recorder-1.0.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ffmpeg-screen-recorder-1.0.6 [INFO] finished frobbing ffmpeg-screen-recorder-1.0.6 [INFO] frobbed toml for ffmpeg-screen-recorder-1.0.6 written to work/ex/clippy-test-run/sources/stable/reg/ffmpeg-screen-recorder/1.0.6/Cargo.toml [INFO] started frobbing ffmpeg-screen-recorder-1.0.6 [INFO] finished frobbing ffmpeg-screen-recorder-1.0.6 [INFO] frobbed toml for ffmpeg-screen-recorder-1.0.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ffmpeg-screen-recorder/1.0.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ffmpeg-screen-recorder-1.0.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ffmpeg-screen-recorder/1.0.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b1bc2de0d737829003b499a549e41d9cef273679704762186447d5a410112b0c [INFO] running `"docker" "start" "-a" "b1bc2de0d737829003b499a549e41d9cef273679704762186447d5a410112b0c"` [INFO] [stderr] Checking subprocess v0.1.18 [INFO] [stderr] Checking ffmpeg-screen-recorder v1.0.6 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:175:47 [INFO] [stderr] | [INFO] [stderr] 175 | let res: Vec<&str> = res.trim().split("x").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `WindowInfo` [INFO] [stderr] --> src/lib.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | / pub fn new() -> WindowInfo { [INFO] [stderr] 208 | | let screen_resolution = Resolution::get_screen_resolution(); [INFO] [stderr] 209 | | [INFO] [stderr] 210 | | let win_info = Exec::shell("xwininfo").capture().unwrap().stdout_str(); [INFO] [stderr] ... | [INFO] [stderr] 274 | | } [INFO] [stderr] 275 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 206 | impl Default for WindowInfo { [INFO] [stderr] 207 | fn default() -> Self { [INFO] [stderr] 208 | Self::new() [INFO] [stderr] 209 | } [INFO] [stderr] 210 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:175:47 [INFO] [stderr] | [INFO] [stderr] 175 | let res: Vec<&str> = res.trim().split("x").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `WindowInfo` [INFO] [stderr] --> src/lib.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | / pub fn new() -> WindowInfo { [INFO] [stderr] 208 | | let screen_resolution = Resolution::get_screen_resolution(); [INFO] [stderr] 209 | | [INFO] [stderr] 210 | | let win_info = Exec::shell("xwininfo").capture().unwrap().stdout_str(); [INFO] [stderr] ... | [INFO] [stderr] 274 | | } [INFO] [stderr] 275 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 206 | impl Default for WindowInfo { [INFO] [stderr] 207 | fn default() -> Self { [INFO] [stderr] 208 | Self::new() [INFO] [stderr] 209 | } [INFO] [stderr] 210 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 55 | | if config.opt_no_sound { [INFO] [stderr] 56 | | audio = vec!["-an"]; [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | } else if config.opt_no_sound { [INFO] [stderr] 55 | audio = vec!["-an"]; [INFO] [stderr] 56 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | if let Err(_) = Exec::cmd(&config.ffmpeg_path).capture() { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 32 | | eprintln!("FFMPEG_PATH is incorrect or the file cannot be executed."); [INFO] [stderr] 33 | | process::exit(1); [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____________- help: try this: `if Exec::cmd(&config.ffmpeg_path).capture().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 55 | | if config.opt_no_sound { [INFO] [stderr] 56 | | audio = vec!["-an"]; [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | } else if config.opt_no_sound { [INFO] [stderr] 55 | audio = vec!["-an"]; [INFO] [stderr] 56 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | if let Err(_) = Exec::cmd(&config.ffmpeg_path).capture() { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 32 | | eprintln!("FFMPEG_PATH is incorrect or the file cannot be executed."); [INFO] [stderr] 33 | | process::exit(1); [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____________- help: try this: `if Exec::cmd(&config.ffmpeg_path).capture().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.91s [INFO] running `"docker" "inspect" "b1bc2de0d737829003b499a549e41d9cef273679704762186447d5a410112b0c"` [INFO] running `"docker" "rm" "-f" "b1bc2de0d737829003b499a549e41d9cef273679704762186447d5a410112b0c"` [INFO] [stdout] b1bc2de0d737829003b499a549e41d9cef273679704762186447d5a410112b0c