[INFO] crate ff_derive 0.3.0 is already in cache [INFO] extracting crate ff_derive 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/ff_derive/0.3.0 [INFO] extracting crate ff_derive 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ff_derive/0.3.0 [INFO] validating manifest of ff_derive-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ff_derive-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ff_derive-0.3.0 [INFO] finished frobbing ff_derive-0.3.0 [INFO] frobbed toml for ff_derive-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/ff_derive/0.3.0/Cargo.toml [INFO] started frobbing ff_derive-0.3.0 [INFO] finished frobbing ff_derive-0.3.0 [INFO] frobbed toml for ff_derive-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ff_derive/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ff_derive-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ff_derive/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 76d2d9805250aa339c4d91296850d188f5a6b4e75a3b282d7f698f844f8ab2b6 [INFO] running `"docker" "start" "-a" "76d2d9805250aa339c4d91296850d188f5a6b4e75a3b282d7f698f844f8ab2b6"` [INFO] [stderr] Checking ff_derive v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | cur = cur << 64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `cur <<= 64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / match body { [INFO] [stderr] 75 | | &syn::Data::Struct(ref variant_data) => match variant_data.fields { [INFO] [stderr] 76 | | syn::Fields::Unnamed(ref fields) => { [INFO] [stderr] 77 | | if fields.unnamed.len() == 1 { [INFO] [stderr] ... | [INFO] [stderr] 90 | | _ => {} [INFO] [stderr] 91 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 74 | if let &syn::Data::Struct(ref variant_data) = body { match variant_data.fields { [INFO] [stderr] 75 | syn::Fields::Unnamed(ref fields) => { [INFO] [stderr] 76 | if fields.unnamed.len() == 1 { [INFO] [stderr] 77 | match fields.unnamed[0].ty { [INFO] [stderr] 78 | syn::Type::Path(ref path) => { [INFO] [stderr] 79 | if path.path.segments.len() == 1 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / match body { [INFO] [stderr] 75 | | &syn::Data::Struct(ref variant_data) => match variant_data.fields { [INFO] [stderr] 76 | | syn::Fields::Unnamed(ref fields) => { [INFO] [stderr] 77 | | if fields.unnamed.len() == 1 { [INFO] [stderr] ... | [INFO] [stderr] 90 | | _ => {} [INFO] [stderr] 91 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 74 | match *body { [INFO] [stderr] 75 | syn::Data::Struct(ref variant_data) => match variant_data.fields { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:75:49 [INFO] [stderr] | [INFO] [stderr] 75 | &syn::Data::Struct(ref variant_data) => match variant_data.fields { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 76 | | syn::Fields::Unnamed(ref fields) => { [INFO] [stderr] 77 | | if fields.unnamed.len() == 1 { [INFO] [stderr] 78 | | match fields.unnamed[0].ty { [INFO] [stderr] ... | [INFO] [stderr] 88 | | _ => {} [INFO] [stderr] 89 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | &syn::Data::Struct(ref variant_data) => if let syn::Fields::Unnamed(ref fields) = variant_data.fields { [INFO] [stderr] 76 | if fields.unnamed.len() == 1 { [INFO] [stderr] 77 | match fields.unnamed[0].ty { [INFO] [stderr] 78 | syn::Type::Path(ref path) => { [INFO] [stderr] 79 | if path.path.segments.len() == 1 { [INFO] [stderr] 80 | return Some(path.path.segments[0].ident.clone()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | / match fields.unnamed[0].ty { [INFO] [stderr] 79 | | syn::Type::Path(ref path) => { [INFO] [stderr] 80 | | if path.path.segments.len() == 1 { [INFO] [stderr] 81 | | return Some(path.path.segments[0].ident.clone()); [INFO] [stderr] ... | [INFO] [stderr] 84 | | _ => {} [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | if let syn::Type::Path(ref path) = fields.unnamed[0].ty { [INFO] [stderr] 79 | if path.path.segments.len() == 1 { [INFO] [stderr] 80 | return Some(path.path.segments[0].ident.clone()); [INFO] [stderr] 81 | } [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:102:24 [INFO] [stderr] | [INFO] [stderr] 102 | if nv.ident.to_string() == name { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `*nv.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:336:9 [INFO] [stderr] | [INFO] [stderr] 336 | v = v >> 64; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `v >>= 64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:358:9 [INFO] [stderr] | [INFO] [stderr] 358 | v = v >> 1; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `v >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:420:9 [INFO] [stderr] | [INFO] [stderr] 420 | t = t >> 1; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `t >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | cur = cur << 64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `cur <<= 64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / match body { [INFO] [stderr] 75 | | &syn::Data::Struct(ref variant_data) => match variant_data.fields { [INFO] [stderr] 76 | | syn::Fields::Unnamed(ref fields) => { [INFO] [stderr] 77 | | if fields.unnamed.len() == 1 { [INFO] [stderr] ... | [INFO] [stderr] 90 | | _ => {} [INFO] [stderr] 91 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 74 | if let &syn::Data::Struct(ref variant_data) = body { match variant_data.fields { [INFO] [stderr] 75 | syn::Fields::Unnamed(ref fields) => { [INFO] [stderr] 76 | if fields.unnamed.len() == 1 { [INFO] [stderr] 77 | match fields.unnamed[0].ty { [INFO] [stderr] 78 | syn::Type::Path(ref path) => { [INFO] [stderr] 79 | if path.path.segments.len() == 1 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / match body { [INFO] [stderr] 75 | | &syn::Data::Struct(ref variant_data) => match variant_data.fields { [INFO] [stderr] 76 | | syn::Fields::Unnamed(ref fields) => { [INFO] [stderr] 77 | | if fields.unnamed.len() == 1 { [INFO] [stderr] ... | [INFO] [stderr] 90 | | _ => {} [INFO] [stderr] 91 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 74 | match *body { [INFO] [stderr] 75 | syn::Data::Struct(ref variant_data) => match variant_data.fields { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:75:49 [INFO] [stderr] | [INFO] [stderr] 75 | &syn::Data::Struct(ref variant_data) => match variant_data.fields { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 76 | | syn::Fields::Unnamed(ref fields) => { [INFO] [stderr] 77 | | if fields.unnamed.len() == 1 { [INFO] [stderr] 78 | | match fields.unnamed[0].ty { [INFO] [stderr] ... | [INFO] [stderr] 88 | | _ => {} [INFO] [stderr] 89 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | &syn::Data::Struct(ref variant_data) => if let syn::Fields::Unnamed(ref fields) = variant_data.fields { [INFO] [stderr] 76 | if fields.unnamed.len() == 1 { [INFO] [stderr] 77 | match fields.unnamed[0].ty { [INFO] [stderr] 78 | syn::Type::Path(ref path) => { [INFO] [stderr] 79 | if path.path.segments.len() == 1 { [INFO] [stderr] 80 | return Some(path.path.segments[0].ident.clone()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | / match fields.unnamed[0].ty { [INFO] [stderr] 79 | | syn::Type::Path(ref path) => { [INFO] [stderr] 80 | | if path.path.segments.len() == 1 { [INFO] [stderr] 81 | | return Some(path.path.segments[0].ident.clone()); [INFO] [stderr] ... | [INFO] [stderr] 84 | | _ => {} [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | if let syn::Type::Path(ref path) = fields.unnamed[0].ty { [INFO] [stderr] 79 | if path.path.segments.len() == 1 { [INFO] [stderr] 80 | return Some(path.path.segments[0].ident.clone()); [INFO] [stderr] 81 | } [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:102:24 [INFO] [stderr] | [INFO] [stderr] 102 | if nv.ident.to_string() == name { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `*nv.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:725:34 [INFO] [stderr] | [INFO] [stderr] 725 | (0..(limbs * 2)).map(|i| get_temp(i)), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `get_temp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:336:9 [INFO] [stderr] | [INFO] [stderr] 336 | v = v >> 64; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `v >>= 64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:358:9 [INFO] [stderr] | [INFO] [stderr] 358 | v = v >> 1; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `v >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:771:34 [INFO] [stderr] | [INFO] [stderr] 771 | (0..(limbs * 2)).map(|i| get_temp(i)), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `get_temp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:420:9 [INFO] [stderr] | [INFO] [stderr] 420 | t = t >> 1; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `t >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:725:34 [INFO] [stderr] | [INFO] [stderr] 725 | (0..(limbs * 2)).map(|i| get_temp(i)), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `get_temp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:771:34 [INFO] [stderr] | [INFO] [stderr] 771 | (0..(limbs * 2)).map(|i| get_temp(i)), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove closure as shown: `get_temp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.83s [INFO] running `"docker" "inspect" "76d2d9805250aa339c4d91296850d188f5a6b4e75a3b282d7f698f844f8ab2b6"` [INFO] running `"docker" "rm" "-f" "76d2d9805250aa339c4d91296850d188f5a6b4e75a3b282d7f698f844f8ab2b6"` [INFO] [stdout] 76d2d9805250aa339c4d91296850d188f5a6b4e75a3b282d7f698f844f8ab2b6