[INFO] crate ferrum 0.2.1 is already in cache [INFO] extracting crate ferrum 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/ferrum/0.2.1 [INFO] extracting crate ferrum 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ferrum/0.2.1 [INFO] validating manifest of ferrum-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ferrum-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ferrum-0.2.1 [INFO] finished frobbing ferrum-0.2.1 [INFO] frobbed toml for ferrum-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/ferrum/0.2.1/Cargo.toml [INFO] started frobbing ferrum-0.2.1 [INFO] finished frobbing ferrum-0.2.1 [INFO] frobbed toml for ferrum-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ferrum/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ferrum-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ferrum/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 33143f9f7cc36272bb6f1ca3918a80d8c4fc57ede9bf587d88525739b2ac8e52 [INFO] running `"docker" "start" "-a" "33143f9f7cc36272bb6f1ca3918a80d8c4fc57ede9bf587d88525739b2ac8e52"` [INFO] [stderr] Checking ferrum-plugin v0.3.0 [INFO] [stderr] Checking ferrum v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/middleware/test.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | befores: befores, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `befores` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/middleware/test.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | afters: afters [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `afters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/middleware/test.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | mode: mode [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `response::Response` [INFO] [stderr] --> src/response/mod.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> Response { [INFO] [stderr] 39 | | Response { [INFO] [stderr] 40 | | status: Default::default(), [INFO] [stderr] 41 | | headers: Headers::new(), [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | impl Default for response::Response { [INFO] [stderr] 36 | fn default() -> Self { [INFO] [stderr] 37 | Self::new() [INFO] [stderr] 38 | } [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ferrum.rs:74:14 [INFO] [stderr] | [INFO] [stderr] 74 | .ok_or(Error::new(ErrorKind::Other, "Empty addrs"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new(ErrorKind::Other, "Empty addrs"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `response::Response` [INFO] [stderr] --> src/response/mod.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> Response { [INFO] [stderr] 39 | | Response { [INFO] [stderr] 40 | | status: Default::default(), [INFO] [stderr] 41 | | headers: Headers::new(), [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | impl Default for response::Response { [INFO] [stderr] 36 | fn default() -> Self { [INFO] [stderr] 37 | Self::new() [INFO] [stderr] 38 | } [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ferrum.rs:74:14 [INFO] [stderr] | [INFO] [stderr] 74 | .ok_or(Error::new(ErrorKind::Other, "Empty addrs"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new(ErrorKind::Other, "Empty addrs"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/time.rs:23:58 [INFO] [stderr] | [INFO] [stderr] 23 | println!("Request took: {} ms", (delta as f64) / 1000000.0); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 42.34s [INFO] running `"docker" "inspect" "33143f9f7cc36272bb6f1ca3918a80d8c4fc57ede9bf587d88525739b2ac8e52"` [INFO] running `"docker" "rm" "-f" "33143f9f7cc36272bb6f1ca3918a80d8c4fc57ede9bf587d88525739b2ac8e52"` [INFO] [stdout] 33143f9f7cc36272bb6f1ca3918a80d8c4fc57ede9bf587d88525739b2ac8e52