[INFO] crate ferrous 0.1.0 is already in cache [INFO] extracting crate ferrous 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/ferrous/0.1.0 [INFO] extracting crate ferrous 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ferrous/0.1.0 [INFO] validating manifest of ferrous-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ferrous-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ferrous-0.1.0 [INFO] finished frobbing ferrous-0.1.0 [INFO] frobbed toml for ferrous-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/ferrous/0.1.0/Cargo.toml [INFO] started frobbing ferrous-0.1.0 [INFO] finished frobbing ferrous-0.1.0 [INFO] frobbed toml for ferrous-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ferrous/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ferrous-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ferrous/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6935b8cba8ce7731bb02397ab5ce12a2d5b8aa43e16813f8d186c404d48970c7 [INFO] running `"docker" "start" "-a" "6935b8cba8ce7731bb02397ab5ce12a2d5b8aa43e16813f8d186c404d48970c7"` [INFO] [stderr] Checking ferrous v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dsl/matchers/equals.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dsl/matchers/contain.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dsl/assertions.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | actual: actual, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `actual` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dsl/assertions.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | timeout: timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dsl/assertions.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | async_type: async_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `async_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dsl/matchers/equals.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dsl/matchers/contain.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | expected: expected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dsl/assertions.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | actual: actual, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `actual` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dsl/assertions.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | timeout: timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dsl/assertions.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | async_type: async_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `async_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/dsl/assertions.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | thread::sleep_ms(self.polling_interval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/dsl/assertions.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | thread::sleep_ms(self.polling_interval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/dsl/assertions.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | / if matcher.matches(&actual) { [INFO] [stderr] 60 | | true [INFO] [stderr] 61 | | } else { [INFO] [stderr] 62 | | false [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `matcher.matches(&actual)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/dsl/assertions.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | / if !matcher.matches(&actual) { [INFO] [stderr] 80 | | true [INFO] [stderr] 81 | | } else { [INFO] [stderr] 82 | | false [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `!matcher.matches(&actual)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dsl/assertions.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | let ref f = self.func; [INFO] [stderr] | ----^^^^^------------- help: try: `let f = &self.func;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dsl/assertions.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | let ref f = self.func; [INFO] [stderr] | ----^^^^^------------- help: try: `let f = &self.func;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/dsl/mod.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn expect<'a, A>(actual: &'a A) -> Expect<'a, A> { [INFO] [stderr] 59 | | Expect::new(actual) [INFO] [stderr] 60 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/dsl/mod.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | / pub fn equal<'a, E>(expected: &'a E) -> Equals<'a, E> { [INFO] [stderr] 92 | | Equals::new(expected) [INFO] [stderr] 93 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/dsl/mod.rs:98:1 [INFO] [stderr] | [INFO] [stderr] 98 | / pub fn contain<'a, E>(expected: &'a E) -> Contain<'a, E> { [INFO] [stderr] 99 | | Contain::new(expected) [INFO] [stderr] 100 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/dsl/assertions.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | thread::sleep_ms(500); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/dsl/assertions.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | thread::sleep_ms(500); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/dsl/assertions.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | thread::sleep_ms(500); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/dsl/assertions.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | thread::sleep_ms(500); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/dsl/assertions.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | thread::sleep_ms(self.polling_interval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> src/dsl/assertions.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | thread::sleep_ms(self.polling_interval); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/dsl/assertions.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | / if matcher.matches(&actual) { [INFO] [stderr] 60 | | true [INFO] [stderr] 61 | | } else { [INFO] [stderr] 62 | | false [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `matcher.matches(&actual)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/dsl/assertions.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | / if !matcher.matches(&actual) { [INFO] [stderr] 80 | | true [INFO] [stderr] 81 | | } else { [INFO] [stderr] 82 | | false [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `!matcher.matches(&actual)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dsl/assertions.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | let ref f = self.func; [INFO] [stderr] | ----^^^^^------------- help: try: `let f = &self.func;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dsl/assertions.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | let ref f = self.func; [INFO] [stderr] | ----^^^^^------------- help: try: `let f = &self.func;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/dsl/mod.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn expect<'a, A>(actual: &'a A) -> Expect<'a, A> { [INFO] [stderr] 59 | | Expect::new(actual) [INFO] [stderr] 60 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/dsl/mod.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | / pub fn equal<'a, E>(expected: &'a E) -> Equals<'a, E> { [INFO] [stderr] 92 | | Equals::new(expected) [INFO] [stderr] 93 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/dsl/mod.rs:98:1 [INFO] [stderr] | [INFO] [stderr] 98 | / pub fn contain<'a, E>(expected: &'a E) -> Contain<'a, E> { [INFO] [stderr] 99 | | Contain::new(expected) [INFO] [stderr] 100 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.15s [INFO] running `"docker" "inspect" "6935b8cba8ce7731bb02397ab5ce12a2d5b8aa43e16813f8d186c404d48970c7"` [INFO] running `"docker" "rm" "-f" "6935b8cba8ce7731bb02397ab5ce12a2d5b8aa43e16813f8d186c404d48970c7"` [INFO] [stdout] 6935b8cba8ce7731bb02397ab5ce12a2d5b8aa43e16813f8d186c404d48970c7