[INFO] crate femto-feed 0.2.0 is already in cache [INFO] extracting crate femto-feed 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/femto-feed/0.2.0 [INFO] extracting crate femto-feed 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/femto-feed/0.2.0 [INFO] validating manifest of femto-feed-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of femto-feed-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing femto-feed-0.2.0 [INFO] finished frobbing femto-feed-0.2.0 [INFO] frobbed toml for femto-feed-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/femto-feed/0.2.0/Cargo.toml [INFO] started frobbing femto-feed-0.2.0 [INFO] finished frobbing femto-feed-0.2.0 [INFO] frobbed toml for femto-feed-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/femto-feed/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting femto-feed-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/femto-feed/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 39cf1879e1d455bf7f64d1c64a9dfc367639c4628b3437e9256ce1492dc08e3a [INFO] running `"docker" "start" "-a" "39cf1879e1d455bf7f64d1c64a9dfc367639c4628b3437e9256ce1492dc08e3a"` [INFO] [stderr] Compiling string_cache v0.5.2 [INFO] [stderr] Compiling markup5ever v0.2.1 [INFO] [stderr] Checking xml5ever v0.7.0 [INFO] [stderr] Checking feed-rs v0.1.3 [INFO] [stderr] Checking femto-feed v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/entry/mod.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / write!( [INFO] [stderr] 15 | | f, [INFO] [stderr] 16 | | "{}{}{}\n", [INFO] [stderr] 17 | | self.created, self.from, self.link, self.title [INFO] [stderr] 18 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/femtofeed/outputs.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | HTML { buf: buf } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/femtofeed/worker.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | jobs: jobs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `jobs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/femtofeed/worker.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | results: results, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/femtofeed/mod.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | threads: threads, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `threads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/entry/mod.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / write!( [INFO] [stderr] 15 | | f, [INFO] [stderr] 16 | | "{}{}{}\n", [INFO] [stderr] 17 | | self.created, self.from, self.link, self.title [INFO] [stderr] 18 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/femtofeed/outputs.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | HTML { buf: buf } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/femtofeed/worker.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | jobs: jobs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `jobs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/femtofeed/worker.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | results: results, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/femtofeed/mod.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | threads: threads, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `threads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/entry/mod.rs:25:32 [INFO] [stderr] | [INFO] [stderr] 25 | title: entry.title.unwrap_or(String::from("no title")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("no title"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/femtofeed/outputs.rs:6:36 [INFO] [stderr] | [INFO] [stderr] 6 | fn entries(&mut self, entries: &Vec) -> Result<(), Error>; [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/femtofeed/outputs.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / self.buf.write( [INFO] [stderr] 23 | | "\ [INFO] [stderr] 24 | | \ [INFO] [stderr] 25 | | \ [INFO] [stderr] ... | [INFO] [stderr] 30 | | .as_bytes(), [INFO] [stderr] 31 | | )?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/femtofeed/outputs.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | self.buf.write(format!("{}", entry).as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/femtofeed/outputs.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | Ok(self.buf.flush()?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 39 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/femtofeed/outputs.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | self.buf.write("".as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/femtofeed/outputs.rs:42:24 [INFO] [stderr] | [INFO] [stderr] 42 | self.buf.write("".as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/femtofeed/worker.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | parser::parse(&mut buf).ok_or(Error::Parse(String::from("nothing parsed"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Parse(String::from("nothing parsed")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/femtofeed/worker.rs:43:37 [INFO] [stderr] | [INFO] [stderr] 43 | let feed_title = feed.title.unwrap_or(String::from("unknown")).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("unknown"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/femtofeed/mod.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | / match worker.run() { [INFO] [stderr] 34 | | Err(err) => println!("worker error: {:?}", err), [INFO] [stderr] 35 | | _ => {} [INFO] [stderr] 36 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let Err(err) = worker.run() { println!("worker error: {:?}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `femto-feed`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/entry/mod.rs:25:32 [INFO] [stderr] | [INFO] [stderr] 25 | title: entry.title.unwrap_or(String::from("no title")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("no title"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/femtofeed/outputs.rs:6:36 [INFO] [stderr] | [INFO] [stderr] 6 | fn entries(&mut self, entries: &Vec) -> Result<(), Error>; [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Entry]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/femtofeed/outputs.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / self.buf.write( [INFO] [stderr] 23 | | "\ [INFO] [stderr] 24 | | \ [INFO] [stderr] 25 | | \ [INFO] [stderr] ... | [INFO] [stderr] 30 | | .as_bytes(), [INFO] [stderr] 31 | | )?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/femtofeed/outputs.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | self.buf.write(format!("{}", entry).as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/femtofeed/outputs.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | Ok(self.buf.flush()?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 39 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/femtofeed/outputs.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | self.buf.write("".as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/femtofeed/outputs.rs:42:24 [INFO] [stderr] | [INFO] [stderr] 42 | self.buf.write("".as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/femtofeed/worker.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | parser::parse(&mut buf).ok_or(Error::Parse(String::from("nothing parsed"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::Parse(String::from("nothing parsed")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/femtofeed/worker.rs:43:37 [INFO] [stderr] | [INFO] [stderr] 43 | let feed_title = feed.title.unwrap_or(String::from("unknown")).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("unknown"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/femtofeed/mod.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | / match worker.run() { [INFO] [stderr] 34 | | Err(err) => println!("worker error: {:?}", err), [INFO] [stderr] 35 | | _ => {} [INFO] [stderr] 36 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let Err(err) = worker.run() { println!("worker error: {:?}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `femto-feed`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "39cf1879e1d455bf7f64d1c64a9dfc367639c4628b3437e9256ce1492dc08e3a"` [INFO] running `"docker" "rm" "-f" "39cf1879e1d455bf7f64d1c64a9dfc367639c4628b3437e9256ce1492dc08e3a"` [INFO] [stdout] 39cf1879e1d455bf7f64d1c64a9dfc367639c4628b3437e9256ce1492dc08e3a