[INFO] crate fel4-config 0.3.2 is already in cache [INFO] extracting crate fel4-config 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/fel4-config/0.3.2 [INFO] extracting crate fel4-config 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fel4-config/0.3.2 [INFO] validating manifest of fel4-config-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fel4-config-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fel4-config-0.3.2 [INFO] finished frobbing fel4-config-0.3.2 [INFO] frobbed toml for fel4-config-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/fel4-config/0.3.2/Cargo.toml [INFO] started frobbing fel4-config-0.3.2 [INFO] finished frobbing fel4-config-0.3.2 [INFO] frobbed toml for fel4-config-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fel4-config/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fel4-config-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fel4-config/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32196600eeb4f05086dbda48c0a6ed25a5af5f5a6913f2632eae539a997fe30d [INFO] running `"docker" "start" "-a" "32196600eeb4f05086dbda48c0a6ed25a5af5f5a6913f2632eae539a997fe30d"` [INFO] [stderr] Checking cc v1.0.28 [INFO] [stderr] Checking multimap v0.4.0 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking proptest v0.8.7 [INFO] [stderr] Checking cmake v0.1.35 [INFO] [stderr] Checking fel4-config v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn full_name(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types.rs:114:22 [INFO] [stderr] | [INFO] [stderr] 114 | pub fn full_name(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types.rs:165:22 [INFO] [stderr] | [INFO] [stderr] 165 | pub fn full_name(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:71:20 [INFO] [stderr] | [INFO] [stderr] 71 | build_profile: &BuildProfile, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `BuildProfile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:260:20 [INFO] [stderr] | [INFO] [stderr] 260 | build_profile: &BuildProfile, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `BuildProfile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn full_name(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types.rs:114:22 [INFO] [stderr] | [INFO] [stderr] 114 | pub fn full_name(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/types.rs:165:22 [INFO] [stderr] | [INFO] [stderr] 165 | pub fn full_name(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:71:20 [INFO] [stderr] | [INFO] [stderr] 71 | build_profile: &BuildProfile, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `BuildProfile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:260:20 [INFO] [stderr] | [INFO] [stderr] 260 | build_profile: &BuildProfile, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `BuildProfile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/integration.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | let x86_target = manifest [INFO] [stderr] | ______________________^ [INFO] [stderr] 19 | | .targets [INFO] [stderr] 20 | | .get(&SupportedTarget::X8664Sel4Fel4) [INFO] [stderr] 21 | | .unwrap(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 18 | let x86_target = &manifest [INFO] [stderr] 19 | .targets[&SupportedTarget::X8664Sel4Fel4]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/integration.rs:70:24 [INFO] [stderr] | [INFO] [stderr] 70 | let armv7_target = manifest [INFO] [stderr] | ________________________^ [INFO] [stderr] 71 | | .targets [INFO] [stderr] 72 | | .get(&SupportedTarget::Armv7Sel4Fel4) [INFO] [stderr] 73 | | .unwrap(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | let armv7_target = &manifest [INFO] [stderr] 71 | .targets[&SupportedTarget::Armv7Sel4Fel4]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/integration.rs:83:26 [INFO] [stderr] | [INFO] [stderr] 83 | let aarch64_target = manifest [INFO] [stderr] | __________________________^ [INFO] [stderr] 84 | | .targets [INFO] [stderr] 85 | | .get(&SupportedTarget::Aarch64Sel4Fel4) [INFO] [stderr] 86 | | .unwrap(); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | let aarch64_target = &manifest [INFO] [stderr] 84 | .targets[&SupportedTarget::Aarch64Sel4Fel4]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/integration.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | config.properties.get("KernelArch").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.properties["KernelArch"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/integration.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | config.properties.get("KernelArch").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.properties["KernelArch"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/integration.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | config.properties.get("KernelArch").unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.properties["KernelArch"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.01s [INFO] running `"docker" "inspect" "32196600eeb4f05086dbda48c0a6ed25a5af5f5a6913f2632eae539a997fe30d"` [INFO] running `"docker" "rm" "-f" "32196600eeb4f05086dbda48c0a6ed25a5af5f5a6913f2632eae539a997fe30d"` [INFO] [stdout] 32196600eeb4f05086dbda48c0a6ed25a5af5f5a6913f2632eae539a997fe30d