[INFO] crate feeds-to-pocket 0.1.6 is already in cache [INFO] extracting crate feeds-to-pocket 0.1.6 into work/ex/clippy-test-run/sources/stable/reg/feeds-to-pocket/0.1.6 [INFO] extracting crate feeds-to-pocket 0.1.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/feeds-to-pocket/0.1.6 [INFO] validating manifest of feeds-to-pocket-0.1.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of feeds-to-pocket-0.1.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing feeds-to-pocket-0.1.6 [INFO] finished frobbing feeds-to-pocket-0.1.6 [INFO] frobbed toml for feeds-to-pocket-0.1.6 written to work/ex/clippy-test-run/sources/stable/reg/feeds-to-pocket/0.1.6/Cargo.toml [INFO] started frobbing feeds-to-pocket-0.1.6 [INFO] finished frobbing feeds-to-pocket-0.1.6 [INFO] frobbed toml for feeds-to-pocket-0.1.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/feeds-to-pocket/0.1.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting feeds-to-pocket-0.1.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/feeds-to-pocket/0.1.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0c6fffb09721989a5d8f38c4dc8a347622d2484bff1b6fdee4caa467d8d93f18 [INFO] running `"docker" "start" "-a" "0c6fffb09721989a5d8f38c4dc8a347622d2484bff1b6fdee4caa467d8d93f18"` [INFO] [stderr] Checking quick-xml v0.12.4 [INFO] [stderr] Checking quick-xml v0.13.2 [INFO] [stderr] Checking rss v1.6.1 [INFO] [stderr] Checking atom_syndication v0.6.0 [INFO] [stderr] Checking feeds-to-pocket v0.1.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pocket.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pocket.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pocket.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pocket.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pocket.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | tweet_id: tweet_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `tweet_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:493:13 [INFO] [stderr] | [INFO] [stderr] 493 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:494:13 [INFO] [stderr] | [INFO] [stderr] 494 | last_modified: last_modified, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_modified` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:495:13 [INFO] [stderr] | [INFO] [stderr] 495 | e_tag: e_tag, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `e_tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:582:13 [INFO] [stderr] | [INFO] [stderr] 582 | error: error, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pocket.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pocket.rs:229:13 [INFO] [stderr] | [INFO] [stderr] 229 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pocket.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pocket.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pocket.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | tweet_id: tweet_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `tweet_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:493:13 [INFO] [stderr] | [INFO] [stderr] 493 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:494:13 [INFO] [stderr] | [INFO] [stderr] 494 | last_modified: last_modified, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_modified` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:495:13 [INFO] [stderr] | [INFO] [stderr] 495 | e_tag: e_tag, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `e_tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:582:13 [INFO] [stderr] | [INFO] [stderr] 582 | error: error, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/pocket.rs:191:30 [INFO] [stderr] | [INFO] [stderr] 191 | const REDIRECT_URI: &'static str = "data:text/plain,Return%20to%20feeds-to-pocket%20and%20press%20Enter%20to%20finish%2E"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | pub const CONFIG: &'static str = "config"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:109:26 [INFO] [stderr] | [INFO] [stderr] 109 | pub const NAME: &'static str = "init"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:113:26 [INFO] [stderr] | [INFO] [stderr] 113 | pub const NAME: &'static str = "set-consumer-key"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:116:29 [INFO] [stderr] | [INFO] [stderr] 116 | pub const KEY: &'static str = "key"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:121:26 [INFO] [stderr] | [INFO] [stderr] 121 | pub const NAME: &'static str = "login"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:125:26 [INFO] [stderr] | [INFO] [stderr] 125 | pub const NAME: &'static str = "add"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:128:32 [INFO] [stderr] | [INFO] [stderr] 128 | pub const UNREAD: &'static str = "unread"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:129:30 [INFO] [stderr] | [INFO] [stderr] 129 | pub const TAGS: &'static str = "tags"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:130:34 [INFO] [stderr] | [INFO] [stderr] 130 | pub const FEED_URL: &'static str = "feed url"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:135:26 [INFO] [stderr] | [INFO] [stderr] 135 | pub const NAME: &'static str = "remove"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:138:34 [INFO] [stderr] | [INFO] [stderr] 138 | pub const FEED_URL: &'static str = "feed url"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/pocket.rs:191:30 [INFO] [stderr] | [INFO] [stderr] 191 | const REDIRECT_URI: &'static str = "data:text/plain,Return%20to%20feeds-to-pocket%20and%20press%20Enter%20to%20finish%2E"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | pub const CONFIG: &'static str = "config"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:109:26 [INFO] [stderr] | [INFO] [stderr] 109 | pub const NAME: &'static str = "init"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:113:26 [INFO] [stderr] | [INFO] [stderr] 113 | pub const NAME: &'static str = "set-consumer-key"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:116:29 [INFO] [stderr] | [INFO] [stderr] 116 | pub const KEY: &'static str = "key"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:121:26 [INFO] [stderr] | [INFO] [stderr] 121 | pub const NAME: &'static str = "login"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:125:26 [INFO] [stderr] | [INFO] [stderr] 125 | pub const NAME: &'static str = "add"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:128:32 [INFO] [stderr] | [INFO] [stderr] 128 | pub const UNREAD: &'static str = "unread"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:129:30 [INFO] [stderr] | [INFO] [stderr] 129 | pub const TAGS: &'static str = "tags"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:130:34 [INFO] [stderr] | [INFO] [stderr] 130 | pub const FEED_URL: &'static str = "feed url"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:135:26 [INFO] [stderr] | [INFO] [stderr] 135 | pub const NAME: &'static str = "remove"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:138:34 [INFO] [stderr] | [INFO] [stderr] 138 | pub const FEED_URL: &'static str = "feed url"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pocket.rs:141:32 [INFO] [stderr] | [INFO] [stderr] 141 | fn serialize_url_ref(value: &&Url, serializer: S) -> Result [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `&Url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/pocket.rs:177:120 [INFO] [stderr] | [INFO] [stderr] 177 | r.headers().get(X_ERROR).map(|v| v.to_str().expect("X-Error is not well-formed UTF-8").into()).unwrap_or("unknown protocol error".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "unknown protocol error".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:152:69 [INFO] [stderr] | [INFO] [stderr] 152 | (subcommands::set_consumer_key::NAME, Some(args)) => Ok(set_consumer_key(&mut config, &args)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 152 | (subcommands::set_consumer_key::NAME, Some(args)) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:164:37 [INFO] [stderr] | [INFO] [stderr] 164 | ($expr:expr, $context:expr) => (match $expr { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 165 | | ::std::result::Result::Ok(val) => val, [INFO] [stderr] 166 | | ::std::result::Result::Err(err) => { [INFO] [stderr] 167 | | return ::std::result::Result::Err($crate::ErrorWithContext::new(::std::convert::From::from(err), $context)) [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 215 | Ok(try_with_context!(fs::rename(from, to), [INFO] [stderr] | ____________- [INFO] [stderr] 216 | | format!("failed to rename {} to {}", from.as_ref().to_string_lossy(), to.as_ref().to_string_lossy()))) [INFO] [stderr] | |_________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 164 | ($expr:expr, $context:expr) => (()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:386:47 [INFO] [stderr] | [INFO] [stderr] 386 | atom_entries = atom.entries().into_iter().rev().flat_map(|entry| entry.links()).filter_map(|link| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:404:61 [INFO] [stderr] | [INFO] [stderr] 404 | if !feed.processed_entries.iter().rev().any(|x| x == &entry_url) { [INFO] [stderr] | ^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `entry_url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/main.rs:537:5 [INFO] [stderr] | [INFO] [stderr] 537 | RSS(rss::Channel), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 537 | RSS(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/pocket.rs:141:32 [INFO] [stderr] | [INFO] [stderr] 141 | fn serialize_url_ref(value: &&Url, serializer: S) -> Result [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `&Url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/pocket.rs:177:120 [INFO] [stderr] | [INFO] [stderr] 177 | r.headers().get(X_ERROR).map(|v| v.to_str().expect("X-Error is not well-formed UTF-8").into()).unwrap_or("unknown protocol error".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "unknown protocol error".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:152:69 [INFO] [stderr] | [INFO] [stderr] 152 | (subcommands::set_consumer_key::NAME, Some(args)) => Ok(set_consumer_key(&mut config, &args)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 152 | (subcommands::set_consumer_key::NAME, Some(args)) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:164:37 [INFO] [stderr] | [INFO] [stderr] 164 | ($expr:expr, $context:expr) => (match $expr { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 165 | | ::std::result::Result::Ok(val) => val, [INFO] [stderr] 166 | | ::std::result::Result::Err(err) => { [INFO] [stderr] 167 | | return ::std::result::Result::Err($crate::ErrorWithContext::new(::std::convert::From::from(err), $context)) [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 215 | Ok(try_with_context!(fs::rename(from, to), [INFO] [stderr] | ____________- [INFO] [stderr] 216 | | format!("failed to rename {} to {}", from.as_ref().to_string_lossy(), to.as_ref().to_string_lossy()))) [INFO] [stderr] | |_________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 164 | ($expr:expr, $context:expr) => (()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:386:47 [INFO] [stderr] | [INFO] [stderr] 386 | atom_entries = atom.entries().into_iter().rev().flat_map(|entry| entry.links()).filter_map(|link| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:404:61 [INFO] [stderr] | [INFO] [stderr] 404 | if !feed.processed_entries.iter().rev().any(|x| x == &entry_url) { [INFO] [stderr] | ^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `entry_url` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/main.rs:537:5 [INFO] [stderr] | [INFO] [stderr] 537 | RSS(rss::Channel), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 537 | RSS(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.32s [INFO] running `"docker" "inspect" "0c6fffb09721989a5d8f38c4dc8a347622d2484bff1b6fdee4caa467d8d93f18"` [INFO] running `"docker" "rm" "-f" "0c6fffb09721989a5d8f38c4dc8a347622d2484bff1b6fdee4caa467d8d93f18"` [INFO] [stdout] 0c6fffb09721989a5d8f38c4dc8a347622d2484bff1b6fdee4caa467d8d93f18