[INFO] crate feedburst 0.4.1 is already in cache [INFO] extracting crate feedburst 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/feedburst/0.4.1 [INFO] extracting crate feedburst 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/feedburst/0.4.1 [INFO] validating manifest of feedburst-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of feedburst-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing feedburst-0.4.1 [INFO] finished frobbing feedburst-0.4.1 [INFO] frobbed toml for feedburst-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/feedburst/0.4.1/Cargo.toml [INFO] started frobbing feedburst-0.4.1 [INFO] finished frobbing feedburst-0.4.1 [INFO] frobbed toml for feedburst-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/feedburst/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting feedburst-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/feedburst/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 91aeec249b564688a0f3fe637648d8d3678d2b17a3cbc922a3197ae33215eb71 [INFO] running `"docker" "start" "-a" "91aeec249b564688a0f3fe637648d8d3678d2b17a3cbc922a3197ae33215eb71"` [INFO] [stderr] Checking syndication v0.4.0 [INFO] [stderr] Checking feedburst v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse_util.rs:386:23 [INFO] [stderr] | [INFO] [stderr] 386 | const HEART: &'static str = "\u{1F49C}"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser.rs:523:47 [INFO] [stderr] | [INFO] [stderr] 523 | FeedEvent::Read(Utc.ymd(2017, 07, 17).and_hms_micro(03, 21, 21, 492180)), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 523 | FeedEvent::Read(Utc.ymd(2017, 7, 17).and_hms_micro(03, 21, 21, 492180)), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 523 | FeedEvent::Read(Utc.ymd(2017, 0o7, 17).and_hms_micro(03, 21, 21, 492180)), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser.rs:523:69 [INFO] [stderr] | [INFO] [stderr] 523 | FeedEvent::Read(Utc.ymd(2017, 07, 17).and_hms_micro(03, 21, 21, 492180)), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 523 | FeedEvent::Read(Utc.ymd(2017, 07, 17).and_hms_micro(3, 21, 21, 492180)), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 523 | FeedEvent::Read(Utc.ymd(2017, 07, 17).and_hms_micro(0o3, 21, 21, 492180)), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:523:81 [INFO] [stderr] | [INFO] [stderr] 523 | FeedEvent::Read(Utc.ymd(2017, 07, 17).and_hms_micro(03, 21, 21, 492180)), [INFO] [stderr] | ^^^^^^ help: consider: `492_180` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/parser.rs:525:47 [INFO] [stderr] | [INFO] [stderr] 525 | FeedEvent::Read(Utc.ymd(2017, 07, 18).and_hms_micro(23, 41, 58, 130248)), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 525 | FeedEvent::Read(Utc.ymd(2017, 7, 18).and_hms_micro(23, 41, 58, 130248)), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 525 | FeedEvent::Read(Utc.ymd(2017, 0o7, 18).and_hms_micro(23, 41, 58, 130248)), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:525:81 [INFO] [stderr] | [INFO] [stderr] 525 | FeedEvent::Read(Utc.ymd(2017, 07, 18).and_hms_micro(23, 41, 58, 130248)), [INFO] [stderr] | ^^^^^^ help: consider: `130_248` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/parser.rs:152:41 [INFO] [stderr] | [INFO] [stderr] 152 | let c = buf.text.chars().next().ok_or(buf.expected("a pattern"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| buf.expected("a pattern"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/parser.rs:152:41 [INFO] [stderr] | [INFO] [stderr] 152 | let c = buf.text.chars().next().ok_or(buf.expected("a pattern"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| buf.expected("a pattern"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.76s [INFO] running `"docker" "inspect" "91aeec249b564688a0f3fe637648d8d3678d2b17a3cbc922a3197ae33215eb71"` [INFO] running `"docker" "rm" "-f" "91aeec249b564688a0f3fe637648d8d3678d2b17a3cbc922a3197ae33215eb71"` [INFO] [stdout] 91aeec249b564688a0f3fe637648d8d3678d2b17a3cbc922a3197ae33215eb71