[INFO] crate fd-passing 0.0.1 is already in cache [INFO] extracting crate fd-passing 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/fd-passing/0.0.1 [INFO] extracting crate fd-passing 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fd-passing/0.0.1 [INFO] validating manifest of fd-passing-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fd-passing-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fd-passing-0.0.1 [INFO] finished frobbing fd-passing-0.0.1 [INFO] frobbed toml for fd-passing-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/fd-passing/0.0.1/Cargo.toml [INFO] started frobbing fd-passing-0.0.1 [INFO] finished frobbing fd-passing-0.0.1 [INFO] frobbed toml for fd-passing-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fd-passing/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fd-passing-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fd-passing/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6d6143b9a1ec469c461d4e75425b70dd1a4d8c1f89545253a9aafdc167614fed [INFO] running `"docker" "start" "-a" "6d6143b9a1ec469c461d4e75425b70dd1a4d8c1f89545253a9aafdc167614fed"` [INFO] [stderr] Compiling fd-passing v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'gcc::compile_library': crate has been renamed to `cc`, the `gcc` name is not maintained [INFO] [stderr] --> build.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | gcc::compile_library("libfd_passing_consts.a", &["ffi/consts.c"]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: The function/method `libc::sendmsg` doesn't need a mutable reference [INFO] [stderr] --> src/functions.rs:74:50 [INFO] [stderr] | [INFO] [stderr] 74 | match libc::sendmsg(channel.as_raw_fd(), &mut message, 0) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/functions.rs:129:52 [INFO] [stderr] | [INFO] [stderr] 129 | FdImplementor::from(fdtype, rawfd).ok_or("Unexpected file descriptor type".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Unexpected file descriptor type".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/utils.rs:47:35 [INFO] [stderr] | [INFO] [stderr] 47 | *data.offset((pos as isize)), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/utils.rs:47:35 [INFO] [stderr] | [INFO] [stderr] 47 | *data.offset((pos as isize)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: The function/method `libc::sendmsg` doesn't need a mutable reference [INFO] [stderr] --> src/functions.rs:74:50 [INFO] [stderr] | [INFO] [stderr] 74 | match libc::sendmsg(channel.as_raw_fd(), &mut message, 0) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/functions.rs:129:52 [INFO] [stderr] | [INFO] [stderr] 129 | FdImplementor::from(fdtype, rawfd).ok_or("Unexpected file descriptor type".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Unexpected file descriptor type".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/functions.rs:189:12 [INFO] [stderr] | [INFO] [stderr] 189 | if !res.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `res.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/functions.rs:197:12 [INFO] [stderr] | [INFO] [stderr] 197 | if !res.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `res.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/functions.rs:201:43 [INFO] [stderr] | [INFO] [stderr] 201 | let mut f = fs::File::open(fpath).expect(&format!("cannot open {:?}", fpath)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("cannot open {:?}", fpath))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/functions.rs:247:31 [INFO] [stderr] | [INFO] [stderr] 247 | .expect(&format!("Could not create data file {:?}", fpath)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not create data file {:?}", fpath))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/functions.rs:250:34 [INFO] [stderr] | [INFO] [stderr] 250 | .expect(&format!("cannot connect to unix socket {:?}", sockpath)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("cannot connect to unix socket {:?}", sockpath))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/utils.rs:47:23 [INFO] [stderr] | [INFO] [stderr] 47 | *data.offset((pos as isize)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data.add(pos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.20s [INFO] running `"docker" "inspect" "6d6143b9a1ec469c461d4e75425b70dd1a4d8c1f89545253a9aafdc167614fed"` [INFO] running `"docker" "rm" "-f" "6d6143b9a1ec469c461d4e75425b70dd1a4d8c1f89545253a9aafdc167614fed"` [INFO] [stdout] 6d6143b9a1ec469c461d4e75425b70dd1a4d8c1f89545253a9aafdc167614fed