[INFO] crate fd-find 7.2.0 is already in cache [INFO] extracting crate fd-find 7.2.0 into work/ex/clippy-test-run/sources/stable/reg/fd-find/7.2.0 [INFO] extracting crate fd-find 7.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fd-find/7.2.0 [INFO] validating manifest of fd-find-7.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fd-find-7.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fd-find-7.2.0 [INFO] finished frobbing fd-find-7.2.0 [INFO] frobbed toml for fd-find-7.2.0 written to work/ex/clippy-test-run/sources/stable/reg/fd-find/7.2.0/Cargo.toml [INFO] started frobbing fd-find-7.2.0 [INFO] finished frobbing fd-find-7.2.0 [INFO] frobbed toml for fd-find-7.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fd-find/7.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fd-find-7.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fd-find/7.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c3d8ae4f0fd6f1ce92f82d6e27233bc6c63a8d71b24c82da95fda9316192d0fa [INFO] running `"docker" "start" "-a" "c3d8ae4f0fd6f1ce92f82d6e27233bc6c63a8d71b24c82da95fda9316192d0fa"` [INFO] [stderr] Compiling term_size v0.3.1 [INFO] [stderr] Checking ignore v0.4.6 [INFO] [stderr] Compiling textwrap v0.10.0 [INFO] [stderr] Compiling clap v2.32.0 [INFO] [stderr] Compiling fd-find v7.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/app.rs:208:1 [INFO] [stderr] | [INFO] [stderr] 208 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exec/mod.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | CommandTemplate { args: args } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | write!(handle, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(handle, "")` [INFO] [stderr] --> src/output.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | writeln!(handle, "") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(handle)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/testenv/mod.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | temp_dir: temp_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `temp_dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/testenv/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | fd_exe: fd_exe, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fd_exe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/app.rs:208:1 [INFO] [stderr] | [INFO] [stderr] 208 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/exec/mod.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | CommandTemplate { args: args } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | write!(handle, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(handle, "")` [INFO] [stderr] --> src/output.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | writeln!(handle, "") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(handle)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> tests/tests.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | path [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> tests/tests.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | let path = env [INFO] [stderr] | ________________^ [INFO] [stderr] 40 | | .test_root() [INFO] [stderr] 41 | | .canonicalize() [INFO] [stderr] 42 | | .expect("absolute path") [INFO] [stderr] 43 | | .to_str() [INFO] [stderr] 44 | | .expect("string") [INFO] [stderr] 45 | | .to_string(); [INFO] [stderr] | |____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> tests/tests.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | f.write(content.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `fd-find`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:91:63 [INFO] [stderr] | [INFO] [stderr] 91 | kilo_minus_multiplier: ("-100k", SizeFilter::Max(100000)), [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:101:63 [INFO] [stderr] | [INFO] [stderr] 101 | kibi_minus_multiplier: ("-100ki", SizeFilter::Max(102400)), [INFO] [stderr] | ^^^^^^ help: consider: `102_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:107:63 [INFO] [stderr] | [INFO] [stderr] 107 | mega_plus: ("+1m", SizeFilter::Min(1000000)), [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:108:63 [INFO] [stderr] | [INFO] [stderr] 108 | mega_plus_suffix: ("+1mb", SizeFilter::Min(1000000)), [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:109:63 [INFO] [stderr] | [INFO] [stderr] 109 | mega_minus: ("-1m", SizeFilter::Max(1000000)), [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:110:63 [INFO] [stderr] | [INFO] [stderr] 110 | mega_minus_suffix: ("-1mb", SizeFilter::Max(1000000)), [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:111:63 [INFO] [stderr] | [INFO] [stderr] 111 | mega_plus_upper: ("+1M", SizeFilter::Min(1000000)), [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:112:63 [INFO] [stderr] | [INFO] [stderr] 112 | mega_plus_suffix_upper: ("+1MB", SizeFilter::Min(1000000)), [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:113:63 [INFO] [stderr] | [INFO] [stderr] 113 | mega_minus_upper: ("-1M", SizeFilter::Max(1000000)), [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:114:63 [INFO] [stderr] | [INFO] [stderr] 114 | mega_minus_suffix_upper: ("-1Mb", SizeFilter::Max(1000000)), [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:115:63 [INFO] [stderr] | [INFO] [stderr] 115 | mebi_plus: ("+1mi", SizeFilter::Min(1048576)), [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:116:63 [INFO] [stderr] | [INFO] [stderr] 116 | mebi_plus_suffix: ("+1mib", SizeFilter::Min(1048576)), [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:117:63 [INFO] [stderr] | [INFO] [stderr] 117 | mebi_minus: ("-1mi", SizeFilter::Max(1048576)), [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:118:63 [INFO] [stderr] | [INFO] [stderr] 118 | mebi_minus_suffix: ("-1mib", SizeFilter::Max(1048576)), [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:119:63 [INFO] [stderr] | [INFO] [stderr] 119 | mebi_plus_upper: ("+1MI", SizeFilter::Min(1048576)), [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:120:63 [INFO] [stderr] | [INFO] [stderr] 120 | mebi_plus_suffix_upper: ("+1MiB", SizeFilter::Min(1048576)), [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:121:63 [INFO] [stderr] | [INFO] [stderr] 121 | mebi_minus_upper: ("-1Mi", SizeFilter::Max(1048576)), [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:122:63 [INFO] [stderr] | [INFO] [stderr] 122 | mebi_minus_suffix_upper: ("-1MIB", SizeFilter::Max(1048576)), [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:123:63 [INFO] [stderr] | [INFO] [stderr] 123 | giga_plus: ("+1g", SizeFilter::Min(1000000000)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:124:63 [INFO] [stderr] | [INFO] [stderr] 124 | giga_plus_suffix: ("+1gb", SizeFilter::Min(1000000000)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:125:63 [INFO] [stderr] | [INFO] [stderr] 125 | giga_minus: ("-1g", SizeFilter::Max(1000000000)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:126:63 [INFO] [stderr] | [INFO] [stderr] 126 | giga_minus_suffix: ("-1gb", SizeFilter::Max(1000000000)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:127:63 [INFO] [stderr] | [INFO] [stderr] 127 | giga_plus_upper: ("+1G", SizeFilter::Min(1000000000)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:128:63 [INFO] [stderr] | [INFO] [stderr] 128 | giga_plus_suffix_upper: ("+1GB", SizeFilter::Min(1000000000)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:129:63 [INFO] [stderr] | [INFO] [stderr] 129 | giga_minus_upper: ("-1G", SizeFilter::Max(1000000000)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:130:63 [INFO] [stderr] | [INFO] [stderr] 130 | giga_minus_suffix_upper: ("-1Gb", SizeFilter::Max(1000000000)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:131:63 [INFO] [stderr] | [INFO] [stderr] 131 | gibi_plus: ("+1gi", SizeFilter::Min(1073741824)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_073_741_824` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:132:63 [INFO] [stderr] | [INFO] [stderr] 132 | gibi_plus_suffix: ("+1gib", SizeFilter::Min(1073741824)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_073_741_824` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:133:63 [INFO] [stderr] | [INFO] [stderr] 133 | gibi_minus: ("-1gi", SizeFilter::Max(1073741824)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_073_741_824` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:134:63 [INFO] [stderr] | [INFO] [stderr] 134 | gibi_minus_suffix: ("-1gib", SizeFilter::Max(1073741824)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_073_741_824` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:135:63 [INFO] [stderr] | [INFO] [stderr] 135 | gibi_plus_upper: ("+1GI", SizeFilter::Min(1073741824)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_073_741_824` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:136:63 [INFO] [stderr] | [INFO] [stderr] 136 | gibi_plus_suffix_upper: ("+1GiB", SizeFilter::Min(1073741824)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_073_741_824` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:137:63 [INFO] [stderr] | [INFO] [stderr] 137 | gibi_minus_upper: ("-1Gi", SizeFilter::Max(1073741824)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_073_741_824` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:138:63 [INFO] [stderr] | [INFO] [stderr] 138 | gibi_minus_suffix_upper: ("-1GIB", SizeFilter::Max(1073741824)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_073_741_824` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:139:63 [INFO] [stderr] | [INFO] [stderr] 139 | tera_plus: ("+1t", SizeFilter::Min(1000000000000)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:140:63 [INFO] [stderr] | [INFO] [stderr] 140 | tera_plus_suffix: ("+1tb", SizeFilter::Min(1000000000000)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:141:63 [INFO] [stderr] | [INFO] [stderr] 141 | tera_minus: ("-1t", SizeFilter::Max(1000000000000)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:142:63 [INFO] [stderr] | [INFO] [stderr] 142 | tera_minus_suffix: ("-1tb", SizeFilter::Max(1000000000000)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:143:63 [INFO] [stderr] | [INFO] [stderr] 143 | tera_plus_upper: ("+1T", SizeFilter::Min(1000000000000)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:144:63 [INFO] [stderr] | [INFO] [stderr] 144 | tera_plus_suffix_upper: ("+1TB", SizeFilter::Min(1000000000000)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:145:63 [INFO] [stderr] | [INFO] [stderr] 145 | tera_minus_upper: ("-1T", SizeFilter::Max(1000000000000)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:146:63 [INFO] [stderr] | [INFO] [stderr] 146 | tera_minus_suffix_upper: ("-1Tb", SizeFilter::Max(1000000000000)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:147:63 [INFO] [stderr] | [INFO] [stderr] 147 | tebi_plus: ("+1ti", SizeFilter::Min(1099511627776)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_099_511_627_776` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:148:63 [INFO] [stderr] | [INFO] [stderr] 148 | tebi_plus_suffix: ("+1tib", SizeFilter::Min(1099511627776)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_099_511_627_776` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:149:63 [INFO] [stderr] | [INFO] [stderr] 149 | tebi_minus: ("-1ti", SizeFilter::Max(1099511627776)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_099_511_627_776` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:150:63 [INFO] [stderr] | [INFO] [stderr] 150 | tebi_minus_suffix: ("-1tib", SizeFilter::Max(1099511627776)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_099_511_627_776` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:151:63 [INFO] [stderr] | [INFO] [stderr] 151 | tebi_plus_upper: ("+1TI", SizeFilter::Min(1099511627776)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_099_511_627_776` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:152:63 [INFO] [stderr] | [INFO] [stderr] 152 | tebi_plus_suffix_upper: ("+1TiB", SizeFilter::Min(1099511627776)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_099_511_627_776` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:153:63 [INFO] [stderr] | [INFO] [stderr] 153 | tebi_minus_upper: ("-1Ti", SizeFilter::Max(1099511627776)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_099_511_627_776` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/internal/filter/size.rs:154:63 [INFO] [stderr] | [INFO] [stderr] 154 | tebi_minus_suffix_upper: ("-1TIB", SizeFilter::Max(1099511627776)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_099_511_627_776` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/internal/filter/size.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn from_string<'a>(s: &str) -> Option { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/internal/filter/size.rs:39:32 [INFO] [stderr] | [INFO] [stderr] 39 | v if v.starts_with("k") => KILO, [INFO] [stderr] | ^^^ help: try using a char instead: `'k'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/internal/filter/size.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | v if v.starts_with("m") => MEGA, [INFO] [stderr] | ^^^ help: try using a char instead: `'m'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/internal/filter/size.rs:43:32 [INFO] [stderr] | [INFO] [stderr] 43 | v if v.starts_with("g") => GIGA, [INFO] [stderr] | ^^^ help: try using a char instead: `'g'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/internal/filter/size.rs:45:32 [INFO] [stderr] | [INFO] [stderr] 45 | v if v.starts_with("t") => TERA, [INFO] [stderr] | ^^^ help: try using a char instead: `'t'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/internal/filter/size.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match self { [INFO] [stderr] 59 | | &SizeFilter::Max(limit) => size <= limit, [INFO] [stderr] 60 | | &SizeFilter::Min(limit) => size >= limit, [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 58 | match *self { [INFO] [stderr] 59 | SizeFilter::Max(limit) => size <= limit, [INFO] [stderr] 60 | SizeFilter::Min(limit) => size >= limit, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lscolors/mod.rs:128:20 [INFO] [stderr] | [INFO] [stderr] 128 | if !parts.next().is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parts.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lscolors/mod.rs:137:31 [INFO] [stderr] | [INFO] [stderr] 137 | match code.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/output.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / fn strip_current_dir<'a>(pathbuf: &'a PathBuf) -> &'a Path { [INFO] [stderr] 25 | | let mut iter = pathbuf.components(); [INFO] [stderr] 26 | | let mut iter_next = iter.clone(); [INFO] [stderr] 27 | | if iter_next.next() == Some(Component::CurDir) { [INFO] [stderr] ... | [INFO] [stderr] 30 | | iter.as_path() [INFO] [stderr] 31 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/walk.rs:258:21 [INFO] [stderr] | [INFO] [stderr] 258 | / { [INFO] [stderr] 259 | | // This is probably a block device, char device, fifo or socket. Skip it. [INFO] [stderr] 260 | | return ignore::WalkState::Continue; [INFO] [stderr] 261 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/walk.rs:253:21 [INFO] [stderr] | [INFO] [stderr] 253 | / { [INFO] [stderr] 254 | | return ignore::WalkState::Continue; [INFO] [stderr] 255 | | } else if !(entry_type.is_file() [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/walk.rs:271:41 [INFO] [stderr] | [INFO] [stderr] 271 | if let Some(path_str) = entry_path.file_name().map_or(None, |s| s.to_str()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `entry_path.file_name().and_then(|s| s.to_str())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/walk.rs:281:16 [INFO] [stderr] | [INFO] [stderr] 281 | if config.size_constraints.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!config.size_constraints.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:67:10 [INFO] [stderr] | [INFO] [stderr] 67 | .or(matches.values_of("search-path")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| matches.values_of("search-path"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `fd-find`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/internal/filter/size.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn from_string<'a>(s: &str) -> Option { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/internal/filter/size.rs:39:32 [INFO] [stderr] | [INFO] [stderr] 39 | v if v.starts_with("k") => KILO, [INFO] [stderr] | ^^^ help: try using a char instead: `'k'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/internal/filter/size.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | v if v.starts_with("m") => MEGA, [INFO] [stderr] | ^^^ help: try using a char instead: `'m'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/internal/filter/size.rs:43:32 [INFO] [stderr] | [INFO] [stderr] 43 | v if v.starts_with("g") => GIGA, [INFO] [stderr] | ^^^ help: try using a char instead: `'g'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/internal/filter/size.rs:45:32 [INFO] [stderr] | [INFO] [stderr] 45 | v if v.starts_with("t") => TERA, [INFO] [stderr] | ^^^ help: try using a char instead: `'t'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/internal/filter/size.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match self { [INFO] [stderr] 59 | | &SizeFilter::Max(limit) => size <= limit, [INFO] [stderr] 60 | | &SizeFilter::Min(limit) => size >= limit, [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 58 | match *self { [INFO] [stderr] 59 | SizeFilter::Max(limit) => size <= limit, [INFO] [stderr] 60 | SizeFilter::Min(limit) => size >= limit, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/internal/mod.rs:103:14 [INFO] [stderr] | [INFO] [stderr] 103 | strs.into_iter().map(OsString::from).collect() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lscolors/mod.rs:128:20 [INFO] [stderr] | [INFO] [stderr] 128 | if !parts.next().is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parts.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/lscolors/mod.rs:137:31 [INFO] [stderr] | [INFO] [stderr] 137 | match code.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try this: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/output.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / fn strip_current_dir<'a>(pathbuf: &'a PathBuf) -> &'a Path { [INFO] [stderr] 25 | | let mut iter = pathbuf.components(); [INFO] [stderr] 26 | | let mut iter_next = iter.clone(); [INFO] [stderr] 27 | | if iter_next.next() == Some(Component::CurDir) { [INFO] [stderr] ... | [INFO] [stderr] 30 | | iter.as_path() [INFO] [stderr] 31 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/walk.rs:258:21 [INFO] [stderr] | [INFO] [stderr] 258 | / { [INFO] [stderr] 259 | | // This is probably a block device, char device, fifo or socket. Skip it. [INFO] [stderr] 260 | | return ignore::WalkState::Continue; [INFO] [stderr] 261 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/walk.rs:253:21 [INFO] [stderr] | [INFO] [stderr] 253 | / { [INFO] [stderr] 254 | | return ignore::WalkState::Continue; [INFO] [stderr] 255 | | } else if !(entry_type.is_file() [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/walk.rs:271:41 [INFO] [stderr] | [INFO] [stderr] 271 | if let Some(path_str) = entry_path.file_name().map_or(None, |s| s.to_str()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `entry_path.file_name().and_then(|s| s.to_str())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/walk.rs:281:16 [INFO] [stderr] | [INFO] [stderr] 281 | if config.size_constraints.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!config.size_constraints.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:67:10 [INFO] [stderr] | [INFO] [stderr] 67 | .or(matches.values_of("search-path")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| matches.values_of("search-path"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `fd-find`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c3d8ae4f0fd6f1ce92f82d6e27233bc6c63a8d71b24c82da95fda9316192d0fa"` [INFO] running `"docker" "rm" "-f" "c3d8ae4f0fd6f1ce92f82d6e27233bc6c63a8d71b24c82da95fda9316192d0fa"` [INFO] [stdout] c3d8ae4f0fd6f1ce92f82d6e27233bc6c63a8d71b24c82da95fda9316192d0fa