[INFO] crate fcm 0.6.0 is already in cache [INFO] extracting crate fcm 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/fcm/0.6.0 [INFO] extracting crate fcm 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fcm/0.6.0 [INFO] validating manifest of fcm-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fcm-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fcm-0.6.0 [INFO] finished frobbing fcm-0.6.0 [INFO] frobbed toml for fcm-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/fcm/0.6.0/Cargo.toml [INFO] started frobbing fcm-0.6.0 [INFO] finished frobbing fcm-0.6.0 [INFO] frobbed toml for fcm-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fcm/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fcm-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fcm/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4e11d371bd7d713acd81afb7ed03336f8bc52c7d1b48729bf315bed299e1d8a7 [INFO] running `"docker" "start" "-a" "4e11d371bd7d713acd81afb7ed03336f8bc52c7d1b48729bf315bed299e1d8a7"` [INFO] [stderr] Checking fcm v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | api_key: api_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `api_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | to: to, [INFO] [stderr] | ^^^^^^ help: replace it with: `to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | api_key: api_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `api_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/message/mod.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | to: to, [INFO] [stderr] | ^^^^^^ help: replace it with: `to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `notification::NotificationBuilder<'a>` [INFO] [stderr] --> src/notification/mod.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn new() -> NotificationBuilder<'a> { [INFO] [stderr] 78 | | NotificationBuilder { [INFO] [stderr] 79 | | title: None, [INFO] [stderr] 80 | | body: None, [INFO] [stderr] ... | [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 60 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/client/response.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | / pub fn from_str(header_value: &str) -> Option { [INFO] [stderr] 158 | | if let Ok(seconds) = header_value.parse::() { [INFO] [stderr] 159 | | Some(RetryAfter::Delay(Duration::seconds(seconds))) [INFO] [stderr] 160 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client/mod.rs:82:35 [INFO] [stderr] | [INFO] [stderr] 82 | let response_status = response.status().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `response.status()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `notification::NotificationBuilder<'a>` [INFO] [stderr] --> src/notification/mod.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn new() -> NotificationBuilder<'a> { [INFO] [stderr] 78 | | NotificationBuilder { [INFO] [stderr] 79 | | title: None, [INFO] [stderr] 80 | | body: None, [INFO] [stderr] ... | [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 60 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/client/response.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | / pub fn from_str(header_value: &str) -> Option { [INFO] [stderr] 158 | | if let Ok(seconds) = header_value.parse::() { [INFO] [stderr] 159 | | Some(RetryAfter::Delay(Duration::seconds(seconds))) [INFO] [stderr] 160 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client/response.rs:207:22 [INFO] [stderr] | [INFO] [stderr] 207 | Some(error_enum.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `error_enum` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client/mod.rs:82:35 [INFO] [stderr] | [INFO] [stderr] 82 | let response_status = response.status().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `response.status()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.22s [INFO] running `"docker" "inspect" "4e11d371bd7d713acd81afb7ed03336f8bc52c7d1b48729bf315bed299e1d8a7"` [INFO] running `"docker" "rm" "-f" "4e11d371bd7d713acd81afb7ed03336f8bc52c7d1b48729bf315bed299e1d8a7"` [INFO] [stdout] 4e11d371bd7d713acd81afb7ed03336f8bc52c7d1b48729bf315bed299e1d8a7