[INFO] crate fbx3d 0.1.0 is already in cache
[INFO] extracting crate fbx3d 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/fbx3d/0.1.0
[INFO] extracting crate fbx3d 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fbx3d/0.1.0
[INFO] validating manifest of fbx3d-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of fbx3d-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing fbx3d-0.1.0
[INFO] finished frobbing fbx3d-0.1.0
[INFO] frobbed toml for fbx3d-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/fbx3d/0.1.0/Cargo.toml
[INFO] started frobbing fbx3d-0.1.0
[INFO] finished frobbing fbx3d-0.1.0
[INFO] frobbed toml for fbx3d-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fbx3d/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting fbx3d-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fbx3d/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b9a5f8c8b62e8944f9471b3d3129b9375bf7f0172c3534295b69574238372d99
[INFO] running `"docker" "start" "-a" "b9a5f8c8b62e8944f9471b3d3129b9375bf7f0172c3534295b69574238372d99"`
[INFO] [stderr]     Checking bytepack v0.1.1
[INFO] [stderr]     Checking fbx3d v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/types.rs:140:9
[INFO] [stderr]     |
[INFO] [stderr] 140 |         name: name,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/types.rs:141:9
[INFO] [stderr]     |
[INFO] [stderr] 141 |         properties: properties,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/types.rs:140:9
[INFO] [stderr]     |
[INFO] [stderr] 140 |         name: name,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/types.rs:141:9
[INFO] [stderr]     |
[INFO] [stderr] 141 |         properties: properties,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/types.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 |     return Ok(array);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(array)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/types.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         return Ok(array);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(array)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/types.rs:83:13
[INFO] [stderr]    |
[INFO] [stderr] 83 |             return Ok(converted);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(converted)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/types.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 |         return Err(Error::new(ErrorKind::InvalidData, "Unknown array encoding"));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::new(ErrorKind::InvalidData, "Unknown array encoding"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/types.rs:139:5
[INFO] [stderr]     |
[INFO] [stderr] 139 | /     return Ok(Some(Node {
[INFO] [stderr] 140 | |         name: name,
[INFO] [stderr] 141 | |         properties: properties,
[INFO] [stderr] 142 | |         subnodes: decode_node_list(r, end_offset)?
[INFO] [stderr] 143 | |     }));
[INFO] [stderr]     | |________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 139 |     Ok(Some(Node {
[INFO] [stderr] 140 |         name: name,
[INFO] [stderr] 141 |         properties: properties,
[INFO] [stderr] 142 |         subnodes: decode_node_list(r, end_offset)?
[INFO] [stderr] 143 |     }))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/types.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 |     return Ok(nodes);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(nodes)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 |     return decode_node_list(r, u64::MAX);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `decode_node_list(r, u64::MAX)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/types.rs:73:16
[INFO] [stderr]    |
[INFO] [stderr] 73 |           if let Err(_) = deflater.decompress(&compressed, &mut decompressed, Flush::Finish) {
[INFO] [stderr]    |  _________-      ^^^^^^
[INFO] [stderr] 74 | |             return Err(Error::new(ErrorKind::InvalidData, "Failed to deflate array"));
[INFO] [stderr] 75 | |         }
[INFO] [stderr]    | |_________- help: try this: `if deflater.decompress(&compressed, &mut decompressed, Flush::Finish).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/types.rs:114:22
[INFO] [stderr]     |
[INFO] [stderr] 114 |     let end_offset = r.unpack::<u32>()? as u64;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(r.unpack::<u32>()?)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/types.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 |     return Ok(array);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(array)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/types.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         return Ok(array);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(array)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/types.rs:83:13
[INFO] [stderr]    |
[INFO] [stderr] 83 |             return Ok(converted);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(converted)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/types.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 |         return Err(Error::new(ErrorKind::InvalidData, "Unknown array encoding"));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::new(ErrorKind::InvalidData, "Unknown array encoding"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/types.rs:139:5
[INFO] [stderr]     |
[INFO] [stderr] 139 | /     return Ok(Some(Node {
[INFO] [stderr] 140 | |         name: name,
[INFO] [stderr] 141 | |         properties: properties,
[INFO] [stderr] 142 | |         subnodes: decode_node_list(r, end_offset)?
[INFO] [stderr] 143 | |     }));
[INFO] [stderr]     | |________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 139 |     Ok(Some(Node {
[INFO] [stderr] 140 |         name: name,
[INFO] [stderr] 141 |         properties: properties,
[INFO] [stderr] 142 |         subnodes: decode_node_list(r, end_offset)?
[INFO] [stderr] 143 |     }))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/types.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 |     return Ok(nodes);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(nodes)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 |     return decode_node_list(r, u64::MAX);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `decode_node_list(r, u64::MAX)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/types.rs:73:16
[INFO] [stderr]    |
[INFO] [stderr] 73 |           if let Err(_) = deflater.decompress(&compressed, &mut decompressed, Flush::Finish) {
[INFO] [stderr]    |  _________-      ^^^^^^
[INFO] [stderr] 74 | |             return Err(Error::new(ErrorKind::InvalidData, "Failed to deflate array"));
[INFO] [stderr] 75 | |         }
[INFO] [stderr]    | |_________- help: try this: `if deflater.decompress(&compressed, &mut decompressed, Flush::Finish).is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/types.rs:114:22
[INFO] [stderr]     |
[INFO] [stderr] 114 |     let end_offset = r.unpack::<u32>()? as u64;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(r.unpack::<u32>()?)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.25s
[INFO] running `"docker" "inspect" "b9a5f8c8b62e8944f9471b3d3129b9375bf7f0172c3534295b69574238372d99"`
[INFO] running `"docker" "rm" "-f" "b9a5f8c8b62e8944f9471b3d3129b9375bf7f0172c3534295b69574238372d99"`
[INFO] [stdout] b9a5f8c8b62e8944f9471b3d3129b9375bf7f0172c3534295b69574238372d99