[INFO] crate fblog 1.2.0 is already in cache [INFO] extracting crate fblog 1.2.0 into work/ex/clippy-test-run/sources/stable/reg/fblog/1.2.0 [INFO] extracting crate fblog 1.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fblog/1.2.0 [INFO] validating manifest of fblog-1.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fblog-1.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fblog-1.2.0 [INFO] finished frobbing fblog-1.2.0 [INFO] frobbed toml for fblog-1.2.0 written to work/ex/clippy-test-run/sources/stable/reg/fblog/1.2.0/Cargo.toml [INFO] started frobbing fblog-1.2.0 [INFO] finished frobbing fblog-1.2.0 [INFO] frobbed toml for fblog-1.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fblog/1.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fblog-1.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fblog/1.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dab79a38a2d07111c6d06a5ef008954f24e5d535866687319ba5c88e4f615329 [INFO] running `"docker" "start" "-a" "dab79a38a2d07111c6d06a5ef008954f24e5d535866687319ba5c88e4f615329"` [INFO] [stderr] Compiling lua52-sys v0.1.2 [INFO] [stderr] Checking hlua v0.4.1 [INFO] [stderr] Checking fblog v1.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/log.rs:57:85 [INFO] [stderr] | [INFO] [stderr] 57 | let formated_prefix = maybe_prefix.map(|p| format!(" {}", prefix_color.paint(p))).unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:88:40 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(Value::Object(log_entry)) => Ok(process_json_log_entry( [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 89 | | log_settings, [INFO] [stderr] 90 | | &mut inspect_logger, [INFO] [stderr] 91 | | maybe_prefix, [INFO] [stderr] ... | [INFO] [stderr] 94 | | implicit_return, [INFO] [stderr] 95 | | )), [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 88 | Ok(Value::Object(log_entry)) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:99:32 [INFO] [stderr] | [INFO] [stderr] 99 | match read_line.find("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/inspect.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/inspect.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | let result = regex.replace_all(&out_with_style, "").into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/log.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/log.rs:119:18 [INFO] [stderr] | [INFO] [stderr] 119 | let result = regex.replace_all(&out_with_style, "").into_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/log.rs:57:85 [INFO] [stderr] | [INFO] [stderr] 57 | let formated_prefix = maybe_prefix.map(|p| format!(" {}", prefix_color.paint(p))).unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:88:40 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(Value::Object(log_entry)) => Ok(process_json_log_entry( [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 89 | | log_settings, [INFO] [stderr] 90 | | &mut inspect_logger, [INFO] [stderr] 91 | | maybe_prefix, [INFO] [stderr] ... | [INFO] [stderr] 94 | | implicit_return, [INFO] [stderr] 95 | | )), [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 88 | Ok(Value::Object(log_entry)) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:99:32 [INFO] [stderr] | [INFO] [stderr] 99 | match read_line.find("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.63s [INFO] running `"docker" "inspect" "dab79a38a2d07111c6d06a5ef008954f24e5d535866687319ba5c88e4f615329"` [INFO] running `"docker" "rm" "-f" "dab79a38a2d07111c6d06a5ef008954f24e5d535866687319ba5c88e4f615329"` [INFO] [stdout] dab79a38a2d07111c6d06a5ef008954f24e5d535866687319ba5c88e4f615329