[INFO] crate fbenv 0.1.5 is already in cache [INFO] extracting crate fbenv 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/fbenv/0.1.5 [INFO] extracting crate fbenv 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fbenv/0.1.5 [INFO] validating manifest of fbenv-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fbenv-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fbenv-0.1.5 [INFO] finished frobbing fbenv-0.1.5 [INFO] frobbed toml for fbenv-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/fbenv/0.1.5/Cargo.toml [INFO] started frobbing fbenv-0.1.5 [INFO] finished frobbing fbenv-0.1.5 [INFO] frobbed toml for fbenv-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fbenv/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fbenv-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fbenv/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4332a89489f5d0c3573c96eb8d601c9ec49294a319e5f9e2005604bdf1615041 [INFO] running `"docker" "start" "-a" "4332a89489f5d0c3573c96eb8d601c9ec49294a319e5f9e2005604bdf1615041"` [INFO] [stderr] Checking fbenv v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config/mod.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:41:10 [INFO] [stderr] | [INFO] [stderr] 41 | if let Some(_) = matches.subcommand_matches("ls") { [INFO] [stderr] | ___- ^^^^^^^ [INFO] [stderr] 42 | | match config::load() { [INFO] [stderr] 43 | | Err(e) => println!("{}", e), [INFO] [stderr] 44 | | Ok(envs) => { [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |___- help: try this: `if matches.subcommand_matches("ls").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeMap [INFO] [stderr] --> src/config/mod.rs:50:41 [INFO] [stderr] | [INFO] [stderr] 50 | let tables: BTreeMap<_, _> = values.into_iter().filter(|&(_, value)| value.is_table()).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeMap [INFO] [stderr] --> src/config/mod.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config/mod.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:41:10 [INFO] [stderr] | [INFO] [stderr] 41 | if let Some(_) = matches.subcommand_matches("ls") { [INFO] [stderr] | ___- ^^^^^^^ [INFO] [stderr] 42 | | match config::load() { [INFO] [stderr] 43 | | Err(e) => println!("{}", e), [INFO] [stderr] 44 | | Ok(envs) => { [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |___- help: try this: `if matches.subcommand_matches("ls").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeMap [INFO] [stderr] --> src/config/mod.rs:50:41 [INFO] [stderr] | [INFO] [stderr] 50 | let tables: BTreeMap<_, _> = values.into_iter().filter(|&(_, value)| value.is_table()).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeMap [INFO] [stderr] --> src/config/mod.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.19s [INFO] running `"docker" "inspect" "4332a89489f5d0c3573c96eb8d601c9ec49294a319e5f9e2005604bdf1615041"` [INFO] running `"docker" "rm" "-f" "4332a89489f5d0c3573c96eb8d601c9ec49294a319e5f9e2005604bdf1615041"` [INFO] [stdout] 4332a89489f5d0c3573c96eb8d601c9ec49294a319e5f9e2005604bdf1615041