[INFO] crate fatr 0.2.0 is already in cache
[INFO] extracting crate fatr 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/fatr/0.2.0
[INFO] extracting crate fatr 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fatr/0.2.0
[INFO] validating manifest of fatr-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of fatr-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing fatr-0.2.0
[INFO] finished frobbing fatr-0.2.0
[INFO] frobbed toml for fatr-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/fatr/0.2.0/Cargo.toml
[INFO] started frobbing fatr-0.2.0
[INFO] finished frobbing fatr-0.2.0
[INFO] frobbed toml for fatr-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fatr/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting fatr-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fatr/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ccecf0084bb293c44a447c05fb84183024bd4f3c84ea34c04567f3f519795406
[INFO] running `"docker" "start" "-a" "ccecf0084bb293c44a447c05fb84183024bd4f3c84ea34c04567f3f519795406"`
[INFO] [stderr]     Checking fatr v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/commands/detail.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/commands/detail.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/commands/mod.rs:12:18
[INFO] [stderr]    |
[INFO] [stderr] 12 | const COMMANDS: &'static [
[INFO] [stderr]    |                  ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] help: consider removing `'static`
[INFO] [stderr]    |
[INFO] [stderr] 12 | const COMMANDS: &[
[INFO] [stderr] 13 |     (&'static str, &'static str, &'static str, Command)
[INFO] [stderr] 14 | ] = &[
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/commands/mod.rs:13:7
[INFO] [stderr]    |
[INFO] [stderr] 13 |     (&'static str, &'static str, &'static str, Command)
[INFO] [stderr]    |      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/commands/mod.rs:13:21
[INFO] [stderr]    |
[INFO] [stderr] 13 |     (&'static str, &'static str, &'static str, Command)
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/commands/mod.rs:13:35
[INFO] [stderr]    |
[INFO] [stderr] 13 |     (&'static str, &'static str, &'static str, Command)
[INFO] [stderr]    |                                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/commands/mod.rs:12:18
[INFO] [stderr]    |
[INFO] [stderr] 12 | const COMMANDS: &'static [
[INFO] [stderr]    |                  ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] help: consider removing `'static`
[INFO] [stderr]    |
[INFO] [stderr] 12 | const COMMANDS: &[
[INFO] [stderr] 13 |     (&'static str, &'static str, &'static str, Command)
[INFO] [stderr] 14 | ] = &[
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/commands/mod.rs:13:7
[INFO] [stderr]    |
[INFO] [stderr] 13 |     (&'static str, &'static str, &'static str, Command)
[INFO] [stderr]    |      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/commands/mod.rs:13:21
[INFO] [stderr]    |
[INFO] [stderr] 13 |     (&'static str, &'static str, &'static str, Command)
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/commands/mod.rs:13:35
[INFO] [stderr]    |
[INFO] [stderr] 13 |     (&'static str, &'static str, &'static str, Command)
[INFO] [stderr]    |                                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/fat/image.rs:185:13
[INFO] [stderr]     |
[INFO] [stderr] 185 |         let mut target_slice = &mut self.data_area[
[INFO] [stderr]     |             ----^^^^^^^^^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> src/commands/add.rs:25:12
[INFO] [stderr]    |
[INFO] [stderr] 25 |       if let Ok(_) = image.get_file_entry(file_name.clone()) {
[INFO] [stderr]    |  _____-      ^^^^^
[INFO] [stderr] 26 | |         return Err(errorf!("file {} already exists", file_name));
[INFO] [stderr] 27 | |     }
[INFO] [stderr]    | |_____- help: try this: `if image.get_file_entry(file_name.clone()).is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/commands/mod.rs:20:26
[INFO] [stderr]    |
[INFO] [stderr] 20 | pub fn get_command(name: &String) -> Option<Command> {
[INFO] [stderr]    |                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/fat/image.rs:151:27
[INFO] [stderr]     |
[INFO] [stderr] 151 |                         ((w[1] as u16 & 0xf) << 8) | w[0] as u16
[INFO] [stderr]     |                           ^^^^^^^^^^^ help: try: `u16::from(w[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/fat/image.rs:151:54
[INFO] [stderr]     |
[INFO] [stderr] 151 |                         ((w[1] as u16 & 0xf) << 8) | w[0] as u16
[INFO] [stderr]     |                                                      ^^^^^^^^^^^ help: try: `u16::from(w[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/fat/image.rs:153:26
[INFO] [stderr]     |
[INFO] [stderr] 153 |                         (w[1] as u16 & 0xf0) | ((w[1] as u16) << 4)
[INFO] [stderr]     |                          ^^^^^^^^^^^ help: try: `u16::from(w[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/fat/image.rs:153:49
[INFO] [stderr]     |
[INFO] [stderr] 153 |                         (w[1] as u16 & 0xf0) | ((w[1] as u16) << 4)
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^ help: try: `u16::from(w[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/fat/image.rs:163:27
[INFO] [stderr]     |
[INFO] [stderr] 163 |         let byte_1: u16 = self.fat_1[offset] as u16;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.fat_1[offset])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/fat/image.rs:164:27
[INFO] [stderr]     |
[INFO] [stderr] 164 |         let byte_2: u16 = self.fat_1[offset + 1] as u16;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.fat_1[offset + 1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/fat/root_entry.rs:25:25
[INFO] [stderr]    |
[INFO] [stderr] 25 |             filename:  [' ' as u8; 8],
[INFO] [stderr]    |                         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b' '
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/fat/root_entry.rs:26:25
[INFO] [stderr]    |
[INFO] [stderr] 26 |             extension: [' ' as u8; 3],
[INFO] [stderr]    |                         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b' '
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/fat/root_entry.rs:44:35
[INFO] [stderr]    |
[INFO] [stderr] 44 |             .take_while(|&c| c != ' ' as u8)
[INFO] [stderr]    |                                   ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b' '
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/fat/root_entry.rs:46:19
[INFO] [stderr]    |
[INFO] [stderr] 46 |         name.push('.' as u8);
[INFO] [stderr]    |                   ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'.'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/fat/root_entry.rs:127:34
[INFO] [stderr]     |
[INFO] [stderr] 127 |                 &self.filename().unwrap_or("bad filename".to_string())
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "bad filename".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/main.rs:27:12
[INFO] [stderr]    |
[INFO] [stderr] 27 |       if let None = cmd_func_opt {
[INFO] [stderr]    |  _____-      ^^^^
[INFO] [stderr] 28 | |         error(errorf!("command \"{}\" not recognized", command));
[INFO] [stderr] 29 | |     }
[INFO] [stderr]    | |_____- help: try this: `if cmd_func_opt.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/fat/image.rs:185:13
[INFO] [stderr]     |
[INFO] [stderr] 185 |         let mut target_slice = &mut self.data_area[
[INFO] [stderr]     |             ----^^^^^^^^^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]   --> src/commands/add.rs:25:12
[INFO] [stderr]    |
[INFO] [stderr] 25 |       if let Ok(_) = image.get_file_entry(file_name.clone()) {
[INFO] [stderr]    |  _____-      ^^^^^
[INFO] [stderr] 26 | |         return Err(errorf!("file {} already exists", file_name));
[INFO] [stderr] 27 | |     }
[INFO] [stderr]    | |_____- help: try this: `if image.get_file_entry(file_name.clone()).is_ok()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/commands/mod.rs:20:26
[INFO] [stderr]    |
[INFO] [stderr] 20 | pub fn get_command(name: &String) -> Option<Command> {
[INFO] [stderr]    |                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/fat/image.rs:151:27
[INFO] [stderr]     |
[INFO] [stderr] 151 |                         ((w[1] as u16 & 0xf) << 8) | w[0] as u16
[INFO] [stderr]     |                           ^^^^^^^^^^^ help: try: `u16::from(w[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/fat/image.rs:151:54
[INFO] [stderr]     |
[INFO] [stderr] 151 |                         ((w[1] as u16 & 0xf) << 8) | w[0] as u16
[INFO] [stderr]     |                                                      ^^^^^^^^^^^ help: try: `u16::from(w[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/fat/image.rs:153:26
[INFO] [stderr]     |
[INFO] [stderr] 153 |                         (w[1] as u16 & 0xf0) | ((w[1] as u16) << 4)
[INFO] [stderr]     |                          ^^^^^^^^^^^ help: try: `u16::from(w[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/fat/image.rs:153:49
[INFO] [stderr]     |
[INFO] [stderr] 153 |                         (w[1] as u16 & 0xf0) | ((w[1] as u16) << 4)
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^ help: try: `u16::from(w[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/fat/image.rs:163:27
[INFO] [stderr]     |
[INFO] [stderr] 163 |         let byte_1: u16 = self.fat_1[offset] as u16;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.fat_1[offset])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/fat/image.rs:164:27
[INFO] [stderr]     |
[INFO] [stderr] 164 |         let byte_2: u16 = self.fat_1[offset + 1] as u16;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.fat_1[offset + 1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/fat/root_entry.rs:25:25
[INFO] [stderr]    |
[INFO] [stderr] 25 |             filename:  [' ' as u8; 8],
[INFO] [stderr]    |                         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b' '
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/fat/root_entry.rs:26:25
[INFO] [stderr]    |
[INFO] [stderr] 26 |             extension: [' ' as u8; 3],
[INFO] [stderr]    |                         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b' '
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/fat/root_entry.rs:44:35
[INFO] [stderr]    |
[INFO] [stderr] 44 |             .take_while(|&c| c != ' ' as u8)
[INFO] [stderr]    |                                   ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b' '
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/fat/root_entry.rs:46:19
[INFO] [stderr]    |
[INFO] [stderr] 46 |         name.push('.' as u8);
[INFO] [stderr]    |                   ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'.'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/fat/root_entry.rs:127:34
[INFO] [stderr]     |
[INFO] [stderr] 127 |                 &self.filename().unwrap_or("bad filename".to_string())
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "bad filename".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/main.rs:27:12
[INFO] [stderr]    |
[INFO] [stderr] 27 |       if let None = cmd_func_opt {
[INFO] [stderr]    |  _____-      ^^^^
[INFO] [stderr] 28 | |         error(errorf!("command \"{}\" not recognized", command));
[INFO] [stderr] 29 | |     }
[INFO] [stderr]    | |_____- help: try this: `if cmd_func_opt.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.12s
[INFO] running `"docker" "inspect" "ccecf0084bb293c44a447c05fb84183024bd4f3c84ea34c04567f3f519795406"`
[INFO] running `"docker" "rm" "-f" "ccecf0084bb293c44a447c05fb84183024bd4f3c84ea34c04567f3f519795406"`
[INFO] [stdout] ccecf0084bb293c44a447c05fb84183024bd4f3c84ea34c04567f3f519795406