[INFO] crate fat 0.0.2 is already in cache [INFO] extracting crate fat 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/fat/0.0.2 [INFO] extracting crate fat 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fat/0.0.2 [INFO] validating manifest of fat-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fat-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fat-0.0.2 [INFO] finished frobbing fat-0.0.2 [INFO] frobbed toml for fat-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/fat/0.0.2/Cargo.toml [INFO] started frobbing fat-0.0.2 [INFO] finished frobbing fat-0.0.2 [INFO] frobbed toml for fat-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fat/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fat-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fat/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c2c84b7096abe101a31dee8bd05cc19f6914de0d702c8ce87902dfce2cf41337 [INFO] running `"docker" "start" "-a" "c2c84b7096abe101a31dee8bd05cc19f6914de0d702c8ce87902dfce2cf41337"` [INFO] [stderr] Checking fat v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `fetch_unicode_string` [INFO] [stderr] --> src/util.rs:83:1 [INFO] [stderr] | [INFO] [stderr] 83 | / pub(crate) fn fetch_unicode_string( [INFO] [stderr] 84 | | content: &[u8], [INFO] [stderr] 85 | | offset: usize, [INFO] [stderr] 86 | | max_length: usize, [INFO] [stderr] ... | [INFO] [stderr] 97 | | s [INFO] [stderr] 98 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BRS` [INFO] [stderr] --> src/constants.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub(crate) const BRS: [u8; 2] = [0x55, 0xAA]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 26 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 39 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:40:23 [INFO] [stderr] | [INFO] [stderr] 40 | result += (buf[i] as u16) * 256u16.pow(p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:52:23 [INFO] [stderr] | [INFO] [stderr] 52 | result += (buf[i] as u32) * 256u32.pow(p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 63 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:64:23 [INFO] [stderr] | [INFO] [stderr] 64 | result += (buf[i] as i32) * 256i32.pow(p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 75 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | result += (buf[i] as u64) * 256u64.pow(p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/analyzer.rs:71:8 [INFO] [stderr] | [INFO] [stderr] 71 | if (bs.jmp[0x00] == 0xEB && bs.jmp[0x02] != 0x90) [INFO] [stderr] | ________^ [INFO] [stderr] 72 | | || (bs.jmp[0x00] != 0xEB && bs.jmp[0x00] != 0xE9) { [INFO] [stderr] | |_______________________________________________________^ help: try: `bs.jmp[0x00] == 0xEB && bs.jmp[0x02] != 0x90 || bs.jmp[0x00] != 0xEB && bs.jmp[0x00] != 0xE9` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: function is never used: `fetch_unicode_string` [INFO] [stderr] --> src/util.rs:83:1 [INFO] [stderr] | [INFO] [stderr] 83 | / pub(crate) fn fetch_unicode_string( [INFO] [stderr] 84 | | content: &[u8], [INFO] [stderr] 85 | | offset: usize, [INFO] [stderr] 86 | | max_length: usize, [INFO] [stderr] ... | [INFO] [stderr] 97 | | s [INFO] [stderr] 98 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BRS` [INFO] [stderr] --> src/constants.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub(crate) const BRS: [u8; 2] = [0x55, 0xAA]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 26 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 39 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:40:23 [INFO] [stderr] | [INFO] [stderr] 40 | result += (buf[i] as u16) * 256u16.pow(p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:52:23 [INFO] [stderr] | [INFO] [stderr] 52 | result += (buf[i] as u32) * 256u32.pow(p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 63 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:64:23 [INFO] [stderr] | [INFO] [stderr] 64 | result += (buf[i] as i32) * 256i32.pow(p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/util.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 75 | for in &buf { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `p` is used as a loop counter. Consider using `for (p, item) in 0..buf.len().enumerate()` or similar iterators [INFO] [stderr] --> src/util.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | for i in 0..buf.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:76:23 [INFO] [stderr] | [INFO] [stderr] 76 | result += (buf[i] as u64) * 256u64.pow(p); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/analyzer.rs:71:8 [INFO] [stderr] | [INFO] [stderr] 71 | if (bs.jmp[0x00] == 0xEB && bs.jmp[0x02] != 0x90) [INFO] [stderr] | ________^ [INFO] [stderr] 72 | | || (bs.jmp[0x00] != 0xEB && bs.jmp[0x00] != 0xE9) { [INFO] [stderr] | |_______________________________________________________^ help: try: `bs.jmp[0x00] == 0xEB && bs.jmp[0x02] != 0x90 || bs.jmp[0x00] != 0xEB && bs.jmp[0x00] != 0xE9` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.06s [INFO] running `"docker" "inspect" "c2c84b7096abe101a31dee8bd05cc19f6914de0d702c8ce87902dfce2cf41337"` [INFO] running `"docker" "rm" "-f" "c2c84b7096abe101a31dee8bd05cc19f6914de0d702c8ce87902dfce2cf41337"` [INFO] [stdout] c2c84b7096abe101a31dee8bd05cc19f6914de0d702c8ce87902dfce2cf41337