[INFO] crate fastping-rs 0.1.1 is already in cache [INFO] extracting crate fastping-rs 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/fastping-rs/0.1.1 [INFO] extracting crate fastping-rs 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fastping-rs/0.1.1 [INFO] validating manifest of fastping-rs-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fastping-rs-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fastping-rs-0.1.1 [INFO] finished frobbing fastping-rs-0.1.1 [INFO] frobbed toml for fastping-rs-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/fastping-rs/0.1.1/Cargo.toml [INFO] started frobbing fastping-rs-0.1.1 [INFO] finished frobbing fastping-rs-0.1.1 [INFO] frobbed toml for fastping-rs-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fastping-rs/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fastping-rs-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fastping-rs/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0b684eae89efed24239ec61ea140847f255707ccb250ac3b3541bf5b56220359 [INFO] running `"docker" "start" "-a" "0b684eae89efed24239ec61ea140847f255707ccb250ac3b3541bf5b56220359"` [INFO] [stderr] Checking fastping-rs v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | thread_tx: thread_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_tx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:206:66 [INFO] [stderr] | [INFO] [stderr] 206 | match thread_tx.send(PingResult::Receive{addr: addr, rtt: Instant::now().duration_since(*start_time)}) { [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:231:68 [INFO] [stderr] | [INFO] [stderr] 231 | match thread_txv6.send(PingResult::Receive{addr: addr, rtt: Instant::now().duration_since(*start_time)}) { [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | thread_tx: thread_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_tx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:206:66 [INFO] [stderr] | [INFO] [stderr] 206 | match thread_tx.send(PingResult::Receive{addr: addr, rtt: Instant::now().duration_since(*start_time)}) { [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:231:68 [INFO] [stderr] | [INFO] [stderr] 231 | match thread_txv6.send(PingResult::Receive{addr: addr, rtt: Instant::now().duration_since(*start_time)}) { [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ping.rs:85:53 [INFO] [stderr] | [INFO] [stderr] 85 | PingResult::Receive{addr, rtt: _} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Receive { addr, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ping.rs:85:53 [INFO] [stderr] | [INFO] [stderr] 85 | PingResult::Receive{addr, rtt: _} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Receive { addr, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:336:59 [INFO] [stderr] | [INFO] [stderr] 336 | PingResult::Receive{addr, rtt: _} => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Receive { addr, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/ping.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn send_pings(timer: Arc>, [INFO] [stderr] 59 | | stop: Arc>, [INFO] [stderr] 60 | | results_sender: Sender, [INFO] [stderr] 61 | | thread_rx: Arc>>, [INFO] [stderr] ... | [INFO] [stderr] 126 | | } [INFO] [stderr] 127 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ping.rs:84:23 [INFO] [stderr] | [INFO] [stderr] 84 | / match result { [INFO] [stderr] 85 | | PingResult::Receive{addr, rtt: _} => { [INFO] [stderr] 86 | | // Update the address to the ping response being received [INFO] [stderr] 87 | | if let Some(seen) = addrs.lock().unwrap().get_mut(&addr) { [INFO] [stderr] ... | [INFO] [stderr] 98 | | _ => {} [INFO] [stderr] 99 | | } [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let PingResult::Receive{addr, rtt: _} = result { [INFO] [stderr] 85 | // Update the address to the ping response being received [INFO] [stderr] 86 | if let Some(seen) = addrs.lock().unwrap().get_mut(&addr) { [INFO] [stderr] 87 | *seen = true; [INFO] [stderr] 88 | } [INFO] [stderr] 89 | // Send the ping result over the client channel [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/ping.rs:112:18 [INFO] [stderr] | [INFO] [stderr] 112 | if *seen == false { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `!(*seen)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:105:28 [INFO] [stderr] | [INFO] [stderr] 105 | stop: Arc::new(Mutex::new(false)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/ping.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | / pub fn send_pings(timer: Arc>, [INFO] [stderr] 59 | | stop: Arc>, [INFO] [stderr] 60 | | results_sender: Sender, [INFO] [stderr] 61 | | thread_rx: Arc>>, [INFO] [stderr] ... | [INFO] [stderr] 126 | | } [INFO] [stderr] 127 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ping.rs:84:23 [INFO] [stderr] | [INFO] [stderr] 84 | / match result { [INFO] [stderr] 85 | | PingResult::Receive{addr, rtt: _} => { [INFO] [stderr] 86 | | // Update the address to the ping response being received [INFO] [stderr] 87 | | if let Some(seen) = addrs.lock().unwrap().get_mut(&addr) { [INFO] [stderr] ... | [INFO] [stderr] 98 | | _ => {} [INFO] [stderr] 99 | | } [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 84 | if let PingResult::Receive{addr, rtt: _} = result { [INFO] [stderr] 85 | // Update the address to the ping response being received [INFO] [stderr] 86 | if let Some(seen) = addrs.lock().unwrap().get_mut(&addr) { [INFO] [stderr] 87 | *seen = true; [INFO] [stderr] 88 | } [INFO] [stderr] 89 | // Send the ping result over the client channel [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/ping.rs:112:18 [INFO] [stderr] | [INFO] [stderr] 112 | if *seen == false { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `!(*seen)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:105:28 [INFO] [stderr] | [INFO] [stderr] 105 | stop: Arc::new(Mutex::new(false)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:265:33 [INFO] [stderr] | [INFO] [stderr] 265 | / match result { [INFO] [stderr] 266 | | PingResult::Idle{addr} => { [INFO] [stderr] 267 | | assert_eq!(addr, "127.0.0.1".parse::().unwrap()); [INFO] [stderr] 268 | | }, [INFO] [stderr] 269 | | _ => {} [INFO] [stderr] 270 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 265 | if let PingResult::Idle{addr} = result { [INFO] [stderr] 266 | assert_eq!(addr, "127.0.0.1".parse::().unwrap()); [INFO] [stderr] 267 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.04s [INFO] running `"docker" "inspect" "0b684eae89efed24239ec61ea140847f255707ccb250ac3b3541bf5b56220359"` [INFO] running `"docker" "rm" "-f" "0b684eae89efed24239ec61ea140847f255707ccb250ac3b3541bf5b56220359"` [INFO] [stdout] 0b684eae89efed24239ec61ea140847f255707ccb250ac3b3541bf5b56220359