[INFO] crate faster_path 0.0.2 is already in cache [INFO] extracting crate faster_path 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/faster_path/0.0.2 [INFO] extracting crate faster_path 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/faster_path/0.0.2 [INFO] validating manifest of faster_path-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of faster_path-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing faster_path-0.0.2 [INFO] finished frobbing faster_path-0.0.2 [INFO] frobbed toml for faster_path-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/faster_path/0.0.2/Cargo.toml [INFO] started frobbing faster_path-0.0.2 [INFO] finished frobbing faster_path-0.0.2 [INFO] frobbed toml for faster_path-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/faster_path/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting faster_path-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/faster_path/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 49da76fdc4816d6449b2c99502446ccda2303704c729836f4cef6f7ee171d76a [INFO] running `"docker" "start" "-a" "49da76fdc4816d6449b2c99502446ccda2303704c729836f4cef6f7ee171d76a"` [INFO] [stderr] Checking faster_path v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dirname.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return CString::new(&r_str[..(non_sep_i2 + 1) as usize]).unwrap().into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CString::new(&r_str[..(non_sep_i2 + 1) as usize]).unwrap().into_raw()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dirname.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return CString::new(MAIN_SEPARATOR.to_string()).unwrap().into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CString::new(MAIN_SEPARATOR.to_string()).unwrap().into_raw()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dirname.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return CString::new(&r_str[..(non_sep_i2 + 1) as usize]).unwrap().into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CString::new(&r_str[..(non_sep_i2 + 1) as usize]).unwrap().into_raw()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dirname.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return CString::new(MAIN_SEPARATOR.to_string()).unwrap().into_raw(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CString::new(MAIN_SEPARATOR.to_string()).unwrap().into_raw()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/ruby_string.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | fn to_ruby>(s: S) -> *const c_char { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/is_absolute.rs:11:39 [INFO] [stderr] | [INFO] [stderr] 11 | let r_str = unsafe { CStr::from_ptr(path) }.to_str().unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/is_directory.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | CStr::from_ptr(string) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/is_relative.rs:10:39 [INFO] [stderr] | [INFO] [stderr] 10 | let r_str = unsafe { CStr::from_ptr(path) }.to_str().unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/is_blank.rs:11:20 [INFO] [stderr] | [INFO] [stderr] 11 | CStr::from_ptr(string) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/both_are_blank.rs:11:20 [INFO] [stderr] | [INFO] [stderr] 11 | CStr::from_ptr(s1) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/both_are_blank.rs:17:20 [INFO] [stderr] | [INFO] [stderr] 17 | CStr::from_ptr(s2) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/basename.rs:12:37 [INFO] [stderr] | [INFO] [stderr] 12 | let pth = unsafe { CStr::from_ptr(c_pth) }.to_str().unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/basename.rs:13:37 [INFO] [stderr] | [INFO] [stderr] 13 | let ext = unsafe { CStr::from_ptr(c_ext) }.to_str().unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/dirname.rs:11:39 [INFO] [stderr] | [INFO] [stderr] 11 | let r_str = unsafe { CStr::from_ptr(path) }.to_str().unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/basename_for_chop.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | CStr::from_ptr(string) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/basename_for_chop.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | / loop { [INFO] [stderr] 20 | | match trailing_slashes.next() { [INFO] [stderr] 21 | | Some(MAIN_SEPARATOR) => { offset = offset + 1 }, [INFO] [stderr] 22 | | _ => { break }, [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |___^ help: try: `while let Some(MAIN_SEPARATOR) = trailing_slashes.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/basename_for_chop.rs:21:33 [INFO] [stderr] | [INFO] [stderr] 21 | Some(MAIN_SEPARATOR) => { offset = offset + 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/dirname_for_chop.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | CStr::from_ptr(string) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/dirname_for_chop.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | / loop { [INFO] [stderr] 24 | | match trailing_slashes.next() { [INFO] [stderr] 25 | | Some(MAIN_SEPARATOR) => { offset = offset + 1 }, [INFO] [stderr] 26 | | _ => { break }, [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |___^ help: try: `while let Some(MAIN_SEPARATOR) = trailing_slashes.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/dirname_for_chop.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | Some(MAIN_SEPARATOR) => { offset = offset + 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/add_trailing_separator.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | let out_str = if !(path.to_str().unwrap().chars().last().unwrap() == '/') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `path.to_str().unwrap().chars().last().unwrap() != '/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/add_trailing_separator.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | CStr::from_ptr(string) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/add_trailing_separator.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | let out_str = if !(path.to_str().unwrap().chars().last().unwrap() == '/') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `path.to_str().unwrap().ends_with('/')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/has_trailing_separator.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | CStr::from_ptr(string) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/extname.rs:11:64 [INFO] [stderr] | [INFO] [stderr] 11 | let name = extract_last_path_segment(unsafe { CStr::from_ptr(c_pth) }.to_str().unwrap()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/entries.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | CStr::from_ptr(string) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/ruby_string.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | fn to_ruby>(s: S) -> *const c_char { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/is_absolute.rs:11:39 [INFO] [stderr] | [INFO] [stderr] 11 | let r_str = unsafe { CStr::from_ptr(path) }.to_str().unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/is_directory.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | CStr::from_ptr(string) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/is_relative.rs:10:39 [INFO] [stderr] | [INFO] [stderr] 10 | let r_str = unsafe { CStr::from_ptr(path) }.to_str().unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/is_blank.rs:11:20 [INFO] [stderr] | [INFO] [stderr] 11 | CStr::from_ptr(string) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/both_are_blank.rs:11:20 [INFO] [stderr] | [INFO] [stderr] 11 | CStr::from_ptr(s1) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/both_are_blank.rs:17:20 [INFO] [stderr] | [INFO] [stderr] 17 | CStr::from_ptr(s2) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 15 previous errors [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/basename.rs:12:37 [INFO] [stderr] | [INFO] [stderr] 12 | let pth = unsafe { CStr::from_ptr(c_pth) }.to_str().unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/basename.rs:13:37 [INFO] [stderr] | [INFO] [stderr] 13 | let ext = unsafe { CStr::from_ptr(c_ext) }.to_str().unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/dirname.rs:11:39 [INFO] [stderr] | [INFO] [stderr] 11 | let r_str = unsafe { CStr::from_ptr(path) }.to_str().unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/basename_for_chop.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | CStr::from_ptr(string) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/basename_for_chop.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | / loop { [INFO] [stderr] 20 | | match trailing_slashes.next() { [INFO] [stderr] 21 | | Some(MAIN_SEPARATOR) => { offset = offset + 1 }, [INFO] [stderr] 22 | | _ => { break }, [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |___^ help: try: `while let Some(MAIN_SEPARATOR) = trailing_slashes.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/basename_for_chop.rs:21:33 [INFO] [stderr] | [INFO] [stderr] 21 | Some(MAIN_SEPARATOR) => { offset = offset + 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/dirname_for_chop.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | CStr::from_ptr(string) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: Could not compile `faster_path`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/dirname_for_chop.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | / loop { [INFO] [stderr] 24 | | match trailing_slashes.next() { [INFO] [stderr] 25 | | Some(MAIN_SEPARATOR) => { offset = offset + 1 }, [INFO] [stderr] 26 | | _ => { break }, [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |___^ help: try: `while let Some(MAIN_SEPARATOR) = trailing_slashes.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/dirname_for_chop.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | Some(MAIN_SEPARATOR) => { offset = offset + 1 }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/add_trailing_separator.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | let out_str = if !(path.to_str().unwrap().chars().last().unwrap() == '/') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `path.to_str().unwrap().chars().last().unwrap() != '/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/add_trailing_separator.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | CStr::from_ptr(string) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/add_trailing_separator.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | let out_str = if !(path.to_str().unwrap().chars().last().unwrap() == '/') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `path.to_str().unwrap().ends_with('/')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/has_trailing_separator.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | CStr::from_ptr(string) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/extname.rs:11:64 [INFO] [stderr] | [INFO] [stderr] 11 | let name = extract_last_path_segment(unsafe { CStr::from_ptr(c_pth) }.to_str().unwrap()); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/entries.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | CStr::from_ptr(string) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 15 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `faster_path`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "49da76fdc4816d6449b2c99502446ccda2303704c729836f4cef6f7ee171d76a"` [INFO] running `"docker" "rm" "-f" "49da76fdc4816d6449b2c99502446ccda2303704c729836f4cef6f7ee171d76a"` [INFO] [stdout] 49da76fdc4816d6449b2c99502446ccda2303704c729836f4cef6f7ee171d76a