[INFO] crate farbfeld 0.3.1 is already in cache [INFO] extracting crate farbfeld 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/farbfeld/0.3.1 [INFO] extracting crate farbfeld 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/farbfeld/0.3.1 [INFO] validating manifest of farbfeld-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of farbfeld-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing farbfeld-0.3.1 [INFO] finished frobbing farbfeld-0.3.1 [INFO] frobbed toml for farbfeld-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/farbfeld/0.3.1/Cargo.toml [INFO] started frobbing farbfeld-0.3.1 [INFO] finished frobbing farbfeld-0.3.1 [INFO] frobbed toml for farbfeld-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/farbfeld/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting farbfeld-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/farbfeld/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19baf08d7a69a8a5ed4ce0ad5f1c9b26e1c13ff02fe621e67c509eb3e3ed2637 [INFO] running `"docker" "start" "-a" "19baf08d7a69a8a5ed4ce0ad5f1c9b26e1c13ff02fe621e67c509eb3e3ed2637"` [INFO] [stderr] Checking farbfeld v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | r: r, [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | r: r, [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:50:35 [INFO] [stderr] | [INFO] [stderr] 50 | let offset = HEADER_LEN + row as u64 * row_len as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(row)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / match self { [INFO] [stderr] 49 | | &Error::FormatError(ref e) => write!(fmt, "Format error: {}", e), [INFO] [stderr] 50 | | &Error::NotEnoughData => write!(fmt, "Not enough data was provided to the \ [INFO] [stderr] 51 | | Decoder to decode the image"), [INFO] [stderr] 52 | | &Error::IoError(ref e) => e.fmt(fmt), [INFO] [stderr] 53 | | &Error::ImageEnd => write!(fmt, "The end of the image has been reached") [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *self { [INFO] [stderr] 49 | Error::FormatError(ref e) => write!(fmt, "Format error: {}", e), [INFO] [stderr] 50 | Error::NotEnoughData => write!(fmt, "Not enough data was provided to the \ [INFO] [stderr] 51 | Decoder to decode the image"), [INFO] [stderr] 52 | Error::IoError(ref e) => e.fmt(fmt), [INFO] [stderr] 53 | Error::ImageEnd => write!(fmt, "The end of the image has been reached") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | pub const IMAGE_DATA: &'static [u8] = [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:50:35 [INFO] [stderr] | [INFO] [stderr] 50 | let offset = HEADER_LEN + row as u64 * row_len as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(row)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/decoder.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | img_data.write(b"test fail").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/decoder.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | img_data.write(&IMAGE_DATA[8..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / match self { [INFO] [stderr] 49 | | &Error::FormatError(ref e) => write!(fmt, "Format error: {}", e), [INFO] [stderr] 50 | | &Error::NotEnoughData => write!(fmt, "Not enough data was provided to the \ [INFO] [stderr] 51 | | Decoder to decode the image"), [INFO] [stderr] 52 | | &Error::IoError(ref e) => e.fmt(fmt), [INFO] [stderr] 53 | | &Error::ImageEnd => write!(fmt, "The end of the image has been reached") [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *self { [INFO] [stderr] 49 | Error::FormatError(ref e) => write!(fmt, "Format error: {}", e), [INFO] [stderr] 50 | Error::NotEnoughData => write!(fmt, "Not enough data was provided to the \ [INFO] [stderr] 51 | Decoder to decode the image"), [INFO] [stderr] 52 | Error::IoError(ref e) => e.fmt(fmt), [INFO] [stderr] 53 | Error::ImageEnd => write!(fmt, "The end of the image has been reached") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `farbfeld`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "19baf08d7a69a8a5ed4ce0ad5f1c9b26e1c13ff02fe621e67c509eb3e3ed2637"` [INFO] running `"docker" "rm" "-f" "19baf08d7a69a8a5ed4ce0ad5f1c9b26e1c13ff02fe621e67c509eb3e3ed2637"` [INFO] [stdout] 19baf08d7a69a8a5ed4ce0ad5f1c9b26e1c13ff02fe621e67c509eb3e3ed2637