[INFO] crate fanta 0.2.0 is already in cache [INFO] extracting crate fanta 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/fanta/0.2.0 [INFO] extracting crate fanta 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fanta/0.2.0 [INFO] validating manifest of fanta-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fanta-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fanta-0.2.0 [INFO] finished frobbing fanta-0.2.0 [INFO] frobbed toml for fanta-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/fanta/0.2.0/Cargo.toml [INFO] started frobbing fanta-0.2.0 [INFO] finished frobbing fanta-0.2.0 [INFO] frobbed toml for fanta-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fanta/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fanta-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fanta/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a701fd0b7caff98ac85538194c9a2561824d4bcff0a403f900c6bd6871752b9e [INFO] running `"docker" "start" "-a" "a701fd0b7caff98ac85538194c9a2561824d4bcff0a403f900c6bd6871752b9e"` [INFO] [stderr] Checking templatify v0.1.0 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking fanta v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/middleware.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | middleware: middleware, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `middleware` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/route_parser.rs:174:7 [INFO] [stderr] | [INFO] [stderr] 174 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/middleware.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | middleware: middleware, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `middleware` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/request.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | body: body, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/route_parser.rs:174:7 [INFO] [stderr] | [INFO] [stderr] 174 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/route_parser.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | parser [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/route_parser.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | let parser = RouteParser { [INFO] [stderr] | __________________^ [INFO] [stderr] 34 | | _method_agnostic_middleware: HashMap::new(), [INFO] [stderr] 35 | | _wildcarded_method_agnostic_middleware: HashMap::new(), [INFO] [stderr] 36 | | _not_found_route: vec![], [INFO] [stderr] ... | [INFO] [stderr] 39 | | sub_apps: HashMap::new(), [INFO] [stderr] 40 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/http.rs:2:41 [INFO] [stderr] | [INFO] [stderr] 2 | use tokio_io::codec::{Encoder, Decoder, Framed}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/http.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | type Transport = Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/http.rs:15:37 [INFO] [stderr] | [INFO] [stderr] 15 | type BindTransport = io::Result>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/http.rs:17:51 [INFO] [stderr] | [INFO] [stderr] 17 | fn bind_transport(&self, io: T) -> io::Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/http.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(io.framed(HttpCodec)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/app.rs:48:10 [INFO] [stderr] | [INFO] [stderr] 48 | if stripped_prefix.len() > 0 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stripped_prefix.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/app.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | (&cap[2]).len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!(&cap[2]).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/app.rs:60:40 [INFO] [stderr] | [INFO] [stderr] 60 | let mut split_iterator = route.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/app.rs:70:47 [INFO] [stderr] | [INFO] [stderr] 70 | match app._route_parser.middleware.get(&templatify! { ""; &accumulator ;"/*" }) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/app.rs:71:36 [INFO] [stderr] | [INFO] [stderr] 71 | Some(val) => accumulator = templatify! { ""; &accumulator ;"/:"; &val.param_name ;"" }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/app.rs:72:31 [INFO] [stderr] | [INFO] [stderr] 72 | None => accumulator = templatify! { ""; &accumulator ;"/*" } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/app.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | accumulator = templatify! { ""; &accumulator ;"/"; piece ;"" }; // Test vs. a join [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/app.rs:107:3 [INFO] [stderr] | [INFO] [stderr] 107 | / pub fn new() -> App { [INFO] [stderr] 108 | | App { [INFO] [stderr] 109 | | _route_parser: RouteParser::new(), [INFO] [stderr] 110 | | context_generator: generate_context [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `context::BasicContext` [INFO] [stderr] --> src/context.rs:15:3 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> BasicContext { [INFO] [stderr] 16 | | BasicContext { [INFO] [stderr] 17 | | body: "".to_owned(), [INFO] [stderr] 18 | | params: HashMap::new() [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `response::Response` [INFO] [stderr] --> src/response.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Response { [INFO] [stderr] 18 | | Response { [INFO] [stderr] 19 | | headers: Vec::new(), [INFO] [stderr] 20 | | response: String::new(), [INFO] [stderr] 21 | | status_message: StatusMessage::Ok, [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for response::Response { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/response.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | push(buf, ": ".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b": "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `route_parser::RouteParser` [INFO] [stderr] --> src/route_parser.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> RouteParser { [INFO] [stderr] 33 | | let parser = RouteParser { [INFO] [stderr] 34 | | _method_agnostic_middleware: HashMap::new(), [INFO] [stderr] 35 | | _wildcarded_method_agnostic_middleware: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 42 | | parser [INFO] [stderr] 43 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/route_parser.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | let _route = strip_leading_slash(route).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 68 | let _route = &(*strip_leading_slash(route)).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 68 | let _route = &str::clone(strip_leading_slash(route)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:70:49 [INFO] [stderr] | [INFO] [stderr] 70 | _add_full_route(self, strip_trailing_slash(&templatify! { "/__DELETE__/"; _route ;"" }), middleware); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:71:49 [INFO] [stderr] | [INFO] [stderr] 71 | _add_full_route(self, strip_trailing_slash(&templatify! { "/__GET__/"; _route ;"" }), middleware); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:72:49 [INFO] [stderr] | [INFO] [stderr] 72 | _add_full_route(self, strip_trailing_slash(&templatify! { "/__POST__/"; _route ;"" }), middleware); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:73:49 [INFO] [stderr] | [INFO] [stderr] 73 | _add_full_route(self, strip_trailing_slash(&templatify! { "/__PUT__/"; _route ;"" }), middleware); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:74:49 [INFO] [stderr] | [INFO] [stderr] 74 | _add_full_route(self, strip_trailing_slash(&templatify! { "/__UPDATE__/"; _route ;"" }), middleware); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/route_parser.rs:84:42 [INFO] [stderr] | [INFO] [stderr] 84 | let mut split_iterator = route.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:95:23 [INFO] [stderr] | [INFO] [stderr] 95 | accumulator = templatify! { ""; &accumulator ;"/*" }; // Test vs. a join [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:102:23 [INFO] [stderr] | [INFO] [stderr] 102 | accumulator = templatify! { ""; &accumulator ;"/"; piece ;"" }; // Test vs. a join [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/route_parser.rs:131:42 [INFO] [stderr] | [INFO] [stderr] 131 | let mut split_iterator = route.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/route_parser.rs:145:7 [INFO] [stderr] | [INFO] [stderr] 145 | / match self.middleware.get(&templatify! { ""; &accumulator ;"/*" }) { [INFO] [stderr] 146 | | Some(hit) => { [INFO] [stderr] 147 | | for func in &hit.associated_middleware { [INFO] [stderr] 148 | | composed_middleware.push(*func); [INFO] [stderr] ... | [INFO] [stderr] 152 | | None => () [INFO] [stderr] 153 | | }; [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 145 | if let Some(hit) = self.middleware.get(&templatify! { ""; &accumulator ;"/*" }) { [INFO] [stderr] 146 | for func in &hit.associated_middleware { [INFO] [stderr] 147 | composed_middleware.push(*func); [INFO] [stderr] 148 | } [INFO] [stderr] 149 | params.insert((&hit.param_name).to_owned(), piece.to_owned()); [INFO] [stderr] 150 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:145:34 [INFO] [stderr] | [INFO] [stderr] 145 | match self.middleware.get(&templatify! { ""; &accumulator ;"/*" }) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:155:21 [INFO] [stderr] | [INFO] [stderr] 155 | accumulator = templatify! { ""; &accumulator ;"/"; piece ;"" }; // Test vs. a join [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/route_parser.rs:158:7 [INFO] [stderr] | [INFO] [stderr] 158 | / match self.middleware.get(&accumulator) { [INFO] [stderr] 159 | | Some(hit) => { [INFO] [stderr] 160 | | for func in &hit.associated_middleware { [INFO] [stderr] 161 | | composed_middleware.push(*func); [INFO] [stderr] ... | [INFO] [stderr] 164 | | None => () [INFO] [stderr] 165 | | }; [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 158 | if let Some(hit) = self.middleware.get(&accumulator) { [INFO] [stderr] 159 | for func in &hit.associated_middleware { [INFO] [stderr] 160 | composed_middleware.push(*func); [INFO] [stderr] 161 | } [INFO] [stderr] 162 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/route_parser.rs:168:8 [INFO] [stderr] | [INFO] [stderr] 168 | if composed_middleware.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `composed_middleware.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/util.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub fn strip_leading_slash<'a>(route: &'a str) -> &'a str { [INFO] [stderr] 2 | | match route.chars().nth(0) { [INFO] [stderr] 3 | | Some(val) => { [INFO] [stderr] 4 | | if val == '/' { [INFO] [stderr] ... | [INFO] [stderr] 11 | | } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/util.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn strip_trailing_slash<'a>(route: &'a str) -> &'a str { [INFO] [stderr] 15 | | if route.len() < 2 { [INFO] [stderr] 16 | | route [INFO] [stderr] 17 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `fanta`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/route_parser.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | parser [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/route_parser.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | let parser = RouteParser { [INFO] [stderr] | __________________^ [INFO] [stderr] 34 | | _method_agnostic_middleware: HashMap::new(), [INFO] [stderr] 35 | | _wildcarded_method_agnostic_middleware: HashMap::new(), [INFO] [stderr] 36 | | _not_found_route: vec![], [INFO] [stderr] ... | [INFO] [stderr] 39 | | sub_apps: HashMap::new(), [INFO] [stderr] 40 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/http.rs:2:41 [INFO] [stderr] | [INFO] [stderr] 2 | use tokio_io::codec::{Encoder, Decoder, Framed}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/http.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | type Transport = Framed; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/http.rs:15:37 [INFO] [stderr] | [INFO] [stderr] 15 | type BindTransport = io::Result>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec [INFO] [stderr] --> src/http.rs:17:51 [INFO] [stderr] | [INFO] [stderr] 17 | fn bind_transport(&self, io: T) -> io::Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead [INFO] [stderr] --> src/http.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(io.framed(HttpCodec)) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/app.rs:48:10 [INFO] [stderr] | [INFO] [stderr] 48 | if stripped_prefix.len() > 0 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stripped_prefix.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/app.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | (&cap[2]).len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!(&cap[2]).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/app.rs:60:40 [INFO] [stderr] | [INFO] [stderr] 60 | let mut split_iterator = route.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/app.rs:70:47 [INFO] [stderr] | [INFO] [stderr] 70 | match app._route_parser.middleware.get(&templatify! { ""; &accumulator ;"/*" }) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/app.rs:71:36 [INFO] [stderr] | [INFO] [stderr] 71 | Some(val) => accumulator = templatify! { ""; &accumulator ;"/:"; &val.param_name ;"" }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/app.rs:72:31 [INFO] [stderr] | [INFO] [stderr] 72 | None => accumulator = templatify! { ""; &accumulator ;"/*" } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/app.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | accumulator = templatify! { ""; &accumulator ;"/"; piece ;"" }; // Test vs. a join [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/app.rs:107:3 [INFO] [stderr] | [INFO] [stderr] 107 | / pub fn new() -> App { [INFO] [stderr] 108 | | App { [INFO] [stderr] 109 | | _route_parser: RouteParser::new(), [INFO] [stderr] 110 | | context_generator: generate_context [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/app.rs:337:15 [INFO] [stderr] | [INFO] [stderr] 337 | body: context.params.get("id").unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&context.params["id"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/app.rs:359:15 [INFO] [stderr] | [INFO] [stderr] 359 | body: context.params.get("id").unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&context.params["id"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `context::BasicContext` [INFO] [stderr] --> src/context.rs:15:3 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> BasicContext { [INFO] [stderr] 16 | | BasicContext { [INFO] [stderr] 17 | | body: "".to_owned(), [INFO] [stderr] 18 | | params: HashMap::new() [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `response::Response` [INFO] [stderr] --> src/response.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Response { [INFO] [stderr] 18 | | Response { [INFO] [stderr] 19 | | headers: Vec::new(), [INFO] [stderr] 20 | | response: String::new(), [INFO] [stderr] 21 | | status_message: StatusMessage::Ok, [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for response::Response { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/response.rs:58:19 [INFO] [stderr] | [INFO] [stderr] 58 | push(buf, ": ".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b": "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `route_parser::RouteParser` [INFO] [stderr] --> src/route_parser.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> RouteParser { [INFO] [stderr] 33 | | let parser = RouteParser { [INFO] [stderr] 34 | | _method_agnostic_middleware: HashMap::new(), [INFO] [stderr] 35 | | _wildcarded_method_agnostic_middleware: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 42 | | parser [INFO] [stderr] 43 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/route_parser.rs:68:18 [INFO] [stderr] | [INFO] [stderr] 68 | let _route = strip_leading_slash(route).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 68 | let _route = &(*strip_leading_slash(route)).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 68 | let _route = &str::clone(strip_leading_slash(route)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:70:49 [INFO] [stderr] | [INFO] [stderr] 70 | _add_full_route(self, strip_trailing_slash(&templatify! { "/__DELETE__/"; _route ;"" }), middleware); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:71:49 [INFO] [stderr] | [INFO] [stderr] 71 | _add_full_route(self, strip_trailing_slash(&templatify! { "/__GET__/"; _route ;"" }), middleware); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:72:49 [INFO] [stderr] | [INFO] [stderr] 72 | _add_full_route(self, strip_trailing_slash(&templatify! { "/__POST__/"; _route ;"" }), middleware); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:73:49 [INFO] [stderr] | [INFO] [stderr] 73 | _add_full_route(self, strip_trailing_slash(&templatify! { "/__PUT__/"; _route ;"" }), middleware); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:74:49 [INFO] [stderr] | [INFO] [stderr] 74 | _add_full_route(self, strip_trailing_slash(&templatify! { "/__UPDATE__/"; _route ;"" }), middleware); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/route_parser.rs:84:42 [INFO] [stderr] | [INFO] [stderr] 84 | let mut split_iterator = route.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:95:23 [INFO] [stderr] | [INFO] [stderr] 95 | accumulator = templatify! { ""; &accumulator ;"/*" }; // Test vs. a join [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:102:23 [INFO] [stderr] | [INFO] [stderr] 102 | accumulator = templatify! { ""; &accumulator ;"/"; piece ;"" }; // Test vs. a join [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/route_parser.rs:131:42 [INFO] [stderr] | [INFO] [stderr] 131 | let mut split_iterator = route.split("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/route_parser.rs:145:7 [INFO] [stderr] | [INFO] [stderr] 145 | / match self.middleware.get(&templatify! { ""; &accumulator ;"/*" }) { [INFO] [stderr] 146 | | Some(hit) => { [INFO] [stderr] 147 | | for func in &hit.associated_middleware { [INFO] [stderr] 148 | | composed_middleware.push(*func); [INFO] [stderr] ... | [INFO] [stderr] 152 | | None => () [INFO] [stderr] 153 | | }; [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 145 | if let Some(hit) = self.middleware.get(&templatify! { ""; &accumulator ;"/*" }) { [INFO] [stderr] 146 | for func in &hit.associated_middleware { [INFO] [stderr] 147 | composed_middleware.push(*func); [INFO] [stderr] 148 | } [INFO] [stderr] 149 | params.insert((&hit.param_name).to_owned(), piece.to_owned()); [INFO] [stderr] 150 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:145:34 [INFO] [stderr] | [INFO] [stderr] 145 | match self.middleware.get(&templatify! { ""; &accumulator ;"/*" }) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/route_parser.rs:155:21 [INFO] [stderr] | [INFO] [stderr] 155 | accumulator = templatify! { ""; &accumulator ;"/"; piece ;"" }; // Test vs. a join [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/route_parser.rs:158:7 [INFO] [stderr] | [INFO] [stderr] 158 | / match self.middleware.get(&accumulator) { [INFO] [stderr] 159 | | Some(hit) => { [INFO] [stderr] 160 | | for func in &hit.associated_middleware { [INFO] [stderr] 161 | | composed_middleware.push(*func); [INFO] [stderr] ... | [INFO] [stderr] 164 | | None => () [INFO] [stderr] 165 | | }; [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 158 | if let Some(hit) = self.middleware.get(&accumulator) { [INFO] [stderr] 159 | for func in &hit.associated_middleware { [INFO] [stderr] 160 | composed_middleware.push(*func); [INFO] [stderr] 161 | } [INFO] [stderr] 162 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/route_parser.rs:168:8 [INFO] [stderr] | [INFO] [stderr] 168 | if composed_middleware.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `composed_middleware.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/route_parser.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | assert!(matched.params.get("param").unwrap() == "somevar"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&matched.params["param"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/util.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub fn strip_leading_slash<'a>(route: &'a str) -> &'a str { [INFO] [stderr] 2 | | match route.chars().nth(0) { [INFO] [stderr] 3 | | Some(val) => { [INFO] [stderr] 4 | | if val == '/' { [INFO] [stderr] ... | [INFO] [stderr] 11 | | } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/util.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn strip_trailing_slash<'a>(route: &'a str) -> &'a str { [INFO] [stderr] 15 | | if route.len() < 2 { [INFO] [stderr] 16 | | route [INFO] [stderr] 17 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `fanta`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a701fd0b7caff98ac85538194c9a2561824d4bcff0a403f900c6bd6871752b9e"` [INFO] running `"docker" "rm" "-f" "a701fd0b7caff98ac85538194c9a2561824d4bcff0a403f900c6bd6871752b9e"` [INFO] [stdout] a701fd0b7caff98ac85538194c9a2561824d4bcff0a403f900c6bd6871752b9e