[INFO] crate fake 1.2.2 is already in cache [INFO] extracting crate fake 1.2.2 into work/ex/clippy-test-run/sources/stable/reg/fake/1.2.2 [INFO] extracting crate fake 1.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fake/1.2.2 [INFO] validating manifest of fake-1.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fake-1.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fake-1.2.2 [INFO] finished frobbing fake-1.2.2 [INFO] frobbed toml for fake-1.2.2 written to work/ex/clippy-test-run/sources/stable/reg/fake/1.2.2/Cargo.toml [INFO] started frobbing fake-1.2.2 [INFO] finished frobbing fake-1.2.2 [INFO] frobbed toml for fake-1.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fake/1.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fake-1.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fake/1.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b5aee41e230217254c706de402bffbe960026646210e98bd6bb0e21bf7287981 [INFO] running `"docker" "start" "-a" "b5aee41e230217254c706de402bffbe960026646210e98bd6bb0e21bf7287981"` [INFO] [stderr] Checking fake v1.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/locales/en.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/locales/zh_tw.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/locales/en.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/locales/zh_tw.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/dummy.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match ::boolean() { [INFO] [stderr] 73 | | true => Some(T::dummy()), [INFO] [stderr] 74 | | false => None, [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if ::boolean() { Some(T::dummy()) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/dummy.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match ::boolean() { [INFO] [stderr] 73 | | true => Some(T::dummy()), [INFO] [stderr] 74 | | false => None, [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if ::boolean() { Some(T::dummy()) } else { None }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | .map(|v| $func(v)) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `$func` [INFO] [stderr] ... [INFO] [stderr] 92 | let data = fake!("{} - {} - {}", [Name.name | to_lowercase], [Number.number(10)], [expr fake!(Name.name).to_lowercase()]); [INFO] [stderr] | -------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | .map(|v| $func(v)) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `$func` [INFO] [stderr] ... [INFO] [stderr] 101 | let image_url = fake!(r#"http://{domain}.{domain_suffix}/user/{username}.png?size={size}x{size}"#, [INFO] [stderr] | _________________________- [INFO] [stderr] 102 | | [domain = Name.last_name | to_lowercase], [INFO] [stderr] 103 | | [domain_suffix = Internet.domain_suffix], [INFO] [stderr] 104 | | [username = Name.first_name | to_lowercase], [INFO] [stderr] 105 | | [size = expr [512, 256, 128][gen_range(0, 3)]] [INFO] [stderr] 106 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | .map(|v| $func(v)) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `$func` [INFO] [stderr] ... [INFO] [stderr] 101 | let image_url = fake!(r#"http://{domain}.{domain_suffix}/user/{username}.png?size={size}x{size}"#, [INFO] [stderr] | _________________________- [INFO] [stderr] 102 | | [domain = Name.last_name | to_lowercase], [INFO] [stderr] 103 | | [domain_suffix = Internet.domain_suffix], [INFO] [stderr] 104 | | [username = Name.first_name | to_lowercase], [INFO] [stderr] 105 | | [size = expr [512, 256, 128][gen_range(0, 3)]] [INFO] [stderr] 106 | | ); [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.29s [INFO] running `"docker" "inspect" "b5aee41e230217254c706de402bffbe960026646210e98bd6bb0e21bf7287981"` [INFO] running `"docker" "rm" "-f" "b5aee41e230217254c706de402bffbe960026646210e98bd6bb0e21bf7287981"` [INFO] [stdout] b5aee41e230217254c706de402bffbe960026646210e98bd6bb0e21bf7287981