[INFO] crate failure_derive 0.1.3 is already in cache [INFO] extracting crate failure_derive 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/failure_derive/0.1.3 [INFO] extracting crate failure_derive 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/failure_derive/0.1.3 [INFO] validating manifest of failure_derive-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of failure_derive-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing failure_derive-0.1.3 [INFO] finished frobbing failure_derive-0.1.3 [INFO] frobbed toml for failure_derive-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/failure_derive/0.1.3/Cargo.toml [INFO] started frobbing failure_derive-0.1.3 [INFO] finished frobbing failure_derive-0.1.3 [INFO] frobbed toml for failure_derive-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/failure_derive/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting failure_derive-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/failure_derive/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d4c21900371d71bca12cafd60a4e8bf070943429877472db4f5bbe3dcf102782 [INFO] running `"docker" "start" "-a" "d4c21900371d71bca12cafd60a4e8bf070943429877472db4f5bbe3dcf102782"` [INFO] [stderr] Compiling failure_derive v0.1.3 (/opt/crater/workdir) [INFO] [stderr] Checking synstructure v0.10.1 [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:146:24 [INFO] [stderr] | [INFO] [stderr] 146 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 147 | | if let syn::Meta::List(list) = meta { [INFO] [stderr] 148 | | error_msg = Some(list); [INFO] [stderr] 149 | | } else { [INFO] [stderr] 150 | | panic!("fail attribute must take a list in parentheses") [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 146 | } else if let syn::Meta::List(list) = meta { [INFO] [stderr] 147 | error_msg = Some(list); [INFO] [stderr] 148 | } else { [INFO] [stderr] 149 | panic!("fail attribute must take a list in parentheses") [INFO] [stderr] 150 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / (quote! { [INFO] [stderr] 66 | | #fail [INFO] [stderr] 67 | | #display [INFO] [stderr] 68 | | }).into() [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 65 | quote! { [INFO] [stderr] 66 | #fail [INFO] [stderr] 67 | #display [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:99:37 [INFO] [stderr] | [INFO] [stderr] 99 | if id_s.starts_with("_") { [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:159:21 [INFO] [stderr] | [INFO] [stderr] 159 | fn is_backtrace(bi: &&synstructure::BindingInfo) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `&synstructure::BindingInfo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | fn is_cause(bi: &&synstructure::BindingInfo) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `&synstructure::BindingInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:186:25 [INFO] [stderr] | [INFO] [stderr] 186 | / if let &&syn::NestedMeta::Meta(syn::Meta::Word(ref word)) = pair.value() { [INFO] [stderr] 187 | | if word == "cause" { [INFO] [stderr] 188 | | if found_cause { [INFO] [stderr] 189 | | panic!("Cannot have two `cause` attributes"); [INFO] [stderr] ... | [INFO] [stderr] 192 | | } [INFO] [stderr] 193 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 186 | if let &syn::NestedMeta::Meta(syn::Meta::Word(ref word)) = *pair.value() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:146:24 [INFO] [stderr] | [INFO] [stderr] 146 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 147 | | if let syn::Meta::List(list) = meta { [INFO] [stderr] 148 | | error_msg = Some(list); [INFO] [stderr] 149 | | } else { [INFO] [stderr] 150 | | panic!("fail attribute must take a list in parentheses") [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 146 | } else if let syn::Meta::List(list) = meta { [INFO] [stderr] 147 | error_msg = Some(list); [INFO] [stderr] 148 | } else { [INFO] [stderr] 149 | panic!("fail attribute must take a list in parentheses") [INFO] [stderr] 150 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / (quote! { [INFO] [stderr] 66 | | #fail [INFO] [stderr] 67 | | #display [INFO] [stderr] 68 | | }).into() [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 65 | quote! { [INFO] [stderr] 66 | #fail [INFO] [stderr] 67 | #display [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:99:37 [INFO] [stderr] | [INFO] [stderr] 99 | if id_s.starts_with("_") { [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:159:21 [INFO] [stderr] | [INFO] [stderr] 159 | fn is_backtrace(bi: &&synstructure::BindingInfo) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `&synstructure::BindingInfo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | fn is_cause(bi: &&synstructure::BindingInfo) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `&synstructure::BindingInfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:186:25 [INFO] [stderr] | [INFO] [stderr] 186 | / if let &&syn::NestedMeta::Meta(syn::Meta::Word(ref word)) = pair.value() { [INFO] [stderr] 187 | | if word == "cause" { [INFO] [stderr] 188 | | if found_cause { [INFO] [stderr] 189 | | panic!("Cannot have two `cause` attributes"); [INFO] [stderr] ... | [INFO] [stderr] 192 | | } [INFO] [stderr] 193 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 186 | if let &syn::NestedMeta::Meta(syn::Meta::Word(ref word)) = *pair.value() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> tests/no_derive_display.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> tests/wraps.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> tests/custom_type_bounds.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> tests/backtrace.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Variant` [INFO] [stderr] --> tests/backtrace.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | / enum BacktraceEnumError { [INFO] [stderr] 39 | | #[fail(display = "Error code: {}", code)] [INFO] [stderr] 40 | | StructVariant { code: i32, backtrace: Backtrace }, [INFO] [stderr] 41 | | #[fail(display = "Error: {}", _0)] [INFO] [stderr] ... | [INFO] [stderr] 44 | | UnitVariant, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Variant` [INFO] [stderr] --> tests/tests.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | / enum EnumError { [INFO] [stderr] 39 | | #[fail(display = "Error code: {}", code)] [INFO] [stderr] 40 | | StructVariant { code: i32 }, [INFO] [stderr] 41 | | #[fail(display = "Error: {}", _0)] [INFO] [stderr] ... | [INFO] [stderr] 44 | | UnitVariant, [INFO] [stderr] 45 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.78s [INFO] running `"docker" "inspect" "d4c21900371d71bca12cafd60a4e8bf070943429877472db4f5bbe3dcf102782"` [INFO] running `"docker" "rm" "-f" "d4c21900371d71bca12cafd60a4e8bf070943429877472db4f5bbe3dcf102782"` [INFO] [stdout] d4c21900371d71bca12cafd60a4e8bf070943429877472db4f5bbe3dcf102782