[INFO] crate fail 0.2.0 is already in cache
[INFO] extracting crate fail 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/fail/0.2.0
[INFO] extracting crate fail 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fail/0.2.0
[INFO] validating manifest of fail-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of fail-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing fail-0.2.0
[INFO] finished frobbing fail-0.2.0
[INFO] frobbed toml for fail-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/fail/0.2.0/Cargo.toml
[INFO] started frobbing fail-0.2.0
[INFO] finished frobbing fail-0.2.0
[INFO] frobbed toml for fail-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fail/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting fail-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fail/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c928229d96b5b7851643fdbfb83fc309e0116ccf354e6698ea93cb38aece204d
[INFO] running `"docker" "start" "-a" "c928229d96b5b7851643fdbfb83fc309e0116ccf354e6698ea93cb38aece204d"`
[INFO] [stderr]     Checking fail v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:121:13
[INFO] [stderr]     |
[INFO] [stderr] 121 |             task: task,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `task`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:122:13
[INFO] [stderr]     |
[INFO] [stderr] 122 |             freq: freq,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `freq`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:121:13
[INFO] [stderr]     |
[INFO] [stderr] 121 |             task: task,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `task`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:122:13
[INFO] [stderr]     |
[INFO] [stderr] 122 |             freq: freq,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `freq`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:201:21
[INFO] [stderr]     |
[INFO] [stderr] 201 |             None => return Err("sleep require timeout".to_owned()),
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("sleep require timeout".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:203:27
[INFO] [stderr]     |
[INFO] [stderr] 203 |                 Err(e) => return Err(format!("failed to parse timeout: {}", e)),
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("failed to parse timeout: {}", e))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:201:21
[INFO] [stderr]     |
[INFO] [stderr] 201 |             None => return Err("sleep require timeout".to_owned()),
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("sleep require timeout".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:203:27
[INFO] [stderr]     |
[INFO] [stderr] 203 |                 Err(e) => return Err(format!("failed to parse timeout: {}", e)),
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("failed to parse timeout: {}", e))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:174:34
[INFO] [stderr]     |
[INFO] [stderr] 174 |             if !second.ends_with(")") {
[INFO] [stderr]     |                                  ^^^ help: try using a char instead: `')'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:174:34
[INFO] [stderr]     |
[INFO] [stderr] 174 |             if !second.ends_with(")") {
[INFO] [stderr]     |                                  ^^^ help: try using a char instead: `')'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/lib.rs:234:20
[INFO] [stderr]     |
[INFO] [stderr] 234 |             pause: Mutex::new(false),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/lib.rs:254:29
[INFO] [stderr]     |
[INFO] [stderr] 254 |             let mut guard = self.pause.lock().unwrap();
[INFO] [stderr]     |                             ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases
[INFO] [stderr]    --> src/lib.rs:260:35
[INFO] [stderr]     |
[INFO] [stderr] 260 |     fn eval(&self, name: &str) -> Option<Option<String>> {
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_option)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/lib.rs:234:20
[INFO] [stderr]     |
[INFO] [stderr] 234 |             pause: Mutex::new(false),
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/lib.rs:254:29
[INFO] [stderr]     |
[INFO] [stderr] 254 |             let mut guard = self.pause.lock().unwrap();
[INFO] [stderr]     |                             ^^^^^^^^^^
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/lib.rs:265:37
[INFO] [stderr]     |
[INFO] [stderr] 265 |                     let mut guard = self.pause.lock().unwrap();
[INFO] [stderr]     |                                     ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases
[INFO] [stderr]    --> src/lib.rs:260:35
[INFO] [stderr]     |
[INFO] [stderr] 260 |     fn eval(&self, name: &str) -> Option<Option<String>> {
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_option)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]    --> src/lib.rs:265:37
[INFO] [stderr]     |
[INFO] [stderr] 265 |                     let mut guard = self.pause.lock().unwrap();
[INFO] [stderr]     |                                     ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:329:44
[INFO] [stderr]     |
[INFO] [stderr] 329 |     for mut cfg in failpoints.trim().split(";") {
[INFO] [stderr]     |                                            ^^^ help: try using a char instead: `';'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:329:44
[INFO] [stderr]     |
[INFO] [stderr] 329 |     for mut cfg in failpoints.trim().split(";") {
[INFO] [stderr]     |                                            ^^^ help: try using a char instead: `';'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/lib.rs:347:19
[INFO] [stderr]     |
[INFO] [stderr] 347 |     for (_, p) in &*registry {
[INFO] [stderr]     |                   ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 347 |     for p in (*registry).values() {
[INFO] [stderr]     |         ^    ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/lib.rs:347:19
[INFO] [stderr]     |
[INFO] [stderr] 347 |     for (_, p) in &*registry {
[INFO] [stderr]     |                   ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 347 |     for p in (*registry).values() {
[INFO] [stderr]     |         ^    ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> tests/tests.rs:123:17
[INFO] [stderr]     |
[INFO] [stderr] 123 |         tx.send(f()).unwrap();
[INFO] [stderr]     |                 ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 123 |         tx.send(()).unwrap();
[INFO] [stderr]     |                 ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> tests/tests.rs:125:17
[INFO] [stderr]     |
[INFO] [stderr] 125 |         tx.send(f()).unwrap();
[INFO] [stderr]     |                 ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 125 |         tx.send(()).unwrap();
[INFO] [stderr]     |                 ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> tests/tests.rs:127:17
[INFO] [stderr]     |
[INFO] [stderr] 127 |         tx.send(f()).unwrap();
[INFO] [stderr]     |                 ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 127 |         tx.send(()).unwrap();
[INFO] [stderr]     |                 ^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.05s
[INFO] running `"docker" "inspect" "c928229d96b5b7851643fdbfb83fc309e0116ccf354e6698ea93cb38aece204d"`
[INFO] running `"docker" "rm" "-f" "c928229d96b5b7851643fdbfb83fc309e0116ccf354e6698ea93cb38aece204d"`
[INFO] [stdout] c928229d96b5b7851643fdbfb83fc309e0116ccf354e6698ea93cb38aece204d