[INFO] crate faerie 0.6.0 is already in cache
[INFO] extracting crate faerie 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/faerie/0.6.0
[INFO] extracting crate faerie 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/faerie/0.6.0
[INFO] validating manifest of faerie-0.6.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of faerie-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing faerie-0.6.0
[INFO] finished frobbing faerie-0.6.0
[INFO] frobbed toml for faerie-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/faerie/0.6.0/Cargo.toml
[INFO] started frobbing faerie-0.6.0
[INFO] finished frobbing faerie-0.6.0
[INFO] frobbed toml for faerie-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/faerie/0.6.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting faerie-0.6.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/faerie/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 05bf7f89c4c24006dab488ca4ad5ba50a9158dc5bc5fa28638bf9362edeacf23
[INFO] running `"docker" "start" "-a" "05bf7f89c4c24006dab488ca4ad5ba50a9158dc5bc5fa28638bf9362edeacf23"`
[INFO] [stderr]     Checking string-interner v0.6.3
[INFO] [stderr]    Compiling target-lexicon v0.2.0
[INFO] [stderr]     Checking scroll v0.9.2
[INFO] [stderr]     Checking goblin v0.0.19
[INFO] [stderr]     Checking faerie v0.6.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/artifact.rs:175:13
[INFO] [stderr]     |
[INFO] [stderr] 175 |             decl: decl,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `decl`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/artifact.rs:175:13
[INFO] [stderr]     |
[INFO] [stderr] 175 |             decl: decl,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `decl`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/elf.rs:225:30
[INFO] [stderr]     |
[INFO] [stderr] 225 |     pub fn create(self, ctx: &Ctx) -> Section {
[INFO] [stderr]     |                              ^^^^ help: consider passing by value instead: `Ctx`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/elf.rs:232:30
[INFO] [stderr]     |
[INFO] [stderr] 232 |             shdr.sh_flags |= SHF_EXECINSTR as u64
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(SHF_EXECINSTR)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/elf.rs:235:30
[INFO] [stderr]     |
[INFO] [stderr] 235 |             shdr.sh_flags |= SHF_WRITE as u64
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^ help: try: `u64::from(SHF_WRITE)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/elf.rs:238:30
[INFO] [stderr]     |
[INFO] [stderr] 238 |             shdr.sh_flags |= SHF_ALLOC as u64
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^ help: try: `u64::from(SHF_ALLOC)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/elf.rs:248:34
[INFO] [stderr]     |
[INFO] [stderr] 248 |                 shdr.sh_flags |= (SHF_MERGE | SHF_STRINGS) as u64;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(SHF_MERGE | SHF_STRINGS)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/elf.rs:570:37
[INFO] [stderr]     |
[INFO] [stderr] 570 |             reloc_section.sh_link = SYMTAB_LINK as u32;
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(SYMTAB_LINK)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 29
[INFO] [stderr]    --> src/elf.rs:577:5
[INFO] [stderr]     |
[INFO] [stderr] 577 | /     pub fn write<T: Write + Seek>(mut self, file: T) -> goblin::error::Result<()> {
[INFO] [stderr] 578 | |         let mut file = BufWriter::new(file);
[INFO] [stderr] 579 | |         /////////////////////////////////////
[INFO] [stderr] 580 | |         // Compute Offsets
[INFO] [stderr] ...   |
[INFO] [stderr] 719 | |         Ok(())
[INFO] [stderr] 720 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/elf.rs:225:30
[INFO] [stderr]     |
[INFO] [stderr] 225 |     pub fn create(self, ctx: &Ctx) -> Section {
[INFO] [stderr]     |                              ^^^^ help: consider passing by value instead: `Ctx`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/elf.rs:627:27
[INFO] [stderr]     |
[INFO] [stderr] 627 |             let offset = *(self.offsets.get(&0).unwrap());
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.offsets[&0]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/elf.rs:634:27
[INFO] [stderr]     |
[INFO] [stderr] 634 |             let offset = *(self.offsets.get(&1).unwrap());
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.offsets[&1]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/elf.rs:232:30
[INFO] [stderr]     |
[INFO] [stderr] 232 |             shdr.sh_flags |= SHF_EXECINSTR as u64
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(SHF_EXECINSTR)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/elf.rs:235:30
[INFO] [stderr]     |
[INFO] [stderr] 235 |             shdr.sh_flags |= SHF_WRITE as u64
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^ help: try: `u64::from(SHF_WRITE)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/elf.rs:238:30
[INFO] [stderr]     |
[INFO] [stderr] 238 |             shdr.sh_flags |= SHF_ALLOC as u64
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^ help: try: `u64::from(SHF_ALLOC)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/elf.rs:248:34
[INFO] [stderr]     |
[INFO] [stderr] 248 |                 shdr.sh_flags |= (SHF_MERGE | SHF_STRINGS) as u64;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(SHF_MERGE | SHF_STRINGS)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/mach.rs:179:22
[INFO] [stderr]     |
[INFO] [stderr] 179 |         let r_type = (self.r_type as u32) << 28;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.r_type)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/mach.rs:359:35
[INFO] [stderr]     |
[INFO] [stderr] 359 |     pub fn load_command_size(ctx: &Ctx) -> u64 {
[INFO] [stderr]     |                                   ^^^^ help: consider passing by value instead: `Ctx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/mach.rs:362:39
[INFO] [stderr]     |
[INFO] [stderr] 362 |     fn _section_data_file_offset(ctx: &Ctx) -> u64 {
[INFO] [stderr]     |                                       ^^^^ help: consider passing by value instead: `Ctx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (10/7)
[INFO] [stderr]    --> src/mach.rs:367:5
[INFO] [stderr]     |
[INFO] [stderr] 367 | /     fn build_section(symtab: &mut SymbolTable, sectname: &'static str, segname: &'static str, offset: &mut u64, addr: &mut u64, symbol_offset: &mut u64, section: SectionIndex, definitions: &[Definition], alignment_exponent: u64, flags: Option<u32>) -> SectionBuilder {
[INFO] [stderr] 368 | |         let mut local_size = 0;
[INFO] [stderr] 369 | |         let mut segment_relative_offset = 0;
[INFO] [stderr] 370 | |         for def in definitions {
[INFO] [stderr] ...   |
[INFO] [stderr] 382 | |         section
[INFO] [stderr] 383 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/mach.rs:386:142
[INFO] [stderr]     |
[INFO] [stderr] 386 |     pub(crate) fn new(artifact: &Artifact, code: &[Definition], data: &[Definition], cstrings: &[Definition], symtab: &mut SymbolTable, ctx: &Ctx) -> Self {
[INFO] [stderr]     |                                                                                                                                              ^^^^ help: consider passing by value instead: `Ctx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 30
[INFO] [stderr]    --> src/mach.rs:464:5
[INFO] [stderr]     |
[INFO] [stderr] 464 | /     pub fn write<T: Write + Seek>(self, file: T) -> Result<(), Error> {
[INFO] [stderr] 465 | |         let mut file = BufWriter::new(file);
[INFO] [stderr] 466 | |         // FIXME: this is ugly af, need cmdsize to get symtable offset
[INFO] [stderr] 467 | |         // construct symtab command
[INFO] [stderr] ...   |
[INFO] [stderr] 597 | |         Ok(())
[INFO] [stderr] 598 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/elf.rs:570:37
[INFO] [stderr]     |
[INFO] [stderr] 570 |             reloc_section.sh_link = SYMTAB_LINK as u32;
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(SYMTAB_LINK)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 29
[INFO] [stderr]    --> src/elf.rs:577:5
[INFO] [stderr]     |
[INFO] [stderr] 577 | /     pub fn write<T: Write + Seek>(mut self, file: T) -> goblin::error::Result<()> {
[INFO] [stderr] 578 | |         let mut file = BufWriter::new(file);
[INFO] [stderr] 579 | |         /////////////////////////////////////
[INFO] [stderr] 580 | |         // Compute Offsets
[INFO] [stderr] ...   |
[INFO] [stderr] 719 | |         Ok(())
[INFO] [stderr] 720 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/mach.rs:470:64
[INFO] [stderr]     |
[INFO] [stderr] 470 |         let sizeof_load_commands = segment_load_command_size + symtab_load_command.cmdsize as u64;
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(symtab_load_command.cmdsize)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]    --> src/mach.rs:483:53
[INFO] [stderr]     |
[INFO] [stderr] 483 |         for (idx, section) in self.segment.sections.into_iter().cloned().enumerate() {
[INFO] [stderr]     |                                                     ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::into_iter_on_array)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/mach.rs:513:59
[INFO] [stderr]     |
[INFO] [stderr] 513 |         assert_eq!(symtable_offset, self.segment.offset + segment_load_command.cmdsize as u64 + symtab_load_command.cmdsize as u64);
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(segment_load_command.cmdsize)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/mach.rs:513:97
[INFO] [stderr]     |
[INFO] [stderr] 513 |         assert_eq!(symtable_offset, self.segment.offset + segment_load_command.cmdsize as u64 + symtab_load_command.cmdsize as u64);
[INFO] [stderr]     |                                                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(symtab_load_command.cmdsize)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/elf.rs:627:27
[INFO] [stderr]     |
[INFO] [stderr] 627 |             let offset = *(self.offsets.get(&0).unwrap());
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.offsets[&0]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/elf.rs:634:27
[INFO] [stderr]     |
[INFO] [stderr] 634 |             let offset = *(self.offsets.get(&1).unwrap());
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.offsets[&1]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/artifact.rs:109:15
[INFO] [stderr]     |
[INFO] [stderr] 109 |         match self.clone() {
[INFO] [stderr]     |               ^^^^^^^^^^^^ help: try dereferencing it: `*self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/artifact.rs:154:22
[INFO] [stderr]     |
[INFO] [stderr] 154 |     pub fn is_import(&self) -> bool {
[INFO] [stderr]     |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/mach.rs:179:22
[INFO] [stderr]     |
[INFO] [stderr] 179 |         let r_type = (self.r_type as u32) << 28;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.r_type)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/artifact.rs:239:24
[INFO] [stderr]     |
[INFO] [stderr] 239 |     fn from_decl(decl: &Decl) -> Option<Self> {
[INFO] [stderr]     |                        ^^^^^ help: consider passing by value instead: `Decl`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/artifact.rs:240:9
[INFO] [stderr]     |
[INFO] [stderr] 240 | /         match decl {
[INFO] [stderr] 241 | |             &Decl::DataImport => {
[INFO] [stderr] 242 | |                 Some (ImportKind::Data)
[INFO] [stderr] 243 | |             },
[INFO] [stderr] ...   |
[INFO] [stderr] 247 | |             _ => None
[INFO] [stderr] 248 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 240 |         match *decl {
[INFO] [stderr] 241 |             Decl::DataImport => {
[INFO] [stderr] 242 |                 Some (ImportKind::Data)
[INFO] [stderr] 243 |             },
[INFO] [stderr] 244 |             Decl::FunctionImport => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/mach.rs:359:35
[INFO] [stderr]     |
[INFO] [stderr] 359 |     pub fn load_command_size(ctx: &Ctx) -> u64 {
[INFO] [stderr]     |                                   ^^^^ help: consider passing by value instead: `Ctx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/mach.rs:362:39
[INFO] [stderr]     |
[INFO] [stderr] 362 |     fn _section_data_file_offset(ctx: &Ctx) -> u64 {
[INFO] [stderr]     |                                       ^^^^ help: consider passing by value instead: `Ctx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (10/7)
[INFO] [stderr]    --> src/mach.rs:367:5
[INFO] [stderr]     |
[INFO] [stderr] 367 | /     fn build_section(symtab: &mut SymbolTable, sectname: &'static str, segname: &'static str, offset: &mut u64, addr: &mut u64, symbol_offset: &mut u64, section: SectionIndex, definitions: &[Definition], alignment_exponent: u64, flags: Option<u32>) -> SectionBuilder {
[INFO] [stderr] 368 | |         let mut local_size = 0;
[INFO] [stderr] 369 | |         let mut segment_relative_offset = 0;
[INFO] [stderr] 370 | |         for def in definitions {
[INFO] [stderr] ...   |
[INFO] [stderr] 382 | |         section
[INFO] [stderr] 383 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/mach.rs:386:142
[INFO] [stderr]     |
[INFO] [stderr] 386 |     pub(crate) fn new(artifact: &Artifact, code: &[Definition], data: &[Definition], cstrings: &[Definition], symtab: &mut SymbolTable, ctx: &Ctx) -> Self {
[INFO] [stderr]     |                                                                                                                                              ^^^^ help: consider passing by value instead: `Ctx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/artifact.rs:360:91
[INFO] [stderr]     |
[INFO] [stderr] 360 |             let previous = self.declarations.entry(decl_name).or_insert(InternalDecl::new(decl.clone()));
[INFO] [stderr]     |                                                                                           ^^^^^^^^^^^^ help: try removing the `clone` call: `decl`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 30
[INFO] [stderr]    --> src/mach.rs:464:5
[INFO] [stderr]     |
[INFO] [stderr] 464 | /     pub fn write<T: Write + Seek>(self, file: T) -> Result<(), Error> {
[INFO] [stderr] 465 | |         let mut file = BufWriter::new(file);
[INFO] [stderr] 466 | |         // FIXME: this is ugly af, need cmdsize to get symtable offset
[INFO] [stderr] 467 | |         // construct symtab command
[INFO] [stderr] ...   |
[INFO] [stderr] 597 | |         Ok(())
[INFO] [stderr] 598 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/artifact.rs:421:63
[INFO] [stderr]     |
[INFO] [stderr] 421 |                     _ if stype.decl.is_import() => return Err(ArtifactError::ImportDefined(name.as_ref().to_string()).into()),
[INFO] [stderr]     |                                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ArtifactError::ImportDefined(name.as_ref().to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/artifact.rs:440:13
[INFO] [stderr]     |
[INFO] [stderr] 440 | /             match &kind {
[INFO] [stderr] 441 | |                 &ImportKind::Function => Decl::FunctionImport,
[INFO] [stderr] 442 | |                 &ImportKind::Data => Decl::DataImport,
[INFO] [stderr] 443 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 440 |             match kind {
[INFO] [stderr] 441 |                 ImportKind::Function => Decl::FunctionImport,
[INFO] [stderr] 442 |                 ImportKind::Data => Decl::DataImport,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/mach.rs:470:64
[INFO] [stderr]     |
[INFO] [stderr] 470 |         let sizeof_load_commands = segment_load_command_size + symtab_load_command.cmdsize as u64;
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(symtab_load_command.cmdsize)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]    --> src/mach.rs:483:53
[INFO] [stderr]     |
[INFO] [stderr] 483 |         for (idx, section) in self.segment.sections.into_iter().cloned().enumerate() {
[INFO] [stderr]     |                                                     ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::into_iter_on_array)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `faerie`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/mach.rs:513:59
[INFO] [stderr]     |
[INFO] [stderr] 513 |         assert_eq!(symtable_offset, self.segment.offset + segment_load_command.cmdsize as u64 + symtab_load_command.cmdsize as u64);
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(segment_load_command.cmdsize)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/mach.rs:513:97
[INFO] [stderr]     |
[INFO] [stderr] 513 |         assert_eq!(symtable_offset, self.segment.offset + segment_load_command.cmdsize as u64 + symtab_load_command.cmdsize as u64);
[INFO] [stderr]     |                                                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(symtab_load_command.cmdsize)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/artifact.rs:109:15
[INFO] [stderr]     |
[INFO] [stderr] 109 |         match self.clone() {
[INFO] [stderr]     |               ^^^^^^^^^^^^ help: try dereferencing it: `*self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/artifact.rs:154:22
[INFO] [stderr]     |
[INFO] [stderr] 154 |     pub fn is_import(&self) -> bool {
[INFO] [stderr]     |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/artifact.rs:239:24
[INFO] [stderr]     |
[INFO] [stderr] 239 |     fn from_decl(decl: &Decl) -> Option<Self> {
[INFO] [stderr]     |                        ^^^^^ help: consider passing by value instead: `Decl`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/artifact.rs:240:9
[INFO] [stderr]     |
[INFO] [stderr] 240 | /         match decl {
[INFO] [stderr] 241 | |             &Decl::DataImport => {
[INFO] [stderr] 242 | |                 Some (ImportKind::Data)
[INFO] [stderr] 243 | |             },
[INFO] [stderr] ...   |
[INFO] [stderr] 247 | |             _ => None
[INFO] [stderr] 248 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 240 |         match *decl {
[INFO] [stderr] 241 |             Decl::DataImport => {
[INFO] [stderr] 242 |                 Some (ImportKind::Data)
[INFO] [stderr] 243 |             },
[INFO] [stderr] 244 |             Decl::FunctionImport => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/artifact.rs:360:91
[INFO] [stderr]     |
[INFO] [stderr] 360 |             let previous = self.declarations.entry(decl_name).or_insert(InternalDecl::new(decl.clone()));
[INFO] [stderr]     |                                                                                           ^^^^^^^^^^^^ help: try removing the `clone` call: `decl`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/artifact.rs:421:63
[INFO] [stderr]     |
[INFO] [stderr] 421 |                     _ if stype.decl.is_import() => return Err(ArtifactError::ImportDefined(name.as_ref().to_string()).into()),
[INFO] [stderr]     |                                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ArtifactError::ImportDefined(name.as_ref().to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/artifact.rs:440:13
[INFO] [stderr]     |
[INFO] [stderr] 440 | /             match &kind {
[INFO] [stderr] 441 | |                 &ImportKind::Function => Decl::FunctionImport,
[INFO] [stderr] 442 | |                 &ImportKind::Data => Decl::DataImport,
[INFO] [stderr] 443 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 440 |             match kind {
[INFO] [stderr] 441 |                 ImportKind::Function => Decl::FunctionImport,
[INFO] [stderr] 442 |                 ImportKind::Data => Decl::DataImport,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `faerie`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "05bf7f89c4c24006dab488ca4ad5ba50a9158dc5bc5fa28638bf9362edeacf23"`
[INFO] running `"docker" "rm" "-f" "05bf7f89c4c24006dab488ca4ad5ba50a9158dc5bc5fa28638bf9362edeacf23"`
[INFO] [stdout] 05bf7f89c4c24006dab488ca4ad5ba50a9158dc5bc5fa28638bf9362edeacf23