[INFO] crate fab 0.1.1 is already in cache
[INFO] extracting crate fab 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/fab/0.1.1
[INFO] extracting crate fab 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fab/0.1.1
[INFO] validating manifest of fab-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of fab-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing fab-0.1.1
[INFO] finished frobbing fab-0.1.1
[INFO] frobbed toml for fab-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/fab/0.1.1/Cargo.toml
[INFO] started frobbing fab-0.1.1
[INFO] finished frobbing fab-0.1.1
[INFO] frobbed toml for fab-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fab/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting fab-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fab/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 383a6d36c3e9acdc17387007cc42f4a7106032654136c2274388a2971e42a322
[INFO] running `"docker" "start" "-a" "383a6d36c3e9acdc17387007cc42f4a7106032654136c2274388a2971e42a322"`
[INFO] [stderr]     Checking fab v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/makefile.rs:16:7
[INFO] [stderr]    |
[INFO] [stderr] 16 |       target: target,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^ help: replace it with: `target`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/makefile.rs:17:7
[INFO] [stderr]    |
[INFO] [stderr] 17 |       dependencies: dependencies,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dependencies`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/makefile.rs:18:7
[INFO] [stderr]    |
[INFO] [stderr] 18 |       commands: commands
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^ help: replace it with: `commands`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/makefile.rs:30:16
[INFO] [stderr]    |
[INFO] [stderr] 30 |     Makefile { rules: rules }
[INFO] [stderr]    |                ^^^^^^^^^^^^ help: replace it with: `rules`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/plan.rs:65:7
[INFO] [stderr]    |
[INFO] [stderr] 65 |       target: target
[INFO] [stderr]    |       ^^^^^^^^^^^^^^ help: replace it with: `target`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/plan.rs:70:5
[INFO] [stderr]    |
[INFO] [stderr] 70 |     makefile: makefile,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: replace it with: `makefile`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/plan.rs:71:5
[INFO] [stderr]    |
[INFO] [stderr] 71 |     phases: phases
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: replace it with: `phases`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/makefile.rs:16:7
[INFO] [stderr]    |
[INFO] [stderr] 16 |       target: target,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^ help: replace it with: `target`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/makefile.rs:17:7
[INFO] [stderr]    |
[INFO] [stderr] 17 |       dependencies: dependencies,
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dependencies`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/makefile.rs:18:7
[INFO] [stderr]    |
[INFO] [stderr] 18 |       commands: commands
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^^ help: replace it with: `commands`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/makefile.rs:30:16
[INFO] [stderr]    |
[INFO] [stderr] 30 |     Makefile { rules: rules }
[INFO] [stderr]    |                ^^^^^^^^^^^^ help: replace it with: `rules`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/plan.rs:65:7
[INFO] [stderr]    |
[INFO] [stderr] 65 |       target: target
[INFO] [stderr]    |       ^^^^^^^^^^^^^^ help: replace it with: `target`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/plan.rs:70:5
[INFO] [stderr]    |
[INFO] [stderr] 70 |     makefile: makefile,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: replace it with: `makefile`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/plan.rs:71:5
[INFO] [stderr]    |
[INFO] [stderr] 71 |     phases: phases
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: replace it with: `phases`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/makefile.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 |     return Ok(MakefileLine::Command(String::from(line.trim())));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(MakefileLine::Command(String::from(line.trim())))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/makefile.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 |     return Ok(MakefileLine::Command(String::from(line.trim())));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(MakefileLine::Command(String::from(line.trim())))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/makefile.rs:79:14
[INFO] [stderr]    |
[INFO] [stderr] 79 |           if command.len() > 0 {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!command.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/makefile.rs:80:32
[INFO] [stderr]    |
[INFO] [stderr] 80 |             rule.commands.push(Command::from(command));
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Command::from()`: `command`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/makefile.rs:88:39
[INFO] [stderr]    |
[INFO] [stderr] 88 |         makefile.rules.push(Rule::new(Target::from(target), dependencies, Vec::new()));
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^ help: consider removing `Target::from()`: `target`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/plan.rs:18:60
[INFO] [stderr]    |
[INFO] [stderr] 18 | pub fn plan_execution<'a> (makefile: &'a Makefile, target: &'a Target) -> Plan<'a> {
[INFO] [stderr]    |                                                            ^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/plan.rs:37:31
[INFO] [stderr]    |
[INFO] [stderr] 37 |         rank = u32::max(rank, rank_for_target.get(&dependency).unwrap() + 1);
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&rank_for_target[&dependency]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/plan.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 |       rule: rule_for_target.get(target).unwrap(),
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&rule_for_target[target]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/plan.rs:77:51
[INFO] [stderr]    |
[INFO] [stderr] 77 | fn find_rule<'a> (makefile: &'a Makefile, target: &String) -> &'a Rule {
[INFO] [stderr]    |                                                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/makefile.rs:79:14
[INFO] [stderr]    |
[INFO] [stderr] 79 |           if command.len() > 0 {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!command.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/makefile.rs:80:32
[INFO] [stderr]    |
[INFO] [stderr] 80 |             rule.commands.push(Command::from(command));
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Command::from()`: `command`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/makefile.rs:88:39
[INFO] [stderr]    |
[INFO] [stderr] 88 |         makefile.rules.push(Rule::new(Target::from(target), dependencies, Vec::new()));
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^ help: consider removing `Target::from()`: `target`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/plan.rs:18:60
[INFO] [stderr]    |
[INFO] [stderr] 18 | pub fn plan_execution<'a> (makefile: &'a Makefile, target: &'a Target) -> Plan<'a> {
[INFO] [stderr]    |                                                            ^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/plan.rs:37:31
[INFO] [stderr]    |
[INFO] [stderr] 37 |         rank = u32::max(rank, rank_for_target.get(&dependency).unwrap() + 1);
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&rank_for_target[&dependency]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/plan.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 |       rule: rule_for_target.get(target).unwrap(),
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&rule_for_target[target]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/plan.rs:77:51
[INFO] [stderr]    |
[INFO] [stderr] 77 | fn find_rule<'a> (makefile: &'a Makefile, target: &String) -> &'a Rule {
[INFO] [stderr]    |                                                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.74s
[INFO] running `"docker" "inspect" "383a6d36c3e9acdc17387007cc42f4a7106032654136c2274388a2971e42a322"`
[INFO] running `"docker" "rm" "-f" "383a6d36c3e9acdc17387007cc42f4a7106032654136c2274388a2971e42a322"`
[INFO] [stdout] 383a6d36c3e9acdc17387007cc42f4a7106032654136c2274388a2971e42a322