[INFO] crate ezra 0.1.3 is already in cache [INFO] extracting crate ezra 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/ezra/0.1.3 [INFO] extracting crate ezra 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ezra/0.1.3 [INFO] validating manifest of ezra-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ezra-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ezra-0.1.3 [INFO] finished frobbing ezra-0.1.3 [INFO] frobbed toml for ezra-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/ezra/0.1.3/Cargo.toml [INFO] started frobbing ezra-0.1.3 [INFO] finished frobbing ezra-0.1.3 [INFO] frobbed toml for ezra-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ezra/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ezra-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ezra/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 141114fb2b4d8e2a240e21cbf107b8b3f3117a3f70685383a0e437fe2ab93d0d [INFO] running `"docker" "start" "-a" "141114fb2b4d8e2a240e21cbf107b8b3f3117a3f70685383a0e437fe2ab93d0d"` [INFO] [stderr] Checking ezra v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dice/numeric_die.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | num_sides: num_sides, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_sides` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dice/numeric_die.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | num_sides: num_sides, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_sides` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dice::dice_collection::DiceCollection` [INFO] [stderr] --> src/dice/dice_collection.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / pub fn new() -> Self { [INFO] [stderr] 62 | | DiceCollection { dice: Vec::new() } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dice/dice_collection.rs:429:27 [INFO] [stderr] | [INFO] [stderr] 429 | let oldval = *result.get(&die.get_value()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[&die.get_value()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dice::dice_collection::DiceCollection` [INFO] [stderr] --> src/dice/dice_collection.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / pub fn new() -> Self { [INFO] [stderr] 62 | | DiceCollection { dice: Vec::new() } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dice/dice_collection.rs:429:27 [INFO] [stderr] | [INFO] [stderr] 429 | let oldval = *result.get(&die.get_value()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[&die.get_value()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.98s [INFO] running `"docker" "inspect" "141114fb2b4d8e2a240e21cbf107b8b3f3117a3f70685383a0e437fe2ab93d0d"` [INFO] running `"docker" "rm" "-f" "141114fb2b4d8e2a240e21cbf107b8b3f3117a3f70685383a0e437fe2ab93d0d"` [INFO] [stdout] 141114fb2b4d8e2a240e21cbf107b8b3f3117a3f70685383a0e437fe2ab93d0d