[INFO] crate ezomyte 0.0.2 is already in cache
[INFO] extracting crate ezomyte 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/ezomyte/0.0.2
[INFO] extracting crate ezomyte 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ezomyte/0.0.2
[INFO] validating manifest of ezomyte-0.0.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ezomyte-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ezomyte-0.0.2
[INFO] removed 7 missing examples
[INFO] finished frobbing ezomyte-0.0.2
[INFO] frobbed toml for ezomyte-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/ezomyte/0.0.2/Cargo.toml
[INFO] started frobbing ezomyte-0.0.2
[INFO] removed 7 missing examples
[INFO] finished frobbing ezomyte-0.0.2
[INFO] frobbed toml for ezomyte-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ezomyte/0.0.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ezomyte-0.0.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ezomyte/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ec061ea0f02618104eca544dbdac1d3b594eed561ff2d465b836c9edf7751a65
[INFO] running `"docker" "start" "-a" "ec061ea0f02618104eca544dbdac1d3b594eed561ff2d465b836c9edf7751a65"`
[INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently
[INFO] [stderr] disables Cargo from automatically inferring other example targets.
[INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following
[INFO] [stderr] files will be included as a example target:
[INFO] [stderr] 
[INFO] [stderr] * /opt/crater/workdir/examples/league_rules.rs
[INFO] [stderr] * /opt/crater/workdir/examples/stash_from_json.rs
[INFO] [stderr] * /opt/crater/workdir/examples/mod_values.rs
[INFO] [stderr] * /opt/crater/workdir/examples/item_names.rs
[INFO] [stderr] * /opt/crater/workdir/examples/search_uniques.rs
[INFO] [stderr] * /opt/crater/workdir/examples/leagues.rs
[INFO] [stderr] * /opt/crater/workdir/examples/latest.rs
[INFO] [stderr] 
[INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be
[INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself
[INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package]
[INFO] [stderr] section. You may also move the files to a location where Cargo would not
[INFO] [stderr] automatically infer them to be a target, such as in subfolders.
[INFO] [stderr] 
[INFO] [stderr] For more information on this warning you can consult
[INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330
[INFO] [stderr]    Compiling ezomyte v0.0.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/api/leagues.rs:159:13
[INFO] [stderr]     |
[INFO] [stderr] 159 |             league: league,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `league`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/model/item/mods/info.rs:40:13
[INFO] [stderr]    |
[INFO] [stderr] 40 |             id: id,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/de/item.rs:386:21
[INFO] [stderr]     |
[INFO] [stderr] 386 |                     tier: tier,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `tier`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/api/leagues.rs:159:13
[INFO] [stderr]     |
[INFO] [stderr] 159 |             league: league,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `league`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/model/item/mods/info.rs:40:13
[INFO] [stderr]    |
[INFO] [stderr] 40 |             id: id,
[INFO] [stderr]    |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model/de/item.rs:386:21
[INFO] [stderr]     |
[INFO] [stderr] 386 |                     tier: tier,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `tier`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/api/league_rules.rs:35:22
[INFO] [stderr]    |
[INFO] [stderr] 35 |                 .map(|resp: LeagueRulesResponse| stream::iter_ok(resp))
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `stream::iter_ok`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/api/leagues.rs:87:21
[INFO] [stderr]    |
[INFO] [stderr] 87 | /                     format!("{}?type={}&compact=1{}", LEAGUES_URL, type_param,
[INFO] [stderr] 88 | |                         season.map(|s| format!("&season={}", s)).unwrap_or_else(String::new)).into()
[INFO] [stderr]    | |____________________________________________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into()`
[INFO] [stderr]    |
[INFO] [stderr] 87 |                     format!("{}?type={}&compact=1{}", LEAGUES_URL, type_param,
[INFO] [stderr] 88 |                         season.map(|s| format!("&season={}", s)).unwrap_or_else(String::new))
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/api/pvp_matches.rs:49:22
[INFO] [stderr]    |
[INFO] [stderr] 49 |                 .map(|resp: PvpMatchesResponse| stream::iter_ok(resp))
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `stream::iter_ok`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/client.rs:64:60
[INFO] [stderr]    |
[INFO] [stderr] 64 |             api_root: api_root.as_ref().trim_right_matches("/").to_owned(),
[INFO] [stderr]    |                                                            ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/client.rs:111:59
[INFO] [stderr]     |
[INFO] [stderr] 111 |             self.api_root, url.as_ref().trim_left_matches("/"));
[INFO] [stderr]     |                                                           ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]    --> src/client.rs:150:77
[INFO] [stderr]     |
[INFO] [stderr] 150 |                         static ref ANGLE_HTML_RE: Regex = RegexBuilder::new("<html")
[INFO] [stderr]     |                                                                             ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivial_regex)] on by default
[INFO] [stderr]     = help: consider using `str::contains`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/model/item/category.rs:41:26
[INFO] [stderr]    |
[INFO] [stderr] 41 |     pub fn is_consumable(&self) -> bool {
[INFO] [stderr]    |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/model/item/category.rs:54:26
[INFO] [stderr]    |
[INFO] [stderr] 54 |     pub fn is_equippable(&self) -> bool {
[INFO] [stderr]    |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/model/item/category.rs:67:26
[INFO] [stderr]    |
[INFO] [stderr] 67 |     pub fn is_modifiable(&self) -> bool {
[INFO] [stderr]    |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases
[INFO] [stderr]    --> src/model/item/properties.rs:114:69
[INFO] [stderr]     |
[INFO] [stderr] 114 |     pub fn insert(&mut self, key: Key, opt_value: Option<Value>) -> Option<Option<Value>> {
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_option)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option
[INFO] [stderr] 
[INFO] [stderr] warning: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases
[INFO] [stderr]    --> src/model/item/properties.rs:141:40
[INFO] [stderr]     |
[INFO] [stderr] 141 |     pub fn put(&mut self, key: Key) -> Option<Option<Value>> {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option
[INFO] [stderr] 
[INFO] [stderr] warning: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases
[INFO] [stderr]    --> src/model/item/properties.rs:154:65
[INFO] [stderr]     |
[INFO] [stderr] 154 |     pub fn put_with_value(&mut self, key: Key, value: Value) -> Option<Option<Value>> {
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option
[INFO] [stderr] 
[INFO] [stderr] warning: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases
[INFO] [stderr]    --> src/model/item/properties.rs:170:53
[INFO] [stderr]     |
[INFO] [stderr] 170 |     pub fn remove<K: ?Sized>(&mut self, key: &K) -> Option<Option<Value>>
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/model/league.rs:184:18
[INFO] [stderr]     |
[INFO] [stderr] 184 |                 .unwrap_or("Temporary Hardcore".into()),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "Temporary Hardcore".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/model/league.rs:189:18
[INFO] [stderr]     |
[INFO] [stderr] 189 |                 .unwrap_or("Temporary SSF".into()),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "Temporary SSF".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/model/league.rs:192:18
[INFO] [stderr]     |
[INFO] [stderr] 192 |                 .unwrap_or("Temporary Hardcore SSF".into()),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "Temporary Hardcore SSF".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/api/league_rules.rs:35:22
[INFO] [stderr]    |
[INFO] [stderr] 35 |                 .map(|resp: LeagueRulesResponse| stream::iter_ok(resp))
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `stream::iter_ok`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/model/de/experience.rs:31:37
[INFO] [stderr]    |
[INFO] [stderr] 31 |         let parts: Vec<_> = v.split("/").collect();
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/api/leagues.rs:87:21
[INFO] [stderr]    |
[INFO] [stderr] 87 | /                     format!("{}?type={}&compact=1{}", LEAGUES_URL, type_param,
[INFO] [stderr] 88 | |                         season.map(|s| format!("&season={}", s)).unwrap_or_else(String::new)).into()
[INFO] [stderr]    | |____________________________________________________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into()`
[INFO] [stderr]    |
[INFO] [stderr] 87 |                     format!("{}?type={}&compact=1{}", LEAGUES_URL, type_param,
[INFO] [stderr] 88 |                         season.map(|s| format!("&season={}", s)).unwrap_or_else(String::new))
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 30
[INFO] [stderr]    --> src/model/de/item.rs:39:5
[INFO] [stderr]     |
[INFO] [stderr] 39  | /     fn visit_map<V>(self, mut map: V) -> Result<Self::Value, V::Error>
[INFO] [stderr] 40  | |         where V: de::MapAccess<'de>
[INFO] [stderr] 41  | |     {
[INFO] [stderr] 42  | |         // TODO: preemptively check the size against minimum & maximum number of fields
[INFO] [stderr] ...   |
[INFO] [stderr] 426 | |         })
[INFO] [stderr] 427 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/api/pvp_matches.rs:49:22
[INFO] [stderr]    |
[INFO] [stderr] 49 |                 .map(|resp: PvpMatchesResponse| stream::iter_ok(resp))
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `stream::iter_ok`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/model/de/item.rs:133:25
[INFO] [stderr]     |
[INFO] [stderr] 133 | /                         match value {
[INFO] [stderr] 134 | |                             8 => { category = Some(Quasi::from(ItemCategory::Prophecy)); }
[INFO] [stderr] 135 | |                             _ => {}
[INFO] [stderr] 136 | |                         }
[INFO] [stderr]     | |_________________________^ help: try this: `if let 8 = value { category = Some(Quasi::from(ItemCategory::Prophecy)); }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/model/de/item.rs:259:85
[INFO] [stderr]     |
[INFO] [stderr] 259 |                         item_quantity = Some(deserialize(quantity).map(|Quality(q)| q as i32)?);
[INFO] [stderr]     |                                                                                     ^^^^^^^^ help: try: `i32::from(q)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/model/de/item.rs:266:81
[INFO] [stderr]     |
[INFO] [stderr] 266 |                         item_rarity = Some(deserialize(rarity).map(|Quality(q)| q as i32)?);
[INFO] [stderr]     |                                                                                 ^^^^^^^^ help: try: `i32::from(q)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/model/de/item.rs:273:90
[INFO] [stderr]     |
[INFO] [stderr] 273 |                         monster_pack_size = Some(deserialize(pack_size).map(|Quality(q)| q as i32)?);
[INFO] [stderr]     |                                                                                          ^^^^^^^^ help: try: `i32::from(q)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/model/de/label.rs:41:27
[INFO] [stderr]    |
[INFO] [stderr] 41 |         if !v.starts_with("~") {
[INFO] [stderr]    |                           ^^^ help: try using a char instead: `'~'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/client.rs:64:60
[INFO] [stderr]    |
[INFO] [stderr] 64 |             api_root: api_root.as_ref().trim_right_matches("/").to_owned(),
[INFO] [stderr]    |                                                            ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/client.rs:111:59
[INFO] [stderr]     |
[INFO] [stderr] 111 |             self.api_root, url.as_ref().trim_left_matches("/"));
[INFO] [stderr]     |                                                           ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
[INFO] [stderr]   --> src/model/de/rarity.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 |         Rarity::iter_variants().skip(v as usize).next().ok_or_else(|| {
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_skip_next)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]    --> src/client.rs:150:77
[INFO] [stderr]     |
[INFO] [stderr] 150 |                         static ref ANGLE_HTML_RE: Regex = RegexBuilder::new("<html")
[INFO] [stderr]     |                                                                             ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivial_regex)] on by default
[INFO] [stderr]     = help: consider using `str::contains`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/model/item/category.rs:41:26
[INFO] [stderr]    |
[INFO] [stderr] 41 |     pub fn is_consumable(&self) -> bool {
[INFO] [stderr]    |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/model/item/category.rs:54:26
[INFO] [stderr]    |
[INFO] [stderr] 54 |     pub fn is_equippable(&self) -> bool {
[INFO] [stderr]    |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/model/item/category.rs:67:26
[INFO] [stderr]    |
[INFO] [stderr] 67 |     pub fn is_modifiable(&self) -> bool {
[INFO] [stderr]    |                          ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/model/item/mods/tests.rs:7:16
[INFO] [stderr]   |
[INFO] [stderr] 7 |         .split("\n")
[INFO] [stderr]   |                ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `MOD_TEXT_PREFIXES`
[INFO] [stderr]   --> src/model/item/mods/tests.rs:31:14
[INFO] [stderr]    |
[INFO] [stderr] 31 |     for i in 0..count {
[INFO] [stderr]    |              ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 31 |     for (i, <item>) in MOD_TEXT_PREFIXES.iter().enumerate().take(count) {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `MOD_TEXT_PREFIXES`.
[INFO] [stderr]   --> src/model/item/mods/tests.rs:32:18
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for j in (i + 1)..count {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for <item> in MOD_TEXT_PREFIXES.iter().take(count).skip((i + 1)) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases
[INFO] [stderr]    --> src/model/item/properties.rs:114:69
[INFO] [stderr]     |
[INFO] [stderr] 114 |     pub fn insert(&mut self, key: Key, opt_value: Option<Value>) -> Option<Option<Value>> {
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_option)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option
[INFO] [stderr] 
[INFO] [stderr] warning: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases
[INFO] [stderr]    --> src/model/item/properties.rs:141:40
[INFO] [stderr]     |
[INFO] [stderr] 141 |     pub fn put(&mut self, key: Key) -> Option<Option<Value>> {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option
[INFO] [stderr] 
[INFO] [stderr] warning: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases
[INFO] [stderr]    --> src/model/item/properties.rs:154:65
[INFO] [stderr]     |
[INFO] [stderr] 154 |     pub fn put_with_value(&mut self, key: Key, value: Value) -> Option<Option<Value>> {
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option
[INFO] [stderr] 
[INFO] [stderr] warning: consider using `Option<T>` instead of `Option<Option<T>>` or a custom enum if you need to distinguish all 3 cases
[INFO] [stderr]    --> src/model/item/properties.rs:170:53
[INFO] [stderr]     |
[INFO] [stderr] 170 |     pub fn remove<K: ?Sized>(&mut self, key: &K) -> Option<Option<Value>>
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/model/league.rs:184:18
[INFO] [stderr]     |
[INFO] [stderr] 184 |                 .unwrap_or("Temporary Hardcore".into()),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "Temporary Hardcore".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/model/league.rs:189:18
[INFO] [stderr]     |
[INFO] [stderr] 189 |                 .unwrap_or("Temporary SSF".into()),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "Temporary SSF".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/model/league.rs:192:18
[INFO] [stderr]     |
[INFO] [stderr] 192 |                 .unwrap_or("Temporary Hardcore SSF".into()),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "Temporary Hardcore SSF".into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/model/de/experience.rs:31:37
[INFO] [stderr]    |
[INFO] [stderr] 31 |         let parts: Vec<_> = v.split("/").collect();
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 30
[INFO] [stderr]    --> src/model/de/item.rs:39:5
[INFO] [stderr]     |
[INFO] [stderr] 39  | /     fn visit_map<V>(self, mut map: V) -> Result<Self::Value, V::Error>
[INFO] [stderr] 40  | |         where V: de::MapAccess<'de>
[INFO] [stderr] 41  | |     {
[INFO] [stderr] 42  | |         // TODO: preemptively check the size against minimum & maximum number of fields
[INFO] [stderr] ...   |
[INFO] [stderr] 426 | |         })
[INFO] [stderr] 427 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/model/de/item.rs:133:25
[INFO] [stderr]     |
[INFO] [stderr] 133 | /                         match value {
[INFO] [stderr] 134 | |                             8 => { category = Some(Quasi::from(ItemCategory::Prophecy)); }
[INFO] [stderr] 135 | |                             _ => {}
[INFO] [stderr] 136 | |                         }
[INFO] [stderr]     | |_________________________^ help: try this: `if let 8 = value { category = Some(Quasi::from(ItemCategory::Prophecy)); }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/model/de/item.rs:259:85
[INFO] [stderr]     |
[INFO] [stderr] 259 |                         item_quantity = Some(deserialize(quantity).map(|Quality(q)| q as i32)?);
[INFO] [stderr]     |                                                                                     ^^^^^^^^ help: try: `i32::from(q)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/model/de/item.rs:266:81
[INFO] [stderr]     |
[INFO] [stderr] 266 |                         item_rarity = Some(deserialize(rarity).map(|Quality(q)| q as i32)?);
[INFO] [stderr]     |                                                                                 ^^^^^^^^ help: try: `i32::from(q)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/model/de/item.rs:273:90
[INFO] [stderr]     |
[INFO] [stderr] 273 |                         monster_pack_size = Some(deserialize(pack_size).map(|Quality(q)| q as i32)?);
[INFO] [stderr]     |                                                                                          ^^^^^^^^ help: try: `i32::from(q)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/model/de/label.rs:41:27
[INFO] [stderr]    |
[INFO] [stderr] 41 |         if !v.starts_with("~") {
[INFO] [stderr]    |                           ^^^ help: try using a char instead: `'~'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
[INFO] [stderr]   --> src/model/de/rarity.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 |         Rarity::iter_variants().skip(v as usize).next().ok_or_else(|| {
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_skip_next)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 15.85s
[INFO] running `"docker" "inspect" "ec061ea0f02618104eca544dbdac1d3b594eed561ff2d465b836c9edf7751a65"`
[INFO] running `"docker" "rm" "-f" "ec061ea0f02618104eca544dbdac1d3b594eed561ff2d465b836c9edf7751a65"`
[INFO] [stdout] ec061ea0f02618104eca544dbdac1d3b594eed561ff2d465b836c9edf7751a65